[jira] [Commented] (IGNITE-7097) performance measurement for SparseDistributedMatrix multiplication

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306247#comment-16306247
 ] 

ASF GitHub Bot commented on IGNITE-7097:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3241


> performance measurement for SparseDistributedMatrix multiplication
> --
>
> Key: IGNITE-7097
> URL: https://issues.apache.org/jira/browse/IGNITE-7097
> Project: Ignite
>  Issue Type: Task
>  Components: ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
> Fix For: 2.4
>
>
> We want to start tracking our performance to avoid performance degradation. 
> Also we need some performance comparison with other ml libs.
> Initial draft for this benchmark was made per IGNITE-6123 (class 
> {{IgniteSparseDistributedMatrixMulBenchmark}}) but it currently hangs so it 
> is excluded. Find a way to do it right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7097) performance measurement for SparseDistributedMatrix multiplication

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292723#comment-16292723
 ] 

ASF GitHub Bot commented on IGNITE-7097:


GitHub user oignatenko opened a pull request:

https://github.com/apache/ignite/pull/3241

IGNITE-7097 performance measurement for SparseDistributedMatrix multi…

…plication

- optimised and unoptimised benchmarks, along with respective documentation
- also a common adjustment to matrix mul benchmarks to make these more 
sensitive to algorithmic changes
-- verified with diffs overview, clean rebuild, trial execution of the 
benchmarks and studying results

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7097

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3241


commit be918641730af3738dcc4d8cd608b63ba6088732
Author: Oleg Ignatenko 
Date:   2017-12-15T15:58:43Z

IGNITE-7097 performance measurement for SparseDistributedMatrix 
multiplication
- optimised and unoptimised benchmarks, along with respective documentation
- also a common adjustment to matrix mul benchmarks to make these more 
sensitive to algorithmic changes
-- verified with diffs overview, clean rebuild, trial execution of the 
benchmarks and studying results




> performance measurement for SparseDistributedMatrix multiplication
> --
>
> Key: IGNITE-7097
> URL: https://issues.apache.org/jira/browse/IGNITE-7097
> Project: Ignite
>  Issue Type: Task
>  Components: ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
> Fix For: 2.4
>
>
> We want to start tracking our performance to avoid performance degradation. 
> Also we need some performance comparison with other ml libs.
> Initial draft for this benchmark was made per IGNITE-6123 (class 
> {{IgniteSparseDistributedMatrixMulBenchmark}}) but it currently hangs so it 
> is excluded. Find a way to do it right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7097) performance measurement for SparseDistributedMatrix multiplication

[Oleg Ignatenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292718#comment-16292718
 ] 

Oleg Ignatenko commented on IGNITE-7097:


On a closer inspection the root cause of the issue turned out that the 
implementation in this matrix type is very slow, much slower than in all other 
classes used in matrix mul benchmarks. Based on that the way to resolve this 
was chosen as follows: this benchmark runs on matrices of smaller size than 
other, plus it is complemented with a benchmark that uses regular size but also 
applies a trivial optimization by delegating multiplication to 
{{SparseBlockDistributedMatrix}}.

For the sake of completeness I also briefly discussed with Yury an option to 
somehow optimize multiplication in this type of matrix. As of now it doesn't 
look worth the effort. This is primarily because we already have a properly 
optimized block version of sparse distributed matrix, so is unclear what 
tangible benefits can be gained by such an optimization.

> performance measurement for SparseDistributedMatrix multiplication
> --
>
> Key: IGNITE-7097
> URL: https://issues.apache.org/jira/browse/IGNITE-7097
> Project: Ignite
>  Issue Type: Task
>  Components: ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
> Fix For: 2.4
>
>
> We want to start tracking our performance to avoid performance degradation. 
> Also we need some performance comparison with other ml libs.
> Initial draft for this benchmark was made per IGNITE-6123 (class 
> {{IgniteSparseDistributedMatrixMulBenchmark}}) but it currently hangs so it 
> is excluded. Find a way to do it right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7097) performance measurement for SparseDistributedMatrix multiplication

[Oleg Ignatenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280426#comment-16280426
 ] 

Oleg Ignatenko commented on IGNITE-7097:


I experimented with running benchmarks using ML codebase in master: the issue 
is still reproducible. Whatever causes it, apparently hasn't been fixed yet. 
Plan to check if maybe there is some kind of leak, maybe intermediate objects 
are created by {{likeMatrix}} or {{likeVector}} somewhere within multiplication 
without corresponding {{destroy}} because in past experiments it was missing 
destroy that caused yardstick to hang

> performance measurement for SparseDistributedMatrix multiplication
> --
>
> Key: IGNITE-7097
> URL: https://issues.apache.org/jira/browse/IGNITE-7097
> Project: Ignite
>  Issue Type: Task
>  Components: ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
> Fix For: 2.4
>
>
> We want to start tracking our performance to avoid performance degradation. 
> Also we need some performance comparison with other ml libs.
> Initial draft for this benchmark was made per IGNITE-6123 (class 
> {{IgniteSparseDistributedMatrixMulBenchmark}}) but it currently hangs so it 
> is excluded. Find a way to do it right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7097) performance measurement for SparseDistributedMatrix multiplication

[Oleg Ignatenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275855#comment-16275855
 ] 

Oleg Ignatenko commented on IGNITE-7097:


primary purpose of "extracting" this particular benchmark from IGNITE-6123 is 
to unblock implementation and merging of other benchmarks and other activities 
related to ML benchmarks

> performance measurement for SparseDistributedMatrix multiplication
> --
>
> Key: IGNITE-7097
> URL: https://issues.apache.org/jira/browse/IGNITE-7097
> Project: Ignite
>  Issue Type: Task
>  Components: ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
> Fix For: 2.4
>
>
> We want to start tracking our performance to avoid performance degradation. 
> Also we need some performance comparison with other ml libs.
> Initial draft for this benchmark was made per IGNITE-6123 (class 
> {{IgniteSparseDistributedMatrixMulBenchmark}}) but it currently hangs so it 
> is excluded. Find a way to do it right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)