[jira] [Commented] (IGNITE-7229) .NET: Rename ICache query methods to Query

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295024#comment-16295024
 ] 

ASF GitHub Bot commented on IGNITE-7229:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/3247

IGNITE-7229 .NET: Rename ICache.QueryFields to Query, add FieldNames



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptupitsyn/ignite ignite-7229

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3247


commit 8abf09fcdcec0a259fcab4345e64db2f5f133f3d
Author: Pavel Tupitsyn 
Date:   2017-12-18T11:37:27Z

IGNITE-7229 .NET: Rename ICache query methods to Query

commit 6758d728b33b53033261011ef8ea7a9a96d5fd46
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:07:49Z

wip

commit 85ec136958c41ac03af585d39e42284e868d4ca3
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:10:42Z

wip

commit 3f55d7383ed0e07269ebfcda472ae9d9642d6e25
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:11:43Z

wip

commit dca634c9173aef0414e661f8b59719a2bb6a69cc
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:13:20Z

Fix obsolete usages

commit 387553edbd69708b0b18afbfe9c7dd877e0fd4f4
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:33:11Z

Fix usages in examples

commit 75d427ef3621d9e2da764221987a019ba68c0816
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:34:45Z

Rename internal method

commit 8ca35ba2a88ccf691af11eb8499ea59b33d13648
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:36:05Z

Fixing all usages

commit ce6e299a89a8e97236c95507f5e24783b03eb350
Author: Pavel Tupitsyn 
Date:   2017-12-18T12:37:41Z

Fixing tests

commit 0b0b02ae4e22408ee47d8d82879399600b6312f1
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:00:54Z

Adding FieldNames tests

commit de38b92477b8c3b8f0addc1034904201d6ca2804
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:02:55Z

wip

commit 393d9f2460205a8688556c91163b195c24cedb0f
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:05:12Z

wip

commit dc9376e6c540c51a4e568f574c490de845e4dd10
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:12:41Z

wip

commit 48abd84fe6e19471ed707ec27992621dd5cc5b06
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:18:50Z

Adding field meta call

commit 951adccd0796fa6a955fbdd3356933c042f3b9cf
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:23:43Z

fieldNames done

commit 51c1898b561d73a3e9341c7166705ea06336ac9b
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:31:36Z

wip tests

commit 2b804743787b9e389e864758739516c4dc672ab1
Author: Pavel Tupitsyn 
Date:   2017-12-18T13:43:46Z

TestFieldNames done




> .NET: Rename ICache query methods to Query
> --
>
> Key: IGNITE-7229
> URL: https://issues.apache.org/jira/browse/IGNITE-7229
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.4
>
>
> Currently some queries share a single method, while others use a different 
> name.
> Rename {{QueryFields}} to {{Query}} to have a more consistent API.
> Leave {{QueryContinuous}} as is because it is very different semantically 
> (like an event subscription).
> Keep old methods and mark them with {{[Obsolete]}}.
> * {{ICacheClient}} uses same method name for all queries
> * {{IgniteCache}} in Java uses same method name for all queries



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7229) .NET: Rename ICache query methods to Query

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294854#comment-16294854
 ] 

Pavel Tupitsyn commented on IGNITE-7229:


Let's combine this with IGNITE-5253: new method should return 
{{IFieldsQueryCursor}} (which is already implemented for the thin client).

> .NET: Rename ICache query methods to Query
> --
>
> Key: IGNITE-7229
> URL: https://issues.apache.org/jira/browse/IGNITE-7229
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.4
>
>
> Currently some queries share a single method, while others use a different 
> name.
> Rename {{QueryFields}} to {{Query}} to have a more consistent API.
> Leave {{QueryContinuous}} as is because it is very different semantically 
> (like an event subscription).
> Keep old methods and mark them with {{[Obsolete]}}.
> * {{ICacheClient}} uses same method name for all queries
> * {{IgniteCache}} in Java uses same method name for all queries



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)