[jira] [Commented] (IGNITE-7586) SQL COPY: add code examples

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355604#comment-16355604
 ] 

ASF GitHub Bot commented on IGNITE-7586:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3485


> SQL COPY: add code examples
> ---
>
> Key: IGNITE-7586
> URL: https://issues.apache.org/jira/browse/IGNITE-7586
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Kirill Shirokov
>Assignee: Kirill Shirokov
>Priority: Major
>  Labels: iep-1
> Fix For: 2.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7586) SQL COPY: add code examples

[Alexander Paschenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355509#comment-16355509
 ] 

Alexander Paschenko commented on IGNITE-7586:
-

[~kirill.shirokov],

Thanks, my comments:
 # Please refactor imports - we don't use wildcards. Also order of imports does 
matter, please have a look at guidelines. (First java.*, then everything else.) 
IDEA may easily be tuned to lay imports out just the way we need.
 # Please remove "create index", it is not necessary to the scope of this 
example.
 # Please change ""JDBC example finished." to ""JDBC COPY command example 
finished."

> SQL COPY: add code examples
> ---
>
> Key: IGNITE-7586
> URL: https://issues.apache.org/jira/browse/IGNITE-7586
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Kirill Shirokov
>Assignee: Kirill Shirokov
>Priority: Major
>  Labels: iep-1
> Fix For: 2.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7586) SQL COPY: add code examples

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355447#comment-16355447
 ] 

ASF GitHub Bot commented on IGNITE-7586:


GitHub user gg-shq opened a pull request:

https://github.com/apache/ignite/pull/3485

IGNITE-7586: Added COPY command into the JDBC example.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7586

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3485


commit 530756813411d51e731ffd5f145c7c9f57adbb31
Author: gg-shq 
Date:   2018-02-07T13:38:59Z

IGNITE-7586: Added COPY command into the JDBC example.




> SQL COPY: add code examples
> ---
>
> Key: IGNITE-7586
> URL: https://issues.apache.org/jira/browse/IGNITE-7586
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Kirill Shirokov
>Assignee: Kirill Shirokov
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)