[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444895#comment-16444895
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

This patch was discussed with [~vozerov] and [~dpavlov].
We came to the next agreements:

1. To make this patch correct we should implement support for a BigDecimal and 
Varchar constraints.
2. If we can't do that when 2.6 will be ready we should revert this patch.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444076#comment-16444076
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~vozerov]

As far as I can see there is no backward compatibility described in thin client 
protocol [1].
Actually, the documentation said opposite thing, you must ensure that your 
client and your server are compatible.

{quote}
The first message upon connection establishment must be a handshake. Handshake 
ensures that client and server versions are compatible.
{quote}

I'm really confused here.

[1] 
https://cwiki.apache.org/confluence/display/IGNITE/IEP-9+Thin+Client+Protocol#IEP-9ThinClientProtocol-ClientOperations

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443948#comment-16443948
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~NIzhikov]

> 1) Binary compatibility for thin .NET client is broken

OK. Let's fix it.
Can you name some broken tests?
Or give me an example how compatibility is implemented in current sources?

> 2) Binary client docs are not updated

OK. Let's update it.

> 3) And the most important question - why QueryField.precision and 
> QueryField.scale are not used?

You suggest to use precision and scale when returning BigDecimal value as a 
query result.
Am I understand you correctly?

I think it has to be done in the separate ticket.
The goal of this ticket provide meta information to a user.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443979#comment-16443979
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~vozerov]

Actually, this ticket is based on your email [1]
Did you change your opinion now?

{quote}
...it is not possible at the moment unfortunately - we do not store information
about lengths, scales and precision, only actual data types are passed to
H2 (e.g. String, BigDecimal, etc.). This will be fixed at some point in
future, but I do not have any dates at the moment.
{quote}

[1] 
https://lists.apache.org/thread.html/13f733e13ce81130d94f9e8692dfbd8ad8bfda26056672d9f71f892c@%3Cdev.ignite.apache.org%3E

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443978#comment-16443978
 ] 

Dmitriy Pavlov commented on IGNITE-7691:


[~vozerov] which compatibilty do you mean? All compatibilty tests are passing 
as far as I can see.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443975#comment-16443975
 ] 

Vladimir Ozerov commented on IGNITE-7691:
-

[~NIzhikov], the main problem is that we implemented a lot of changes, broken 
compatibiltiy, but solved nothing. Ignite hadn't supported scale/precision 
before, it doesn't support it after.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443980#comment-16443980
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~vozerov]

> Ignite hadn't supported scale/precision before, it doesn't support it after.

{quote}This will be fixed at some point in future, but I do not have any dates 
at the moment.{quote}

I'm fully confused here. 
Are we going to fix it or not?

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443969#comment-16443969
 ] 

Vladimir Ozerov commented on IGNITE-7691:
-

Solution which makes sense to me:
1) Revert current patch
2) Return zero for precision and scale in JDBC 
3) Return any sensible number in Spark, since we do not support scale/precision 
anyway. It could be 0, -1, MAX_VALUE, whatever fit our needs
4) Disallow custom precision/scale in our new parser by default [1]

[1] https://issues.apache.org/jira/browse/IGNITE-6861

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443954#comment-16443954
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~vozerov]

> even though we set the precision, it is simply ignored.

It's ignored in current SQL engine too.
So I think we have to fix it in a separate ticket.

I still can't understand, what is broken with this patch.
Can you give me some tests or written rules that were violated?

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443939#comment-16443939
 ] 

Vladimir Ozerov commented on IGNITE-7691:
-

[~NIzhikov], [~dpavlov], another critical comment is from Taras - even though 
we set the precision, it is simply ignored. What is the reason to have it the 
product at all? Looks like this is a candidate for reverting.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443936#comment-16443936
 ] 

Vladimir Ozerov commented on IGNITE-7691:
-

[~NIzhikov], [~dpavlov], [~tledkov-gridgain],
Folks, this patch is wrong in many places, how come we agreed to merge it?
1) Binary compatibility for thin .NET client is broken - previous version 
cannot work with new protocol any more because it doesn't write scale and 
precision {{PlatformConfigurationUtils#readQueryEntity}}
2) Binary client docs are not updated (see query entity section - 
https://apacheignite.readme.io/docs/binary-client-protocol-cache-configuration-operations)
3) And the most important question - why {{QueryField.precision}} and 
{{QueryField.scale}} are not used? 

I do not see why we need these fields. Let's just remove them and restore 
compatibility ASAP.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437038#comment-16437038
 ] 

ASF GitHub Bot commented on IGNITE-7691:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3691


> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.6
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-12 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435386#comment-16435386
 ] 

Dmitriy Pavlov commented on IGNITE-7691:


It seems there are no test left, all others are failing in master.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-12 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435345#comment-16435345
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

Latest "Run All" for my PR - 
https://ci.ignite.apache.org/viewLog.html?buildId=1195498
I've checked all failures locally and it seems, that no failed tests that are 
related to my changes.


> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-11 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433876#comment-16433876
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~dpavlov] Thank you.

Actually, these failures ARE related to my changes.
I fixed it and start "run all" one more time.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-10 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432152#comment-16432152
 ] 

Dmitriy Pavlov commented on IGNITE-7691:


There is still concern about failing tests:
{noformat}
   Java Thin Client [ tests 2 ] 
  ClientTestSuite: FunctionalTest.testCacheConfiguration (master fail rate 
0,0%) 
  ClientTestSuite: IgniteBinaryQueryTest.testBinaryQueries (master fail 
rate 0,0%) 
{noformat}
test is passing in master. Probably tests are not related to fix and was broken 
early, but it needs to be checked.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-10 Thread Taras Ledkov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432070#comment-16432070
 ] 

Taras Ledkov commented on IGNITE-7691:
--

[~NIzhikov] you are right. Please merge the path.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-09 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430553#comment-16430553
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

Hello, [~tledkov-gridgain].

Thanks for the review.

> Why we need this implementation?

To made Ignite better, obviously.

I, personally, need this feature to make better integration with Spark Data 
Frame.
I should provide column type for Data Frame schema and I want to use scale and 
precision from table metadata.
Please, see [1] from current master.

> I'm afraid that the user may be confused the contradiction between right 
> CREATE TABLE syntax (and right metadata) and wrong query results.

AFAIK it's a current Ignite behaviour.
So, it's already confusing a user who wants to restrict DECIMAL columns.
I thought that *wrong query results* is a bug so we have a plan to fix it.

Am I wrong?

[1] 
https://github.com/apache/ignite/blob/master/modules/spark/src/main/scala/org/apache/ignite/spark/impl/QueryUtils.scala#L133

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-09 Thread Taras Ledkov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430507#comment-16430507
 ] 

Taras Ledkov commented on IGNITE-7691:
--

[~NIzhikov], [~vozerov], the patch looks good.
But I have one question:
The implementation looks like stub. Why we need this implementation?
In common SQL servers fixed precision specify the column's store format and 
default column output.

At the proposal implementation:
{code}
CREATE TABLE TEST (id INT, val DECIMAL(2,1));
INSERT INTO TEST (1, 123456789);
INSERT INTO TEST (2, 12345678.12345678);
INSERT INTO TEST (3, .123456789);
SELECT * from TEST;

// Result is:
1, 123456789
2, 12345678.12345678
3, 0.123456789

// For specified precision and scale it is MUST BE:
1, 9.9
2, 9.9
3, 0.1
{code}

Please clarify the main goal of the patch.
I'm afraid that the user may be confused the contradiction between right CREATE 
TABLE syntax (and right metadata) and wrong query results.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-04 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425785#comment-16425785
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

Run All - 
https://ci.ignite.apache.org/viewQueued.html?itemId=1179009=queuedBuildOverviewTab

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-04 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425762#comment-16425762
 ] 

Dmitriy Pavlov commented on IGNITE-7691:


[~tledkov-gridgain], could you please review SQL part?

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-04 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425724#comment-16425724
 ] 

Dmitriy Pavlov commented on IGNITE-7691:


I've checked the tests, most of failures are common with master, but there is  
3 suspicious:

   ClientTestSuite: FunctionalTest.testCacheConfiguration (master fail rate 
0,0%) 
   ClientTestSuite: IgniteBinaryQueryTest.testBinaryQueries (master fail rate 
0,0%) 
   ClientTestSuite: ReliabilityTest.testFailover (master fail rate 0,0%)  

[~NIzhikov], could you please check? Simplest workaround is merge master into 
branch and re-run, probably these tests were already fixed.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-01 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421624#comment-16421624
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

[~dpavlov] Here they are - 
https://ci.ignite.apache.org/viewLog.html?buildId=1170080

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-30 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420682#comment-16420682
 ] 

Dmitriy Pavlov commented on IGNITE-7691:


First run is more or less ok, let's wait for second run.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-30 Thread Pavel Tupitsyn (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420238#comment-16420238
 ] 

Pavel Tupitsyn commented on IGNITE-7691:


Hi [~NIzhikov], changes look good to me in gerenal, thank you.
Please make sure TeamCity passes.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-29 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419077#comment-16419077
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

Hello, [~ptupitsyn]

Could you, please, review .Net changes I made in PR

https://github.com/apache/ignite/pull/3691

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-29 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419075#comment-16419075
 ] 

Nikolay Izhikov commented on IGNITE-7691:
-

Hello, [~vozerov].

Could you, please, review my changes.
They are required to make integration with Spark Data Frame more correct.

> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411202#comment-16411202
 ] 

ASF GitHub Bot commented on IGNITE-7691:


GitHub user nizhikov opened a pull request:

https://github.com/apache/ignite/pull/3691

IGNITE-7691: Provide info about DECIMAL column scale and precision



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nizhikov/ignite IGNITE-7691

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3691


commit a9c9548301056172454d83cb191a4866e37cb828
Author: Nikolay Izhikov 
Date:   2018-03-07T14:02:00Z

IGNITE-7691: Wrote some tests and empty implementation

commit 1b7604462321e40ea331e28be3f7d6352ffbd65c
Author: Nikolay Izhikov 
Date:   2018-03-14T19:31:38Z

IGNITE-7691: commit in the middle of development

commit 7bf4aee3db6362958c133c23f0efdd8fc8ef11fa
Author: Nikolay Izhikov 
Date:   2018-03-16T10:49:48Z

IGNITE-7691: Couple of edits to follow the way IGNITE-5623 follows.

commit 34b879264851d5b58133cd332d72fdfd2513d270
Author: Nikolay Izhikov 
Date:   2018-03-20T14:20:08Z

IGNITE-7691: One of failed tests fixed.

commit 8ec5d4508b60803dab0026ee1928e30207e4aa1b
Author: Nikolay Izhikov 
Date:   2018-03-22T19:12:45Z

Merge branch 'master' into IGNITE-7691

commit 496566a14ead99d368f8f933469ff7f63df9fa1d
Author: Nikolay Izhikov 
Date:   2018-03-23T09:16:41Z

Merge branch 'master' into IGNITE-7691

commit 4612eb7daad5bf31ccf0b603c2d66992f6185da5
Author: Nikolay Izhikov 
Date:   2018-03-23T10:44:15Z

IGNITE-7691: Tests seems to be OK




> Provide info about DECIMAL column scale and precision
> -
>
> Key: IGNITE-7691
> URL: https://issues.apache.org/jira/browse/IGNITE-7691
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.4
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Minor
> Fix For: 2.5
>
>
> Currently, it impossible to obtain scale and precision of DECIMAL column from 
> sql table metadata.
> Ignite should provide those type of meta information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)