[jira] [Commented] (IGNITE-7737) SQL COPY: rename "batch_size" to "packet_size"

2018-02-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367422#comment-16367422
 ] 

ASF GitHub Bot commented on IGNITE-7737:


Github user devozerov closed the pull request at:

https://github.com/apache/ignite/pull/3533


> SQL COPY: rename "batch_size" to "packet_size"
> --
>
> Key: IGNITE-7737
> URL: https://issues.apache.org/jira/browse/IGNITE-7737
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-7737) SQL COPY: rename "batch_size" to "packet_size"

2018-02-16 Thread Kirill Shirokov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367342#comment-16367342
 ] 

Kirill Shirokov commented on IGNITE-7737:
-

I've found a couple of tiny cosmetic problems in the patch:

1. JdbcThinBulkLoadAbstractSelfTest.java:392: 
typo: packets instead of packets

2. SqlKeyword.java:46
PACKET_SIZE is not in the alphabet order (as the most of the keywords)

> SQL COPY: rename "batch_size" to "packet_size"
> --
>
> Key: IGNITE-7737
> URL: https://issues.apache.org/jira/browse/IGNITE-7737
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-7737) SQL COPY: rename "batch_size" to "packet_size"

2018-02-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366906#comment-16366906
 ] 

ASF GitHub Bot commented on IGNITE-7737:


GitHub user devozerov opened a pull request:

https://github.com/apache/ignite/pull/3533

IGNITE-7737



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3533


commit 8a6e5a7c070968a410aec327c1530b06145c3a26
Author: devozerov 
Date:   2018-02-16T11:52:00Z

Done.




> SQL COPY: rename "batch_size" to "packet_size"
> --
>
> Key: IGNITE-7737
> URL: https://issues.apache.org/jira/browse/IGNITE-7737
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)