[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409332#comment-16409332
 ] 

Pavel Konstantinov commented on IGNITE-7864:


Tested.

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409323#comment-16409323
 ] 

Pavel Konstantinov commented on IGNITE-7864:


Found an issue.
To reproduce
# start ignite.sh
# execute .\control.sh --baseline add 111
{code}
[17:05:37,396][SEVERE][rest-#68][GridRestProcessor] Failed to handle request: 
EXE
class org.apache.ignite.IgniteCheckedException: null
at 
org.apache.ignite.internal.util.IgniteUtils.cast(IgniteUtils.java:7273)
at 
org.apache.ignite.internal.util.future.GridFutureAdapter.resolve(GridFutureAdapter.java:259)
at 
org.apache.ignite.internal.util.future.GridFutureAdapter.get0(GridFutureAdapter.java:171)
at 
org.apache.ignite.internal.util.future.GridFutureAdapter.get(GridFutureAdapter.java:140)
at 
org.apache.ignite.internal.processors.rest.handlers.task.GridTaskCommandHandler$2.apply(GridTaskCommandHandler.java:263)
at 
org.apache.ignite.internal.processors.rest.handlers.task.GridTaskCommandHandler$2.apply(GridTaskCommandHandler.java:257)
at 
org.apache.ignite.internal.util.future.GridFutureAdapter.notifyListener(GridFutureAdapter.java:383)
at 
org.apache.ignite.internal.util.future.GridFutureAdapter.listen(GridFutureAdapter.java:353)
at 
org.apache.ignite.internal.processors.rest.handlers.task.GridTaskCommandHandler.handleAsyncUnsafe(GridTaskCommandHandler.java:257)
at 
org.apache.ignite.internal.processors.rest.handlers.task.GridTaskCommandHandler.handleAsync(GridTaskCommandHandler.java:163)
at 
org.apache.ignite.internal.processors.rest.GridRestProcessor.handleRequest(GridRestProcessor.java:266)
at 
org.apache.ignite.internal.processors.rest.GridRestProcessor.access$100(GridRestProcessor.java:89)
at 
org.apache.ignite.internal.processors.rest.GridRestProcessor$2.body(GridRestProcessor.java:155)
at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at 
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.currentBaseLine(VisorBaselineTask.java:100)
at 
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.add(VisorBaselineTask.java:148)
at 
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:203)
at 
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at 
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:566)
at 
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6652)
at 
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:560)
at 
org.apache.ignite.internal.processors.job.GridJobWorker.body(GridJobWorker.java:489)
at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at 
org.apache.ignite.internal.processors.job.GridJobProcessor.processJobExecuteRequest(GridJobProcessor.java:1123)
at 
org.apache.ignite.internal.processors.task.GridTaskWorker.sendRequest(GridTaskWorker.java:1407)
at 
org.apache.ignite.internal.processors.task.GridTaskWorker.processMappedJobs(GridTaskWorker.java:660)
at 
org.apache.ignite.internal.processors.task.GridTaskWorker.body(GridTaskWorker.java:532)
at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at 
org.apache.ignite.internal.processors.task.GridTaskProcessor.startTask(GridTaskProcessor.java:760)
at 
org.apache.ignite.internal.processors.task.GridTaskProcessor.execute(GridTaskProcessor.java:509)
at 
org.apache.ignite.internal.processors.task.GridTaskProcessor.execute(GridTaskProcessor.java:489)
at 
org.apache.ignite.internal.processors.rest.handlers.task.GridTaskCommandHandler.handleAsyncUnsafe(GridTaskCommandHandler.java:227)
... 8 more
{code}

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Pavel Konstantinov
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, 

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407373#comment-16407373
 ] 

Pavel Konstantinov commented on IGNITE-7864:


Tested.

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Sergey Kosarev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406166#comment-16406166
 ] 

Sergey Kosarev commented on IGNITE-7864:


fixed

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406067#comment-16406067
 ] 

Pavel Konstantinov commented on IGNITE-7864:


Please remove the warning from --baseline command.

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Pavel Konstantinov
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Sergey Kosarev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405984#comment-16405984
 ] 

Sergey Kosarev commented on IGNITE-7864:


1. you are correct, we don't print waring for --baseline as it only prints 
current baseline state.
2. fixed:
  Deactivate cluster:
control.sh [--host HOST_OR_IP] [--port PORT] [--user USER] [--password 
PASSWORD] --deactivate [--force]

  Add nodes into baseline topology:
control.sh [--host HOST_OR_IP] [--port PORT] [--user USER] [--password 
PASSWORD] --baseline add consistentId1[,consistentId2,,consistentIdN] 
[--force]

  Remove nodes from baseline topology:
control.sh [--host HOST_OR_IP] [--port PORT] [--user USER] [--password 
PASSWORD] --baseline remove consistentId1[,consistentId2,,consistentIdN] 
[--force]

  Set baseline topology:
control.sh [--host HOST_OR_IP] [--port PORT] [--user USER] [--password 
PASSWORD] --baseline set consistentId1[,consistentId2,,consistentIdN] 
[--force]

  Set baseline topology based on version:
control.sh [--host HOST_OR_IP] [--port PORT] [--user USER] [--password 
PASSWORD] --baseline version topologyVersion [--force]

By default cluster deactivation and changes in baseline topology commands 
request interactive confirmation. 
  --force option can be used to execute commands without prompting for 
confirmation.

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405741#comment-16405741
 ] 

Pavel Konstantinov commented on IGNITE-7864:


 # Do not print the warning for --baseline


> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Pavel Konstantinov
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Sergey Kosarev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404825#comment-16404825
 ] 

Sergey Kosarev commented on IGNITE-7864:


1. fixed 

2. fixed 
baseline prompt changed to
Warning: the command will perform changes in baseline.

3. fixed 
error will be shown in this case 
Check arguments.
Error: Unexpected argument: ba5afe6e-5a3b-4238-8492-ac577d004112
(--force considered as consistentId)
4. fixed
help for --force added:
"By default cluster deactivation and changes in baseline topology commands 
request interactive confirmation. 
  --force option can be used to execute commands without prompting for 
confirmation."



> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404624#comment-16404624
 ] 

Pavel Konstantinov commented on IGNITE-7864:


NPE in case when executed --baseline w\o cluster
{code}
PS C:\work\ignite-7864\bin> .\control.bat --baseline
Control utility [ver. 2.4.3#19700101-sha1:DEV]
2018 Copyright(C) Apache Software Foundation
User: kope1

Error: java.lang.NullPointerException
{code}

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Pavel Konstantinov
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Sergey Kosarev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401776#comment-16401776
 ] 

Sergey Kosarev commented on IGNITE-7864:


Need to test on Linux/Win/MAc

For Commands 
--deactivate 
--baseline add
--baseline remove
--baseline set
--baseline version 
(notice --baseline without arguments does not require confirmation)
should show warning text annd require interactive confirmation from console
if user responds with y/Y utility will proceed, othertwise exit with zero code 
(success)


if --force option added then confirmation is not requested and commands are 
executing as usual.

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Sergey Kosarev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401760#comment-16401760
 ] 

Sergey Kosarev commented on IGNITE-7864:


It's probably matter of taste I prefer Lists more than Arrays)

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[Sergey Kosarev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401619#comment-16401619
 ] 

Sergey Kosarev commented on IGNITE-7864:


updated PR.
new TC run
https://ci.ignite.apache.org/viewQueued.html?itemId=1139902

> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7864) Control utility: Add confirm on dangerous operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388090#comment-16388090
 ] 

ASF GitHub Bot commented on IGNITE-7864:


GitHub user macrergate opened a pull request:

https://github.com/apache/ignite/pull/3610

IGNITE-7864 Control utility: Add confirm on dangerous operations



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3610


commit dd08ed09c4f770009b7764727b3ffe880f250d61
Author: macrergate 
Date:   2018-03-06T16:45:33Z

IGNITE-7864 Control utility: Add confirm on dangerous operations

commit a3528cd156cd4a1753b96e31727cf3c0ac8fdca7
Author: macrergate 
Date:   2018-03-06T16:48:02Z

Merge branch 'master' of https://github.com/apache/ignite into ignite-7864




> Control utility: Add confirm on dangerous operations
> 
>
> Key: IGNITE-7864
> URL: https://issues.apache.org/jira/browse/IGNITE-7864
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Kuznetsov
>Assignee: Sergey Kosarev
>Priority: Major
> Fix For: 2.5
>
>
> control.sh can deactivate cluster.
> It could be very dangerous in some cases.
> Lets add manual confirmation for dangerous operations: deactivate, change 
> base line, ...
> Also, lets add "-force" option to not ask for confirmation (will be useful in 
> scripts).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)