[jira] [Commented] (IGNITE-7881) Add tests for using TreeMap/TreeSet in cache key

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401883#comment-16401883
 ] 

ASF GitHub Bot commented on IGNITE-7881:


Github user alamar closed the pull request at:

https://github.com/apache/ignite/pull/3602


> Add tests for using TreeMap/TreeSet in cache key
> 
>
> Key: IGNITE-7881
> URL: https://issues.apache.org/jira/browse/IGNITE-7881
> Project: Ignite
>  Issue Type: Task
>  Components: binary, cache
>Affects Versions: 2.3
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.5
>
>
> It came to our attention that in Ignite 1.x, [Binary]TreeMap/TreeSet could 
> not be used in cache keys without configuration or code changes, since 
> equality won't work correctly for them.
> It was since fixed by IGNITE-4558, but test cases won't hurt to nail this 
> behaviour fast.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7881) Add tests for using TreeMap/TreeSet in cache key

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395145#comment-16395145
 ] 

Andrey Gura commented on IGNITE-7881:
-

[~ilyak] Thanks for your contribution!

> Add tests for using TreeMap/TreeSet in cache key
> 
>
> Key: IGNITE-7881
> URL: https://issues.apache.org/jira/browse/IGNITE-7881
> Project: Ignite
>  Issue Type: Task
>  Components: binary, cache
>Affects Versions: 2.3
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.5
>
>
> It came to our attention that in Ignite 1.x, [Binary]TreeMap/TreeSet could 
> not be used in cache keys without configuration or code changes, since 
> equality won't work correctly for them.
> It was since fixed by IGNITE-4558, but test cases won't hurt to nail this 
> behaviour fast.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7881) Add tests for using TreeMap/TreeSet in cache key

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395143#comment-16395143
 ] 

Andrey Gura commented on IGNITE-7881:
-

[~dpavlov] This change adds a couple tests and doesn't affect other tests.

> Add tests for using TreeMap/TreeSet in cache key
> 
>
> Key: IGNITE-7881
> URL: https://issues.apache.org/jira/browse/IGNITE-7881
> Project: Ignite
>  Issue Type: Task
>  Components: binary, cache
>Affects Versions: 2.3
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.5
>
>
> It came to our attention that in Ignite 1.x, [Binary]TreeMap/TreeSet could 
> not be used in cache keys without configuration or code changes, since 
> equality won't work correctly for them.
> It was since fixed by IGNITE-4558, but test cases won't hurt to nail this 
> behaviour fast.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7881) Add tests for using TreeMap/TreeSet in cache key

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386111#comment-16386111
 ] 

Dmitriy Pavlov commented on IGNITE-7881:


Please use Run-All for check changes. 1 suite from 98 can't give us 
representative picture of impact of the issue.

> Add tests for using TreeMap/TreeSet in cache key
> 
>
> Key: IGNITE-7881
> URL: https://issues.apache.org/jira/browse/IGNITE-7881
> Project: Ignite
>  Issue Type: Task
>  Components: binary, cache
>Affects Versions: 2.3
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.5
>
>
> It came to our attention that in Ignite 1.x, [Binary]TreeMap/TreeSet could 
> not be used in cache keys without configuration or code changes, since 
> equality won't work correctly for them.
> It was since fixed by IGNITE-4558, but test cases won't hurt to nail this 
> behaviour fast.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7881) Add tests for using TreeMap/TreeSet in cache key

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385994#comment-16385994
 ] 

ASF GitHub Bot commented on IGNITE-7881:


GitHub user alamar opened a pull request:

https://github.com/apache/ignite/pull/3602

IGNITE-7881 Tests for using TreeMap or TreeSet as cache key.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7881

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3602


commit 567d2007b69884f0448115fd88733e8f9aba0534
Author: Ilya Kasnacheev 
Date:   2018-03-05T12:06:51Z

IGNITE-7881 Tests for using TreeMap or TreeSet as cache key.




> Add tests for using TreeMap/TreeSet in cache key
> 
>
> Key: IGNITE-7881
> URL: https://issues.apache.org/jira/browse/IGNITE-7881
> Project: Ignite
>  Issue Type: Task
>  Components: binary, cache
>Affects Versions: 2.3
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.5
>
>
> It came to our attention that in Ignite 1.x, [Binary]TreeMap/TreeSet could 
> not be used in cache keys without configuration or code changes, since 
> equality won't work correctly for them.
> It was since fixed by IGNITE-4558, but test cases won't hurt to nail this 
> behaviour fast.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)