[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418922#comment-16418922
 ] 

ASF GitHub Bot commented on IGNITE-7962:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3649


> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.5
>
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-28 Thread Igor Seliverstov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418442#comment-16418442
 ] 

Igor Seliverstov commented on IGNITE-7962:
--

[~dpavlov], now it's better, looks OK to me.

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-28 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417801#comment-16417801
 ] 

Dmitriy Pavlov commented on IGNITE-7962:


[~gvvinblade], PR  updated. Is it OK for you now?

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-25 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413107#comment-16413107
 ] 

Dmitriy Pavlov commented on IGNITE-7962:


[~gvvinblade], thank you for reviewing the changes. 

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-25 Thread Igor Seliverstov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413101#comment-16413101
 ] 

Igor Seliverstov commented on IGNITE-7962:
--

[~ilyak], [~dpavlov], changes in {{DataStreamerImpl.IsolatedUpdater#receive}} 
are OK, but {{DataStreamerImpl.Buffer#submit}} isn't expected to throw any 
exceptions except {{IgniteDataStreamerTimeoutException}}. What you need to do 
is to finish {{curFut}} with corresponding exception and return. It will cancel 
DataStreamer in a proper way.

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-23 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411249#comment-16411249
 ] 

Dmitriy Pavlov commented on IGNITE-7962:


[~gvvinblade], change seems reasonable to me, but I would like to hear expert 
opinion. Could you please take a look?

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-23 Thread Ilya Kasnacheev (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411126#comment-16411126
 ] 

Ilya Kasnacheev commented on IGNITE-7962:
-

[~dpavlov] I expect a formal review from you.

No, I didn't perform performance testing, but I don't see why it will be 
affected.

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-22 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409511#comment-16409511
 ] 

Dmitriy Pavlov commented on IGNITE-7962:


[~ilyak], why do you mention two reviewers? From whom you are expecting review? 

Did you perfomed performance testing?

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-22 Thread Ilya Kasnacheev (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409489#comment-16409489
 ] 

Ilya Kasnacheev commented on IGNITE-7962:
-

[~agoncharuk] please take a look in case you have any reservations

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-22 Thread Ilya Kasnacheev (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409485#comment-16409485
 ] 

Ilya Kasnacheev commented on IGNITE-7962:
-

[~dpavlov] please review this fix

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401880#comment-16401880
 ] 

ASF GitHub Bot commented on IGNITE-7962:


GitHub user alamar opened a pull request:

https://github.com/apache/ignite/pull/3649

IGNITE-7962 Avoid swallowing unexpected exceptions.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7962

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3649


commit 2cb6d469e89758684de3391ee679da250173b6b1
Author: Ilya Kasnacheev 
Date:   2018-03-16T13:23:03Z

IGNITE-7962 Avoid swallowing unexpected exceptions.




> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7962) More cases of suppressed exceptions in IsolatedUpdater

2018-03-15 Thread Dmitriy Setrakyan (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400342#comment-16400342
 ] 

Dmitriy Setrakyan commented on IGNITE-7962:
---

We must make sure that whatever changes are made to the data streamer, the 
performance should not degrade. Please make sure to aggressively benchmark 
before and after the change to ensure that there is no effect on the 
performance.

> More cases of suppressed exceptions in IsolatedUpdater
> --
>
> Key: IGNITE-7962
> URL: https://issues.apache.org/jira/browse/IGNITE-7962
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.4
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> IsolatedUpdater is a StreamReciever.
> The contract for StreamReciever.recieve() is, @throws 
> org.apache.ignite.IgniteException If failed.
> However, there's a number of cases where this doesn't happen and exceptions 
> are suppressed after being written in server log. Should replace (or augment) 
> log.error()'s with throw new IgniteException().
> See maillist discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)