[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418959#comment-16418959
 ] 

ASF GitHub Bot commented on IGNITE-8025:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3687


> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418791#comment-16418791
 ] 

Andrey Kuznetsov commented on IGNITE-8025:
--

[~dpavlov], thanks for your alertness. I've executed this suite again, and it 
turned green. Probably, new flaky tests nave been found.

> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418681#comment-16418681
 ] 

Dmitriy Pavlov commented on IGNITE-8025:


I've found 2 suspicious tests
   Binary Objects (Simple Mapper Queries) [ tests 4 ]  
...
 IgniteBinarySimpleNameMapperCacheQueryTestSuite: 
IgniteCacheLocalQueryCancelOrTimeoutSelfTest.testQueryCancelZeroTimeout (master 
fail rate 0,0%) 
 IgniteBinarySimpleNameMapperCacheQueryTestSuite: 
IgniteSqlSplitterSelfTest.testReplicatedTablesUsingPartitionedCacheClient 
(master fail rate 0,0%) 

Could you please check if these failures not related to change?

> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417875#comment-16417875
 ] 

Andrey Kuznetsov commented on IGNITE-8025:
--

[~dpavlov], I've launched some suites (including Memory Leaks) separately to 
ensure test validity. So, there is no need to wait for one more launch 
completion.

> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417841#comment-16417841
 ] 

Dmitriy Pavlov commented on IGNITE-8025:


Change itself looks reasonable to me.

> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417818#comment-16417818
 ] 

Dmitriy Pavlov commented on IGNITE-8025:


[~andrey-kuznetsov], it seems run-all was not finished because of cancel Ignite 
Mem Leaks suite.

So I've re-triggered run-all 
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll_IgniteTests24Java8=pull%2F3687%2Fhead=buildTypeStatusDiv

Hope it will be completed today by night.

> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411596#comment-16411596
 ] 

Dmitriy Pavlov commented on IGNITE-8025:


[~andrey-kuznetsov], I left one question, will review later rest of this change.

> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8025) Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410892#comment-16410892
 ] 

ASF GitHub Bot commented on IGNITE-8025:


GitHub user andrey-kuznetsov opened a pull request:

https://github.com/apache/ignite/pull/3687

IGNITE-8025 runMultiThreadedAsync cancellation fix.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrey-kuznetsov/ignite ignite-8025

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3687


commit 2b6dd75e80a1b59ec04c2a5a8d9cf147b736822d
Author: Andrey Kuznetsov 
Date:   2018-03-23T06:46:41Z

IGNITE-8025 runMultiThreadedAsync cancellation fix.




> Result of GridTestUtils.runMultiThreadedAsync has a bug in cancel() 
> implementation
> --
>
> Key: IGNITE-8025
> URL: https://issues.apache.org/jira/browse/IGNITE-8025
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.4
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
>  Labels: MakeTeamcityGreenAgain, test
> Fix For: 2.5
>
> Attachments: BugRunMTAsyncTest.java
>
>
> GridTestUtils.runMultiThreadedAsync returns a future with cancel() support, 
> but cancellation implementation never interrupts threads that execute 
> user-provided tasks. That is, those threads can continue their execution even 
> after test method finishes.
> The reproducer attached demonstrates activity from threads created by test0 
> after test0 finished and test1 is being run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)