[jira] [Commented] (IGNITE-8544) WAL disabling during rebalance mechanism uses wrong topology version in case of exchanges merge

2018-05-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482945#comment-16482945
 ] 

ASF GitHub Bot commented on IGNITE-8544:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4039


> WAL disabling during rebalance mechanism uses wrong topology version in case 
> of exchanges merge
> ---
>
> Key: IGNITE-8544
> URL: https://issues.apache.org/jira/browse/IGNITE-8544
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.5
>Reporter: Pavel Kovalenko
>Assignee: Pavel Kovalenko
>Priority: Critical
> Fix For: 2.6
>
>
> After exchange is done, we're using initial exchange version to determine 
> topology version on what rebalance should be finished and save it. After 
> rebalance finishing we check current topology version and saved version and 
> if they are equal, we enable WAL, own partitions and do checkpoint. In other 
> case we do nothing, because of topology change. 
> In case of exchanges merge we're saving old topology version (before merge) 
> and it leads to ignoring logic of enabling WAL and etc, because check on 
> topology version will be always false-negative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8544) WAL disabling during rebalance mechanism uses wrong topology version in case of exchanges merge

2018-05-21 Thread Alexey Goncharuk (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482943#comment-16482943
 ] 

Alexey Goncharuk commented on IGNITE-8544:
--

Looks good, merged to master.

> WAL disabling during rebalance mechanism uses wrong topology version in case 
> of exchanges merge
> ---
>
> Key: IGNITE-8544
> URL: https://issues.apache.org/jira/browse/IGNITE-8544
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.5
>Reporter: Pavel Kovalenko
>Assignee: Pavel Kovalenko
>Priority: Critical
> Fix For: 2.6
>
>
> After exchange is done, we're using initial exchange version to determine 
> topology version on what rebalance should be finished and save it. After 
> rebalance finishing we check current topology version and saved version and 
> if they are equal, we enable WAL, own partitions and do checkpoint. In other 
> case we do nothing, because of topology change. 
> In case of exchanges merge we're saving old topology version (before merge) 
> and it leads to ignoring logic of enabling WAL and etc, because check on 
> topology version will be always false-negative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8544) WAL disabling during rebalance mechanism uses wrong topology version in case of exchanges merge

2018-05-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482588#comment-16482588
 ] 

ASF GitHub Bot commented on IGNITE-8544:


GitHub user Jokser opened a pull request:

https://github.com/apache/ignite/pull/4039

IGNITE-8544 Use exchange result topology version for local wal state change



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8544

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4039


commit 139a1fe580f777c081d073cca8199369de1878dd
Author: Pavel Kovalenko 
Date:   2018-05-21T15:01:21Z

IGNITE-8544 Use exchange result topology version for local wal state 
management.




> WAL disabling during rebalance mechanism uses wrong topology version in case 
> of exchanges merge
> ---
>
> Key: IGNITE-8544
> URL: https://issues.apache.org/jira/browse/IGNITE-8544
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.5
>Reporter: Pavel Kovalenko
>Assignee: Pavel Kovalenko
>Priority: Critical
> Fix For: 2.6
>
>
> After exchange is done, we're using initial exchange version to determine 
> topology version on what rebalance should be finished and save it. After 
> rebalance finishing we check current topology version and saved version and 
> if they are equal, we enable WAL, own partitions and do checkpoint. In other 
> case we do nothing, because of topology change. 
> In case of exchanges merge we're saving old topology version (before merge) 
> and it leads to ignoring logic of enabling WAL and etc, because check on 
> topology version will be always false-negative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)