[jira] [Commented] (IGNITE-8683) Tests fail after IGNITE-6639
[ https://issues.apache.org/jira/browse/IGNITE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559967#comment-16559967 ] Dmitriy Pavlov commented on IGNITE-8683: Hi, fix version is empty. I've set 2.7, please set another version if commit was cherry-picked. > Tests fail after IGNITE-6639 > > > Key: IGNITE-8683 > URL: https://issues.apache.org/jira/browse/IGNITE-8683 > Project: Ignite > Issue Type: Bug >Reporter: Mikhail Cherkasov >Assignee: Mikhail Cherkasov >Priority: Major > Fix For: 2.7 > > > Example of failed tests: > org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeSelfTest#testDeployOnEachNodeButClientUpdateTopology > > instead of checking address for loopback we should compare addr with locHost, > because nodes can use the same port, but different local address and both > addresses can be loopback. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8683) Tests fail after IGNITE-6639
[ https://issues.apache.org/jira/browse/IGNITE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527624#comment-16527624 ] Mikhail Cherkasov commented on IGNITE-8683: --- [~agoncharuk] I fixed this, now first I check for port equality, then I check if address equals to local OR if we listens on 0:0:0:0 I check if remote address belongs to any local interface. > Tests fail after IGNITE-6639 > > > Key: IGNITE-8683 > URL: https://issues.apache.org/jira/browse/IGNITE-8683 > Project: Ignite > Issue Type: Bug >Reporter: Mikhail Cherkasov >Assignee: Mikhail Cherkasov >Priority: Major > > Example of failed tests: > org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeSelfTest#testDeployOnEachNodeButClientUpdateTopology > > instead of checking address for loopback we should compare addr with locHost, > because nodes can use the same port, but different local address and both > addresses can be loopback. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8683) Tests fail after IGNITE-6639
[ https://issues.apache.org/jira/browse/IGNITE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527346#comment-16527346 ] Alexey Goncharuk commented on IGNITE-8683: -- Not quite agree with the change. If localHost is {{0.0.0.0}}, then the check {{addr.equals(locHost)}} will be {{false}}, and we may attempt to connect to the local node. If {{locHost}} is {{0.0.0.0}}, we need to capture all local IPs during the server start and check if we are connecting to one of those addresses. > Tests fail after IGNITE-6639 > > > Key: IGNITE-8683 > URL: https://issues.apache.org/jira/browse/IGNITE-8683 > Project: Ignite > Issue Type: Bug >Reporter: Mikhail Cherkasov >Assignee: Mikhail Cherkasov >Priority: Major > > Example of failed tests: > org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeSelfTest#testDeployOnEachNodeButClientUpdateTopology > > instead of checking address for loopback we should compare addr with locHost, > because nodes can use the same port, but different local address and both > addresses can be loopback. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8683) Tests fail after IGNITE-6639
[ https://issues.apache.org/jira/browse/IGNITE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512543#comment-16512543 ] Mikhail Cherkasov commented on IGNITE-8683: --- [~dpavlov] TC looks good: [https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8_IgniteTests24Java8=pull%2F4109%2Fhead] [~agoncharuk] could you please take a look at this changeset and push it to master repo? > Tests fail after IGNITE-6639 > > > Key: IGNITE-8683 > URL: https://issues.apache.org/jira/browse/IGNITE-8683 > Project: Ignite > Issue Type: Bug >Reporter: Mikhail Cherkasov >Assignee: Mikhail Cherkasov >Priority: Major > > Example of failed tests: > org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeSelfTest#testDeployOnEachNodeButClientUpdateTopology > > instead of checking address for loopback we should compare addr with locHost, > because nodes can use the same port, but different local address and both > addresses can be loopback. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8683) Tests fail after IGNITE-6639
[ https://issues.apache.org/jira/browse/IGNITE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507035#comment-16507035 ] Dmitriy Pavlov commented on IGNITE-8683: [~mcherkasov], could you also share TC run? > Tests fail after IGNITE-6639 > > > Key: IGNITE-8683 > URL: https://issues.apache.org/jira/browse/IGNITE-8683 > Project: Ignite > Issue Type: Bug >Reporter: Mikhail Cherkasov >Assignee: Mikhail Cherkasov >Priority: Major > > Example of failed tests: > org.apache.ignite.internal.processors.service.GridServiceProcessorMultiNodeSelfTest#testDeployOnEachNodeButClientUpdateTopology > > instead of checking address for loopback we should compare addr with locHost, > because nodes can use the same port, but different local address and both > addresses can be loopback. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)