[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-09-06 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605594#comment-16605594
 ] 

ASF GitHub Bot commented on IGNITE-8915:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4414


> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-09-06 Thread Vladimir Ozerov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605545#comment-16605545
 ] 

Vladimir Ozerov commented on IGNITE-8915:
-

[~NIzhikov], 

Looks good to me.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-09-05 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604025#comment-16604025
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~vozerov], [~zstan] Guys. I'm planning to merge extended patch if no one has 
any objections.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-24 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591293#comment-16591293
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

Lates Run All - https://ci.ignite.apache.org/viewLog.html?buildId=1715542

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-20 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585790#comment-16585790
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~vozerov]

> we should not prevent local queries from being executed over LOCAL cache on a 
> client

OK. I've updated PR

Please, take a look.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-20 Thread Vladimir Ozerov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585575#comment-16585575
 ] 

Vladimir Ozerov commented on IGNITE-8915:
-

[~NIzhikov], I thought about it a bit more and now think that we should not 
prevent local queries from being executed over LOCAL cache on a client. From 
user perspective this is not a matter of API consistency, but rather about data 
distribution. {{PARTITIONED}} and {{REPLICATED}} are never located on client 
nodes. \{{LOCAL}} cache is a different story - it can be located on a client 
node. For this reason I do not think we should throw an exception in this case.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-14 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579580#comment-16579580
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~vozerov]

> goes directly to query processor.

Got it.
I moved checks to {{GridQueryProcessor#validateSqlFieldsQuery}}, so they will 
be executed for your case.

> What exactly concerns you?

For now, I propose to disallow execution of *local* sql queries for all types 
of caches(including LOCAL cache) to preserve API consistency.
Is it correct?

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-14 Thread Vladimir Ozerov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579429#comment-16579429
 ] 

Vladimir Ozerov commented on IGNITE-8915:
-

[~NIzhikov], my comment about JDBC/ODBC was about thin drivers. Please see how 
it is executed here: 
{{org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler#executeQuery}}.
 That is, it bypasses cache objects, and goes directly to query processor.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-14 Thread Vladimir Ozerov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579431#comment-16579431
 ] 

Vladimir Ozerov commented on IGNITE-8915:
-

Hi [~zstan], I am not sure I understand your question. What exactly concerns 
you?

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-07 Thread Stanilovsky Evgeny (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571413#comment-16571413
 ] 

Stanilovsky Evgeny commented on IGNITE-8915:


I don`t understand why we need to fail in case of : 
IgniteCacheLocalQuerySelfTest, [~vozerov] can u comment here?

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-08-05 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569419#comment-16569419
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~zstan] Did you have a chance to look at patch?

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-31 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563473#comment-16563473
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~zstan]

>  is it works properly well for LOCAL cache created on client side too?

It will throw the same exception.

I moved tests to {{IgniteCacheAbstractQuerySelfTest}} so now it tested for all 
types of caches.

https://github.com/apache/ignite/pull/4414

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-29 Thread Stanilovsky Evgeny (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561119#comment-16561119
 ] 

Stanilovsky Evgeny commented on IGNITE-8915:


[~NIzhikov], thanks, is it works properly well for LOCAL cache created on 
client side too?

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-27 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559363#comment-16559363
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~zstan], [~vozerov]

Guys, please, share your thoughts about an extended patch.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-24 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553938#comment-16553938
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~zstan], [~vozerov]

1. Check for a {{SqlFieldsQuery}} added.
2. Checks moved to a {{GridQueryProcessor}}
3. Tests added.

Please, review PR

https://github.com/apache/ignite/pull/4414

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553936#comment-16553936
 ] 

ASF GitHub Bot commented on IGNITE-8915:


GitHub user nizhikov opened a pull request:

https://github.com/apache/ignite/pull/4414

IGNITE-8915: Check moved to GridQueryProcessor. Check for SqlFieldsQuery 
added.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nizhikov/ignite IGNITE-8915

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4414


commit 0181ca3d835235b50b768d92b9671f2d4ce9e354
Author: Nikolay Izhikov 
Date:   2018-07-03T13:14:43Z

IGNITE-8915: NPE reproducer.

commit c084cce9d81b4bd8311d5f718befeca3dd40d211
Author: Nikolay Izhikov 
Date:   2018-07-17T08:16:09Z

Merge branch 'master' into IGNITE-8915

commit c78f688dd2bdd1309b7bafe15062bafa5090a110
Author: Nikolay Izhikov 
Date:   2018-07-18T08:38:48Z

Merge branch 'master' into IGNITE-8915

commit 99246843676c5ef9bf27b4eeb902bba7216751c4
Author: Nikolay Izhikov 
Date:   2018-07-18T09:15:05Z

IGNITE-8915: Test and fix.

commit 79f4ac22e29fe018f8f6f597667e69691157196e
Author: Nikolay Izhikov 
Date:   2018-07-19T11:15:38Z

Merge branch 'master' into IGNITE-8915

commit da788b5b11e5ea29b263c088ec3115efe5ac4e33
Author: Nikolay Izhikov 
Date:   2018-07-23T11:37:21Z

Merge branch 'master' into IGNITE-8915

commit e724b9118a44c87bbde3183cf4f96d5e70b8a543
Author: Nikolay Izhikov 
Date:   2018-07-24T07:12:53Z

IGNITE-8915: Added SqlFieldsQuery check. Tests added.

commit 5d19aa48d15927c9a87c5d3b051c7a2f8d08c5d4
Author: Nikolay Izhikov 
Date:   2018-07-24T07:57:00Z

IGNITE-8915: Checks moved to GridQueryProcessor.




> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-23 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552807#comment-16552807
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~vozerov]

> 4) JDBC and ODBC drivers do not use IgniteCacheProxyImpl, so implemented 
> check is skipped altogether. For SQL you should use 
> GridQueryProcessor.querySqlFields and GridQueryProcessor.querySql methods. 
> Also we need tests for JDBC.

If I understand you correctly by {JDBC} you mean JdbcClientDriver. 
Only it has {local} param.
Currently, we can use server {nodeId} only for this type of driver.
You can look at test {JdbcConnectionSelfTest.testClientNodeId}
So, no additional fix required here.

Can you confirm it?

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-23 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552689#comment-16552689
 ] 

Nikolay Izhikov commented on IGNITE-8915:
-

[~vozerov] Thanks for comments. I will extend fix according to them.

[~zstan] I will reopen this issue and extend fix according to Vladimir comments.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-23 Thread Stanilovsky Evgeny (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552654#comment-16552654
 ] 

Stanilovsky Evgeny commented on IGNITE-8915:


[~NIzhikov] if you panning to open ticket for fix, plz mention it here, thanks !

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-23 Thread Vladimir Ozerov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552629#comment-16552629
 ] 

Vladimir Ozerov commented on IGNITE-8915:
-

[~daradurvs], [~NIzhikov], fix looks incomplete to me:
1) There is no check for {{SqlFieldsQuery}}
2) There are no tests for {{SqlFieldsQuery}} and non-REPLICATED caches
3) Why {{ScanQuery}} and {{TextQuery}} doesn't use the same check?
4) JDBC and ODBC drivers do not use {{IgniteCacheProxyImpl}}, so implemented 
check is skipped altogether. For SQL you should use 
{{GridQueryProcessor.querySqlFields}} and {{GridQueryProcessor.querySql}} 
methods. Also we need tests for JDBC.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-20 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550692#comment-16550692
 ] 

ASF GitHub Bot commented on IGNITE-8915:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4378


> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-18 Thread Vyacheslav Daradur (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547625#comment-16547625
 ] 

Vyacheslav Daradur commented on IGNITE-8915:


[~NIzhikov], changes look good to me.

Let's make sure that there are not new failures in tests on TC which are 
affected by the changes.

> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Fix For: 2.7
>
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].
> UPD:
> Right behavior:
> Local query should be forbidden and a sensible exception should be thrown if 
> it is executed on client node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8915) NPE during executing local SqlQuery from client node

2018-07-18 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547595#comment-16547595
 ] 

ASF GitHub Bot commented on IGNITE-8915:


GitHub user nizhikov opened a pull request:

https://github.com/apache/ignite/pull/4378

IGNITE-8915: NPE on local sql query for client node.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nizhikov/ignite IGNITE-8915

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4378


commit 0181ca3d835235b50b768d92b9671f2d4ce9e354
Author: Nikolay Izhikov 
Date:   2018-07-03T13:14:43Z

IGNITE-8915: NPE reproducer.

commit c084cce9d81b4bd8311d5f718befeca3dd40d211
Author: Nikolay Izhikov 
Date:   2018-07-17T08:16:09Z

Merge branch 'master' into IGNITE-8915

commit c78f688dd2bdd1309b7bafe15062bafa5090a110
Author: Nikolay Izhikov 
Date:   2018-07-18T08:38:48Z

Merge branch 'master' into IGNITE-8915

commit 99246843676c5ef9bf27b4eeb902bba7216751c4
Author: Nikolay Izhikov 
Date:   2018-07-18T09:15:05Z

IGNITE-8915: Test and fix.




> NPE during executing local SqlQuery from client node
> 
>
> Key: IGNITE-8915
> URL: https://issues.apache.org/jira/browse/IGNITE-8915
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Vyacheslav Daradur
>Assignee: Nikolay Izhikov
>Priority: Major
> Attachments: IgniteCacheReplicatedClientLocalQuerySelfTest.java
>
>
> NPE when trying to execute {{SqlQuery}} with {{setLocal(true)}} from client 
> node.
> [Reproducer|^IgniteCacheReplicatedClientLocalQuerySelfTest.java].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)