[jira] [Commented] (IGNITE-8939) Transaction string reprsentation unhandled exception
[
https://issues.apache.org/jira/browse/IGNITE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565138#comment-16565138
]
ASF GitHub Bot commented on IGNITE-8939:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/4454
> Transaction string reprsentation unhandled exception
>
>
> Key: IGNITE-8939
> URL: https://issues.apache.org/jira/browse/IGNITE-8939
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Reporter: Evgenii Zagumennov
>Assignee: Stanilovsky Evgeny
>Priority: Major
> Fix For: 2.7
>
>
> IgniteTxHandler.finishDhtLocal() (IgniteTxHandler.java:957)
> {code:java}
> U.error(log, "Failed completing transaction [commit=" + req.commit() + ",
> tx=" + *tx* + ']', e);{code}
> tx.toString() can lead to excepion (in GridToStringBuilder.toStringImpl()),
> and original exception in transaction will be lost. We need to log original
> exception and catch probable tx.toString() exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8939) Transaction string reprsentation unhandled exception
[
https://issues.apache.org/jira/browse/IGNITE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565133#comment-16565133
]
Dmitriy Pavlov commented on IGNITE-8939:
Merged to master, [~zstan], thank you for contribution, [~agura], thank you for
review.
> Transaction string reprsentation unhandled exception
>
>
> Key: IGNITE-8939
> URL: https://issues.apache.org/jira/browse/IGNITE-8939
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Reporter: Evgenii Zagumennov
>Assignee: Stanilovsky Evgeny
>Priority: Major
> Fix For: 2.7
>
>
> IgniteTxHandler.finishDhtLocal() (IgniteTxHandler.java:957)
> {code:java}
> U.error(log, "Failed completing transaction [commit=" + req.commit() + ",
> tx=" + *tx* + ']', e);{code}
> tx.toString() can lead to excepion (in GridToStringBuilder.toStringImpl()),
> and original exception in transaction will be lost. We need to log original
> exception and catch probable tx.toString() exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8939) Transaction string reprsentation unhandled exception
[
https://issues.apache.org/jira/browse/IGNITE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564178#comment-16564178
]
Stanilovsky Evgeny commented on IGNITE-8939:
looks good for me
> Transaction string reprsentation unhandled exception
>
>
> Key: IGNITE-8939
> URL: https://issues.apache.org/jira/browse/IGNITE-8939
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Reporter: Evgenii Zagumennov
>Assignee: Stanilovsky Evgeny
>Priority: Major
>
> IgniteTxHandler.finishDhtLocal() (IgniteTxHandler.java:957)
> {code:java}
> U.error(log, "Failed completing transaction [commit=" + req.commit() + ",
> tx=" + *tx* + ']', e);{code}
> tx.toString() can lead to excepion (in GridToStringBuilder.toStringImpl()),
> and original exception in transaction will be lost. We need to log original
> exception and catch probable tx.toString() exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8939) Transaction string reprsentation unhandled exception
[
https://issues.apache.org/jira/browse/IGNITE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562310#comment-16562310
]
Stanilovsky Evgeny commented on IGNITE-8939:
[~agura] plz, take a look, is it correct? thanks.
> Transaction string reprsentation unhandled exception
>
>
> Key: IGNITE-8939
> URL: https://issues.apache.org/jira/browse/IGNITE-8939
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Reporter: Evgenii Zagumennov
>Assignee: Stanilovsky Evgeny
>Priority: Major
>
> IgniteTxHandler.finishDhtLocal() (IgniteTxHandler.java:957)
> {code:java}
> U.error(log, "Failed completing transaction [commit=" + req.commit() + ",
> tx=" + *tx* + ']', e);{code}
> tx.toString() can lead to excepion (in GridToStringBuilder.toStringImpl()),
> and original exception in transaction will be lost. We need to log original
> exception and catch probable tx.toString() exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8939) Transaction string reprsentation unhandled exception
[
https://issues.apache.org/jira/browse/IGNITE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561783#comment-16561783
]
ASF GitHub Bot commented on IGNITE-8939:
GitHub user zstan opened a pull request:
https://github.com/apache/ignite/pull/4454
IGNITE-8939 Catch and proper propagate transaction string reprsentation
i have no reproducer here, but sometimes when schema for object can`t be
found in server side tx toString can throw exception which can lead into
failure handler.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8939-zstan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4454
commit a7dca517e72fa318c38e01cdce8d0c641151e6ba
Author: Evgeny Stanilovskiy
Date: 2018-07-30T11:03:29Z
IGNITE-8939 Catch and proper propagate transaction string reprsentation
> Transaction string reprsentation unhandled exception
>
>
> Key: IGNITE-8939
> URL: https://issues.apache.org/jira/browse/IGNITE-8939
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Reporter: Evgenii Zagumennov
>Assignee: Stanilovsky Evgeny
>Priority: Major
>
> IgniteTxHandler.finishDhtLocal() (IgniteTxHandler.java:957)
> {code:java}
> U.error(log, "Failed completing transaction [commit=" + req.commit() + ",
> tx=" + *tx* + ']', e);{code}
> tx.toString() can lead to excepion (in GridToStringBuilder.toStringImpl()),
> and original exception in transaction will be lost. We need to log original
> exception and catch probable tx.toString() exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8939) Transaction string reprsentation unhandled exception
[
https://issues.apache.org/jira/browse/IGNITE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558178#comment-16558178
]
Alexei Scherbakov commented on IGNITE-8939:
---
I suggest using CU.txString(tx) for printing transaction.
There are some places where it's not still changed.
> Transaction string reprsentation unhandled exception
>
>
> Key: IGNITE-8939
> URL: https://issues.apache.org/jira/browse/IGNITE-8939
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Reporter: Evgenii Zagumennov
>Priority: Major
>
> IgniteTxHandler.finishDhtLocal() (IgniteTxHandler.java:957)
> {code:java}
> U.error(log, "Failed completing transaction [commit=" + req.commit() + ",
> tx=" + *tx* + ']', e);{code}
> tx.toString() can lead to excepion (in GridToStringBuilder.toStringImpl()),
> and original exception in transaction will be lost. We need to log original
> exception and catch probable tx.toString() exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
