[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-12-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728515#comment-16728515
 ] 

ASF GitHub Bot commented on IGNITE-9149:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4635


> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
> Fix For: 2.8
>
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-12-24 Thread Dmitriy Govorukhin (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728514#comment-16728514
 ] 

Dmitriy Govorukhin commented on IGNITE-9149:


[~PetrovMikhail] Thanks for the contribution! [~ilantukh] Thanks for the 
review. Changes merged to master.

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
> Fix For: 2.8
>
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-12-24 Thread Ilya Lantukh (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728396#comment-16728396
 ] 

Ilya Lantukh commented on IGNITE-9149:
--

Thanks for the contribution! Changes look good.

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-12-14 Thread PetrovMikhail (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721489#comment-16721489
 ] 

PetrovMikhail commented on IGNITE-9149:
---

[~Mmuzaf] I fixed all you mentioned. Can you take a look again, please.

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-12-14 Thread Dmitriy Pavlov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721482#comment-16721482
 ] 

Dmitriy Pavlov commented on IGNITE-9149:


Are any docs required here? 

[~PetrovMikhail] do you have any updates?

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-11-07 Thread Maxim Muzafarov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678268#comment-16678268
 ] 

Maxim Muzafarov commented on IGNITE-9149:
-

[~PetrovMikhail]

Thank you for your work! 
I think the changes are almost ready. I've left some comments in your PR.

Please, fix them and set Patch Available status to this issue.

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-11-01 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671249#comment-16671249
 ] 

Ignite TC Bot commented on IGNITE-9149:
---

{panel:title=No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity Run All 
Results|http://ci.ignite.apache.org/viewLog.html?buildId=2209918buildTypeId=IgniteTests24Java8_RunAll]

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-10-31 Thread PetrovMikhail (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670207#comment-16670207
 ] 

PetrovMikhail commented on IGNITE-9149:
---

Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-938

PR: https://github.com/apache/ignite/pull/4635


> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-10-31 Thread PetrovMikhail (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670199#comment-16670199
 ] 

PetrovMikhail commented on IGNITE-9149:
---

All failed tests passe locally.


> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-10-31 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670197#comment-16670197
 ] 

Ignite TC Bot commented on IGNITE-9149:
---

{panel:title=Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Continuous Query 1{color} [[tests 
4|https://ci.ignite.apache.org/viewLog.html?buildId=2209820]]
* IgniteCacheQuerySelfTestSuite3: 
IgniteCacheContinuousQueryReconnectTest.testReconnectServer - 0,0% fails in 
last 100 master runs.

{color:#d04437}Cache (Restarts) 1{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=2209878]]
* IgniteCacheRestartTestSuite: 
GridCachePartitionedNodeRestartTest.testRestartWithPutTenNodesTwoBackups - 0,0% 
fails in last 100 master runs.

{color:#d04437}Cache 4{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=2209884]]
* IgniteCacheTestSuite4: 
CacheStoreUsageMultinodeDynamicStartTxTest.testDynamicStartFromClientWriteBehindStore
 - 0,0% fails in last 100 master runs.

{panel}
[TeamCity Run All 
Results|http://ci.ignite.apache.org/viewLog.html?buildId=2209918buildTypeId=IgniteTests24Java8_RunAll]

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-08-29 Thread PetrovMikhail (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596064#comment-16596064
 ] 

PetrovMikhail commented on IGNITE-9149:
---

Get rid of logging remaining supplier nodes rebalance time

PR:  [https://github.com/apache/ignite/pull/4635]

TC: 
[https://ci.ignite.apache.org/viewLog.html?buildId=1751553=buildResultsDiv=IgniteTests24Java8_RunAll]

Project is buildable, tests are ok, flacky as usual. [~Mmuzaf], please, review 
my change.

 

> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-08-28 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595130#comment-16595130
 ] 

ASF GitHub Bot commented on IGNITE-9149:


GitHub user ololo3000 opened a pull request:

https://github.com/apache/ignite/pull/4635

IGNITE-9149 Get rid of logging remaining supplier nodes rebalance time



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ololo3000/ignite IGNITE-9149

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4635


commit f3320b678b9f1be17bff433b32d8cc2cf26d1ae2
Author: ololo3000 
Date:   2018-08-28T14:24:18Z

IGNITE-9149 Get rid of logging remaining supplier nodes rebalance time




> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: PetrovMikhail
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time

2018-08-03 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568216#comment-16568216
 ] 

ASF GitHub Bot commented on IGNITE-9149:


GitHub user ivandasch opened a pull request:

https://github.com/apache/ignite/pull/4483

IGNITE-9149 Add proper handling of UUID column in DDL statements.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9149

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4483


commit 06ab44c311a0084f75c44aacb1fc11142f67a922
Author: Ivan Daschinskiy 
Date:   2018-08-03T13:30:51Z

IGNITE-9149 Add proper handling of UUID column in DDL statements.




> Get rid of logging remaining supplier nodes rebalance time
> --
>
> Key: IGNITE-9149
> URL: https://issues.apache.org/jira/browse/IGNITE-9149
> Project: Ignite
>  Issue Type: Task
>Reporter: Maxim Muzafarov
>Priority: Minor
>  Labels: rebalance
>
> Logging rebalance execution time in section of each supplier node have no 
> sence and provides no helpfull info for analyzing logs. It also 
> overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map IgniteDhtDemandedPartitionsMap>>}} to {{Map IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map> remaining = 
> new HashMap<>();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)