[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687668#comment-16687668 ] Ignite TC Bot commented on IGNITE-9274: --- {panel:title=Possible Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric |https://ci.ignite.apache.org/viewLog.html?buildId=2319081]] {color:#d04437}Continuous Query 1{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=2318985]] * IgniteCacheQuerySelfTestSuite3: CacheContinuousWithTransformerReplicatedSelfTest.testContinuousWithTransformerAsync - 0,0% fails in last 100 master runs. {color:#d04437}Activate | Deactivate Cluster{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=2318978]] * IgniteStandByClusterSuite: IgniteClusterActivateDeactivateTest.testConcurrentJoinAndActivate - 0,0% fails in last 100 master runs. {panel} [TeamCity Run All Results|http://ci.ignite.apache.org/viewLog.html?buildId=2319085buildTypeId=IgniteTests24Java8_RunAll] > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.8 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686960#comment-16686960 ] Vladimir Ozerov commented on IGNITE-9274: - Fixed two issues: new inspections and proper field ordering in messages. Final rerun: https://ci.ignite.apache.org/viewQueued.html?itemId=2319085 > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.8 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686881#comment-16686881 ] Ignite TC Bot commented on IGNITE-9274: --- {panel:title=Possible Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric |https://ci.ignite.apache.org/viewLog.html?buildId=2307507]] {panel} [TeamCity Run All Results|http://ci.ignite.apache.org/viewLog.html?buildId=2307511buildTypeId=IgniteTests24Java8_RunAll] > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.8 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683335#comment-16683335 ] Vladimir Ozerov commented on IGNITE-9274: - And one more run: https://ci.ignite.apache.org/viewQueued.html?itemId=2297887 > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.8 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660257#comment-16660257 ] Vladimir Ozerov commented on IGNITE-9274: - Blockers were found. Merged with master, one more run: https://ci.ignite.apache.org/viewLog.html?buildId=2145987 > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.8 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653358#comment-16653358 ] Vladimir Ozerov commented on IGNITE-9274: - Merged with master, re-run tests: https://ci.ignite.apache.org/viewQueued.html?itemId=2105966 > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.8 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623722#comment-16623722 ] Yury Gerzhedovich commented on IGNITE-9274: --- [~NIzhikov], Yes > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623596#comment-16623596 ] Nikolay Izhikov commented on IGNITE-9274: - [~jooger] Do we have a chance to resolve this ticket until the code freeze of 2.7? > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603183#comment-16603183 ] Yury Gerzhedovich commented on IGNITE-9274: --- [~vozerov], TC run has been successfully done - [https://ci.ignite.apache.org/viewLog.html?buildId=1792649;] > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599654#comment-16599654 ] Yury Gerzhedovich commented on IGNITE-9274: --- test results after merge with MVCC master - https://ci.ignite.apache.org/viewLog.html?buildId=1773873; > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590179#comment-16590179 ] Yury Gerzhedovich commented on IGNITE-9274: --- [~tledkov-gridgain], # Thanks, will be more attentive in the future :) # 3. My first attempts was separate tests for each of case - huge number of tests not readable. Current approach looks better. > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590160#comment-16590160 ] Taras Ledkov commented on IGNITE-9274: -- [~jooger], my comments: # I've pushed minor changes, please take a look; # Does make sense to collect all errors at the all test cases instead separate assertions at the each case? # Does make sense combine all tests cases into one test? > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590132#comment-16590132 ] Yury Gerzhedovich commented on IGNITE-9274: --- tests passed - [https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_Cache4=1714667_IgniteTests24Java8_Cache4=pull/4600/head] > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9274) Pass transaction label to cache events
[ https://issues.apache.org/jira/browse/IGNITE-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583726#comment-16583726 ] Yury Gerzhedovich commented on IGNITE-9274: --- TX events already covered by tests, see ``org.apache.ignite.internal.processors.cache.transactions.TxStateChangeEventTest`` > Pass transaction label to cache events > -- > > Key: IGNITE-9274 > URL: https://issues.apache.org/jira/browse/IGNITE-9274 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Yury Gerzhedovich >Priority: Major > Fix For: 2.7 > > > It is possible to set transaction label - \{{IgniteTransactions.withLabel}}. > We need to pass this label to related cache and transaction events: > 1) EVT_TX_STARTED, EVT_TX_COMMITTED, EVT_TX_ROLLED_BACK, EVT_TX_SUSPENDED, > EVT_TX_RESUMED > 2) EVT_CACHE_OBJECT_READ, EVT_CACHE_OBJECT_PUT, EVT_CACHE_OBJECT_REMOVED > For TX events most probably everything is already passed (see > \{{TransactionStateChangedEvent}}), we only need to add tests. > For put/remove events we need to investigate correct messages to pass label, > prepare requests appear to be good candidates for this. > For read operation we may need to add pass label to get/lock requests > ({{GridNearLockRequest}}, {{GridNearGetRequest}}, > {{GridNearSingleGetRequest}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)