[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2019-01-11 Thread Alexey Goncharuk (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740456#comment-16740456
 ] 

Alexey Goncharuk commented on IGNITE-9290:
--

[~amashenkov], I've re-checked, since we do not submit the task to the striped 
pool, nothing else should be changed. Thanks, merged to master.

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-12-24 Thread Andrew Mashenkov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728261#comment-16728261
 ] 

Andrew Mashenkov commented on IGNITE-9290:
--

[~agoncharuk], I've removed exchangerUpdateHeartbeat() from async call. 

I'm not sure if using system pools can cause deadlocks in that case. 
Do we have any thread pool for cluster maintenance tasks?  
Or should I create a separate GridWorker for this regarding Andrey's note 
above? What is common practice?

Also, as a further improvement, we can allow "no more than one" 
removeExplicitNodeLocks task in fly in case of several nodes leavings.

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-12-18 Thread Andrey Gura (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724100#comment-16724100
 ] 

Andrey Gura commented on IGNITE-9290:
-

There is no such way. You can use {{GridWorker.updateHeartbeat()}} method or 
use {{GridWorker.blockingSectionBegin()/GridWorker.blockingSectionEnd()}} for 
blocking operations if you implement own worker. In general, if your code could 
be invoked from different threads you should check that thread is runner of 
{{GridWorker}} and this particular {{GridWroker}} instance is registered in 
{{WorkersRegistry}}. 

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-12-11 Thread Alexey Goncharuk (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717356#comment-16717356
 ] 

Alexey Goncharuk commented on IGNITE-9290:
--

[~amashenkov], since {{removeExplicitNodeLocks}} is now called asynchronously, 
we do not need to call {{cctx.exchange().exchangerUpdateHeartbeat()}}. Instead, 
if we are running in a system worker, we need to update it's heartbeat. 
[~agura], can you suggest a canonical way to do this?

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-12-10 Thread Ignite TC Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714691#comment-16714691
 ] 

Ignite TC Bot commented on IGNITE-9290:
---

{panel:title=-- Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Hibernate 2{color} [[tests 0 TIMEOUT , Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=2478647]]
* HibernateL2CacheTransactionalSelfTest.testEntityCacheTransactionFails (last 
started)

{color:#d04437}PDS 2{color} [[tests 0 TIMEOUT , Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=2478714]]
* IgniteWalFlushBackgroundSelfTest.testFailWhileStart (last started)

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2478729buildTypeId=IgniteTests24Java8_RunAll]

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-12-05 Thread Andrew Mashenkov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710185#comment-16710185
 ] 

Andrew Mashenkov commented on IGNITE-9290:
--

[~ilantukh]
 # Agree, this looks wrong. Reverted onLeft call change. 
Do we really need to call onLeft twice from onClientLeft\onServerLeft 
recursively and then possibly once again? unwindEvicts may costs and look like 
it shouldn't spent exchange thread time.
 # I see no removeExplicitNodeLocks() call from ExchangeFuture.

Merged with latest master and still see no unnecessary 
removeExplicitNodeLocks() calls.

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-12-05 Thread Ilya Lantukh (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710008#comment-16710008
 ] 

Ilya Lantukh commented on IGNITE-9290:
--

[~amashenkov], why did you remove onLeft() call in ExchangeFuture.init(...) for 
case when event node is client?

And why do we still need to call removeExplicitNodeLocks(...) from 
ExchangeFuture if it is now handled by listener in GridCacheMvccManager?

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-11-28 Thread Ignite TC Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702079#comment-16702079
 ] 

Ignite TC Bot commented on IGNITE-9290:
---

{panel:title=No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity Run All 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2360376buildTypeId=IgniteTests24Java8_RunAll]

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-11-21 Thread Ignite TC Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694423#comment-16694423
 ] 

Ignite TC Bot commented on IGNITE-9290:
---

{panel:title=Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric 
|https://ci.ignite.apache.org/viewLog.html?buildId=2367590]]

{color:#d04437}Cache (Restarts) 1{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=2360337]]
* IgniteCacheRestartTestSuite: 
GridCachePartitionedNodeRestartTest.testRestartWithTxPutAllFourNodesTwoBackups 
- 0,0% fails in last 100 master runs.

{panel}
[TeamCity Run All 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2360376buildTypeId=IgniteTests24Java8_RunAll]

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-11-18 Thread Ignite TC Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691332#comment-16691332
 ] 

Ignite TC Bot commented on IGNITE-9290:
---

{panel:title=Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric 
|https://ci.ignite.apache.org/viewLog.html?buildId=236]]

{color:#d04437}~Build Apache Ignite~{color} [[tests 0 Exit Code , 
TC_COMPILATION_ERROR 
|https://ci.ignite.apache.org/viewLog.html?buildId=2333226]]

{color:#d04437}_Javadoc_{color} [[tests 0 Exit Code , TC_COMPILATION_ERROR 
|https://ci.ignite.apache.org/viewLog.html?buildId=2333286]]

{panel}
[TeamCity Run All 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=240buildTypeId=IgniteTests24Java8_RunAll]

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-11-12 Thread Vladimir Ozerov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683436#comment-16683436
 ] 

Vladimir Ozerov commented on IGNITE-9290:
-

[~agoncharuk], could you please suggest who can look at this PR?

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-10-15 Thread Andrew Mashenkov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649897#comment-16649897
 ] 

Andrew Mashenkov commented on IGNITE-9290:
--

[~NIzhikov], sorry, I've missed your last message.

The ticket is on review stage since I've asked for review at 23 Aug on dev list 
[1].
Now, it looks targeted to the next 2.8 release. Most likely, PR contains 
changes on critical path and need to be reviewed very carefully that may takes 
a time.

I've merged PR with latest master to resolve conflicts.

 

[1] 
http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-09-21 Thread Nikolay Izhikov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623597#comment-16623597
 ] 

Nikolay Izhikov commented on IGNITE-9290:
-

[~amashenkov] Do we have a chance to resolve this ticket until the code freeze 
of 2.7?

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
>  Labels: deadlock, iep-25
> Fix For: 2.7
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or 
> CQ), as manager stops right after last exchange has finished so managers 
> can't detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-08-16 Thread Andrew Mashenkov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582512#comment-16582512
 ] 

Andrew Mashenkov commented on IGNITE-9290:
--

TC tests looks ok.

 

> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Improvement
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Major
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or dr), 
> as manager stops right after last exchange has finished so managers can't 
> detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.

2018-08-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582172#comment-16582172
 ] 

ASF GitHub Bot commented on IGNITE-9290:


GitHub user AMashenkov opened a pull request:

https://github.com/apache/ignite/pull/4556

IGNITE-9290: Make remove explicit locks async when node left.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9290

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4556


commit 5190f178898ca25a71cd1b7be5efec71ef39a827
Author: Andrey V. Mashenkov 
Date:   2018-08-15T09:52:08Z

Cleanup code.

Remove unused method parameter.

commit 7602100c68bd177d93a9a8d12df7ddb397efc77f
Author: Andrey V. Mashenkov 
Date:   2018-08-15T09:53:01Z

Make explicit locks removal async.




> Make remove explicit locks async when node left.
> 
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
>  Issue Type: Improvement
>  Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Major
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery 
> and exchange threads. This introduce unnecessary delays in discovery and 
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an 
> entry lock and awaits some Ignite manager response (e.g. cache store or dr), 
> as manager stops right after last exchange has finished so managers can't 
> detect node is stopping. 
>  
> [1] 
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)