[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602834#comment-16602834 ] ASF GitHub Bot commented on IGNITE-9433: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4652 > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602833#comment-16602833 ] Dmitriy Govorukhin commented on IGNITE-9433: [~voropava] Changes looks good. Merged to master branch. Thanks for the contribution! > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602106#comment-16602106 ] Pavel Voronkin commented on IGNITE-9433: [~DmitriyGovorukhin], please assist with merge > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602075#comment-16602075 ] Anton Kalashnikov commented on IGNITE-9433: --- Looks good for me. It can be merged to master. > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597504#comment-16597504 ] ASF GitHub Bot commented on IGNITE-9433: GitHub user voropava opened a pull request: https://github.com/apache/ignite/pull/4652 IGNITE-9433 Extracted zip suffix constant You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9433 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4652.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4652 commit 466f485f0c030f542dac5ac34fc10f543d924ec0 Author: Pavel Voronkin Date: 2018-08-30T14:11:38Z IGNITE-9433 Extracted zip suffix constant > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597476#comment-16597476 ] ASF GitHub Bot commented on IGNITE-9433: Github user voropava closed the pull request at: https://github.com/apache/ignite/pull/4651 > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9433) Refactoring to improve constant usage for file suffixes
[ https://issues.apache.org/jira/browse/IGNITE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597463#comment-16597463 ] ASF GitHub Bot commented on IGNITE-9433: GitHub user voropava opened a pull request: https://github.com/apache/ignite/pull/4651 IGNITE-9433 Extractted zip suffix constant You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9433 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4651.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4651 commit a7999cb5646716cd662f21c125df9af68558fddf Author: Pavel Voronkin Date: 2018-08-30T13:37:18Z IGNITE-9433 Extractted zip suffix constant > Refactoring to improve constant usage for file suffixes > --- > > Key: IGNITE-9433 > URL: https://issues.apache.org/jira/browse/IGNITE-9433 > Project: Ignite > Issue Type: Task >Reporter: Pavel Voronkin >Priority: Major > Fix For: 2.7 > > > We need extract file suffix constants to avoid duplication of string > constants for zip files, like ".zip" and ".tmp" across the project -- This message was sent by Atlassian JIRA (v7.6.3#76005)
