[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627693#comment-16627693 ] ASF GitHub Bot commented on IGNITE-9573: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4755 > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627450#comment-16627450 ] Ilya Kasnacheev commented on IGNITE-9573: - [~dpavlov] can you please take it forward? > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627369#comment-16627369 ] Ivan Bessonov commented on IGNITE-9573: --- [~ilyak] looks good, thank you! > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627279#comment-16627279 ] Ilya Kasnacheev commented on IGNITE-9573: - [~ibessonov] thank you for noticing, I have replaced it with field. > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625712#comment-16625712 ] Ivan Bessonov commented on IGNITE-9573: --- [~ilyak] magic constant in test wasn't replaced with IgniteSystemProperties field. > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625620#comment-16625620 ] Ilya Kasnacheev commented on IGNITE-9573: - [~ibessonov] I have updated the pull request, please look. > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623399#comment-16623399 ] Ivan Bessonov commented on IGNITE-9573: --- Hi [~ilyak], [~dpavlov] delegated review to me. Please move properties names into "IgniteSystemProperties" with some short comments. > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > Labels: MakeTeamcityGreenAgain > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614601#comment-16614601 ] Ilya Kasnacheev commented on IGNITE-9573: - [~dpavlov] please review proposed test fix. > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9573) ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite
[ https://issues.apache.org/jira/browse/IGNITE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614531#comment-16614531 ] ASF GitHub Bot commented on IGNITE-9573: GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/4755 IGNITE-9573 Fix ZooKeeper SASL authentication tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9573 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4755.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4755 commit bd146cb9bb0459021a3f46fb3f1f5961118c32e8 Author: Ilya Kasnacheev Date: 2018-09-13T12:16:26Z IGNITE-9573 Fix ZooKeeper SASL authentication tests. > ZookeeperDiscoverySpiSaslFailedAuthTest fails after added to suite > -- > > Key: IGNITE-9573 > URL: https://issues.apache.org/jira/browse/IGNITE-9573 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Minor > > Due to proliferation of static fields in Zk and Security code it fails when a > part of suite and/or will cause other tests to fail. Needs to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
