[jira] [Commented] (IGNITE-9583) PHP thin: php directory should be included in binary release
[
https://issues.apache.org/jira/browse/IGNITE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646352#comment-16646352
]
ASF GitHub Bot commented on IGNITE-9583:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/4951
> PHP thin: php directory should be included in binary release
>
>
> Key: IGNITE-9583
> URL: https://issues.apache.org/jira/browse/IGNITE-9583
> Project: Ignite
> Issue Type: Improvement
> Components: build, thin client
>Reporter: Igor Sapego
>Assignee: Peter Ivanov
>Priority: Blocker
> Labels: php
> Fix For: 2.7
>
>
> Currently, php directory is not generated by the {{maven install}} command.
> Need to add appropriate copy steps to {{assembly/release-fabric-base.xml}}
> file.
> The following components should be copied:
> {noformat}
> ignite/modules/platforms/php/composer.json
> ignite/modules/platforms/php/src
> ignite/modules/platforms/php/examples
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9583) PHP thin: php directory should be included in binary release
[
https://issues.apache.org/jira/browse/IGNITE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645475#comment-16645475
]
ASF GitHub Bot commented on IGNITE-9583:
GitHub user vveider opened a pull request:
https://github.com/apache/ignite/pull/4951
IGNITE-9583 PHP thin: php directory should be included in binary release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9583
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4951.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4951
commit d7cb94b0476514394f46b8801fdd5eb3ed1782fe
Author: Peter Ivanov
Date: 2018-10-10T19:56:29Z
IGNITE-9583 PHP thin: php directory should be included in binary release
> PHP thin: php directory should be included in binary release
>
>
> Key: IGNITE-9583
> URL: https://issues.apache.org/jira/browse/IGNITE-9583
> Project: Ignite
> Issue Type: Improvement
> Components: build, thin client
>Reporter: Igor Sapego
>Assignee: Peter Ivanov
>Priority: Blocker
> Labels: php
> Fix For: 2.7
>
>
> Currently, php directory is not generated by the {{maven install}} command.
> Need to add appropriate copy steps to {{assembly/release-fabric-base.xml}}
> file.
> The following components should be copied:
> {noformat}
> ignite/modules/platforms/php/composer.json
> ignite/modules/platforms/php/src
> ignite/modules/platforms/php/examples
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9583) PHP thin: php directory should be included in binary release
[
https://issues.apache.org/jira/browse/IGNITE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645476#comment-16645476
]
Peter Ivanov commented on IGNITE-9583:
--
Done. [~isapego], please review.
> PHP thin: php directory should be included in binary release
>
>
> Key: IGNITE-9583
> URL: https://issues.apache.org/jira/browse/IGNITE-9583
> Project: Ignite
> Issue Type: Improvement
> Components: build, thin client
>Reporter: Igor Sapego
>Assignee: Peter Ivanov
>Priority: Blocker
> Labels: php
> Fix For: 2.7
>
>
> Currently, php directory is not generated by the {{maven install}} command.
> Need to add appropriate copy steps to {{assembly/release-fabric-base.xml}}
> file.
> The following components should be copied:
> {noformat}
> ignite/modules/platforms/php/composer.json
> ignite/modules/platforms/php/src
> ignite/modules/platforms/php/examples
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
