[jira] [Commented] (IGNITE-9740) [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up to IGNITE-9711)

2020-06-26 Thread Alexey Zinoviev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146194#comment-17146194
 ] 

Alexey Zinoviev commented on IGNITE-9740:
-

This test was removed, no IgniteThread usage in ML tests anymore

> [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up 
> to IGNITE-9711)
> ---
>
> Key: IGNITE-9740
> URL: https://issues.apache.org/jira/browse/IGNITE-9740
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Oleg Ignatenko
>Assignee: Alexey Zinoviev
>Priority: Critical
> Fix For: 2.9
>
>
> [EvaluatorTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/EvaluatorTest.java]
>  involves {{IgniteThread}} which is in fact not needed there and should be 
> removed.
> {{IgniteThread}} usage is a remainder / copy-paste from older tests and 
> examples that were using API requiring it. This API has been removed and 
> there is no need for wrapping like that anymore. For the reference on how to 
> perform suggested cleanup check changes made to ml examples per IGNITE-9711.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-9740) [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up to IGNITE-9711)

2020-04-16 Thread Alexey Zinoviev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085054#comment-17085054
 ] 

Alexey Zinoviev commented on IGNITE-9740:
-

All ML related bugs are not urgent and are not influence on users.

> [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up 
> to IGNITE-9711)
> ---
>
> Key: IGNITE-9740
> URL: https://issues.apache.org/jira/browse/IGNITE-9740
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Oleg Ignatenko
>Assignee: Alexey Zinoviev
>Priority: Critical
> Fix For: 2.9
>
>
> [EvaluatorTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/EvaluatorTest.java]
>  involves {{IgniteThread}} which is in fact not needed there and should be 
> removed.
> {{IgniteThread}} usage is a remainder / copy-paste from older tests and 
> examples that were using API requiring it. This API has been removed and 
> there is no need for wrapping like that anymore. For the reference on how to 
> perform suggested cleanup check changes made to ml examples per IGNITE-9711.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-9740) [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up to IGNITE-9711)

2020-04-16 Thread Nikolay Izhikov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085035#comment-17085035
 ] 

Nikolay Izhikov commented on IGNITE-9740:
-

Moved to 2.9

Please, write a comment if you want to see the fix for this issue in 2.8.1

> [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up 
> to IGNITE-9711)
> ---
>
> Key: IGNITE-9740
> URL: https://issues.apache.org/jira/browse/IGNITE-9740
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Oleg Ignatenko
>Assignee: Alexey Zinoviev
>Priority: Critical
> Fix For: 2.8.1
>
>
> [EvaluatorTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/EvaluatorTest.java]
>  involves {{IgniteThread}} which is in fact not needed there and should be 
> removed.
> {{IgniteThread}} usage is a remainder / copy-paste from older tests and 
> examples that were using API requiring it. This API has been removed and 
> there is no need for wrapping like that anymore. For the reference on how to 
> perform suggested cleanup check changes made to ml examples per IGNITE-9711.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-9740) [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up to IGNITE-9711)

2018-09-28 Thread Oleg Ignatenko (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632597#comment-16632597
 ] 

Oleg Ignatenko commented on IGNITE-9740:


[~chief] as promised when we spoke today I checked ml unit tests. It looks like 
the only test class that involves {{IgniteThread}} is the one reported in this 
ticket.

> [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up 
> to IGNITE-9711)
> ---
>
> Key: IGNITE-9740
> URL: https://issues.apache.org/jira/browse/IGNITE-9740
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Affects Versions: 2.6
>Reporter: Oleg Ignatenko
>Priority: Minor
> Fix For: 2.8
>
>
> [EvaluatorTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/EvaluatorTest.java]
>  involves {{IgniteThread}} which is in fact not needed there and should be 
> removed.
> {{IgniteThread}} usage is a remainder / copy-paste from older tests and 
> examples that were using API requiring it. This API has been removed and 
> there is no need for wrapping like that anymore. For the reference on how to 
> perform suggested cleanup check changes made to ml examples per IGNITE-9711.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)