[jira] [Updated] (IGNITE-8896) Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()

2018-09-27 Thread Vladimir Ozerov (JIRA) 


 [ 
https://issues.apache.org/jira/browse/IGNITE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Ozerov updated IGNITE-8896:

Fix Version/s: (was: 2.7)
   2.8

> Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
> ---
>
> Key: IGNITE-8896
> URL: https://issues.apache.org/jira/browse/IGNITE-8896
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Dmitry Karachentsev
>Priority: Minor
>  Labels: newbie
> Fix For: 2.8
>
>
> Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should 
> be set to value equal to TcpCommunicationSpi.getMessageQueueLimit().
> But this is wrong, because first checks back pressure limit and sender thread 
> will be blocked before slow client check. Also, warning checks the value 
> correctly, but message should be "...greater or equal...":
> {code:java}
> if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit >= 
> msgQueueLimit) {
> U.quietAndWarn(log, "Slow client queue limit is set to a value 
> greater than message queue limit " +
> "(slow client queue limit will have no effect) 
> [msgQueueLimit=" + msgQueueLimit +
> ", slowClientQueueLimit=" + slowClientQueueLimit + ']');
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (IGNITE-8896) Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()

2018-09-25 Thread Nikolay Izhikov (JIRA) 


 [ 
https://issues.apache.org/jira/browse/IGNITE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikolay Izhikov updated IGNITE-8896:

Fix Version/s: (was: 2.8)
   2.7

> Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
> ---
>
> Key: IGNITE-8896
> URL: https://issues.apache.org/jira/browse/IGNITE-8896
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Dmitry Karachentsev
>Priority: Minor
>  Labels: newbie
> Fix For: 2.7
>
>
> Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should 
> be set to value equal to TcpCommunicationSpi.getMessageQueueLimit().
> But this is wrong, because first checks back pressure limit and sender thread 
> will be blocked before slow client check. Also, warning checks the value 
> correctly, but message should be "...greater or equal...":
> {code:java}
> if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit >= 
> msgQueueLimit) {
> U.quietAndWarn(log, "Slow client queue limit is set to a value 
> greater than message queue limit " +
> "(slow client queue limit will have no effect) 
> [msgQueueLimit=" + msgQueueLimit +
> ", slowClientQueueLimit=" + slowClientQueueLimit + ']');
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (IGNITE-8896) Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()

2018-09-24 Thread Nikolay Izhikov (JIRA) 


 [ 
https://issues.apache.org/jira/browse/IGNITE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikolay Izhikov updated IGNITE-8896:

Fix Version/s: (was: 2.7)
   2.8

> Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
> ---
>
> Key: IGNITE-8896
> URL: https://issues.apache.org/jira/browse/IGNITE-8896
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.5
>Reporter: Dmitry Karachentsev
>Priority: Minor
>  Labels: newbie
> Fix For: 2.8
>
>
> Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should 
> be set to value equal to TcpCommunicationSpi.getMessageQueueLimit().
> But this is wrong, because first checks back pressure limit and sender thread 
> will be blocked before slow client check. Also, warning checks the value 
> correctly, but message should be "...greater or equal...":
> {code:java}
> if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit >= 
> msgQueueLimit) {
> U.quietAndWarn(log, "Slow client queue limit is set to a value 
> greater than message queue limit " +
> "(slow client queue limit will have no effect) 
> [msgQueueLimit=" + msgQueueLimit +
> ", slowClientQueueLimit=" + slowClientQueueLimit + ']');
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)