[jira] [Commented] (KARAF-4980) OSGi framework capabilities: add all services
[ https://issues.apache.org/jira/browse/KARAF-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855498#comment-15855498 ] Guillaume Nodet commented on KARAF-4980: It would be nice to add the karaf service: {code} org.osgi.framework.system.capabilities= \ ${eecap-${java.specification.version}}, \ ${${karaf.framework}-capabilities}, \ osgi.service;effective:=active;objectClass=org.apache.karaf.info.ServerInfo {code} I also think the {{DebugOptionsListener}} should not be listed as they are not supposed to be used, they're part of a whiteboard pattern. Although, I suppose the {{Location}} services are only usefull if given with the {{type}} attribute: {code} osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.user.area, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.instance.area, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.configuration.area, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.install.area, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=eclipse.home.location, \ {code} I think other non standard attributes should be kept: {code} osgi.service;effective:=active;objectClass=java.lang.ClassLoader;equinox.classloader.type=contextClassLoader, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.urlconversion.URLConverter;protocol:List="bundleentry,bundleresource", \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.security.TrustEngine;osgi.signedcontent.trust.engine=org.eclipse.osgi {code} Anyway, I came up with this small script that can be run in the console: {code} each (($.context bundle 0) registeredServices) { ref = $it msg = "osgi.service;effective:=active;" classes = new ArrayList each ($ref getProperty objectClass) { $classes add $it } nbClasses = ($classes size) if { %(nbClasses > 1) } { msg = "${msg}objectClass:List=\\"${(j:,:)classes}\\"" } { cls = ($classes get 0) msg = "${msg}objectClass=${cls}" } each ($ref getPropertyKeys) { if { $it startsWith "service." } { continue } if { $it equals "objectClass" } { continue } key = $it val = ($ref getProperty $key) if { "$val" startsWith "[" } { msg = "${msg};${key}:List=\\"${(j:,:)val}\\"" } { msg = "${msg};${key}=${val}" } } echo $msg } {code} Here's the trimmed and sorted output in the equinox case: {code} osgi.service;effective:=active;objectClass=java.lang.ClassLoader;equinox.classloader.type=contextClassLoader osgi.service;effective:=active;objectClass=javax.xml.parsers.DocumentBuilderFactory osgi.service;effective:=active;objectClass=javax.xml.parsers.SAXParserFactory osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog;performance=true osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=eclipse.home.location osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.configuration.area osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.install.area osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.instance.area osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location;type=osgi.user.area osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptions osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.environment.EnvironmentInfo osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.localization.BundleLocalization osgi.service;effective:=active;objectClass:List="org.osgi.service.log.LogReaderService,org.eclipse.equinox.log.ExtendedLogReaderService" osgi.service;effective:=active;objectClass:List="org.osgi.service.log.LogService,org.eclipse.equinox.log.ExtendedLogService" osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.security.TrustEngine;osgi.signedcontent.trust.engine=org.eclipse.osgi osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.urlconversion.URLConverter;protocol:List="bundleentry,bundleresource" osgi.service;effective:=active;objectClass=org.eclipse.osgi.signedcontent.SignedContentFactory osgi.service;effective:=active;objectClass=org.osgi.service.condpermadmin.ConditionalPermissionAdmin osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin osgi.service;effective:=active;objectClass=org.osgi.service.permissionadmin.PermissionAdmin
[jira] [Commented] (KARAF-4980) OSGi framework capabilities: add all services
[ https://issues.apache.org/jira/browse/KARAF-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854715#comment-15854715 ] ASF GitHub Bot commented on KARAF-4980: --- GitHub user maggu2810 opened a pull request: https://github.com/apache/karaf/pull/280 [KARAF-4980] add OSGi capabilities for services You can merge this pull request into a Git repository by running: $ git pull https://github.com/maggu2810/karaf karaf-4980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/karaf/pull/280.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #280 commit 149ef4bc3d7a1cc94d26e26ab944ec76e51c0dd2 Author: Markus RathgebDate: 2017-02-06T20:44:17Z [KARAF-4980] add OSGi capabilities for services Signed-off-by: Markus Rathgeb > OSGi framework capabilities: add all services > - > > Key: KARAF-4980 > URL: https://issues.apache.org/jira/browse/KARAF-4980 > Project: Karaf > Issue Type: Improvement > Components: karaf-core >Affects Versions: 4.1.0 >Reporter: Markus Rathgeb >Assignee: Guillaume Nodet > > The services provided by the Felix and the Equinox framework differs and > should be provided by the system capabilities. > I used service:list to find the services that are provided by Felix and the > ones that are provided by Equinox. > I would like to propagate this change to the config.properties (I will create > a PR if you agree): > {noformat} > org.osgi.framework.system.capabilities= \ > ${eecap-${java.specification.version}}, \ > ${${karaf.framework}-capabilities} > felix-capabilities= \ > > osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel > equinox-capabilities= \ > osgi.service;effective:=active;objectClass=java.lang.ClassLoader, \ > > osgi.service;effective:=active;objectClass=javax.xml.parsers.DocumentBuilderFactory, > \ > > osgi.service;effective:=active;objectClass=javax.xml.parsers.SAXParserFactory, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogReaderService, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogService, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptions, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptionsListener, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.environment.EnvironmentInfo, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.localization.BundleLocalization, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.security.TrustEngine, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.urlconversion.URLConverter, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.signedcontent.SignedContentFactory, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.condpermadmin.ConditionalPermissionAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.log.LogReaderService, > \ > osgi.service;effective:=active;objectClass=org.osgi.service.log.LogService, \ > > osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.permissionadmin.PermissionAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel > {noformat} > The currently configuration also contains: > {noformat} > osgi.service;effective:=active;objectClass=org.osgi.service.url.URLHandlers > {noformat} > but this service is not listed by service:list. > Is it still valid? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (KARAF-4980) OSGi framework capabilities: add all services
[ https://issues.apache.org/jira/browse/KARAF-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned KARAF-4980: -- Assignee: Guillaume Nodet > OSGi framework capabilities: add all services > - > > Key: KARAF-4980 > URL: https://issues.apache.org/jira/browse/KARAF-4980 > Project: Karaf > Issue Type: Improvement > Components: karaf-core >Affects Versions: 4.1.0 >Reporter: Markus Rathgeb >Assignee: Guillaume Nodet > > The services provided by the Felix and the Equinox framework differs and > should be provided by the system capabilities. > I used service:list to find the services that are provided by Felix and the > ones that are provided by Equinox. > I would like to propagate this change to the config.properties (I will create > a PR if you agree): > {noformat} > org.osgi.framework.system.capabilities= \ > ${eecap-${java.specification.version}}, \ > ${${karaf.framework}-capabilities} > felix-capabilities= \ > > osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel > equinox-capabilities= \ > osgi.service;effective:=active;objectClass=java.lang.ClassLoader, \ > > osgi.service;effective:=active;objectClass=javax.xml.parsers.DocumentBuilderFactory, > \ > > osgi.service;effective:=active;objectClass=javax.xml.parsers.SAXParserFactory, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogReaderService, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogService, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptions, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptionsListener, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.environment.EnvironmentInfo, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.localization.BundleLocalization, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.security.TrustEngine, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.urlconversion.URLConverter, > \ > > osgi.service;effective:=active;objectClass=org.eclipse.osgi.signedcontent.SignedContentFactory, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.condpermadmin.ConditionalPermissionAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.log.LogReaderService, > \ > osgi.service;effective:=active;objectClass=org.osgi.service.log.LogService, \ > > osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.permissionadmin.PermissionAdmin, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, > \ > > osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel > {noformat} > The currently configuration also contains: > {noformat} > osgi.service;effective:=active;objectClass=org.osgi.service.url.URLHandlers > {noformat} > but this service is not listed by service:list. > Is it still valid? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (KARAF-4980) OSGi framework capabilities: add all services
[ https://issues.apache.org/jira/browse/KARAF-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Rathgeb updated KARAF-4980: -- Description: The services provided by the Felix and the Equinox framework differs and should be provided by the system capabilities. I used service:list to find the services that are provided by Felix and the ones that are provided by Equinox. I would like to propagate this change to the config.properties (I will create a PR if you agree): {noformat} org.osgi.framework.system.capabilities= \ ${eecap-${java.specification.version}}, \ ${${karaf.framework}-capabilities} felix-capabilities= \ osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, \ osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel equinox-capabilities= \ osgi.service;effective:=active;objectClass=java.lang.ClassLoader, \ osgi.service;effective:=active;objectClass=javax.xml.parsers.DocumentBuilderFactory, \ osgi.service;effective:=active;objectClass=javax.xml.parsers.SAXParserFactory, \ osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogReaderService, \ osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogService, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptions, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptionsListener, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.environment.EnvironmentInfo, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.localization.BundleLocalization, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.security.TrustEngine, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.urlconversion.URLConverter, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.signedcontent.SignedContentFactory, \ osgi.service;effective:=active;objectClass=org.osgi.service.condpermadmin.ConditionalPermissionAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.log.LogReaderService, \ osgi.service;effective:=active;objectClass=org.osgi.service.log.LogService, \ osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.permissionadmin.PermissionAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, \ osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel {noformat} The currently configuration also contains: {noformat} osgi.service;effective:=active;objectClass=org.osgi.service.url.URLHandlers {noformat} but this service is not listed by service:list. Is it still valid? was: The services provided by the Felix and the Equinox framework differs and should be provided by the system capabilities. I used service:list to find the services that are provided by Felix and the ones that are provided by Equinox. I would like to propagate this change to the config.properties (I will create a PR if you agree): {{noformat}} org.osgi.framework.system.capabilities= \ ${eecap-${java.specification.version}}, \ ${${karaf.framework}-capabilities} felix-capabilities= \ osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, \ osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel equinox-capabilities= \ osgi.service;effective:=active;objectClass=java.lang.ClassLoader, \ osgi.service;effective:=active;objectClass=javax.xml.parsers.DocumentBuilderFactory, \ osgi.service;effective:=active;objectClass=javax.xml.parsers.SAXParserFactory, \ osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogReaderService, \ osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogService, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptions, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptionsListener, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.environment.EnvironmentInfo, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.localization.BundleLocalization, \
[jira] [Created] (KARAF-4980) OSGi framework capabilities: add all services
Markus Rathgeb created KARAF-4980: - Summary: OSGi framework capabilities: add all services Key: KARAF-4980 URL: https://issues.apache.org/jira/browse/KARAF-4980 Project: Karaf Issue Type: Improvement Components: karaf-core Affects Versions: 4.1.0 Reporter: Markus Rathgeb The services provided by the Felix and the Equinox framework differs and should be provided by the system capabilities. I used service:list to find the services that are provided by Felix and the ones that are provided by Equinox. I would like to propagate this change to the config.properties (I will create a PR if you agree): {{noformat}} org.osgi.framework.system.capabilities= \ ${eecap-${java.specification.version}}, \ ${${karaf.framework}-capabilities} felix-capabilities= \ osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, \ osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel equinox-capabilities= \ osgi.service;effective:=active;objectClass=java.lang.ClassLoader, \ osgi.service;effective:=active;objectClass=javax.xml.parsers.DocumentBuilderFactory, \ osgi.service;effective:=active;objectClass=javax.xml.parsers.SAXParserFactory, \ osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogReaderService, \ osgi.service;effective:=active;objectClass=org.eclipse.equinox.log.ExtendedLogService, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.framework.log.FrameworkLog, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.datalocation.Location, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptions, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.debug.DebugOptionsListener, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.environment.EnvironmentInfo, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.localization.BundleLocalization, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.security.TrustEngine, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.service.urlconversion.URLConverter, \ osgi.service;effective:=active;objectClass=org.eclipse.osgi.signedcontent.SignedContentFactory, \ osgi.service;effective:=active;objectClass=org.osgi.service.condpermadmin.ConditionalPermissionAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.log.LogReaderService, \ osgi.service;effective:=active;objectClass=org.osgi.service.log.LogService, \ osgi.service;effective:=active;objectClass=org.osgi.service.packageadmin.PackageAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.permissionadmin.PermissionAdmin, \ osgi.service;effective:=active;objectClass=org.osgi.service.resolver.Resolver, \ osgi.service;effective:=active;objectClass=org.osgi.service.startlevel.StartLevel {{noformat}} The currently configuration also contains: {{noformat}} osgi.service;effective:=active;objectClass=org.osgi.service.url.URLHandlers {{noformat}} but this service is not listed by service:list. Is it still valid? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4210) Unreleased Resource: Streams
[ https://issues.apache.org/jira/browse/KARAF-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854665#comment-15854665 ] Fabian Lange commented on KARAF-4210: - good find, made me find KARAF-4979 as well. > Unreleased Resource: Streams > > > Key: KARAF-4210 > URL: https://issues.apache.org/jira/browse/KARAF-4210 > Project: Karaf > Issue Type: Bug >Affects Versions: 4.0.3 >Reporter: Eduardo Aguinaga >Assignee: Christian Schneider > Fix For: 4.1.1 > > > HP Fortify SCA and SciTools Understand were used to perform an application > security analysis on the karaf source code. > The function getLocalRepoFromConfig() in MavenConfigService.java sometimes > fails to release a system resource allocated by FileInputStream() on line 74. > File: > bundle/core/src/main/java/org/apache/karaf/bundle/core/internal/MavenConfigService.java > Line: 74 > MavenConfigService.java, lines 66-76: > 66 static String getLocalRepoFromConfig(Dictionarydict) > throws XMLStreamException, FileNotFoundException { > 67 String path = null; > 68 if (dict != null) { > 69 path = (String) dict.get("org.ops4j.pax.url.mvn.localRepository"); > 70 if (path == null) { > 71 String settings = (String) > dict.get("org.ops4j.pax.url.mvn.settings"); > 72 if (settings != null) { > 73 File file = new File(settings); > 74 XMLStreamReader reader = > XMLInputFactory.newFactory().createXMLStreamReader(new FileInputStream(file)); > 75 try { > 76 int event; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4979) Features StaxParser and UrlLoader leak resources
[ https://issues.apache.org/jira/browse/KARAF-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854662#comment-15854662 ] ASF subversion and git services commented on KARAF-4979: Commit 264cd4e2ae9d8cb6b8410a597cc5ee981c374694 in karaf's branch refs/heads/master from [~fabianlange] [ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=264cd4e ] [KARAF-4979] fixes resource leaks in UrlLoader & StaxParser > Features StaxParser and UrlLoader leak resources > > > Key: KARAF-4979 > URL: https://issues.apache.org/jira/browse/KARAF-4979 > Project: Karaf > Issue Type: Bug >Reporter: Fabian Lange > > UrlLoader makes a GzipInputStream which is not properly closed > StaxParser uses XmlReader/writer without closing them -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (KARAF-4979) Features StaxParser and UrlLoader leak resources
Fabian Lange created KARAF-4979: --- Summary: Features StaxParser and UrlLoader leak resources Key: KARAF-4979 URL: https://issues.apache.org/jira/browse/KARAF-4979 Project: Karaf Issue Type: Bug Reporter: Fabian Lange UrlLoader makes a GzipInputStream which is not properly closed StaxParser uses XmlReader/writer without closing them -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (KARAF-4210) Unreleased Resource: Streams
[ https://issues.apache.org/jira/browse/KARAF-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved KARAF-4210. Resolution: Fixed Assignee: Christian Schneider Fix Version/s: (was: 4.0.9) > Unreleased Resource: Streams > > > Key: KARAF-4210 > URL: https://issues.apache.org/jira/browse/KARAF-4210 > Project: Karaf > Issue Type: Bug >Affects Versions: 4.0.3 >Reporter: Eduardo Aguinaga >Assignee: Christian Schneider > Fix For: 4.1.1 > > > HP Fortify SCA and SciTools Understand were used to perform an application > security analysis on the karaf source code. > The function getLocalRepoFromConfig() in MavenConfigService.java sometimes > fails to release a system resource allocated by FileInputStream() on line 74. > File: > bundle/core/src/main/java/org/apache/karaf/bundle/core/internal/MavenConfigService.java > Line: 74 > MavenConfigService.java, lines 66-76: > 66 static String getLocalRepoFromConfig(Dictionarydict) > throws XMLStreamException, FileNotFoundException { > 67 String path = null; > 68 if (dict != null) { > 69 path = (String) dict.get("org.ops4j.pax.url.mvn.localRepository"); > 70 if (path == null) { > 71 String settings = (String) > dict.get("org.ops4j.pax.url.mvn.settings"); > 72 if (settings != null) { > 73 File file = new File(settings); > 74 XMLStreamReader reader = > XMLInputFactory.newFactory().createXMLStreamReader(new FileInputStream(file)); > 75 try { > 76 int event; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4210) Unreleased Resource: Streams
[ https://issues.apache.org/jira/browse/KARAF-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854247#comment-15854247 ] ASF subversion and git services commented on KARAF-4210: Commit 868c6852424a80e07d2f925791c28ac498581145 in karaf's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=868c685 ] [KARAF-4210] Make sure resource is released > Unreleased Resource: Streams > > > Key: KARAF-4210 > URL: https://issues.apache.org/jira/browse/KARAF-4210 > Project: Karaf > Issue Type: Bug >Affects Versions: 4.0.3 >Reporter: Eduardo Aguinaga > Fix For: 4.1.1 > > > HP Fortify SCA and SciTools Understand were used to perform an application > security analysis on the karaf source code. > The function getLocalRepoFromConfig() in MavenConfigService.java sometimes > fails to release a system resource allocated by FileInputStream() on line 74. > File: > bundle/core/src/main/java/org/apache/karaf/bundle/core/internal/MavenConfigService.java > Line: 74 > MavenConfigService.java, lines 66-76: > 66 static String getLocalRepoFromConfig(Dictionarydict) > throws XMLStreamException, FileNotFoundException { > 67 String path = null; > 68 if (dict != null) { > 69 path = (String) dict.get("org.ops4j.pax.url.mvn.localRepository"); > 70 if (path == null) { > 71 String settings = (String) > dict.get("org.ops4j.pax.url.mvn.settings"); > 72 if (settings != null) { > 73 File file = new File(settings); > 74 XMLStreamReader reader = > XMLInputFactory.newFactory().createXMLStreamReader(new FileInputStream(file)); > 75 try { > 76 int event; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (KARAF-3921) Installing an already installed feature again sometimes switches used bundles
[ https://issues.apache.org/jira/browse/KARAF-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated KARAF-3921: --- Fix Version/s: (was: 4.1.1) (was: 4.0.9) > Installing an already installed feature again sometimes switches used bundles > - > > Key: KARAF-3921 > URL: https://issues.apache.org/jira/browse/KARAF-3921 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.0.0 >Reporter: Christian Schneider > > First install my example from: > https://github.com/cschneider/Karaf-Tutorial/tree/jpa-2.1.0/tasklist-blueprint-cdi > according to the README. > Then install the already install jaxrs service bundle again several times. As > you see from the console log below the resolved tends to use a different > transaction manager every time. > - > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to uninstall: > org.apache.aries.transaction.manager/1.0.1 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Uninstalling bundles: > org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Refreshing bundles: > org.apache.aries.transaction.blueprint/1.1.1 (Should be wired to: > org.apache.aries.transaction.blueprint/1.1.1 (through > [org.apache.aries.transaction.blueprint/1.1.1] osgi.wiring.package; > filter:="(&(osgi.wiring.package=org.apache.aries.transaction.exception)(version>=1.0.0)(!(version>=2.0.0)))")) > org.apache.aries.transaction.manager/1.0.1 (Bundle will be uninstalled) > Starting bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.0 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.1 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.1 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.0 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.0 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (KARAF-3921) Installing an already installed feature again sometimes switches used bundles
[ https://issues.apache.org/jira/browse/KARAF-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider closed KARAF-3921. -- Resolution: Won't Fix > Installing an already installed feature again sometimes switches used bundles > - > > Key: KARAF-3921 > URL: https://issues.apache.org/jira/browse/KARAF-3921 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.0.0 >Reporter: Christian Schneider > > First install my example from: > https://github.com/cschneider/Karaf-Tutorial/tree/jpa-2.1.0/tasklist-blueprint-cdi > according to the README. > Then install the already install jaxrs service bundle again several times. As > you see from the console log below the resolved tends to use a different > transaction manager every time. > - > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to uninstall: > org.apache.aries.transaction.manager/1.0.1 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Uninstalling bundles: > org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Refreshing bundles: > org.apache.aries.transaction.blueprint/1.1.1 (Should be wired to: > org.apache.aries.transaction.blueprint/1.1.1 (through > [org.apache.aries.transaction.blueprint/1.1.1] osgi.wiring.package; > filter:="(&(osgi.wiring.package=org.apache.aries.transaction.exception)(version>=1.0.0)(!(version>=2.0.0)))")) > org.apache.aries.transaction.manager/1.0.1 (Bundle will be uninstalled) > Starting bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.0 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.1 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.1 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.0 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.0 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (KARAF-3921) Installing an already installed feature again sometimes switches used bundles
[ https://issues.apache.org/jira/browse/KARAF-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider reopened KARAF-3921: > Installing an already installed feature again sometimes switches used bundles > - > > Key: KARAF-3921 > URL: https://issues.apache.org/jira/browse/KARAF-3921 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.0.0 >Reporter: Christian Schneider > > First install my example from: > https://github.com/cschneider/Karaf-Tutorial/tree/jpa-2.1.0/tasklist-blueprint-cdi > according to the README. > Then install the already install jaxrs service bundle again several times. As > you see from the console log below the resolved tends to use a different > transaction manager every time. > - > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to uninstall: > org.apache.aries.transaction.manager/1.0.1 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Uninstalling bundles: > org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Refreshing bundles: > org.apache.aries.transaction.blueprint/1.1.1 (Should be wired to: > org.apache.aries.transaction.blueprint/1.1.1 (through > [org.apache.aries.transaction.blueprint/1.1.1] osgi.wiring.package; > filter:="(&(osgi.wiring.package=org.apache.aries.transaction.exception)(version>=1.0.0)(!(version>=2.0.0)))")) > org.apache.aries.transaction.manager/1.0.1 (Bundle will be uninstalled) > Starting bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.0 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.1 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.1 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.0 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.0 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (KARAF-3921) Installing an already installed feature again sometimes switches used bundles
[ https://issues.apache.org/jira/browse/KARAF-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider closed KARAF-3921. -- Resolution: Won't Fix > Installing an already installed feature again sometimes switches used bundles > - > > Key: KARAF-3921 > URL: https://issues.apache.org/jira/browse/KARAF-3921 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.0.0 >Reporter: Christian Schneider > Fix For: 4.0.9, 4.1.1 > > > First install my example from: > https://github.com/cschneider/Karaf-Tutorial/tree/jpa-2.1.0/tasklist-blueprint-cdi > according to the README. > Then install the already install jaxrs service bundle again several times. As > you see from the console log below the resolved tends to use a different > transaction manager every time. > - > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to uninstall: > org.apache.aries.transaction.manager/1.0.1 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Uninstalling bundles: > org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Refreshing bundles: > org.apache.aries.transaction.blueprint/1.1.1 (Should be wired to: > org.apache.aries.transaction.blueprint/1.1.1 (through > [org.apache.aries.transaction.blueprint/1.1.1] osgi.wiring.package; > filter:="(&(osgi.wiring.package=org.apache.aries.transaction.exception)(version>=1.0.0)(!(version>=2.0.0)))")) > org.apache.aries.transaction.manager/1.0.1 (Bundle will be uninstalled) > Starting bundles: > org.apache.aries.transaction.blueprint/1.1.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.0 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.1 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to update: > org.apache.aries.transaction.manager/1.0.1 with > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.1 > Updating bundles: > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.0 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > Stopping bundles: > org.apache.aries.transaction.manager/1.0.0 > Refreshing bundles: > org.apache.aries.transaction.manager/1.0.0 (Bundle will be updated) > Starting bundles: > org.apache.aries.transaction.manager/1.0.0 > Done. > karaf@root()> feature:install -v example-tasklist-cdi-service > Adding features: example-tasklist-cdi-service/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT] > Changes to perform: > Region: root > Bundles to install: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Installing bundles: > > mvn:org.apache.aries.transaction/org.apache.aries.transaction.blueprint/1.1.1 > mvn:org.apache.aries.transaction/org.apache.aries.transaction.manager/1.0.1 > Starting bundles: > org.apache.aries.transaction.manager/1.0.1 > Done. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (KARAF-550) Make it easier to add additional custom property files
[ https://issues.apache.org/jira/browse/KARAF-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated KARAF-550: -- Fix Version/s: (was: 4.1.1) > Make it easier to add additional custom property files > -- > > Key: KARAF-550 > URL: https://issues.apache.org/jira/browse/KARAF-550 > Project: Karaf > Issue Type: Improvement > Components: karaf-core >Reporter: Andreas Pieber >Assignee: Andreas Pieber > > The current custom.properties approach has some drawbacks in case you have a > structure like karaf <- other framework project like smx <- client project. > In this case you may like to add some custom.properties which should not be > as easy to overwrite by the client. For example you want to provide a default > configuration for activemq webconsole, or some other properties. As the > framework you can overwrite the config.properties file now and include > additional property files used this way but this has the drawback that you, > as framework developer, have to upgrade the config.properties with each karaf > upgrade. I've two options in minds: > <> > After some lengthy discussion with Guillaume and JB we come to the following > conclusion for this issue: > In addition to providing directly the files which should be used in > config.properties in system.properties and config.properties a pattern could > be defined in config.properties and system.properties (besides the "regular" > includes) to allow that client projects/frameworks could easily add > additional config files which are included without any additional work -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Work stopped] (KARAF-550) Make it easier to add additional custom property files
[ https://issues.apache.org/jira/browse/KARAF-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KARAF-550 stopped by Christian Schneider. - > Make it easier to add additional custom property files > -- > > Key: KARAF-550 > URL: https://issues.apache.org/jira/browse/KARAF-550 > Project: Karaf > Issue Type: Improvement > Components: karaf-core >Reporter: Andreas Pieber >Assignee: Andreas Pieber > > The current custom.properties approach has some drawbacks in case you have a > structure like karaf <- other framework project like smx <- client project. > In this case you may like to add some custom.properties which should not be > as easy to overwrite by the client. For example you want to provide a default > configuration for activemq webconsole, or some other properties. As the > framework you can overwrite the config.properties file now and include > additional property files used this way but this has the drawback that you, > as framework developer, have to upgrade the config.properties with each karaf > upgrade. I've two options in minds: > <> > After some lengthy discussion with Guillaume and JB we come to the following > conclusion for this issue: > In addition to providing directly the files which should be used in > config.properties in system.properties and config.properties a pattern could > be defined in config.properties and system.properties (besides the "regular" > includes) to allow that client projects/frameworks could easily add > additional config files which are included without any additional work -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (KARAF-4973) Refactoring of features extension
[ https://issues.apache.org/jira/browse/KARAF-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved KARAF-4973. Resolution: Fixed > Refactoring of features extension > - > > Key: KARAF-4973 > URL: https://issues.apache.org/jira/browse/KARAF-4973 > Project: Karaf > Issue Type: Improvement > Components: karaf-feature >Affects Versions: 4.1.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 4.1.1 > > > The features extension bundle does all the work in the Activator. > I would like to refactoring this into two extra classes BundleWires and > StoredWiringResolver. This should make the code easier to understand. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (KARAF-4237) can't install transaction feature and activemq-camel feature: Missing dependency javax.transaction.TransactionManager
[ https://issues.apache.org/jira/browse/KARAF-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved KARAF-4237. Resolution: Cannot Reproduce Fix Version/s: (was: 4.1.1) (was: 4.0.9) I still can not reproduce this problem. Do you still see the problem in the current karaf version 4.1.0? You will need this adapted set of commands. feature:repo-add spring-legacy 4.1.0 feature:repo-add activemq 5.13.0 feature:repo-add camel 2.16.1 feature:install transaction activemq-camel bundle:diag > can't install transaction feature and activemq-camel feature: Missing > dependency javax.transaction.TransactionManager > - > > Key: KARAF-4237 > URL: https://issues.apache.org/jira/browse/KARAF-4237 > Project: Karaf > Issue Type: Bug >Affects Versions: 4.0.3 > Environment: ubuntu 14.04, java 7 update 79 (also tried with java 8 > update 45), karaf 3.0.3 camel 2.16.1, activemq 5.13.0 >Reporter: Edward Welch >Assignee: Christian Schneider > > I found a little bit of a strange behavior, which I think points to a > possible bug in the features dependency resolver? > Easiest way to reproduce, start with a vanilla 4.0.3 > feature:repo-add activemq 5.13.0 > feature:repo-add camel 2.16.1 > feature:install transaction activemq-camel > bundle:diag > You will see both Apache Aries Transaction Blueprint bundles in Grace Period > waiting for javax.transaction.TransactionManager > Pretty sure this is caused by some bad wiring on a bundle which > activemq-camel brings in, here is that feature descriptor: > {code} > start-level='50'> > spring > dependency='true'>mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/${geronimo-jta-spec-version} > dependency='true'>mvn:commons-pool/commons-pool/${commons-pool-version} > dependency='true'>mvn:org.apache.geronimo.specs/geronimo-jms_1.1_spec/${geronimo-jms-spec-version} > spring-jms > camel-core > mvn:org.apache.camel/camel-jms/${project.version} > > {code} > I see the aries transaction bundles being wired to this bundle coming from > the activemq-camel feature: > mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/${geronimo-jta-spec-version} > What's strange about this, that bundle is marked dependency="true" so I would > think it wouldn't need to be installed at all. > Also peculiar, if you follow this install order: > feature:repo-add activemq 5.13.0 > feature:repo-add camel 2.16.1 > feature:install transaction > feature:install activemq-camel > bundle:diag > There is no issue, so the re-wiring/refresh of the transaction bundles never > happens > Also when I originally posted this on the mailing list: > http://karaf.922171.n3.nabble.com/Missing-dependency-javax-transaction-TransactionManager-with-transaction-feature-and-activemq-camel-td4044354.html > Christian Schneider was unable to reproduce the issue, even though it occurs > 100% of the time for me, so maybe there is something else in play here that I > can't think of. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4973) Refactoring of features extension
[ https://issues.apache.org/jira/browse/KARAF-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854167#comment-15854167 ] ASF subversion and git services commented on KARAF-4973: Commit 9ce324f577d427d501558740b440f264eb6e2d27 in karaf's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=9ce324f ] [KARAF-4973] Refactoring of features extension > Refactoring of features extension > - > > Key: KARAF-4973 > URL: https://issues.apache.org/jira/browse/KARAF-4973 > Project: Karaf > Issue Type: Improvement > Components: karaf-feature >Affects Versions: 4.1.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 4.1.1 > > > The features extension bundle does all the work in the Activator. > I would like to refactoring this into two extra classes BundleWires and > StoredWiringResolver. This should make the code easier to understand. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854014#comment-15854014 ] Oliver Lietz commented on KARAF-201: That won't work as the service providing resources is shared by different applications and IMHO the feature lifecycle is the best place to hook into when you manage (install, uninstall, update) applications (set of bundles, features and configurations) with Karaf Features. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854003#comment-15854003 ] Christian Schneider commented on KARAF-201: --- What I wanted to express is that for each persistence technology you will have some central resource that can provide a good hook for doing migration tasks. Karaf features are only used for the first start of karaf. If you restart karaf then there is only the ordinary bundle startup. So I think it would not be a good practice to use the feature service at all for migration scripts. Instead hook into the resources that channel access to your persistence layer and make sure the migration is finished before the resource is made available to other bundles. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853985#comment-15853985 ] Oliver Lietz commented on KARAF-201: Sorry, no. Database migration was an example and it could be any task. In my case it is a [Java Content Repository (JCR)|http://jackrabbit.apache.org/jcr/jcr-api.html], concretely [Apache Jackrabbit Oak|https://jackrabbit.apache.org/oak/] (Oak runs with Tar, Mongo or RDBMS _backend_). _On top_ of Oak sits [Sling|https://sling.apache.org] and provides services to access resources (from Oak but not only). Now you install applications _on top_ of Sling and in some cases you need to transform, add, remove or move existing content before these applications are installed (updated) – this is a concrete example close to database migration but I can imagine more use cases. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853921#comment-15853921 ] Christian Schneider commented on KARAF-201: --- I sent a discuss mail on ops4j about database migration https://groups.google.com/d/topic/ops4j/C2dIkkcl5Uw/discussion. Would this work for you? > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853912#comment-15853912 ] Achim Nierbeck commented on KARAF-201: -- hmm ... for DB migration you might also want to take a look at [PAX Warp|http://ops4j.github.io/pax/warp/0.7.0/index.html] > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853909#comment-15853909 ] Christian Schneider commented on KARAF-201: --- A simple way to do this is to couple it with a service that encapsulates a resource. For example if you have a db then the common resource is the DataSource. So I think the right place to run automatic migration scripts would be the service that provides the DataSource. The service could make sure the migration scripts are run before the DataSource is published. In OSGi there is already a really good system to express dependencies using capabilities and services. So I think we can implement this in a good way without touching the feature mechanism. If you are interested we can look into providing database migration hooks in pax-jdbc-config which I think would be a good place for this. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4952) Provide features list on website
[ https://issues.apache.org/jira/browse/KARAF-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853901#comment-15853901 ] Christian Schneider commented on KARAF-4952: Aren't you on vacation? > Provide features list on website > > > Key: KARAF-4952 > URL: https://issues.apache.org/jira/browse/KARAF-4952 > Project: Karaf > Issue Type: Improvement > Components: website >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > Fix For: 4.1.1 > > > Even if the features repositories are already listed in > {{etc/org.apache.karaf.features.repos.cfg}}, it could be interesting to > provide the list on the website or user guide. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4952) Provide features list on website
[ https://issues.apache.org/jira/browse/KARAF-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853852#comment-15853852 ] Jean-Baptiste Onofré commented on KARAF-4952: - I will do that for 4.1.1 > Provide features list on website > > > Key: KARAF-4952 > URL: https://issues.apache.org/jira/browse/KARAF-4952 > Project: Karaf > Issue Type: Improvement > Components: website >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > Fix For: 4.1.1 > > > Even if the features repositories are already listed in > {{etc/org.apache.karaf.features.repos.cfg}}, it could be interesting to > provide the list on the website or user guide. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (KARAF-4952) Provide features list on website
[ https://issues.apache.org/jira/browse/KARAF-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned KARAF-4952: --- Assignee: Jean-Baptiste Onofré (was: Christian Schneider) > Provide features list on website > > > Key: KARAF-4952 > URL: https://issues.apache.org/jira/browse/KARAF-4952 > Project: Karaf > Issue Type: Improvement > Components: website >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > Fix For: 4.1.1 > > > Even if the features repositories are already listed in > {{etc/org.apache.karaf.features.repos.cfg}}, it could be interesting to > provide the list on the website or user guide. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853825#comment-15853825 ] Oliver Lietz commented on KARAF-201: That's a lot of boilerplate to do some work depending on feature lifecycle (I'm not interested in _any_ OSGi environment but Karaf with Features only). Though having a common _OSGi Task API_ sounds interesting. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853808#comment-15853808 ] Christian Schneider commented on KARAF-201: --- You can already do this in an Activator or DS / blueprint callbacks. By putting this code in a bundle you make sure it can run in any OSGi environment. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853802#comment-15853802 ] Oliver Lietz commented on KARAF-201: I would like to have a standard mechanism to run pre-/post- install, uninstall and update tasks (full lifecycle) for features (not limited to gogo commands) for e.g. database migrations. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (KARAF-4952) Provide features list on website
[ https://issues.apache.org/jira/browse/KARAF-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider reassigned KARAF-4952: -- Assignee: Christian Schneider (was: Jean-Baptiste Onofré) > Provide features list on website > > > Key: KARAF-4952 > URL: https://issues.apache.org/jira/browse/KARAF-4952 > Project: Karaf > Issue Type: Improvement > Components: website >Reporter: Jean-Baptiste Onofré >Assignee: Christian Schneider > Fix For: 4.1.1 > > > Even if the features repositories are already listed in > {{etc/org.apache.karaf.features.repos.cfg}}, it could be interesting to > provide the list on the website or user guide. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-4953) Completion trim last character in the delegate buffer
[ https://issues.apache.org/jira/browse/KARAF-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853801#comment-15853801 ] Christian Schneider commented on KARAF-4953: I just tested on karaf 4.1.0 and can not reproduce. > Completion trim last character in the delegate buffer > - > > Key: KARAF-4953 > URL: https://issues.apache.org/jira/browse/KARAF-4953 > Project: Karaf > Issue Type: Bug > Components: karaf-shell >Affects Versions: 4.1.0 >Reporter: Jean-Baptiste Onofré >Assignee: Guillaume Nodet > Fix For: 4.1.1 > > > When using tab key for the completion, even if the proposed completion are > good, the last character in the command is trimmed. > For instance: > {code} > karaf@root()> feature:install transaction > {code} > the cursor is on 'n' and when completing: > {code} > karaf@root()> feature:install transactio-api > {code} > instead of {{transaction-api}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KARAF-201) Add post feature installation triggers
[ https://issues.apache.org/jira/browse/KARAF-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853792#comment-15853792 ] Christian Schneider commented on KARAF-201: --- Do we really still need this? After all bundles can also do actions once they become active. So I think we can already do this without a new element for features. > Add post feature installation triggers > -- > > Key: KARAF-201 > URL: https://issues.apache.org/jira/browse/KARAF-201 > Project: Karaf > Issue Type: New Feature > Components: karaf-core, karaf-feature >Reporter: Guillaume Nodet > Fix For: 4.1.1 > > > Something like: > {code} > > // do anything using gogo commands > > {code} > The result could be displayed to the user so that the installation could give > him some information (manual steps, or whatever), though it may need a > separate element. -- This message was sent by Atlassian JIRA (v6.3.15#6346)