[jira] [Commented] (KARAF-4829) Make sure configFile in features makes config available early

2017-04-03 Thread Jean-Philippe CLEMENT (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953725#comment-15953725
 ] 

Jean-Philippe CLEMENT commented on KARAF-4829:
--

Ok good, thank you :)

> Make sure configFile in features makes config available early
> -
>
> Key: KARAF-4829
> URL: https://issues.apache.org/jira/browse/KARAF-4829
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-config
>Affects Versions: 4.0.7
>Reporter: Christian Schneider
>Assignee: Guillaume Nodet
>
> We currently have the config and configFile elements in feature files.
> Config writes the given entries to ConfigAdmin while configFile writes a file.
> So configFile is needed if the user should get a nice file to edit. The 
> problem with configFile is that ConfigurationAdmin reads the files 
> asyncronously. So bundles of the feature might already be started at the time 
> the config is written.
> So bundles might need to restart or if they only process the config once are 
> in a kind of invalid state that does not relfect the config from the feature.
> So I propose to also write the config to ConfigAdmin if configFile is used. 
> This should allow the bundles to come up in the correct state from the start.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-4829) Make sure configFile in features makes config available early

2017-04-03 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953710#comment-15953710
 ] 

Guillaume Nodet commented on KARAF-4829:


This is not an issue for simple properties file.
The enhanced config files containing typed values are not fully supported and 
it must be done in multiple locations in Karaf, but also FileInstall.  I've 
raised a JIRA for that, and I started implementing a file to read / write / 
update those configurations properly.

> Make sure configFile in features makes config available early
> -
>
> Key: KARAF-4829
> URL: https://issues.apache.org/jira/browse/KARAF-4829
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-config
>Affects Versions: 4.0.7
>Reporter: Christian Schneider
>Assignee: Guillaume Nodet
>
> We currently have the config and configFile elements in feature files.
> Config writes the given entries to ConfigAdmin while configFile writes a file.
> So configFile is needed if the user should get a nice file to edit. The 
> problem with configFile is that ConfigurationAdmin reads the files 
> asyncronously. So bundles of the feature might already be started at the time 
> the config is written.
> So bundles might need to restart or if they only process the config once are 
> in a kind of invalid state that does not relfect the config from the feature.
> So I propose to also write the config to ConfigAdmin if configFile is used. 
> This should allow the bundles to come up in the correct state from the start.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-4829) Make sure configFile in features makes config available early

2017-04-03 Thread Jean-Philippe CLEMENT (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953685#comment-15953685
 ] 

Jean-Philippe CLEMENT commented on KARAF-4829:
--

I'm not too sure to understand. Is the config tag updated to have a location 
attribute? Is there a sample or a documentation?

> Make sure configFile in features makes config available early
> -
>
> Key: KARAF-4829
> URL: https://issues.apache.org/jira/browse/KARAF-4829
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-config
>Affects Versions: 4.0.7
>Reporter: Christian Schneider
>Assignee: Guillaume Nodet
>
> We currently have the config and configFile elements in feature files.
> Config writes the given entries to ConfigAdmin while configFile writes a file.
> So configFile is needed if the user should get a nice file to edit. The 
> problem with configFile is that ConfigurationAdmin reads the files 
> asyncronously. So bundles of the feature might already be started at the time 
> the config is written.
> So bundles might need to restart or if they only process the config once are 
> in a kind of invalid state that does not relfect the config from the feature.
> So I propose to also write the config to ConfigAdmin if configFile is used. 
> This should allow the bundles to come up in the correct state from the start.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (KARAF-4975) karaf script uses #!/bin/bash instead of #!/usr/bin/env bash

2017-04-03 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-4975.
-
Resolution: Fixed

> karaf script uses #!/bin/bash instead of #!/usr/bin/env bash
> 
>
> Key: KARAF-4975
> URL: https://issues.apache.org/jira/browse/KARAF-4975
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.0.8
> Environment: FreeBSD
>Reporter: Eric de Boer
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.0.9
>
>
> The karaf script used to use #/bin/sh, but [changed 
> to|https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commit;h=55db450a95453c9e587cb6147ef087bb39bb4061]
>  #!/bin/bash, which on FreeBSD doesn't work, as bash is located in 
> /usr/local/bin/bash
> According to 
> http://superuser.com/questions/1133187/when-must-i-use-bin-bash-and-when-bin-sh
> It is better to use the environment to find the correct bash, by using
> #!/usr/bin/env bash
> which indeed works fine on FreeBSD.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-4975) karaf script uses #!/bin/bash instead of #!/usr/bin/env bash

2017-04-03 Thread JIRA

[ 
https://issues.apache.org/jira/browse/KARAF-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953635#comment-15953635
 ] 

Jean-Baptiste Onofré commented on KARAF-4975:
-

Fixed via: 
https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commitdiff;h=f7fad515f7f64ca43923000d49b6b4a46974722b

> karaf script uses #!/bin/bash instead of #!/usr/bin/env bash
> 
>
> Key: KARAF-4975
> URL: https://issues.apache.org/jira/browse/KARAF-4975
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.0.8
> Environment: FreeBSD
>Reporter: Eric de Boer
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.0.9
>
>
> The karaf script used to use #/bin/sh, but [changed 
> to|https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commit;h=55db450a95453c9e587cb6147ef087bb39bb4061]
>  #!/bin/bash, which on FreeBSD doesn't work, as bash is located in 
> /usr/local/bin/bash
> According to 
> http://superuser.com/questions/1133187/when-must-i-use-bin-bash-and-when-bin-sh
> It is better to use the environment to find the correct bash, by using
> #!/usr/bin/env bash
> which indeed works fine on FreeBSD.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-4865) Karaf startup no longer works on platforms without "readlink"

2017-04-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953632#comment-15953632
 ] 

ASF subversion and git services commented on KARAF-4865:


Commit f7fad515f7f64ca43923000d49b6b4a46974722b in karaf's branch 
refs/heads/karaf-4.0.x from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=f7fad51 ]

[KARAF-4564] [KARAF-4852] [KARAF-4865] Improve the main karaf script
 * use /bin/sh
 * do not rely on readlink, but use 'ls -l'
 * check exit code when changing directory
 * verify ulimit availability
 * use 'command -v' instead of 'type'
 * support spaces in the JAVA path
 * do not use {} expansion for file names
 * fix endorsed/ext dirs on cygwin/mingw


> Karaf startup no longer works on platforms without "readlink"
> -
>
> Key: KARAF-4865
> URL: https://issues.apache.org/jira/browse/KARAF-4865
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Reporter: Fabian Lange
>Assignee: Guillaume Nodet
> Fix For: 4.1.0, 3.0.8, 4.0.8
>
>
> With KARAF-4564 we used "readlink" to resolve some symlink issues. but this 
> broke karaf now for platforms which do not support "readlink". we should make 
> it optional.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-4564) Can't start karaf using symbolic link

2017-04-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953630#comment-15953630
 ] 

ASF subversion and git services commented on KARAF-4564:


Commit f7fad515f7f64ca43923000d49b6b4a46974722b in karaf's branch 
refs/heads/karaf-4.0.x from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=f7fad51 ]

[KARAF-4564] [KARAF-4852] [KARAF-4865] Improve the main karaf script
 * use /bin/sh
 * do not rely on readlink, but use 'ls -l'
 * check exit code when changing directory
 * verify ulimit availability
 * use 'command -v' instead of 'type'
 * support spaces in the JAVA path
 * do not use {} expansion for file names
 * fix endorsed/ext dirs on cygwin/mingw


>  Can't start karaf using symbolic link
> --
>
> Key: KARAF-4564
> URL: https://issues.apache.org/jira/browse/KARAF-4564
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 3.0.6
> Environment: Ubuntu (Linux vagrant 3.19.0-25-generic 
> #26~14.04.1-Ubuntu SMP Fri Jul 24 21:16:20 UTC 2015 x86_64 x86_64 x86_64 
> GNU/Linux)
> OSX (Darwin inocybe.local 14.5.0 Darwin Kernel Version 14.5.0: Tue Sep  1 
> 21:23:09 PDT 2015; root:xnu-2782.50.1~1/RELEASE_X86_64 x86_64)
> Solaris (SunOS solaris11.3 5.11 11.3 i86pc i386 i86pc)
>Reporter: Alexis de Talhouët
>Assignee: Guillaume Nodet
> Fix For: 4.1.0, 3.0.7, 4.0.8
>
>
> When using a symbolic link to use the scripts defined here: 
> https://github.com/apache/karaf/tree/karaf-3.0.6/assemblies/features/framework/src/main/filtered-resources/resources/bin
>  e.g. karaf or client and so on, it's failing to start the container and show 
> this error:
> Error: Could not find or load main class org.apache.karaf.main.Main
> This issue is related to the DIRNAME variable and the way it is setup.
> This bug has been found in OpenDaylight, here is the ticket with more 
> information https://bugs.opendaylight.org/show_bug.cgi?id=6027
> I have also propose a candidate fix in ODL: 
> https://git.opendaylight.org/gerrit/#/c/39982/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-4852) Minor issues with start script

2017-04-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953631#comment-15953631
 ] 

ASF subversion and git services commented on KARAF-4852:


Commit f7fad515f7f64ca43923000d49b6b4a46974722b in karaf's branch 
refs/heads/karaf-4.0.x from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=f7fad51 ]

[KARAF-4564] [KARAF-4852] [KARAF-4865] Improve the main karaf script
 * use /bin/sh
 * do not rely on readlink, but use 'ls -l'
 * check exit code when changing directory
 * verify ulimit availability
 * use 'command -v' instead of 'type'
 * support spaces in the JAVA path
 * do not use {} expansion for file names
 * fix endorsed/ext dirs on cygwin/mingw


> Minor issues with start script
> --
>
> Key: KARAF-4852
> URL: https://issues.apache.org/jira/browse/KARAF-4852
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.7
>Reporter: Lars Kiesow
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.0
>
>
> If a cd command fails in the start script the following behavior is undefined 
> and could potentially cause problems.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (KARAF-5079) Log:tail does not print messages steadily

2017-04-03 Thread Guillaume Nodet (JIRA)

 [ 
https://issues.apache.org/jira/browse/KARAF-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved KARAF-5079.

Resolution: Fixed

https://github.com/apache/karaf/commit/4f18c5b96c8e561e2a4eb7500917884a7d352864

> Log:tail does not print messages steadily
> -
>
> Key: KARAF-5079
> URL: https://issues.apache.org/jira/browse/KARAF-5079
> Project: Karaf
>  Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 4.1.2
>
>
> It waits for some keyboard entries, at least when executed through the 
> bin/client script.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (KARAF-5081) Fix problem with resource extraction from kar files

2017-04-03 Thread Guillaume Nodet (JIRA)

 [ 
https://issues.apache.org/jira/browse/KARAF-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved KARAF-5081.

Resolution: Fixed

https://github.com/apache/karaf/commit/fa3828bbab6d23997092547a7540b5b520c00a0d

> Fix problem with resource extraction from kar files
> ---
>
> Key: KARAF-5081
> URL: https://issues.apache.org/jira/browse/KARAF-5081
> Project: Karaf
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 4.1.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-5081) Fix problem with resource extraction from kar files

2017-04-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953136#comment-15953136
 ] 

ASF subversion and git services commented on KARAF-5081:


Commit fa3828bbab6d23997092547a7540b5b520c00a0d in karaf's branch 
refs/heads/master from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=fa3828b ]

[KARAF-5081] Fix problem with resource extraction from kar files

> Fix problem with resource extraction from kar files
> ---
>
> Key: KARAF-5081
> URL: https://issues.apache.org/jira/browse/KARAF-5081
> Project: Karaf
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 4.1.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-5079) Log:tail does not print messages steadily

2017-04-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953134#comment-15953134
 ] 

ASF subversion and git services commented on KARAF-5079:


Commit 4f18c5b96c8e561e2a4eb7500917884a7d352864 in karaf's branch 
refs/heads/master from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=4f18c5b ]

[KARAF-5079] Log:tail does not print messages steadily

> Log:tail does not print messages steadily
> -
>
> Key: KARAF-5079
> URL: https://issues.apache.org/jira/browse/KARAF-5079
> Project: Karaf
>  Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 4.1.2
>
>
> It waits for some keyboard entries, at least when executed through the 
> bin/client script.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-5016) Possible NPE while running "log:tail" in Karaf console

2017-04-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953135#comment-15953135
 ] 

ASF subversion and git services commented on KARAF-5016:


Commit 689616a7680a0746ce0cbd8a28ff7661ba3ed0de in karaf's branch 
refs/heads/master from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=689616a ]

[KARAF-5016] Fix another possible NPE

> Possible NPE while running "log:tail" in Karaf console
> --
>
> Key: KARAF-5016
> URL: https://issues.apache.org/jira/browse/KARAF-5016
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.1.0
>Reporter: Richard Kosegi
>Assignee: Guillaume Nodet
>Priority: Trivial
> Fix For: 4.1.1
>
>
> There is occasional NPE while running "log:tail" in Karaf console.
> This occurs few times per day, it has no real impact other then tailing of 
> log is stopped (and must be restarted by CTRL+C, log:tail)
> Exception in thread "pool-51-thread-1" java.lang.NullPointerException
> at 
> org.apache.karaf.log.core.internal.layout.PatternParser$MDCPatternConverter.convert(PatternParser.java:551)
> at 
> org.apache.karaf.log.core.internal.layout.PatternConverter.format(PatternConverter.java:63)
> at 
> org.apache.karaf.log.core.internal.LogEventFormatterImpl.format(LogEventFormatterImpl.java:117)
> at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:121)
> at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:105)
> at 
> org.apache.karaf.log.command.LogTail$PrintEventThread.run(LogTail.java:113)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (KARAF-5081) Fix problem with resource extraction from kar files

2017-04-03 Thread Guillaume Nodet (JIRA)
Guillaume Nodet created KARAF-5081:
--

 Summary: Fix problem with resource extraction from kar files
 Key: KARAF-5081
 URL: https://issues.apache.org/jira/browse/KARAF-5081
 Project: Karaf
  Issue Type: Improvement
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 4.1.2






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (KARAF-5080) Use the full ttop command from gogo-jline

2017-04-03 Thread Guillaume Nodet (JIRA)
Guillaume Nodet created KARAF-5080:
--

 Summary: Use the full ttop command from gogo-jline
 Key: KARAF-5080
 URL: https://issues.apache.org/jira/browse/KARAF-5080
 Project: Karaf
  Issue Type: Improvement
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KARAF-5079) Log:tail does not print messages steadily

2017-04-03 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953042#comment-15953042
 ] 

Guillaume Nodet commented on KARAF-5079:


It seems KARAF-3021 leads to 2 threads being submitted to the single threaded 
executor, so only one can run at a single time.

> Log:tail does not print messages steadily
> -
>
> Key: KARAF-5079
> URL: https://issues.apache.org/jira/browse/KARAF-5079
> Project: Karaf
>  Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 4.1.2
>
>
> It waits for some keyboard entries, at least when executed through the 
> bin/client script.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (KARAF-5079) Log:tail does not print messages steadily

2017-04-03 Thread Guillaume Nodet (JIRA)
Guillaume Nodet created KARAF-5079:
--

 Summary: Log:tail does not print messages steadily
 Key: KARAF-5079
 URL: https://issues.apache.org/jira/browse/KARAF-5079
 Project: Karaf
  Issue Type: Bug
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 4.1.2


It waits for some keyboard entries, at least when executed through the 
bin/client script.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)