[jira] [Assigned] (KARAF-5380) Fix typo in JDBC lock implementation

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KARAF-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré reassigned KARAF-5380:
---

Assignee: Jean-Baptiste Onofré

> Fix typo in JDBC lock implementation
> 
>
> Key: KARAF-5380
> URL: https://issues.apache.org/jira/browse/KARAF-5380
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-jdbc
>Reporter: Bryan Eargle
>Assignee: Jean-Baptiste Onofré
>Priority: Trivial
>  Labels: easyfix, newbie
> Fix For: 4.2.0, 4.1.3
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Typo in method names used to acquire JDBC lock. Should be _acquireLock()_ 
> instead of _aquireLock()_. Affects Default, Oracle, and PostgreSQL classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (KARAF-5380) Fix typo in JDBC lock implementation

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KARAF-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-5380:

Fix Version/s: 4.1.3
   4.2.0

> Fix typo in JDBC lock implementation
> 
>
> Key: KARAF-5380
> URL: https://issues.apache.org/jira/browse/KARAF-5380
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-jdbc
>Reporter: Bryan Eargle
>Assignee: Jean-Baptiste Onofré
>Priority: Trivial
>  Labels: easyfix, newbie
> Fix For: 4.2.0, 4.1.3
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Typo in method names used to acquire JDBC lock. Should be _acquireLock()_ 
> instead of _aquireLock()_. Affects Default, Oracle, and PostgreSQL classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KARAF-5380) Fix typo in JDBC lock implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169145#comment-16169145
 ] 

ASF GitHub Bot commented on KARAF-5380:
---

GitHub user beargle opened a pull request:

https://github.com/apache/karaf/pull/372

[KARAF-5380] Fix typo in JDBC lock implementation

Replace `aquire` with `acquire` in method names, variables, and comments. 
Also remove trailing whitespace and apply consistent indentation in touched 
files.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/beargle/karaf KARAF-5380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/karaf/pull/372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #372


commit 0c44e3ef9dc050037e59d52585eca291c4b6a47e
Author: Bryan Eargle 
Date:   2017-09-16T22:22:54Z

[KARAF-5380] Fix typo in JDBC lock implementation.

Replace `aquire` with `acquire` in method names, variables, and
comments.

commit b452923dbf2bbd44f745be6c27e69826bc03dd15
Author: Bryan Eargle 
Date:   2017-09-16T23:40:41Z

[KARAF-5380] Apply minor whitespace formatting.

Remove trailing whitespace, improve consistency of identation.




> Fix typo in JDBC lock implementation
> 
>
> Key: KARAF-5380
> URL: https://issues.apache.org/jira/browse/KARAF-5380
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-jdbc
>Reporter: Bryan Eargle
>Priority: Trivial
>  Labels: easyfix, newbie
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Typo in method names used to acquire JDBC lock. Should be _acquireLock()_ 
> instead of _aquireLock()_. Affects Default, Oracle, and PostgreSQL classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (KARAF-5380) Fix typo in JDBC lock implementation

[Bryan Eargle (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KARAF-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Eargle updated KARAF-5380:

Summary: Fix typo in JDBC lock implementation  (was: Fix typo in JDBC lock 
acquisition method names)

> Fix typo in JDBC lock implementation
> 
>
> Key: KARAF-5380
> URL: https://issues.apache.org/jira/browse/KARAF-5380
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-jdbc
>Reporter: Bryan Eargle
>Priority: Trivial
>  Labels: easyfix, newbie
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Typo in method names used to acquire JDBC lock. Should be _acquireLock()_ 
> instead of _aquireLock()_. Affects Default, Oracle, and PostgreSQL classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (KARAF-5380) Fix typo in JDBC lock acquisition method names

[Bryan Eargle (JIRA)]

Bryan Eargle created KARAF-5380:
---

 Summary: Fix typo in JDBC lock acquisition method names
 Key: KARAF-5380
 URL: https://issues.apache.org/jira/browse/KARAF-5380
 Project: Karaf
  Issue Type: Improvement
  Components: karaf-jdbc
Reporter: Bryan Eargle
Priority: Trivial


Typo in method names used to acquire JDBC lock. Should be _acquireLock()_ 
instead of _aquireLock()_. Affects Default, Oracle, and PostgreSQL classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (KARAF-4255) karaf-maven-plugin does include unused feature conditional dependencies in assembly

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KARAF-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4255:

Fix Version/s: (was: 4.0.10)
   4.0.11

> karaf-maven-plugin does include unused feature conditional dependencies in 
> assembly
> ---
>
> Key: KARAF-4255
> URL: https://issues.apache.org/jira/browse/KARAF-4255
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.3
>Reporter: Fabian Lange
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.1.3, 4.0.11
>
>
> I am using karaf-maven-plugin to make a custom assembly.
> I do include SCR, but I do not include webconsole.
> When I look into the system folder of my generated assembly, I can see:
> {code}
> target/assembly/system/org/apache/felix/org.apache.felix.webconsole.plugins.ds/2.0.2/org.apache.felix.webconsole.plugins.ds-2.0.2.jar
> {code}
> this correlates to the maven output:
> {code}
> [INFO] Feature scr is defined as a boot feature
> [INFO] == Installing artifact 
> mvn:org.apache.karaf.scr/org.apache.karaf.scr.command/4.0.3
> [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.scr/2.0.2
> [INFO] == Installing artifact 
> mvn:org.apache.felix/org.apache.felix.scr.compat/1.0.2
> [INFO] == Installing artifact 
> mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.0.2
> [INFO] == Installing artifact 
> mvn:org.apache.felix/org.apache.felix.metatype/1.1.2
> [INFO] == Installing artifact 
> mvn:org.apache.karaf.scr/org.apache.karaf.scr.management/4.0.3
> {code}
> however looking at: 
> https://github.com/apache/karaf/blob/master/assemblies/features/standard/src/main/feature/feature.xml#L524
> you can see that this is an conditional dependency only.
> This is caused by the fact that assembly does not check if the conditional 
> had been met:
> https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apache/karaf/profile/assembly/Builder.java#L822
> I believe we need a check for the conditionals wether the condition is 
> actually met.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KARAF-3976) Broken compatibility with 3.x jdbc DataSources

[JIRA]

[ 
https://issues.apache.org/jira/browse/KARAF-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168932#comment-16168932
 ] 

Jean-Baptiste Onofré commented on KARAF-3976:
-

FYI, I'm resuming the full support of "old style datasources" in pax-jdbc.

> Broken compatibility with 3.x jdbc DataSources
> --
>
> Key: KARAF-3976
> URL: https://issues.apache.org/jira/browse/KARAF-3976
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-jdbc
>Affects Versions: 4.0.1
>Reporter: Sergey 
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.2.0, 4.0.10, 4.1.3
>
>
> 1st of all, current documentaion is wrong, because command names was changed 
> to jdbc:ds-info, for example, but 
> http://karaf.apache.org/manual/latest/users-guide/jdbc.html still contains 
> jdbc:info command names.
> Most important compatibility breaking change was another one: in karaf 3.x I 
> was able to deploy DataSource using spring-dm xml or blueprint, and it was 
> registered as a service and in jndi, and was listed using jdbc:datasources 
> command. Right now no datasources are listed.
> {code}
> karaf@root()> jndi:names
> JNDI Name | Class Name
> --
> osgi:service/jdbc/zeusDataSource  | 
> net.sourceforge.jtds.jdbcx.JtdsDataSource
> osgi:service/jdbc/arenaDS | 
> net.sourceforge.jtds.jdbcx.JtdsDataSource
> osgi:service/jdbc/tomsDS  | 
> net.sourceforge.jtds.jdbcx.JtdsDataSource
> osgi:service/jdbc/cofDS   | 
> com.sybase.jdbc3.jdbc.SybDataSource
> osgi:service/jdbc/fidbDataSource  | 
> net.sourceforge.jtds.jdbcx.JtdsDataSource
> osgi:service/jdbc/murexDS | 
> com.sybase.jdbc3.jdbc.SybDataSource
> osgi:service/jdbc/gpDataSource| 
> org.postgresql.ds.PGPoolingDataSource
> karaf@root()> jdbc:ds-info jdbc/fidbDataSource
> Property   | Value
> -
> driver.version | 1.2.2
> db.version | 10.50.4000
> db.product | Microsoft SQL Server
> url| jdbc:jtds:sqlserver:
> driver.name| jTDS Type 4 JDBC Driver for MS SQL Server and Sybase
> username   | ...
> karaf@root()> jdbc:ds-list
> Name | Product | Version | URL | Status
> ---
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (KARAF-3572) Override resources for instance:create in custom distributions

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KARAF-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-3572:

Fix Version/s: (was: 4.0.10)

> Override resources for instance:create in custom distributions
> --
>
> Key: KARAF-3572
> URL: https://issues.apache.org/jira/browse/KARAF-3572
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-instance
>Affects Versions: 3.0.3, 2.4.1, 4.0.0.M2
>Reporter: Krzysztof Sobkowiak
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.3
>
>
> Currently the command {{instance:create}} creates a new instance using the 
> resources included in {{org.apache.karaf.instance.core}} bundle. It would be 
> resonable to allow people to override the resources in custom distributions, 
> e.g. in the same way like branding bundles.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (KARAF-2511) Review and update documentation

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KARAF-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-2511:

Fix Version/s: (was: 4.0.10)

> Review and update documentation
> ---
>
> Key: KARAF-2511
> URL: https://issues.apache.org/jira/browse/KARAF-2511
> Project: Karaf
>  Issue Type: Task
>  Components: karaf-documentation
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.2.0, 4.1.3
>
>
> The documentation (manual) should be reviewed:
> - The subshell part should be described (usage and configuration).
> - The "code samples"/screenshots have to be updated with Karaf 3.0.0 use cases
> - a global polishing, double read



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (KARAF-4188) Add support for Systemd's watchdog

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KARAF-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4188:

Fix Version/s: (was: 4.0.10)

> Add support for Systemd's watchdog
> --
>
> Key: KARAF-4188
> URL: https://issues.apache.org/jira/browse/KARAF-4188
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.3
>
>
> Systemd has a watchdog feature that could help detecting freeze jvm, 
> integrating it in karaf would be possible via jna/jnr



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KARAF-5379) Upgrade Pax-Web to 4.3.4

[JIRA]

[ 
https://issues.apache.org/jira/browse/KARAF-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168891#comment-16168891
 ] 

Jean-Baptiste Onofré commented on KARAF-5379:
-

I gonna prepare a 4.0.10.

> Upgrade Pax-Web to 4.3.4
> 
>
> Key: KARAF-5379
> URL: https://issues.apache.org/jira/browse/KARAF-5379
> Project: Karaf
>  Issue Type: Dependency upgrade
>  Components: karaf-webcontainer
>Affects Versions: 4.0.9
>Reporter: Martin Lichtin
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.0.10
>
>
> Ran into an issue and a version >= 4.3.3 would help.
> https://groups.google.com/forum/#!topic/ops4j/M2hk8RjA31I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KARAF-5379) Upgrade Pax-Web to 4.3.4

[Martin Lichtin (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1616#comment-1616
 ] 

Martin Lichtin commented on KARAF-5379:
---

That was quick, thanks!

About the 4.0.10 ETA, would you be able to update 
http://karaf.apache.org/download.html#container-schedule ?
Or perhaps remove the ETA column if it proves difficult to estimate.
On the other hand, it'd be nice if the table would show the release date of the 
"Last Version".

> Upgrade Pax-Web to 4.3.4
> 
>
> Key: KARAF-5379
> URL: https://issues.apache.org/jira/browse/KARAF-5379
> Project: Karaf
>  Issue Type: Dependency upgrade
>  Components: karaf-webcontainer
>Affects Versions: 4.0.9
>Reporter: Martin Lichtin
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.0.10
>
>
> Ran into an issue and a version >= 4.3.3 would help.
> https://groups.google.com/forum/#!topic/ops4j/M2hk8RjA31I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KARAF-5372) startup.properties doesn't respect overrides

[JIRA]

[ 
https://issues.apache.org/jira/browse/KARAF-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168873#comment-16168873
 ] 

Jérémie Brébec commented on KARAF-5372:
---

In order to fix KARAF-5371, I have patched the feature jar with a custom 
version (4.1.2.a), and I wanted to install this version instead of the 4.1.2. I 
do the same for bugs in pax-web or others librairies. however, it's not simple 
to make a distribution with a patch for the feature.jar

The startup.properties is generated by the karaf-maven-plugin, and I don't want 
to add a patched startup.properties in git for all of my containers, and ask 
for all the teams to do the same for their own application  (I manage a lot of 
applications based on Karaf, and some of them are built by other teams - I 
don't want those teams to have to fix this kind of low level bugs, they just 
use a profile and a kar for now)

> startup.properties doesn't respect overrides
> 
>
> Key: KARAF-5372
> URL: https://issues.apache.org/jira/browse/KARAF-5372
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-tooling
>Affects Versions: 4.1.2
>Reporter: J. Brébec
>Assignee: Guillaume Nodet
>
> The karaf-maven-plugin doesn't take into account bundles overrides. The karaf 
> main doesn't use it either. As a consequence, it is not possible to override 
> core bundle as fileinstall or features-core
> For a real usecase, I was trying to patch locally KARAF-5371 (which is a 
> blocker issue in my context), but it's not possible to override the 
> feature-core bundle. I have to overwrite the jar with a patched version after 
> the assembly goal..



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)