[jira] [Resolved] (KARAF-5203) KAR:Create missing bundles that are marked conditional

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-5203.
-
Resolution: Fixed

> KAR:Create missing bundles that are marked conditional
> --
>
> Key: KARAF-5203
> URL: https://issues.apache.org/jira/browse/KARAF-5203
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.4, 4.2.0
>
>
> When creating a KAR file using the KAR:CREATE commands for a feature contains 
> a  bundle in the feature file, the bundle is not being included 
> in the resulting KAR.
> I found this while creating a KAR for aries-rsa using the following command.
> >kar:create aries-rsa-1.9.0 aries-rsa-discovery-zookeeper
> When trying to start the KAR, I received errors stating that it could not 
> find the mvn:org.apache.aries.rsa/org.apache.aries.rsa.eapub/1.9.0 from the 
> repository. Checking the KAR, this bundle was not present. I manually updated 
> the KAR and the feature started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5203) KAR:Create missing bundles that are marked conditional

2017-12-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289594#comment-16289594
 ] 

ASF subversion and git services commented on KARAF-5203:


Commit 07ef05be2b8016872b06b9af890921aa7469750a in karaf's branch 
refs/heads/karaf-4.1.x from [~jbonofre]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=07ef05b ]

[KARAF-5203] Includes conditional bundles and configuration files when creating 
a KAR


> KAR:Create missing bundles that are marked conditional
> --
>
> Key: KARAF-5203
> URL: https://issues.apache.org/jira/browse/KARAF-5203
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.4, 4.2.0
>
>
> When creating a KAR file using the KAR:CREATE commands for a feature contains 
> a  bundle in the feature file, the bundle is not being included 
> in the resulting KAR.
> I found this while creating a KAR for aries-rsa using the following command.
> >kar:create aries-rsa-1.9.0 aries-rsa-discovery-zookeeper
> When trying to start the KAR, I received errors stating that it could not 
> find the mvn:org.apache.aries.rsa/org.apache.aries.rsa.eapub/1.9.0 from the 
> repository. Checking the KAR, this bundle was not present. I manually updated 
> the KAR and the feature started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5203) KAR:Create missing bundles that are marked conditional

2017-12-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289593#comment-16289593
 ] 

ASF subversion and git services commented on KARAF-5203:


Commit b2142603c5b6f8b8bc97b9c4d62d8396bd167b6a in karaf's branch 
refs/heads/master from [~jbonofre]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=b214260 ]

[KARAF-5203] Includes conditional bundles and configuration files when creating 
a KAR


> KAR:Create missing bundles that are marked conditional
> --
>
> Key: KARAF-5203
> URL: https://issues.apache.org/jira/browse/KARAF-5203
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.4, 4.2.0
>
>
> When creating a KAR file using the KAR:CREATE commands for a feature contains 
> a  bundle in the feature file, the bundle is not being included 
> in the resulting KAR.
> I found this while creating a KAR for aries-rsa using the following command.
> >kar:create aries-rsa-1.9.0 aries-rsa-discovery-zookeeper
> When trying to start the KAR, I received errors stating that it could not 
> find the mvn:org.apache.aries.rsa/org.apache.aries.rsa.eapub/1.9.0 from the 
> repository. Checking the KAR, this bundle was not present. I manually updated 
> the KAR and the feature started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5203) KAR:Create missing bundles that are marked conditional

2017-12-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289592#comment-16289592
 ] 

ASF GitHub Bot commented on KARAF-5203:
---

jbonofre closed pull request #429: [KARAF-5203] Includes conditional bundles 
and configuration files whe…
URL: https://github.com/apache/karaf/pull/429
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/kar/src/main/java/org/apache/karaf/kar/internal/KarServiceImpl.java 
b/kar/src/main/java/org/apache/karaf/kar/internal/KarServiceImpl.java
index ec7e21d34c..f7b6758f67 100644
--- a/kar/src/main/java/org/apache/karaf/kar/internal/KarServiceImpl.java
+++ b/kar/src/main/java/org/apache/karaf/kar/internal/KarServiceImpl.java
@@ -45,12 +45,7 @@
 import java.util.jar.JarOutputStream;
 import java.util.jar.Manifest;
 
-import org.apache.karaf.features.BundleInfo;
-import org.apache.karaf.features.ConfigFileInfo;
-import org.apache.karaf.features.Dependency;
-import org.apache.karaf.features.Feature;
-import org.apache.karaf.features.FeaturesService;
-import org.apache.karaf.features.Repository;
+import org.apache.karaf.features.*;
 import org.apache.karaf.kar.KarService;
 import org.apache.karaf.util.StreamUtils;
 import org.apache.karaf.util.maven.Parser;
@@ -404,14 +399,27 @@ private void closeStream(OutputStream os) {
 
 private void copyFeatureToJar(JarOutputStream jos, Feature feature, 
Map locationMap)
 throws URISyntaxException {
+// add bundles
 for (BundleInfo bundleInfo : feature.getBundles()) {
 URI location = new URI(bundleInfo.getLocation());
 copyResourceToJar(jos, location, locationMap);
 }
+// add config files
 for (ConfigFileInfo configFileInfo : feature.getConfigurationFiles()) {
 URI location = new URI(configFileInfo.getLocation());
 copyResourceToJar(jos, location, locationMap);
 }
+// add bundles and config files in conditionals
+for (Conditional conditional : feature.getConditional()) {
+for (BundleInfo bundleInfo : conditional.getBundles()) {
+URI location = new URI(bundleInfo.getLocation());
+copyResourceToJar(jos, location, locationMap);
+}
+for (ConfigFileInfo configFileInfo : 
conditional.getConfigurationFiles()) {
+URI location = new URI(configFileInfo.getLocation());
+copyResourceToJar(jos, location, locationMap);
+}
+}
 }
 
 private void copyResourceToJar(JarOutputStream jos, URI location, Map locationMap) {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> KAR:Create missing bundles that are marked conditional
> --
>
> Key: KARAF-5203
> URL: https://issues.apache.org/jira/browse/KARAF-5203
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.4, 4.2.0
>
>
> When creating a KAR file using the KAR:CREATE commands for a feature contains 
> a  bundle in the feature file, the bundle is not being included 
> in the resulting KAR.
> I found this while creating a KAR for aries-rsa using the following command.
> >kar:create aries-rsa-1.9.0 aries-rsa-discovery-zookeeper
> When trying to start the KAR, I received errors stating that it could not 
> find the mvn:org.apache.aries.rsa/org.apache.aries.rsa.eapub/1.9.0 from the 
> repository. Checking the KAR, this bundle was not present. I manually updated 
> the KAR and the feature started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5210) Seemingly random NPEs from Aether resolver

2017-12-13 Thread Peter Berkman (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289448#comment-16289448
 ] 

Peter Berkman commented on KARAF-5210:
--

I have not tried 4.1.3 yet (been busy with release).  Was Guillaume's fix part 
of 4.1.3?

> Seemingly random NPEs from Aether resolver
> --
>
> Key: KARAF-5210
> URL: https://issues.apache.org/jira/browse/KARAF-5210
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.1.1
> Environment: Windows
>Reporter: Peter Berkman
>Assignee: Guillaume Nodet
> Fix For: 4.2.0, 4.1.5
>
> Attachments: mvnsettings.xml, org.ops4j.pax.url.mvn.cfg
>
>
> We have an installer that automates much of our Karaf and product 
> installation.  
> since the upgrade to Karaf 4.1, I've been getting these about every 5th 
> automated install. could be timing? Happens at random places and sometimes 
> with dependencies that the target doesn't have.
> One thing is that we do turn OFF internet access for maven through settings 
> in the org.ops4j.pax.url.mvn.cfg and provider our out mvnsettings.xml.  I 
> will try and attach them later, but these are the relevant settings:
> {code}
> org.ops4j.pax.url.mvn.settings=${karaf.etc}/mvnsettings.xml
> org.ops4j.pax.url.mvn.localRepository=${karaf.data}/repo
> org.ops4j.pax.url.mvn.useFallbackRepositories=false
> org.ops4j.pax.url.mvn.defaultRepositories=
> org.ops4j.pax.url.mvn.defaultLocalRepoAsRemote=true
> org.ops4j.pax.url.mvn.repositories= \
> 
> file:${karaf.home}/${karaf.default.repository}@id=system.repository@snapshots,\
> file:${karaf.data}/kar@id=kar.repository@multi@snapshots
> {code}
> mvnsettings.xml:
> {code}
> http://maven.apache.org/SETTINGS/1.1.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 
> http://maven.apache.org/xsd/settings-1.1.0.xsd;>
>   data/repo
> 
> {code}
> Here is what the stack looks like - note that the target bundle is almost 
> always different on different failures.
> {code}
> 20170614 11:24:50.512 [INFO ] pipe-feature:install -v -r ngaudit | 
> 10:org.apache.karaf.features.core | 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl | Adding 
> features: ngaudit/[10.0.0.SNAPSHOT,10.0.0.SNAPSHOT]
> 20170614 11:24:50.531 [ERROR] Thread-85 | 69:org.apache.karaf.shell.core | 
> org.apache.karaf.shell.support.ShellUtil | Exception caught while executing 
> command
> org.apache.karaf.features.internal.util.MultiException: Error
> at 
> org.apache.karaf.features.internal.download.impl.MavenDownloadManager$MavenDownloader.(MavenDownloadManager.java:84)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.download.impl.MavenDownloadManager.createDownloader(MavenDownloadManager.java:72)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.Subsystem.downloadBundles(Subsystem.java:375)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.Subsystem.downloadBundles(Subsystem.java:372)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:187)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:285)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1170)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$0(FeaturesServiceImpl.java:1069)[10:org.apache.karaf.features.core:4.1.1]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_92]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_92]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_92]
> at java.lang.Thread.run(Thread.java:745)[:1.8.0_92]
> Caused by: java.io.IOException: Error downloading 
> mvn:org.apache.karaf.jndi/org.apache.karaf.jndi.core/4.1.1
> at 
> org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run(AbstractRetryableDownloadTask.java:81)[10:org.apache.karaf.features.core:4.1.1]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_92]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_92]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)[:1.8.0_92]
> at 
> 

[jira] [Resolved] (KARAF-5485) Be able to disable the sftp server

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-5485.
-
Resolution: Fixed

> Be able to disable the sftp server
> --
>
> Key: KARAF-5485
> URL: https://issues.apache.org/jira/browse/KARAF-5485
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-shell
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.1.4, 4.2.0
>
>
> Thanks to sshd, Karaf also provides a sftp server. For security reason, it 
> would be great to be able to disable the sftp server (via 
> {{etc/org.apache.karaf.shell.cfg}} for instance).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5485) Be able to disable the sftp server

2017-12-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289348#comment-16289348
 ] 

ASF subversion and git services commented on KARAF-5485:


Commit 7ef7ccd04beb02649a3427c2c6c882de30e14f17 in karaf's branch 
refs/heads/karaf-4.1.x from [~jbonofre]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=7ef7ccd ]

[KARAF-5485] Add the sftpEnabled property in org.apache.karaf.shell 
configuration to control the SSH SFTP system startup


> Be able to disable the sftp server
> --
>
> Key: KARAF-5485
> URL: https://issues.apache.org/jira/browse/KARAF-5485
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-shell
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.1.4, 4.2.0
>
>
> Thanks to sshd, Karaf also provides a sftp server. For security reason, it 
> would be great to be able to disable the sftp server (via 
> {{etc/org.apache.karaf.shell.cfg}} for instance).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5485) Be able to disable the sftp server

2017-12-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289337#comment-16289337
 ] 

ASF subversion and git services commented on KARAF-5485:


Commit 4b32a5b7514f63423adfc63857c6abe1ef46 in karaf's branch 
refs/heads/master from [~jbonofre]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=4b32a5b ]

[KARAF-5485] Add the sftpEnabled property in org.apache.karaf.shell 
configuration to control the SSH SFTP system startup


> Be able to disable the sftp server
> --
>
> Key: KARAF-5485
> URL: https://issues.apache.org/jira/browse/KARAF-5485
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-shell
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.1.4, 4.2.0
>
>
> Thanks to sshd, Karaf also provides a sftp server. For security reason, it 
> would be great to be able to disable the sftp server (via 
> {{etc/org.apache.karaf.shell.cfg}} for instance).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KARAF-4966) Provide a Update Note document

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-4966.
-
   Resolution: Won't Fix
Fix Version/s: (was: 4.2.0)
   (was: 4.1.4)

> Provide a Update Note document
> --
>
> Key: KARAF-4966
> URL: https://issues.apache.org/jira/browse/KARAF-4966
> Project: Karaf
>  Issue Type: Task
>  Components: karaf-documentation
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>
> As we did for the update from Karaf 3.0.x to 4.0.x, we will provide a 
> documentation containing update notes. It should provide the key diff for 
> people upgrading to  Karaf 4.1.x (location of the features, shell behavior, 
> ...).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KARAF-5228) Add documentation about staged featuresBoot

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-5228.
-
   Resolution: Not A Problem
Fix Version/s: (was: 4.2.0)
   (was: 4.1.4)

> Add documentation about staged featuresBoot
> ---
>
> Key: KARAF-5228
> URL: https://issues.apache.org/jira/browse/KARAF-5228
> Project: Karaf
>  Issue Type: Documentation
>  Components: karaf-feature
>Affects Versions: 4.1.1
>Reporter: Emily Berk
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
> Documentation should be added to clarify the relationship between features 
> included in parentheses and features not wrapped in parentheses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5485) Be able to disable the sftp server

2017-12-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289336#comment-16289336
 ] 

ASF GitHub Bot commented on KARAF-5485:
---

jbonofre closed pull request #428: [KARAF-5485] Add the sftpEnabled property in 
org.apache.karaf.shell c…
URL: https://github.com/apache/karaf/pull/428
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/assemblies/features/standard/src/main/feature/feature.xml 
b/assemblies/features/standard/src/main/feature/feature.xml
index cde6feafc3..a7d8b25700 100644
--- a/assemblies/features/standard/src/main/feature/feature.xml
+++ b/assemblies/features/standard/src/main/feature/feature.xml
@@ -270,6 +270,11 @@
 #
 sshRole = ssh
 
+#
+# Defines if the SFTP system is enabled or not in the SSH server
+#
+sftpEnabled=true
+
 #
 # The location of the hostKey file defines where the 
private/public key of the server
 # is located. If no file is at the defined location it will be 
ignored.
diff --git a/manual/src/main/asciidoc/user-guide/remote.adoc 
b/manual/src/main/asciidoc/user-guide/remote.adoc
index 7c33f9de37..546252390e 100644
--- a/manual/src/main/asciidoc/user-guide/remote.adoc
+++ b/manual/src/main/asciidoc/user-guide/remote.adoc
@@ -87,6 +87,11 @@ hostKey = ${karaf.etc}/host.key
 #
 # sshRole = admin
 
+#
+# Defines if the SFTP system is enabled or not in the SSH server
+#
+sftpEnabled=true
+
 #
 # Self defined key size in 1024, 2048, 3072, or 4096
 # If not set, this defaults to 4096.
@@ -122,6 +127,8 @@ The `etc/org.apache.karaf.shell.cfg` configuration file 
contains different prope
  and private key pair of the SSHd server.
 * `sshRole` is the default role used for SSH access. The default value is the 
value of `karaf.admin.role` property
  defined in `etc/system.properties`. See the [Security section|security] of 
this user guide for details.
+* `sftpEnabled` controls if the SSH server start the SFTP system or not. When 
enabled, Karaf SSHd supports SFTP, meaning
+ that you can remotely access to the Karaf filesystem with any sftp clients.
 * `keySize` is the key size used by the SSHd server. The possible values are 
1024, 2048, 3072, or 4096. The default
  value is 1024.
 * `algorithm` is the host key algorithm used by the SSHd server. The possible 
values are DSA or RSA. The default
diff --git a/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/Activator.java 
b/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/Activator.java
index 4c7667b390..1deb9fe009 100644
--- a/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/Activator.java
+++ b/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/Activator.java
@@ -156,6 +156,7 @@ protected SshServer createSshServer(SessionFactory 
sessionFactory) {
 String[] kexAlgorithms = getStringArray("kexAlgorithms", 
"diffie-hellman-group-exchange-sha256,ecdh-sha2-nistp521,ecdh-sha2-nistp384,ecdh-sha2-nistp256,diffie-hellman-group-exchange-sha1,diffie-hellman-group1-sha1");
 String welcomeBanner   = getString("welcomeBanner", null);
 String moduliUrl   = getString("moduli-url", null);
+boolean sftpEnabled = getBoolean("sftpEnabled", true);
 
 Path serverKeyPath = Paths.get(hostKey);
 KeyPairProvider keyPairProvider = new 
OpenSSHKeyPairProvider(serverKeyPath.toFile(), algorithm, keySize);
@@ -170,12 +171,14 @@ protected SshServer createSshServer(SessionFactory 
sessionFactory) {
 server.setCipherFactories(SshUtils.buildCiphers(ciphers));
 
server.setKeyExchangeFactories(SshUtils.buildKexAlgorithms(kexAlgorithms));
 server.setShellFactory(new ShellFactoryImpl(sessionFactory));
-server.setCommandFactory(new 
ScpCommandFactory.Builder().withDelegate(cmd -> new 
ShellCommand(sessionFactory, cmd)).build());
-server.setSubsystemFactories(Collections.singletonList(new 
SftpSubsystemFactory()));
+if (sftpEnabled) {
+server.setCommandFactory(new 
ScpCommandFactory.Builder().withDelegate(cmd -> new 
ShellCommand(sessionFactory, cmd)).build());
+server.setSubsystemFactories(Collections.singletonList(new 
SftpSubsystemFactory()));
+server.setFileSystemFactory(new 
VirtualFileSystemFactory(Paths.get(System.getProperty("karaf.base";
+}
 server.setKeyPairProvider(keyPairProvider);
 server.setPasswordAuthenticator(authenticator);
 server.setPublickeyAuthenticator(authenticator);
-server.setFileSystemFactory(new 
VirtualFileSystemFactory(Paths.get(System.getProperty("karaf.base";
 

[jira] [Resolved] (KARAF-3402) Deployed KARs aren't uninstall at start up

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-3402.
-
Resolution: Won't Fix

It's more a FileInstall issue, and we can't do a lot for now internally to the 
Kar Deployer.

> Deployed KARs aren't uninstall at start up
> --
>
> Key: KARAF-3402
> URL: https://issues.apache.org/jira/browse/KARAF-3402
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
>Affects Versions: 3.0.2
> Environment: ubuntu 14
>Reporter: Karl Leopold
>Assignee: Jean-Baptiste Onofré
>
> Installing KARs via dropping them into the deploy dir is a very useful 
> feature to me. Installing when Karaf is running works. It is also possible to 
> remove a kar from the deploy dir and it will be automatically uninstalled, 
> then. When you deplay a kar and start Karaf afterwards, it will be installed.
> The only case the kar deployment mechanism doesn't work is, when you remove a 
> kar while Karaf is not running and then start Karaf. The Karaf deployer 
> doesn't uninstall it. That's bad for me, because I wan't to install/uninstall 
> kar files independently whether it's on or off. I also think that this 
> behavior is inconsistent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-2511) Review and update documentation

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-2511:

Fix Version/s: (was: 4.1.4)
   4.1.5

> Review and update documentation
> ---
>
> Key: KARAF-2511
> URL: https://issues.apache.org/jira/browse/KARAF-2511
> Project: Karaf
>  Issue Type: Task
>  Components: karaf-documentation
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.2.0, 4.1.5
>
>
> The documentation (manual) should be reviewed:
> - The subshell part should be described (usage and configuration).
> - The "code samples"/screenshots have to be updated with Karaf 3.0.0 use cases
> - a global polishing, double read



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-3402) Deployed KARs aren't uninstall at start up

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-3402:

Fix Version/s: (was: 4.2.0)
   (was: 4.1.4)
   (was: 4.0.11)

> Deployed KARs aren't uninstall at start up
> --
>
> Key: KARAF-3402
> URL: https://issues.apache.org/jira/browse/KARAF-3402
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
>Affects Versions: 3.0.2
> Environment: ubuntu 14
>Reporter: Karl Leopold
>Assignee: Jean-Baptiste Onofré
>
> Installing KARs via dropping them into the deploy dir is a very useful 
> feature to me. Installing when Karaf is running works. It is also possible to 
> remove a kar from the deploy dir and it will be automatically uninstalled, 
> then. When you deplay a kar and start Karaf afterwards, it will be installed.
> The only case the kar deployment mechanism doesn't work is, when you remove a 
> kar while Karaf is not running and then start Karaf. The Karaf deployer 
> doesn't uninstall it. That's bad for me, because I wan't to install/uninstall 
> kar files independently whether it's on or off. I also think that this 
> behavior is inconsistent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-5198) KAR:Create update feature file based on list of features provided

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-5198:

Fix Version/s: (was: 4.1.4)
   4.1.5

> KAR:Create update feature file based on list of features provided
> -
>
> Key: KARAF-5198
> URL: https://issues.apache.org/jira/browse/KARAF-5198
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.5
>
>
> When you create a KAR file using the kar:create command, you can give it a 
> list of features of the specified repo to include in the KAR file.
> It appears that the feature file that is included in the KAR is copied 
> straight out of the repo and includes all the features regardless of the 
> those specified.
> When the KAR is deployed, it is starting all the features in the feature 
> file. In many cases this is resulting in the starting of numerous other 
> features.
> One good example of this is the cxf-dosgi repo's feature "cxf-dosgi-base" 
> which has a feature defined for libs needed when running outside Karaf (or at 
> least that is what the description says for the feature). It references a 
> bunch of bundles that come with core Karaf and when this feature tries to 
> install, it hangs the KAR deployer and Karaf won't shutdown correctly.
> It would be nice if the feature file either removed those features that were 
> not exported, or mark the feature with install="manual", assuming KARAF-5197 
> adds this capability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5210) Seemingly random NPEs from Aether resolver

2017-12-13 Thread JIRA

[ 
https://issues.apache.org/jira/browse/KARAF-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289324#comment-16289324
 ] 

Jean-Baptiste Onofré commented on KARAF-5210:
-

Any update about this Jira ? Does it still happen with Karaf >= 4.1.3 ?

> Seemingly random NPEs from Aether resolver
> --
>
> Key: KARAF-5210
> URL: https://issues.apache.org/jira/browse/KARAF-5210
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.1.1
> Environment: Windows
>Reporter: Peter Berkman
>Assignee: Guillaume Nodet
> Fix For: 4.2.0, 4.1.5
>
> Attachments: mvnsettings.xml, org.ops4j.pax.url.mvn.cfg
>
>
> We have an installer that automates much of our Karaf and product 
> installation.  
> since the upgrade to Karaf 4.1, I've been getting these about every 5th 
> automated install. could be timing? Happens at random places and sometimes 
> with dependencies that the target doesn't have.
> One thing is that we do turn OFF internet access for maven through settings 
> in the org.ops4j.pax.url.mvn.cfg and provider our out mvnsettings.xml.  I 
> will try and attach them later, but these are the relevant settings:
> {code}
> org.ops4j.pax.url.mvn.settings=${karaf.etc}/mvnsettings.xml
> org.ops4j.pax.url.mvn.localRepository=${karaf.data}/repo
> org.ops4j.pax.url.mvn.useFallbackRepositories=false
> org.ops4j.pax.url.mvn.defaultRepositories=
> org.ops4j.pax.url.mvn.defaultLocalRepoAsRemote=true
> org.ops4j.pax.url.mvn.repositories= \
> 
> file:${karaf.home}/${karaf.default.repository}@id=system.repository@snapshots,\
> file:${karaf.data}/kar@id=kar.repository@multi@snapshots
> {code}
> mvnsettings.xml:
> {code}
> http://maven.apache.org/SETTINGS/1.1.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 
> http://maven.apache.org/xsd/settings-1.1.0.xsd;>
>   data/repo
> 
> {code}
> Here is what the stack looks like - note that the target bundle is almost 
> always different on different failures.
> {code}
> 20170614 11:24:50.512 [INFO ] pipe-feature:install -v -r ngaudit | 
> 10:org.apache.karaf.features.core | 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl | Adding 
> features: ngaudit/[10.0.0.SNAPSHOT,10.0.0.SNAPSHOT]
> 20170614 11:24:50.531 [ERROR] Thread-85 | 69:org.apache.karaf.shell.core | 
> org.apache.karaf.shell.support.ShellUtil | Exception caught while executing 
> command
> org.apache.karaf.features.internal.util.MultiException: Error
> at 
> org.apache.karaf.features.internal.download.impl.MavenDownloadManager$MavenDownloader.(MavenDownloadManager.java:84)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.download.impl.MavenDownloadManager.createDownloader(MavenDownloadManager.java:72)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.Subsystem.downloadBundles(Subsystem.java:375)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.Subsystem.downloadBundles(Subsystem.java:372)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:187)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:285)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1170)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$0(FeaturesServiceImpl.java:1069)[10:org.apache.karaf.features.core:4.1.1]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_92]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_92]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_92]
> at java.lang.Thread.run(Thread.java:745)[:1.8.0_92]
> Caused by: java.io.IOException: Error downloading 
> mvn:org.apache.karaf.jndi/org.apache.karaf.jndi.core/4.1.1
> at 
> org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run(AbstractRetryableDownloadTask.java:81)[10:org.apache.karaf.features.core:4.1.1]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_92]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_92]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)[:1.8.0_92]
> at 
> 

[jira] [Updated] (KARAF-5210) Seemingly random NPEs from Aether resolver

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-5210:

Fix Version/s: (was: 4.1.4)
   4.1.5

> Seemingly random NPEs from Aether resolver
> --
>
> Key: KARAF-5210
> URL: https://issues.apache.org/jira/browse/KARAF-5210
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.1.1
> Environment: Windows
>Reporter: Peter Berkman
>Assignee: Guillaume Nodet
> Fix For: 4.2.0, 4.1.5
>
> Attachments: mvnsettings.xml, org.ops4j.pax.url.mvn.cfg
>
>
> We have an installer that automates much of our Karaf and product 
> installation.  
> since the upgrade to Karaf 4.1, I've been getting these about every 5th 
> automated install. could be timing? Happens at random places and sometimes 
> with dependencies that the target doesn't have.
> One thing is that we do turn OFF internet access for maven through settings 
> in the org.ops4j.pax.url.mvn.cfg and provider our out mvnsettings.xml.  I 
> will try and attach them later, but these are the relevant settings:
> {code}
> org.ops4j.pax.url.mvn.settings=${karaf.etc}/mvnsettings.xml
> org.ops4j.pax.url.mvn.localRepository=${karaf.data}/repo
> org.ops4j.pax.url.mvn.useFallbackRepositories=false
> org.ops4j.pax.url.mvn.defaultRepositories=
> org.ops4j.pax.url.mvn.defaultLocalRepoAsRemote=true
> org.ops4j.pax.url.mvn.repositories= \
> 
> file:${karaf.home}/${karaf.default.repository}@id=system.repository@snapshots,\
> file:${karaf.data}/kar@id=kar.repository@multi@snapshots
> {code}
> mvnsettings.xml:
> {code}
> http://maven.apache.org/SETTINGS/1.1.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 
> http://maven.apache.org/xsd/settings-1.1.0.xsd;>
>   data/repo
> 
> {code}
> Here is what the stack looks like - note that the target bundle is almost 
> always different on different failures.
> {code}
> 20170614 11:24:50.512 [INFO ] pipe-feature:install -v -r ngaudit | 
> 10:org.apache.karaf.features.core | 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl | Adding 
> features: ngaudit/[10.0.0.SNAPSHOT,10.0.0.SNAPSHOT]
> 20170614 11:24:50.531 [ERROR] Thread-85 | 69:org.apache.karaf.shell.core | 
> org.apache.karaf.shell.support.ShellUtil | Exception caught while executing 
> command
> org.apache.karaf.features.internal.util.MultiException: Error
> at 
> org.apache.karaf.features.internal.download.impl.MavenDownloadManager$MavenDownloader.(MavenDownloadManager.java:84)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.download.impl.MavenDownloadManager.createDownloader(MavenDownloadManager.java:72)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.Subsystem.downloadBundles(Subsystem.java:375)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.Subsystem.downloadBundles(Subsystem.java:372)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:187)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:285)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1170)[10:org.apache.karaf.features.core:4.1.1]
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$0(FeaturesServiceImpl.java:1069)[10:org.apache.karaf.features.core:4.1.1]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_92]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_92]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_92]
> at java.lang.Thread.run(Thread.java:745)[:1.8.0_92]
> Caused by: java.io.IOException: Error downloading 
> mvn:org.apache.karaf.jndi/org.apache.karaf.jndi.core/4.1.1
> at 
> org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run(AbstractRetryableDownloadTask.java:81)[10:org.apache.karaf.features.core:4.1.1]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_92]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_92]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)[:1.8.0_92]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)[:1.8.0_92]
> ... 3 more
> Caused by: 

[jira] [Resolved] (KARAF-4738) since karaf-maven-plugin version 3.0.3 and later the goal of install-kars takes too long time

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-4738.
-
Resolution: Won't Fix

We did lot of changes in karaf-maven-plugin 4.x, especially around the 
artifacts resolution (which I think was your issue). I close this Jira, please 
don't hesitate to re-open it if required.

> since karaf-maven-plugin version 3.0.3 and later the goal of  install-kars 
> takes too long time 
> ---
>
> Key: KARAF-4738
> URL: https://issues.apache.org/jira/browse/KARAF-4738
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-tooling
>Affects Versions: 3.0.3
> Environment: Opendaylight karaf
>Reporter: wu sandi
>Assignee: Jean-Baptiste Onofré
>
> In the pom.xml to build opendaylight distribution using karaf-maven-plugin 
> 3.0.3, I add my own features into the bootFeatures element. When I fire the 
> command "mvn clean install", it starts to build. During the "install kars" 
> resolving features, it takes too long time, about 13 minutes,  to Install 
> bundles. It looks like some bundles and features are installed repeatedly. 
> The building doses't fail but success finally. If I rollabck the 
> karaf-maven-plugin version to 3.0.1,  the "install kars"  goal only takes 3 
> minutes or less. Then the question is what is the difference between 3.0.3 
> and 3.0.3 and how to solve this problem?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-1677) Unpacked KAR deployment

2017-12-13 Thread JIRA

[ 
https://issues.apache.org/jira/browse/KARAF-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289318#comment-16289318
 ] 

Jean-Baptiste Onofré commented on KARAF-1677:
-

[~gnt] Actually, FileInstall will consider the extracted folder in the 
{{deploy}} directory as a bundle. As a KAR contains itself jar files (bundles) 
and features, it won't install anything. I think we have to improve the 
KarDeployer to be able to use directory (currently it checks if the kar is a 
file). If the kar is a file, it has to be unzipped, whereas if it's a 
directory, it just copy the content in the kar working directory.

> Unpacked KAR deployment
> ---
>
> Key: KARAF-1677
> URL: https://issues.apache.org/jira/browse/KARAF-1677
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-kar
>Reporter: Lars-Erik Helander
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.4, 4.2.0
>
>
> I am looking for a method, similar to KAR where the 
> "repository//features.xml" are automatically registered, but where the 
> data is not in a KAR file, but in a directory, e.g. unpacking a KAR file to a 
> folder and then somehow point that the content of that folder should be 
> recognised as a repo and the features under the repository folder is 
> automatically registered.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-4537) Karaf Maven Plugin should respect scope when building a feature

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4537:

Fix Version/s: (was: 4.1.4)

> Karaf Maven Plugin should respect scope when building a feature
> ---
>
> Key: KARAF-4537
> URL: https://issues.apache.org/jira/browse/KARAF-4537
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-tooling
>Affects Versions: 4.0.5
>Reporter: Viktor Kozlov
>Assignee: Jean-Baptiste Onofré
>
> I am building a feature without a feature template file. I list my feature 
> content via pom dependencies.
> For example:
> {code:xml}
> 
> 
> org.apache.geronimo.specs
> geronimo-validation_1.1_spec
> compile
> 
> 
> org.apache.geronimo.specs
> geronimo-el_2.2_spec
> compile
> 
> 
> commons-collections
> commons-collections
> compile
> 
> 
> commons-beanutils
> commons-beanutils
> compile
> 
> 
> org.apache.bval
> org.apache.bval.bundle
> compile
> 
> 
> {code}
> The target file is OK except I need to mark somehow whether bundle is 
> dependency or not.
> dependency="true">mvn:org.apache.geronimo.specs/geronimo-validation_1.1_spec
> I think maven runtime scope would be nice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-4310) Installing kar causes karaf restart

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4310:

Fix Version/s: (was: 4.1.4)
   4.1.5

> Installing kar causes karaf restart
> ---
>
> Key: KARAF-4310
> URL: https://issues.apache.org/jira/browse/KARAF-4310
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.0.4
> Environment: OpenSUSE Tumbleweed (4.4.0-2-default) oracle jdk 1.8.0_72
>Reporter: Michal Hlavac
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.0.11, 4.2.0, 4.1.5
>
> Attachments: karaf-3.0.5.log, karaf-4.0.4.log
>
>
> Prerequisites:
> {code}
> feature:repo-add mvn:org.apache.cxf.karaf/apache-cxf/3.1.4/xml/features
> feature:install pax-cdi war cxf eventadmin
> {code}
> In karaf 3.0.5 kar installation works properly (see attached log), but in 
> karaf 4.0.4 it seems instance is restarting and redeploy kar again which 
> cause some error (see attached log).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5204) Create dependant feature KAR files when KAR:Create find external feature dependancy

2017-12-13 Thread JIRA

[ 
https://issues.apache.org/jira/browse/KARAF-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289291#comment-16289291
 ] 

Jean-Baptiste Onofré commented on KARAF-5204:
-

It could work if the provided features repository cleanly provides 
{{}}. Then, we can iterate in the inner defined {{}} 
and create the corresponding kar files.

However, unfortunately, in the case of the Aries RSA, it doesn't define 
{{}} for the SCR feature (which is basically wrong).

> Create dependant feature KAR files when KAR:Create find external feature 
> dependancy
> ---
>
> Key: KARAF-5204
> URL: https://issues.apache.org/jira/browse/KARAF-5204
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.5
>
>
> It would be nice if the KAR:Create command could create additional KAR files 
> to capture all the listed dependencies for the requested feature. Currently 
> you have to manually review the feature that you are exporting to a KAR and 
> look for feature references that are external to the feature. This external 
> feature review then has to be performed recursively on each external feature.
> A good example of this is the aries-rsa repo which references the feature 
> "scr", which is defined in the "standard" repository. After I exported 
> aries-rsa, and tried to start it, it was missing the bundle 
> org.apache.karaf.scr:org.apache.karaf.scr.management. Manually created the 
> "standard" KAR to include the "scr" feature and aries-rsa-core feature then 
> started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-5204) Create dependant feature KAR files when KAR:Create find external feature dependancy

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-5204:

Fix Version/s: (was: 4.1.4)
   4.1.5

> Create dependant feature KAR files when KAR:Create find external feature 
> dependancy
> ---
>
> Key: KARAF-5204
> URL: https://issues.apache.org/jira/browse/KARAF-5204
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.5
>
>
> It would be nice if the KAR:Create command could create additional KAR files 
> to capture all the listed dependencies for the requested feature. Currently 
> you have to manually review the feature that you are exporting to a KAR and 
> look for feature references that are external to the feature. This external 
> feature review then has to be performed recursively on each external feature.
> A good example of this is the aries-rsa repo which references the feature 
> "scr", which is defined in the "standard" repository. After I exported 
> aries-rsa, and tried to start it, it was missing the bundle 
> org.apache.karaf.scr:org.apache.karaf.scr.management. Manually created the 
> "standard" KAR to include the "scr" feature and aries-rsa-core feature then 
> started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5203) KAR:Create missing bundles that are marked conditional

2017-12-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289285#comment-16289285
 ] 

ASF GitHub Bot commented on KARAF-5203:
---

jbonofre opened a new pull request #429: [KARAF-5203] Includes conditional 
bundles and configuration files whe…
URL: https://github.com/apache/karaf/pull/429
 
 
   …n creating a KAR


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> KAR:Create missing bundles that are marked conditional
> --
>
> Key: KARAF-5203
> URL: https://issues.apache.org/jira/browse/KARAF-5203
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-kar
> Environment: N/A
>Reporter: George McCone
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.4, 4.2.0
>
>
> When creating a KAR file using the KAR:CREATE commands for a feature contains 
> a  bundle in the feature file, the bundle is not being included 
> in the resulting KAR.
> I found this while creating a KAR for aries-rsa using the following command.
> >kar:create aries-rsa-1.9.0 aries-rsa-discovery-zookeeper
> When trying to start the KAR, I received errors stating that it could not 
> find the mvn:org.apache.aries.rsa/org.apache.aries.rsa.eapub/1.9.0 from the 
> repository. Checking the KAR, this bundle was not present. I manually updated 
> the KAR and the feature started successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-4738) since karaf-maven-plugin version 3.0.3 and later the goal of install-kars takes too long time

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4738:

Fix Version/s: (was: 4.2.0)
   (was: 4.1.4)
   (was: 4.0.11)
   (was: 3.0.9)

> since karaf-maven-plugin version 3.0.3 and later the goal of  install-kars 
> takes too long time 
> ---
>
> Key: KARAF-4738
> URL: https://issues.apache.org/jira/browse/KARAF-4738
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-tooling
>Affects Versions: 3.0.3
> Environment: Opendaylight karaf
>Reporter: wu sandi
>Assignee: Jean-Baptiste Onofré
>
> In the pom.xml to build opendaylight distribution using karaf-maven-plugin 
> 3.0.3, I add my own features into the bootFeatures element. When I fire the 
> command "mvn clean install", it starts to build. During the "install kars" 
> resolving features, it takes too long time, about 13 minutes,  to Install 
> bundles. It looks like some bundles and features are installed repeatedly. 
> The building doses't fail but success finally. If I rollabck the 
> karaf-maven-plugin version to 3.0.1,  the "install kars"  goal only takes 3 
> minutes or less. Then the question is what is the difference between 3.0.3 
> and 3.0.3 and how to solve this problem?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KARAF-4537) Karaf Maven Plugin should respect scope when building a feature

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-4537.
-
Resolution: Won't Fix

As we did lot of changes in the karaf-maven-plugin, I'm closing this Jira and I 
think it's not the case anymore. Please, don't hesitate to re-open it if 
required.

> Karaf Maven Plugin should respect scope when building a feature
> ---
>
> Key: KARAF-4537
> URL: https://issues.apache.org/jira/browse/KARAF-4537
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-tooling
>Affects Versions: 4.0.5
>Reporter: Viktor Kozlov
>Assignee: Jean-Baptiste Onofré
>
> I am building a feature without a feature template file. I list my feature 
> content via pom dependencies.
> For example:
> {code:xml}
> 
> 
> org.apache.geronimo.specs
> geronimo-validation_1.1_spec
> compile
> 
> 
> org.apache.geronimo.specs
> geronimo-el_2.2_spec
> compile
> 
> 
> commons-collections
> commons-collections
> compile
> 
> 
> commons-beanutils
> commons-beanutils
> compile
> 
> 
> org.apache.bval
> org.apache.bval.bundle
> compile
> 
> 
> {code}
> The target file is OK except I need to mark somehow whether bundle is 
> dependency or not.
> dependency="true">mvn:org.apache.geronimo.specs/geronimo-validation_1.1_spec
> I think maven runtime scope would be nice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-4310) Installing kar causes karaf restart

2017-12-13 Thread JIRA

[ 
https://issues.apache.org/jira/browse/KARAF-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289292#comment-16289292
 ] 

Jean-Baptiste Onofré commented on KARAF-4310:
-

Any update on this one ? As asked by Guillaume, it would be great to have the 
kar file in order to investigate.

> Installing kar causes karaf restart
> ---
>
> Key: KARAF-4310
> URL: https://issues.apache.org/jira/browse/KARAF-4310
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.0.4
> Environment: OpenSUSE Tumbleweed (4.4.0-2-default) oracle jdk 1.8.0_72
>Reporter: Michal Hlavac
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.0.11, 4.2.0, 4.1.5
>
> Attachments: karaf-3.0.5.log, karaf-4.0.4.log
>
>
> Prerequisites:
> {code}
> feature:repo-add mvn:org.apache.cxf.karaf/apache-cxf/3.1.4/xml/features
> feature:install pax-cdi war cxf eventadmin
> {code}
> In karaf 3.0.5 kar installation works properly (see attached log), but in 
> karaf 4.0.4 it seems instance is restarting and redeploy kar again which 
> cause some error (see attached log).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-5384) Optional dependencies in MINA SSHD Core cause system bundle refreshes

2017-12-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-5384:

Fix Version/s: (was: 4.1.4)
   4.1.5

> Optional dependencies in MINA SSHD Core cause system bundle refreshes
> -
>
> Key: KARAF-5384
> URL: https://issues.apache.org/jira/browse/KARAF-5384
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.1.0, 4.1.1, 4.1.2
> Environment: Fedora Linux
>Reporter: Seth Leger
>Assignee: Jean-Baptiste Onofré
>Priority: Critical
> Fix For: 4.1.5
>
>
> In similar fashion to KARAF-5251, if you install any feature in Karaf that 
> includes:
> - Apache MINA
> - bouncycastle
> - net.i2p.crypto
> it will cause the MINA SSHD Core bundle to refresh, which in turn refreshes 
> most of the core framework bundles. This has a variety of bad effects 
> including:
> - Terminating the current SSH session
> - Terminating subsequent feature installations
> This is more severe than KARAF-5251 because these libraries are not part of 
> the core Karaf distro so it is not possible to add them to 
> {{startup.properties}} without first repackaging Karaf to contain the desired 
> bundles in the {{/system}} directory.
> This also makes testing any Karaf feature that contains MINA, bouncycastle, 
> or net.i2p.crypto impossible in Pax Exam (unless you use 
> org.apache.karaf.features.FeaturesService.Option.NoAutoRefreshBundles or 
> feature:install -r) because the refresh invalidates @Inject references in 
> your test as the core bundles are refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5485) Be able to disable the sftp server

2017-12-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289238#comment-16289238
 ] 

ASF GitHub Bot commented on KARAF-5485:
---

jbonofre opened a new pull request #428: [KARAF-5485] Add the sftpEnabled 
property in org.apache.karaf.shell c…
URL: https://github.com/apache/karaf/pull/428
 
 
   …onfiguration to control the SSH SFTP system startup


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Be able to disable the sftp server
> --
>
> Key: KARAF-5485
> URL: https://issues.apache.org/jira/browse/KARAF-5485
> Project: Karaf
>  Issue Type: New Feature
>  Components: karaf-shell
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.1.4, 4.2.0
>
>
> Thanks to sshd, Karaf also provides a sftp server. For security reason, it 
> would be great to be able to disable the sftp server (via 
> {{etc/org.apache.karaf.shell.cfg}} for instance).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)