[jira] [Resolved] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved KARAF-5604. - Resolution: Fixed > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359310#comment-16359310 ] ASF subversion and git services commented on KARAF-5604: Commit 89de305e4747abc1cbf1d4805ae0da92a22bd315 in karaf's branch refs/heads/karaf-4.1.x from [~nite] [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=89de305 ] [KARAF-5604] Speed up descriptor generation (#446) * KARAF-5604: Check log.isDebugEnabled() before string concat & cache aether Artifacts > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359309#comment-16359309 ] ASF subversion and git services commented on KARAF-5604: Commit 89de305e4747abc1cbf1d4805ae0da92a22bd315 in karaf's branch refs/heads/karaf-4.1.x from [~nite] [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=89de305 ] [KARAF-5604] Speed up descriptor generation (#446) * KARAF-5604: Check log.isDebugEnabled() before string concat & cache aether Artifacts > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359298#comment-16359298 ] ASF subversion and git services commented on KARAF-5604: Commit cbc97ec20499a5d08f419cdd91c775dd219b4fe1 in karaf's branch refs/heads/master from [~nite] [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=cbc97ec ] [KARAF-5604] Speed up descriptor generation (#446) * KARAF-5604: Check log.isDebugEnabled() before string concat & cache aether Artifacts > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359297#comment-16359297 ] ASF GitHub Bot commented on KARAF-5604: --- jbonofre closed pull request #446: [KARAF-5604] Speed up descriptor generation URL: https://github.com/apache/karaf/pull/446 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java index f38c2be9be..b644540d93 100644 --- a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java +++ b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java @@ -471,7 +471,7 @@ private void writeFeatures(PrintStream out) throws ArtifactResolutionException, // TODO Initialise the repositories from the existing feature file if any MapotherFeatures = new HashMap<>(); Map featureRepositories = new HashMap<>(); -FeaturesCache cache = new FeaturesCache(featuresCacheSize); +FeaturesCache cache = new FeaturesCache(featuresCacheSize, artifactCacheSize); for (final LocalDependency entry : localDependencies) { Object artifact = entry.getArtifact(); @@ -585,10 +585,10 @@ private void processFeatureArtifact(Features features, Feature feature, Map cache; +// Maven-to-Aether Artifact cache, as parsing strings is expensive +private final SimpleLRUCache artifactCache; +private final SimpleLRUCache featuresCache; -FeaturesCache(int featuresCacheSize) { -cache = new SimpleLRUCache<>(featuresCacheSize); +FeaturesCache(int featuresCacheSize, int artifactCacheSize) { +featuresCache = new SimpleLRUCache<>(featuresCacheSize); +artifactCache = new SimpleLRUCache<>(artifactCacheSize); } -Features get(final File featuresFile) throws XMLStreamException, JAXBException, IOException { -final Features existing = cache.get(featuresFile); +DefaultArtifact getArtifact(String mavenName) { +return artifactCache.computeIfAbsent(mavenName, MavenUtil::mvnToArtifact); +} + +Features getFeature(final File featuresFile) throws XMLStreamException, JAXBException, IOException { +final Features existing = featuresCache.get(featuresFile); if (existing != null) { return existing; } final Features computed = readFeaturesFile(featuresFile); -cache.put(featuresFile, computed); +featuresCache.put(featuresFile, computed); return computed; } } diff --git a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/utils/Dependency31Helper.java b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/utils/Dependency31Helper.java index 3c139008ff..29c25d0732 100644 --- a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/utils/Dependency31Helper.java +++ b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/utils/Dependency31Helper.java @@ -328,7 +328,9 @@ private ArtifactResult resolveArtifact(Artifact artifact) throws ArtifactResolut @Override public File resolve(Object artifact, Log log) { -log.debug("Resolving artifact " + artifact + " from " + projectRepositories); +if (log.isDebugEnabled()) { +log.debug("Resolving artifact " + artifact + " from " + projectRepositories); +} ArtifactResult result; try { @@ -338,7 +340,10 @@ public File resolve(Object artifact, Log log) { return null; } -log.debug("Resolved artifact " + artifact + " to " + result.getArtifact().getFile() + " from " + result.getRepository()); +if (log.isDebugEnabled()) { +log.debug("Resolved artifact " + artifact + " to " + result.getArtifact().getFile() + " from " ++ result.getRepository()); +} return result.getArtifact().getFile(); } @@ -355,17 +360,22 @@ public File resolveById(String id, Log log) throws MojoFailureException { } id = MavenUtil.mvnToAether(id); -log.debug("Resolving artifact " + id + " from " + projectRepositories); +if (log.isDebugEnabled()) { +log.debug("Resolving artifact " + id + " from " + projectRepositories); +}
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359299#comment-16359299 ] ASF subversion and git services commented on KARAF-5604: Commit cbc97ec20499a5d08f419cdd91c775dd219b4fe1 in karaf's branch refs/heads/master from [~nite] [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=cbc97ec ] [KARAF-5604] Speed up descriptor generation (#446) * KARAF-5604: Check log.isDebugEnabled() before string concat & cache aether Artifacts > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5198) KAR:Create update feature file based on list of features provided
[ https://issues.apache.org/jira/browse/KARAF-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359295#comment-16359295 ] Jean-Baptiste Onofré commented on KARAF-5198: - That's good idea, the {{kar:create}} command could use a releases set optionally to define the feature started automatically (using the {{install}} flag). > KAR:Create update feature file based on list of features provided > - > > Key: KARAF-5198 > URL: https://issues.apache.org/jira/browse/KARAF-5198 > Project: Karaf > Issue Type: Improvement > Components: karaf-kar > Environment: N/A >Reporter: George McCone >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: 4.2.0, 4.1.6 > > > When you create a KAR file using the kar:create command, you can give it a > list of features of the specified repo to include in the KAR file. > It appears that the feature file that is included in the KAR is copied > straight out of the repo and includes all the features regardless of the > those specified. > When the KAR is deployed, it is starting all the features in the feature > file. In many cases this is resulting in the starting of numerous other > features. > One good example of this is the cxf-dosgi repo's feature "cxf-dosgi-base" > which has a feature defined for libs needed when running outside Karaf (or at > least that is what the description says for the feature). It references a > bunch of bundles that come with core Karaf and when this feature tries to > install, it hangs the KAR deployer and Karaf won't shutdown correctly. > It would be nice if the feature file either removed those features that were > not exported, or mark the feature with install="manual", assuming KARAF-5197 > adds this capability. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-5198) KAR:Create update feature file based on list of features provided
[ https://issues.apache.org/jira/browse/KARAF-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-5198: Fix Version/s: (was: 4.1.5) 4.1.6 > KAR:Create update feature file based on list of features provided > - > > Key: KARAF-5198 > URL: https://issues.apache.org/jira/browse/KARAF-5198 > Project: Karaf > Issue Type: Improvement > Components: karaf-kar > Environment: N/A >Reporter: George McCone >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: 4.2.0, 4.1.6 > > > When you create a KAR file using the kar:create command, you can give it a > list of features of the specified repo to include in the KAR file. > It appears that the feature file that is included in the KAR is copied > straight out of the repo and includes all the features regardless of the > those specified. > When the KAR is deployed, it is starting all the features in the feature > file. In many cases this is resulting in the starting of numerous other > features. > One good example of this is the cxf-dosgi repo's feature "cxf-dosgi-base" > which has a feature defined for libs needed when running outside Karaf (or at > least that is what the description says for the feature). It references a > bunch of bundles that come with core Karaf and when this feature tries to > install, it hangs the KAR deployer and Karaf won't shutdown correctly. > It would be nice if the feature file either removed those features that were > not exported, or mark the feature with install="manual", assuming KARAF-5197 > adds this capability. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-2511) Review and update documentation
[ https://issues.apache.org/jira/browse/KARAF-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-2511: Fix Version/s: (was: 4.1.5) 4.1.6 > Review and update documentation > --- > > Key: KARAF-2511 > URL: https://issues.apache.org/jira/browse/KARAF-2511 > Project: Karaf > Issue Type: Task > Components: karaf-documentation >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.6 > > > The documentation (manual) should be reviewed: > - The subshell part should be described (usage and configuration). > - The "code samples"/screenshots have to be updated with Karaf 3.0.0 use cases > - a global polishing, double read -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KARAF-4310) Installing kar causes karaf restart
[ https://issues.apache.org/jira/browse/KARAF-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved KARAF-4310. - Resolution: Cannot Reproduce Fix Version/s: (was: 4.1.5) (was: 4.2.0) (was: 4.0.11) We didn't get update recently on this one. Please reopen with kar and/or details. > Installing kar causes karaf restart > --- > > Key: KARAF-4310 > URL: https://issues.apache.org/jira/browse/KARAF-4310 > Project: Karaf > Issue Type: Bug > Components: karaf-core >Affects Versions: 4.0.4 > Environment: OpenSUSE Tumbleweed (4.4.0-2-default) oracle jdk 1.8.0_72 >Reporter: Michal Hlavac >Assignee: Jean-Baptiste Onofré >Priority: Major > Attachments: karaf-3.0.5.log, karaf-4.0.4.log > > > Prerequisites: > {code} > feature:repo-add mvn:org.apache.cxf.karaf/apache-cxf/3.1.4/xml/features > feature:install pax-cdi war cxf eventadmin > {code} > In karaf 3.0.5 kar installation works properly (see attached log), but in > karaf 4.0.4 it seems instance is restarting and redeploy kar again which > cause some error (see attached log). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-3202) Not able to login via client
[ https://issues.apache.org/jira/browse/KARAF-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-3202: Fix Version/s: (was: 4.1.5) 4.1.6 > Not able to login via client > > > Key: KARAF-3202 > URL: https://issues.apache.org/jira/browse/KARAF-3202 > Project: Karaf > Issue Type: Question > Components: karaf-shell > Environment: Dev >Reporter: Srini >Assignee: Jean-Baptiste Onofré >Priority: Critical > Fix For: 4.0.11, 4.2.0, 4.1.5 > > > I'm trying to login via client script from karaf but not able to login. No > idea why this is happening. I need support. > /opt/app/t1c1m1022/sites/OSGI/CE10/apache-servicemix-4.5.3/bin> ./client -v > 50 [main] INFO org.apache.sshd.common.util.SecurityUtils - BouncyCastle not > registered, using the default JCE provider > org.apache.sshd.common.RuntimeSshException: Failed to get the session. > at > org.apache.sshd.client.future.DefaultConnectFuture.getSession(DefaultConnectFuture.java:43) > at org.apache.karaf.client.Main.main(Main.java:106) > Caused by: java.net.ConnectException: Connection refused > at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) > at > sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567) > at > org.apache.mina.transport.socket.nio.NioSocketConnector.finishConnect(NioSocketConnector.java:224) > at > org.apache.mina.transport.socket.nio.NioSocketConnector.finishConnect(NioSocketConnector.java:46) > at > org.apache.mina.core.polling.AbstractPollingIoConnector.processConnections(AbstractPollingIoConnector.java:439) > at > org.apache.mina.core.polling.AbstractPollingIoConnector.access$700(AbstractPollingIoConnector.java:64) > at > org.apache.mina.core.polling.AbstractPollingIoConnector$Connector.run(AbstractPollingIoConnector.java:508) > at > org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) > at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) > at java.lang.Thread.run(Thread.java:662) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-3202) Not able to login via client
[ https://issues.apache.org/jira/browse/KARAF-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359293#comment-16359293 ] Jean-Baptiste Onofré commented on KARAF-3202: - I gonna test with the wrapper. > Not able to login via client > > > Key: KARAF-3202 > URL: https://issues.apache.org/jira/browse/KARAF-3202 > Project: Karaf > Issue Type: Question > Components: karaf-shell > Environment: Dev >Reporter: Srini >Assignee: Jean-Baptiste Onofré >Priority: Critical > Fix For: 4.0.11, 4.2.0, 4.1.5 > > > I'm trying to login via client script from karaf but not able to login. No > idea why this is happening. I need support. > /opt/app/t1c1m1022/sites/OSGI/CE10/apache-servicemix-4.5.3/bin> ./client -v > 50 [main] INFO org.apache.sshd.common.util.SecurityUtils - BouncyCastle not > registered, using the default JCE provider > org.apache.sshd.common.RuntimeSshException: Failed to get the session. > at > org.apache.sshd.client.future.DefaultConnectFuture.getSession(DefaultConnectFuture.java:43) > at org.apache.karaf.client.Main.main(Main.java:106) > Caused by: java.net.ConnectException: Connection refused > at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) > at > sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567) > at > org.apache.mina.transport.socket.nio.NioSocketConnector.finishConnect(NioSocketConnector.java:224) > at > org.apache.mina.transport.socket.nio.NioSocketConnector.finishConnect(NioSocketConnector.java:46) > at > org.apache.mina.core.polling.AbstractPollingIoConnector.processConnections(AbstractPollingIoConnector.java:439) > at > org.apache.mina.core.polling.AbstractPollingIoConnector.access$700(AbstractPollingIoConnector.java:64) > at > org.apache.mina.core.polling.AbstractPollingIoConnector$Connector.run(AbstractPollingIoConnector.java:508) > at > org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) > at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) > at java.lang.Thread.run(Thread.java:662) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-3202) Not able to login via client
[ https://issues.apache.org/jira/browse/KARAF-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-3202: Fix Version/s: (was: 4.1.6) 4.1.5 > Not able to login via client > > > Key: KARAF-3202 > URL: https://issues.apache.org/jira/browse/KARAF-3202 > Project: Karaf > Issue Type: Question > Components: karaf-shell > Environment: Dev >Reporter: Srini >Assignee: Jean-Baptiste Onofré >Priority: Critical > Fix For: 4.0.11, 4.2.0, 4.1.5 > > > I'm trying to login via client script from karaf but not able to login. No > idea why this is happening. I need support. > /opt/app/t1c1m1022/sites/OSGI/CE10/apache-servicemix-4.5.3/bin> ./client -v > 50 [main] INFO org.apache.sshd.common.util.SecurityUtils - BouncyCastle not > registered, using the default JCE provider > org.apache.sshd.common.RuntimeSshException: Failed to get the session. > at > org.apache.sshd.client.future.DefaultConnectFuture.getSession(DefaultConnectFuture.java:43) > at org.apache.karaf.client.Main.main(Main.java:106) > Caused by: java.net.ConnectException: Connection refused > at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) > at > sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567) > at > org.apache.mina.transport.socket.nio.NioSocketConnector.finishConnect(NioSocketConnector.java:224) > at > org.apache.mina.transport.socket.nio.NioSocketConnector.finishConnect(NioSocketConnector.java:46) > at > org.apache.mina.core.polling.AbstractPollingIoConnector.processConnections(AbstractPollingIoConnector.java:439) > at > org.apache.mina.core.polling.AbstractPollingIoConnector.access$700(AbstractPollingIoConnector.java:64) > at > org.apache.mina.core.polling.AbstractPollingIoConnector$Connector.run(AbstractPollingIoConnector.java:508) > at > org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) > at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) > at java.lang.Thread.run(Thread.java:662) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5592) Karaf shell unexpected exit when Ctrl + C during log:display or select text then press Enter
[ https://issues.apache.org/jira/browse/KARAF-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359291#comment-16359291 ] Jean-Baptiste Onofré commented on KARAF-5592: - I'm able to reproduce the first issue with 4.1.5-SNAPSHOT (on Linux). I'm testing on master; > Karaf shell unexpected exit when Ctrl + C during log:display or select text > then press Enter > > > Key: KARAF-5592 > URL: https://issues.apache.org/jira/browse/KARAF-5592 > Project: Karaf > Issue Type: Bug > Components: karaf-shell >Affects Versions: 4.1.4 > Environment: Java 1.8.0_121 > Windows 7 64bit >Reporter: Xilai Dai >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Start Karaf 4.1.4 on Windows (bin/karaf.bat) > 1) execute log:display from the shell console > 2) during the display (not finished), press Ctrl + C to interrupt, then the > shell will exit unexpected > {code:java} > 2018-02-02T11:04:04,039 | ERROR | Karaf local console user karaf | > he.karaf.shell.support.ShellUtil 149 | 111 - org.apache.karaf.shell.core - > 4.1.4 | Exception caught while executing command > com.sun.jna.LastErrorException: [6] The handle is invalid. > at com.sun.jna.Native.invokeVoid(Native Method) ~[?:?] > at com.sun.jna.Function.invoke(Function.java:408) [?:?] > at com.sun.jna.Function.invoke(Function.java:354) [?:?] > at com.sun.jna.Library$Handler.invoke(Library.java:244) [?:?] > at > org.jline.terminal.impl.jna.win.$Proxy28.GetConsoleScreenBufferInfo(Unknown > Source) [183:org.jline:3.4.0] > at > org.jline.terminal.impl.jna.win.JnaWinSysTerminal.getSize(JnaWinSysTerminal.java:72) > [183:org.jline:3.4.0] > at > org.apache.karaf.shell.impl.console.JLineTerminal.getSize(JLineTerminal.java:173) > [111:org.apache.karaf.shell.core:4.1.4] > at > org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:481) > [183:org.jline:3.4.0] > at > org.apache.karaf.shell.impl.console.ConsoleSessionImpl.run(ConsoleSessionImpl.java:348) > [111:org.apache.karaf.shell.core:4.1.4] > at java.lang.Thread.run(Thread.java:748) [?:?]{code} > > Or: > 1) Select some text in the shell console, then press "Enter" try to > copy/paste it > 2) then the shell console will exit unexpected. > > I did some tests locally, the second problem (copy/paste) can be solved after > upgrade jline from 3.4.0 to 3.5.2(or 3.5.0 also OK). but the first problem > still existing after jline upgrade. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5592) Karaf shell unexpected exit when Ctrl + C during log:display or select text then press Enter
[ https://issues.apache.org/jira/browse/KARAF-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359279#comment-16359279 ] Jean-Baptiste Onofré commented on KARAF-5592: - We upgraded to jline 3.6.0 recently. The second issue should be fixed now. I'm testing the first one (CTRL-C in {{log:display}}). To avoid to hold the release for too long, I might postpone the fix to 4.1.6. > Karaf shell unexpected exit when Ctrl + C during log:display or select text > then press Enter > > > Key: KARAF-5592 > URL: https://issues.apache.org/jira/browse/KARAF-5592 > Project: Karaf > Issue Type: Bug > Components: karaf-shell >Affects Versions: 4.1.4 > Environment: Java 1.8.0_121 > Windows 7 64bit >Reporter: Xilai Dai >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Start Karaf 4.1.4 on Windows (bin/karaf.bat) > 1) execute log:display from the shell console > 2) during the display (not finished), press Ctrl + C to interrupt, then the > shell will exit unexpected > {code:java} > 2018-02-02T11:04:04,039 | ERROR | Karaf local console user karaf | > he.karaf.shell.support.ShellUtil 149 | 111 - org.apache.karaf.shell.core - > 4.1.4 | Exception caught while executing command > com.sun.jna.LastErrorException: [6] The handle is invalid. > at com.sun.jna.Native.invokeVoid(Native Method) ~[?:?] > at com.sun.jna.Function.invoke(Function.java:408) [?:?] > at com.sun.jna.Function.invoke(Function.java:354) [?:?] > at com.sun.jna.Library$Handler.invoke(Library.java:244) [?:?] > at > org.jline.terminal.impl.jna.win.$Proxy28.GetConsoleScreenBufferInfo(Unknown > Source) [183:org.jline:3.4.0] > at > org.jline.terminal.impl.jna.win.JnaWinSysTerminal.getSize(JnaWinSysTerminal.java:72) > [183:org.jline:3.4.0] > at > org.apache.karaf.shell.impl.console.JLineTerminal.getSize(JLineTerminal.java:173) > [111:org.apache.karaf.shell.core:4.1.4] > at > org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:481) > [183:org.jline:3.4.0] > at > org.apache.karaf.shell.impl.console.ConsoleSessionImpl.run(ConsoleSessionImpl.java:348) > [111:org.apache.karaf.shell.core:4.1.4] > at java.lang.Thread.run(Thread.java:748) [?:?]{code} > > Or: > 1) Select some text in the shell console, then press "Enter" try to > copy/paste it > 2) then the shell console will exit unexpected. > > I did some tests locally, the second problem (copy/paste) can be solved after > upgrade jline from 3.4.0 to 3.5.2(or 3.5.0 also OK). but the first problem > still existing after jline upgrade. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5559) log:tail kills ssh & karaf when root logger is in DEBUG
[ https://issues.apache.org/jira/browse/KARAF-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359277#comment-16359277 ] ASF GitHub Bot commented on KARAF-5559: --- jbonofre opened a new pull request #448: [KARAF-5559] Change the sshd log level in log:tail & log:display commands to avoid infinite loop using ssh URL: https://github.com/apache/karaf/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > log:tail kills ssh & karaf when root logger is in DEBUG > --- > > Key: KARAF-5559 > URL: https://issues.apache.org/jira/browse/KARAF-5559 > Project: Karaf > Issue Type: Bug > Components: karaf-logging, karaf-shell >Affects Versions: 4.1.4, 4.2.0.M2 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (KARAF-5559) log:tail kills ssh & karaf when root logger is in DEBUG
[ https://issues.apache.org/jira/browse/KARAF-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KARAF-5559 started by Jean-Baptiste Onofré. --- > log:tail kills ssh & karaf when root logger is in DEBUG > --- > > Key: KARAF-5559 > URL: https://issues.apache.org/jira/browse/KARAF-5559 > Project: Karaf > Issue Type: Bug > Components: karaf-logging, karaf-shell >Affects Versions: 4.1.4, 4.2.0.M2 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358484#comment-16358484 ] ASF GitHub Bot commented on KARAF-5604: --- rovarga opened a new pull request #446: KARAF-5604: Speed up descriptor generation URL: https://github.com/apache/karaf/pull/446 Profiling has turned out two more inefficiencies: - calling log.debug() with a concatenated string -- we end up wasting time constructing the string, which is never logged - aether's DefaultArtifact(String) is extremely slow due to Pattern.compile() it contains This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358382#comment-16358382 ] Jean-Baptiste Onofré commented on KARAF-5604: - Waiting your PRs to do the review ;) > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (KARAF-5604) karaf:features-generate-descriptor takes long when faced with complex feature dependencies
[ https://issues.apache.org/jira/browse/KARAF-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Varga reopened KARAF-5604: - Actually, based on profiling I think we can do a lot better with just two more patches. > karaf:features-generate-descriptor takes long when faced with complex feature > dependencies > -- > > Key: KARAF-5604 > URL: https://issues.apache.org/jira/browse/KARAF-5604 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.1.3 >Reporter: Robert Varga >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Opendaylight's distribution-check jobs generate features which have complex > feature dependencies, which exposes scaling issues in > karaf:features-generate-descriptor. > [https://github.com/opendaylight/integration-distribution/tree/master/features/singles/odl-integration-all] > takes ~270 seconds to generate: > real 4m28.834s > user 3m40.287s > sys 1m23.629s > [https://github.com/opendaylight/integration-distribution/tree/master/features/repos/index] > takes ~638 seconds to generate: > real 10m38.859s > user 7m55.004s > sys 3m17.269s > Running profiling shows that this time is dominated by short-lived > FileInputStreams being generated at a rate of 7K-8Kps – which are coming from > both feature reading and from artifact resolution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5559) log:tail kills ssh & karaf when root logger is in DEBUG
[ https://issues.apache.org/jira/browse/KARAF-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358370#comment-16358370 ] Jean-Baptiste Onofré commented on KARAF-5559: - Actually, it's a normal behavior as SSHD shows the commands in DEBUG, and as we are connected using SSH, we are in an infinite loop. To avoid this, the sshd logger itself should not be in DEBUG. A possible improvement is to set sshd logger to WARN in {{log:display}} and {{log:tail}} commands to avoid this behavior. > log:tail kills ssh & karaf when root logger is in DEBUG > --- > > Key: KARAF-5559 > URL: https://issues.apache.org/jira/browse/KARAF-5559 > Project: Karaf > Issue Type: Bug > Components: karaf-logging, karaf-shell >Affects Versions: 4.1.4, 4.2.0.M2 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KARAF-5318) log:tail sometimes hangs and freezes terminal
[ https://issues.apache.org/jira/browse/KARAF-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned KARAF-5318: --- Assignee: Jean-Baptiste Onofré > log:tail sometimes hangs and freezes terminal > - > > Key: KARAF-5318 > URL: https://issues.apache.org/jira/browse/KARAF-5318 > Project: Karaf > Issue Type: Bug >Affects Versions: 4.1.2 >Reporter: Cetra Free >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Sometimes when using log:tail the terminal freezes completely, and you can't > ctrl + c out of it. > I'm not sure what the cause is, I normally have a lot of debug messages going. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-5318) log:tail sometimes hangs and freezes terminal
[ https://issues.apache.org/jira/browse/KARAF-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-5318: Fix Version/s: 4.1.5 4.2.0 > log:tail sometimes hangs and freezes terminal > - > > Key: KARAF-5318 > URL: https://issues.apache.org/jira/browse/KARAF-5318 > Project: Karaf > Issue Type: Bug >Affects Versions: 4.1.2 >Reporter: Cetra Free >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.5 > > > Sometimes when using log:tail the terminal freezes completely, and you can't > ctrl + c out of it. > I'm not sure what the cause is, I normally have a lot of debug messages going. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (KARAF-5603) karaf config:update says "Command not found"
[ https://issues.apache.org/jira/browse/KARAF-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harish Jamb reopened KARAF-5603: Hope the below details gives the required information. I am not sure if it is customized or vanialla. But its been there since some years now created for an application and have taken over it recently for maintenance. Logging in as karaf 1177 [pool-2-thread-2] WARN org.apache.sshd.client.keyverifier.AcceptAllServerKeyVerifier - Server at /0.0.0.0:8101 presented unverified key: __ __ / //_/ __ _/ __/ / ,< / __ `/ ___/ __ `/ /_ / /| |/ /_/ / / / /_/ / __/ /_/ |_|\__,_/_/ \__,_/_/ Apache Karaf (3.0.0) Hit '' for a list of available commands and '[cmd] --help' for help on a specific command. Hit 'system:shutdown' to shutdown Karaf. Hit '' or type 'logout' to disconnect shell from current session. karaf@root()> config: config:delete config:edit config:list config:property-append config:property-delete config:property-list config:property-set karaf@root()> logout :~$ java -version java version "1.7.0_51" OpenJDK Runtime Environment (IcedTea 2.4.4) (7u51-2.4.4-0ubuntu0.12.04.2) OpenJDK 64-Bit Server VM (build 24.45-b08, mixed mode) :~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 12.04.4 LTS Release: 12.04 Codename: precise > karaf config:update says "Command not found" > > > Key: KARAF-5603 > URL: https://issues.apache.org/jira/browse/KARAF-5603 > Project: Karaf > Issue Type: Bug > Components: karaf-config >Affects Versions: 3.0.0 >Reporter: Harish Jamb >Assignee: Jean-Baptiste Onofré >Priority: Major > Attachments: karaf-update-config-not-found.GIF > > > I have done some edits using config:edit in a pid and config:property-set > commands > after this when I am executing config:update, karaf says that the command is > not found. > even in the display all commands, it doesnt show-up in the list > also checked for the alternative or new commands but no luck! > karaf version is: 3.0.0 > Can anybody help here? to resolve this issue or suggest alternative command > if this command is removed and not used any more? thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-5204) Create dependant feature KAR files when KAR:Create find external feature dependancy
[ https://issues.apache.org/jira/browse/KARAF-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-5204: Fix Version/s: (was: 4.1.5) 4.1.6 > Create dependant feature KAR files when KAR:Create find external feature > dependancy > --- > > Key: KARAF-5204 > URL: https://issues.apache.org/jira/browse/KARAF-5204 > Project: Karaf > Issue Type: Improvement > Components: karaf-kar > Environment: N/A >Reporter: George McCone >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: 4.2.0, 4.1.6 > > > It would be nice if the KAR:Create command could create additional KAR files > to capture all the listed dependencies for the requested feature. Currently > you have to manually review the feature that you are exporting to a KAR and > look for feature references that are external to the feature. This external > feature review then has to be performed recursively on each external feature. > A good example of this is the aries-rsa repo which references the feature > "scr", which is defined in the "standard" repository. After I exported > aries-rsa, and tried to start it, it was missing the bundle > org.apache.karaf.scr:org.apache.karaf.scr.management. Manually created the > "standard" KAR to include the "scr" feature and aries-rsa-core feature then > started successfully. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KARAF-4336) Add support for ordering of CLI scripts and commands in karaf-maven-plugin
[ https://issues.apache.org/jira/browse/KARAF-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-4336: Fix Version/s: (was: 4.1.5) 4.1.6 > Add support for ordering of CLI scripts and commands in karaf-maven-plugin > -- > > Key: KARAF-4336 > URL: https://issues.apache.org/jira/browse/KARAF-4336 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling >Affects Versions: 4.0.4 >Reporter: Martin Basovník >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.2.0, 4.1.6 > > > {code:xml} > > > setup1.cli > setup2.cli > > > feature:repo-add camel ${version.camel} > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KARAF-5597) Upgrade to Spring 4.3.14.RELEASE
[ https://issues.apache.org/jira/browse/KARAF-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved KARAF-5597. - Resolution: Fixed > Upgrade to Spring 4.3.14.RELEASE > > > Key: KARAF-5597 > URL: https://issues.apache.org/jira/browse/KARAF-5597 > Project: Karaf > Issue Type: Dependency upgrade > Components: karaf-core >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.0.11, 4.2.0, 4.1.5 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)