[jira] [Commented] (KARAF-5641) Karaf boot scripts need to deal with JDK10 version patterns

2018-05-01 Thread Sanne Grinovero (JIRA) 

[ 
https://issues.apache.org/jira/browse/KARAF-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459595#comment-16459595
 ] 

Sanne Grinovero commented on KARAF-5641:


Thanks a lot! Seems to work fine on JDK10, now just need a working pax-exam too 
to be able to use it.

In the meantime I'm testing JDK11 now, added some comments on KARAF-5725 as 
it's related to this one: the version detection pattern needs another little 
tweak.

Thanks

> Karaf boot scripts need to deal with JDK10 version patterns
> ---
>
> Key: KARAF-5641
> URL: https://issues.apache.org/jira/browse/KARAF-5641
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.2.0.M2
>Reporter: Sanne Grinovero
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.2.0
>
>
> The {{checkJvmVersion()}} function in the {{/bin/inc}} script of the 
> distribution is not dealing with the new output of {{java -version}} of JDK10 
> (and later?).
> The {{VERSION}} variable is left undefined, which then has the main 
> bootscript to not set the Jigsaw modules correctly (the various JVM flags 
> which need to be enabled since Java 9).
> This is a blocker to use Karaf on Java 10, which is already in candidate 
> release. I don't think much else is changed compared to Java 9 so it would be 
> great to sort this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5641) Karaf boot scripts need to deal with JDK10 version patterns

2018-03-15 Thread Guillaume Nodet (JIRA) 

[ 
https://issues.apache.org/jira/browse/KARAF-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400495#comment-16400495
 ] 

Guillaume Nodet commented on KARAF-5641:


We should also verify on windows I think.

> Karaf boot scripts need to deal with JDK10 version patterns
> ---
>
> Key: KARAF-5641
> URL: https://issues.apache.org/jira/browse/KARAF-5641
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.2.0.M2
>Reporter: Sanne Grinovero
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.2.0
>
>
> The {{checkJvmVersion()}} function in the {{/bin/inc}} script of the 
> distribution is not dealing with the new output of {{java -version}} of JDK10 
> (and later?).
> The {{VERSION}} variable is left undefined, which then has the main 
> bootscript to not set the Jigsaw modules correctly (the various JVM flags 
> which need to be enabled since Java 9).
> This is a blocker to use Karaf on Java 10, which is already in candidate 
> release. I don't think much else is changed compared to Java 9 so it would be 
> great to sort this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5641) Karaf boot scripts need to deal with JDK10 version patterns

2018-03-14 Thread Guillaume Nodet (JIRA) 

[ 
https://issues.apache.org/jira/browse/KARAF-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398340#comment-16398340
 ] 

Guillaume Nodet commented on KARAF-5641:


Oh, nice, thx [~ffang] !

> Karaf boot scripts need to deal with JDK10 version patterns
> ---
>
> Key: KARAF-5641
> URL: https://issues.apache.org/jira/browse/KARAF-5641
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.2.0.M2
>Reporter: Sanne Grinovero
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.2.0
>
>
> The {{checkJvmVersion()}} function in the {{/bin/inc}} script of the 
> distribution is not dealing with the new output of {{java -version}} of JDK10 
> (and later?).
> The {{VERSION}} variable is left undefined, which then has the main 
> bootscript to not set the Jigsaw modules correctly (the various JVM flags 
> which need to be enabled since Java 9).
> This is a blocker to use Karaf on Java 10, which is already in candidate 
> release. I don't think much else is changed compared to Java 9 so it would be 
> great to sort this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5641) Karaf boot scripts need to deal with JDK10 version patterns

2018-03-13 Thread Guillaume Nodet (JIRA) 

[ 
https://issues.apache.org/jira/browse/KARAF-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397606#comment-16397606
 ] 

Guillaume Nodet commented on KARAF-5641:


I pushed a fix but this is not sufficient to have support for Java 10, as Karaf 
does not start, even after fixing the JRE packages by adding 
{code:java}
jre-10 = ${jre-9}{code}
to the {{etc/jre.properties}} file.

> Karaf boot scripts need to deal with JDK10 version patterns
> ---
>
> Key: KARAF-5641
> URL: https://issues.apache.org/jira/browse/KARAF-5641
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.2.0.M2
>Reporter: Sanne Grinovero
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.2.0
>
>
> The {{checkJvmVersion()}} function in the {{/bin/inc}} script of the 
> distribution is not dealing with the new output of {{java -version}} of JDK10 
> (and later?).
> The {{VERSION}} variable is left undefined, which then has the main 
> bootscript to not set the Jigsaw modules correctly (the various JVM flags 
> which need to be enabled since Java 9).
> This is a blocker to use Karaf on Java 10, which is already in candidate 
> release. I don't think much else is changed compared to Java 9 so it would be 
> great to sort this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5641) Karaf boot scripts need to deal with JDK10 version patterns

2018-03-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/KARAF-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397604#comment-16397604
 ] 

ASF subversion and git services commented on KARAF-5641:


Commit 7fa1d274bda958e5ff24d0ab74aa6c19b534a35e in karaf's branch 
refs/heads/master from [~gnt]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=7fa1d27 ]

[KARAF-5641] Karaf boot scripts need to deal with JDK10 version patterns


> Karaf boot scripts need to deal with JDK10 version patterns
> ---
>
> Key: KARAF-5641
> URL: https://issues.apache.org/jira/browse/KARAF-5641
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Affects Versions: 4.2.0.M2
>Reporter: Sanne Grinovero
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.2.0
>
>
> The {{checkJvmVersion()}} function in the {{/bin/inc}} script of the 
> distribution is not dealing with the new output of {{java -version}} of JDK10 
> (and later?).
> The {{VERSION}} variable is left undefined, which then has the main 
> bootscript to not set the Jigsaw modules correctly (the various JVM flags 
> which need to be enabled since Java 9).
> This is a blocker to use Karaf on Java 10, which is already in candidate 
> release. I don't think much else is changed compared to Java 9 so it would be 
> great to sort this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)