[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695629#comment-16695629
]
Jean-Baptiste Onofré commented on KARAF-5845:
-
We still have flaky itests on Jenkins:
{code}
org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsAdmin
org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager
{code}
I'm trying to reproduce locally and I will fix that.
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Labels: itest
> Fix For: 4.2.2
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583381#comment-16583381
]
ASF GitHub Bot commented on KARAF-5845:
---
jbonofre closed pull request #598: [KARAF-5845] Avoid race condition in
JMXSecurityTest
URL: https://github.com/apache/karaf/pull/598
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/itests/test/src/test/java/org/apache/karaf/itests/JMXSecurityTest.java
b/itests/test/src/test/java/org/apache/karaf/itests/JMXSecurityTest.java
index 5a5a0add5a..ee7630e538 100644
--- a/itests/test/src/test/java/org/apache/karaf/itests/JMXSecurityTest.java
+++ b/itests/test/src/test/java/org/apache/karaf/itests/JMXSecurityTest.java
@@ -368,6 +368,12 @@ private void
testKarafConfigAdminMBean(MBeanServerConnection connection, String
newProps.put("d.e.f", "def");
assertJmxInvoke(shouldSucceed, connection, mbean, "update", new Object
[] {pid, newProps}, new String [] {String.class.getName(),
Map.class.getName()});
assertJmxInvoke(shouldSucceed, connection, mbean, "deleteProperty",
new Object [] {pid, "d.e.f"}, new String [] {String.class.getName(),
String.class.getName()});
+// just put some delay to avoid KARAF-5845
+try {
+Thread.sleep(3000);
+} catch (Throwable t) {
+// nothing to do
+}
Map m3 = (Map) connection.invoke(mbean, "listProperties",
new Object [] {pid}, new String [] {String.class.getName()});
if (shouldSucceed) {
assertEquals("abc", m3.get("a.b.c"));
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583383#comment-16583383
]
ASF subversion and git services commented on KARAF-5845:
Commit b7a249caa3968e41d0c558b17b33fa3a72899142 in karaf's branch
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=b7a249c ]
Merge pull request #598 from jbonofre/KARAF-5845
[KARAF-5845] Avoid race condition in JMXSecurityTest
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583382#comment-16583382
]
ASF subversion and git services commented on KARAF-5845:
Commit 10560c4cf76a35866ed9e52919662a01c4f2344d in karaf's branch
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=10560c4 ]
[KARAF-5845] Avoid race condition in JMXSecurityTest
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583384#comment-16583384
]
ASF subversion and git services commented on KARAF-5845:
Commit b7a249caa3968e41d0c558b17b33fa3a72899142 in karaf's branch
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=b7a249c ]
Merge pull request #598 from jbonofre/KARAF-5845
[KARAF-5845] Avoid race condition in JMXSecurityTest
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583335#comment-16583335
]
ASF GitHub Bot commented on KARAF-5845:
---
jbonofre opened a new pull request #598: [KARAF-5845] Avoid race condition in
JMXSecurityTest
URL: https://github.com/apache/karaf/pull/598
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582766#comment-16582766
]
Jean-Baptiste Onofré commented on KARAF-5845:
-
It seems to be a race condition with ConfigAdmin. I'm investigating.
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5845) JMXSecurityTest.testJMXSecurityAsManager is flaky
[
https://issues.apache.org/jira/browse/KARAF-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551733#comment-16551733
]
Jean-Baptiste Onofré commented on KARAF-5845:
-
I'm able to reproduce the issue running the test multiple time (it fails once
for 10 executions roughly). I'm investigating.
> JMXSecurityTest.testJMXSecurityAsManager is flaky
> -
>
> Key: KARAF-5845
> URL: https://issues.apache.org/jira/browse/KARAF-5845
> Project: Karaf
> Issue Type: Test
> Components: karaf-test
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.1
>
>
> {{JMXSecurityTest.testJMXSecurityAsManager}} randomly fails on Jenkins:
> {code}
> java.lang.AssertionError: expected: but was:
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:356)
> at
> org.apache.karaf.itests.JMXSecurityTest.testKarafConfigAdminMBean(JMXSecurityTest.java:337)
> at
> org.apache.karaf.itests.JMXSecurityTest.testJMXSecurityAsManager(JMXSecurityTest.java:164)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
