[jira] [Commented] (KUDU-1438) [java client] Upgrade to Netty 4
[ https://issues.apache.org/jira/browse/KUDU-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032752#comment-17032752 ] ASF subversion and git services commented on KUDU-1438: --- Commit 57dda5d4868d29f68de4aa0ac516ca390333e6be in kudu's branch refs/heads/master from Grant Henke [ https://gitbox.apache.org/repos/asf?p=kudu.git;h=57dda5d ] KUDU-1438: [java] Upgrade to Netty 4 This patch upgrades from Netty 3 to the latest Netty 4. Below is a list of some of the changes required: - Changed org.jboss.netty imports to io.netty - Adjust shading to relocate io.netty - Removed outdated reflection in Bytes.java - Changed ChannelBuffer to ByteBuffer - Changed OneToOneDecoder to BytesToMessageDecoder - Changed OneToOneEncoder to MessageToByteEncoder - Changed DecoderEmbedder to EmbeddedChannel - Changed Negotiator and Connection to extend SimpleChannelInboundHandler instead of SimpleChannelUpstreamHandler - Worked around non-sharable SslHandler - Migrated from NioClientSocketChannelFactory to Netty Boostrap - Removed boss threads and deprecated setter methods in the AsyncKuduClient - Removed ShutdownThread in AsyncKuduClient - Updated Negotiator tests to unwrap SSL messages - Added build flag to run tests with paranoid level leak detection - Suppressed errorprone FutureReturnValueIgnored warnings I used YCSB to performance test this change and ensure there isn’t a large performance regression. On an m4.2xlarge instance I ran a test of 5 iterations of workload a, b, and c using 1M records and 1M operations. The difference between runs was negligible (< 1%) and within test variance. Change-Id: Ic75bd15a982187039ff2e1510af9390d304f7626 Reviewed-on: http://gerrit.cloudera.org:8080/15136 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo > [java client] Upgrade to Netty 4 > > > Key: KUDU-1438 > URL: https://issues.apache.org/jira/browse/KUDU-1438 > Project: Kudu > Issue Type: Improvement > Components: client >Reporter: Jean-Daniel Cryans >Assignee: Grant Henke >Priority: Major > Labels: roadmap-candidate > > Netty 4 promises better performance for certain workloads, it was an effort > mostly led by Twitter. See their blog post about it: > https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead > asynchbase has a pull request for this, so our work should be similar: > https://github.com/OpenTSDB/asynchbase/pull/116/commits -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KUDU-1438) [java client] Upgrade to Netty 4
[ https://issues.apache.org/jira/browse/KUDU-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865887#comment-16865887 ] Grant Henke commented on KUDU-1438: --- Yeah, IIRC there will be no more Netty 3 releases. This is the last of our outdated Java dependencies. Everything else has been updated. It would be awesome to get this one upgraded. > [java client] Upgrade to Netty 4 > > > Key: KUDU-1438 > URL: https://issues.apache.org/jira/browse/KUDU-1438 > Project: Kudu > Issue Type: Improvement > Components: client >Reporter: Jean-Daniel Cryans >Priority: Major > Labels: kudu-roadmap > > Netty 4 promises better performance for certain workloads, it was an effort > mostly led by Twitter. See their blog post about it: > https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead > asynchbase has a pull request for this, so our work should be similar: > https://github.com/OpenTSDB/asynchbase/pull/116/commits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KUDU-1438) [java client] Upgrade to Netty 4
[ https://issues.apache.org/jira/browse/KUDU-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865880#comment-16865880 ] Todd Lipcon commented on KUDU-1438: --- Are we at risk of CVEs getting filed against Netty 3 and no one supporting it? That might increase the priority of this a bit > [java client] Upgrade to Netty 4 > > > Key: KUDU-1438 > URL: https://issues.apache.org/jira/browse/KUDU-1438 > Project: Kudu > Issue Type: Improvement > Components: client >Reporter: Jean-Daniel Cryans >Priority: Major > Labels: kudu-roadmap > > Netty 4 promises better performance for certain workloads, it was an effort > mostly led by Twitter. See their blog post about it: > https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead > asynchbase has a pull request for this, so our work should be similar: > https://github.com/OpenTSDB/asynchbase/pull/116/commits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KUDU-1438) [java client] Upgrade to Netty 4
[ https://issues.apache.org/jira/browse/KUDU-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594418#comment-16594418 ] Grant Henke commented on KUDU-1438: --- Netty 3.10.6, released in June 2016, is the last ever Netty 3 release: [https://netty.io/news/2016/06/29/3-10-6-Final.html]] At one point people had considered waiting for Netty 5 to avoid two major version changes, but Netty 5 work was dropped and there are no current plans for a Netty 5. See here for details: https://github.com/netty/netty/issues/4466 > [java client] Upgrade to Netty 4 > > > Key: KUDU-1438 > URL: https://issues.apache.org/jira/browse/KUDU-1438 > Project: Kudu > Issue Type: Improvement > Components: client >Reporter: Jean-Daniel Cryans >Priority: Major > > Netty 4 promises better performance for certain workloads, it was an effort > mostly led by Twitter. See their blog post about it: > https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead > asynchbase has a pull request for this, so our work should be similar: > https://github.com/OpenTSDB/asynchbase/pull/116/commits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
