[jira] [Created] (KYLIN-2702) Ineffective null check in DataModelDesc#initComputedColumns()

2017-06-30 Thread Ted Yu (JIRA)
Ted Yu created KYLIN-2702:
-

 Summary: Ineffective null check in 
DataModelDesc#initComputedColumns()
 Key: KYLIN-2702
 URL: https://issues.apache.org/jira/browse/KYLIN-2702
 Project: Kylin
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor


{code}
private void initComputedColumns(Map ccInfoMap) {
if (ccInfoMap == null) {
logger.error("cc info map is null");
}
...
CCInfo other = ccInfoMap.get(thisCCName);
{code}
Subsequent access to ccInfoMap may produce NPE.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KYLIN-2701) Unclosed PreparedStatement in QueryService#getPrepareOnlySqlResponse

2017-06-30 Thread Ted Yu (JIRA)
Ted Yu created KYLIN-2701:
-

 Summary: Unclosed PreparedStatement in 
QueryService#getPrepareOnlySqlResponse
 Key: KYLIN-2701
 URL: https://issues.apache.org/jira/browse/KYLIN-2701
 Project: Kylin
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor


{code}
try {
conn.prepareStatement(correctedSql);
throw new IllegalStateException("Should have thrown 
OnlyPrepareEarlyAbortException");
{code}
The return value of prepareStatement() may leak if there is no exception from 
the call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KYLIN-2700) Should allow user to override Kafka conf in cube level

2017-06-30 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu resolved KYLIN-2700.
--
   Resolution: Fixed
Fix Version/s: v2.1.0

LGTM, patch merged. 

https://github.com/apache/kylin/commit/40e4d627227f584d6212ef588eb3fd658bf159dc

> Should allow user to override Kafka conf in cube level
> --
>
> Key: KYLIN-2700
> URL: https://issues.apache.org/jira/browse/KYLIN-2700
> Project: Kylin
>  Issue Type: Improvement
>Affects Versions: v2.0.0
>Reporter: qiumingming
> Fix For: v2.1.0
>
> Attachments: KYLIN-2700.patch
>
>
> Currently, user can not override Kafka conf in cube level.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-2700) Should allow user to override Kafka conf in cube level

2017-06-30 Thread qiumingming (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

qiumingming updated KYLIN-2700:
---
Affects Version/s: v2.0.0
Fix Version/s: (was: v2.1.0)

> Should allow user to override Kafka conf in cube level
> --
>
> Key: KYLIN-2700
> URL: https://issues.apache.org/jira/browse/KYLIN-2700
> Project: Kylin
>  Issue Type: Improvement
>Affects Versions: v2.0.0
>Reporter: qiumingming
> Attachments: KYLIN-2700.patch
>
>
> Currently, user can not override Kafka conf in cube level.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2700) Should allow user to override Kafka conf in cube level

2017-06-30 Thread qiumingming (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069870#comment-16069870
 ] 

qiumingming commented on KYLIN-2700:


I contribute a patch for this issue.

> Should allow user to override Kafka conf in cube level
> --
>
> Key: KYLIN-2700
> URL: https://issues.apache.org/jira/browse/KYLIN-2700
> Project: Kylin
>  Issue Type: Improvement
>Reporter: qiumingming
> Attachments: KYLIN-2700.patch
>
>
> Currently, user can not override Kafka conf in cube level.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-2700) Should allow user to override Kafka conf in cube level

2017-06-30 Thread qiumingming (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

qiumingming updated KYLIN-2700:
---
Attachment: KYLIN-2700.patch

> Should allow user to override Kafka conf in cube level
> --
>
> Key: KYLIN-2700
> URL: https://issues.apache.org/jira/browse/KYLIN-2700
> Project: Kylin
>  Issue Type: Improvement
>Reporter: qiumingming
> Attachments: KYLIN-2700.patch
>
>
> Currently, user can not override Kafka conf in cube level.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KYLIN-2700) Should allow user to override Kafka conf in cube level

2017-06-30 Thread qiumingming (JIRA)
qiumingming created KYLIN-2700:
--

 Summary: Should allow user to override Kafka conf in cube level
 Key: KYLIN-2700
 URL: https://issues.apache.org/jira/browse/KYLIN-2700
 Project: Kylin
  Issue Type: Improvement
Reporter: qiumingming


Currently, user can not override Kafka conf in cube level.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-2699) Tomcat LinkageError for curator-client jar file conflict

2017-06-30 Thread qiumingming (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

qiumingming updated KYLIN-2699:
---
Attachment: KYLIN-2699.patch

I contribute a patch for this issue.

> Tomcat LinkageError for curator-client jar file conflict
> 
>
> Key: KYLIN-2699
> URL: https://issues.apache.org/jira/browse/KYLIN-2699
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine, Web 
>Affects Versions: v2.0.0
>Reporter: qiumingming
>Assignee: Dong Li
> Attachments: KYLIN-2699.patch
>
>
> Exception: java.lang.LinkageError: loader constraint violation: loader 
> (instance of sun/misc/Launcher$AppClassLoader) previously initiated loading 
> for a different type with name "org/apache/curator/RetryPolicy"
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at 
> org.apache.curator.CuratorZookeeperClient.(CuratorZookeeperClient.java:97)
> at 
> org.apache.curator.framework.imps.CuratorFrameworkImpl.(CuratorFrameworkImpl.java:108)
> at 
> org.apache.curator.framework.CuratorFrameworkFactory$Builder.build(CuratorFrameworkFactory.java:124)
> at 
> org.apache.kylin.storage.hbase.util.ZookeeperJobLock.lock(ZookeeperJobLock.java:70)
> at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler.init(DefaultScheduler.java:208)
> at org.apache.kylin.rest.service.JobService$1.run(JobService.java:116)
> at java.lang.Thread.run(Thread.java:745)
> This exception will make kylin job engine does not work. And I found it 
> occured because in the kylin/WEB-INF/lib contains the 
> curator-client-2.7.1.jar which make some conflicts. In general, the HBase and 
> Hadoop cluster always contain their own curator-client jar files. So there is 
> no need to include the  curator-client jar file in kylin/WEB-INF/lib.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KYLIN-2699) Tomcat LinkageError for curator-client jar file conflict

2017-06-30 Thread qiumingming (JIRA)
qiumingming created KYLIN-2699:
--

 Summary: Tomcat LinkageError for curator-client jar file conflict
 Key: KYLIN-2699
 URL: https://issues.apache.org/jira/browse/KYLIN-2699
 Project: Kylin
  Issue Type: Bug
  Components: Job Engine, Web 
Affects Versions: v2.0.0
Reporter: qiumingming
Assignee: Dong Li


Exception: java.lang.LinkageError: loader constraint violation: loader 
(instance of sun/misc/Launcher$AppClassLoader) previously initiated loading for 
a different type with name "org/apache/curator/RetryPolicy"
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at 
org.apache.curator.CuratorZookeeperClient.(CuratorZookeeperClient.java:97)
at 
org.apache.curator.framework.imps.CuratorFrameworkImpl.(CuratorFrameworkImpl.java:108)
at 
org.apache.curator.framework.CuratorFrameworkFactory$Builder.build(CuratorFrameworkFactory.java:124)
at 
org.apache.kylin.storage.hbase.util.ZookeeperJobLock.lock(ZookeeperJobLock.java:70)
at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler.init(DefaultScheduler.java:208)
at org.apache.kylin.rest.service.JobService$1.run(JobService.java:116)
at java.lang.Thread.run(Thread.java:745)

This exception will make kylin job engine does not work. And I found it occured 
because in the kylin/WEB-INF/lib contains the curator-client-2.7.1.jar which 
make some conflicts. In general, the HBase and Hadoop cluster always contain 
their own curator-client jar files. So there is no need to include the  
curator-client jar file in kylin/WEB-INF/lib.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-2670) CASE WHEN supporting problem in kylin2.0

2017-06-30 Thread liyang (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liyang updated KYLIN-2670:
--
Labels: focus scope  (was: )

> CASE WHEN supporting problem in kylin2.0
> 
>
> Key: KYLIN-2670
> URL: https://issues.apache.org/jira/browse/KYLIN-2670
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.0.0
>Reporter: zhou degao
>Assignee: liyang
>  Labels: focus, scope
>
> Following query failed in kylin 2.0 but succeeded in kylin 1.6
> select "fact_pv_data_alias"."PRODUCT_NAME" as "c0", 
> "fact_pv_data_alias"."PLATFORM" as "c1" from "CSDNBI"."FACT_PV_DATA" as 
> "fact_pv_data_alias" group by "fact_pv_data_alias"."PRODUCT_NAME", 
> "fact_pv_data_alias"."PLATFORM" order by CASE WHEN 
> "fact_pv_data_alias"."PRODUCT_NAME" IS NULL THEN 1 ELSE 0 END, 
> "fact_pv_data_alias"."PRODUCT_NAME" ASC, CASE WHEN 
> "fact_pv_data_alias"."PLATFORM" IS NULL THEN 1 ELSE 0 END, 
> "fact_pv_data_alias"."PLATFORM" ASC
> Reported error in kylin 2.0:
> Error while executing SQL "select "fact_pv_data_alias"."PRODUCT_NAME" as 
> "c0", "fact_pv_data_alias"."PLATFORM" as "c1" from "CSDNBI"."FACT_PV_DATA" as 
> "fact_pv_data_alias" group by "fact_pv_data_alias"."PRODUCT_NAME", 
> "fact_pv_data_alias"."PLATFORM" order by CASE WHEN 
> "fact_pv_data_alias"."PRODUCT_NAME" IS NULL THEN 1 ELSE 0 END, 
> "fact_pv_data_alias"."PRODUCT_NAME" ASC, CASE WHEN 
> "fact_pv_data_alias"."PLATFORM" IS NULL THEN 1 ELSE 0 END, 
> "fact_pv_data_alias"."PLATFORM" ASC LIMIT 5": index (2) must be less than 
> size (2) 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)