[jira] [Commented] (KYLIN-2964) AclEntity operation issue
[ https://issues.apache.org/jira/browse/KYLIN-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284645#comment-16284645 ] jiatao.tao commented on KYLIN-2964: --- Hi [~julianpan] Could add some UTs? > AclEntity operation issue > -- > > Key: KYLIN-2964 > URL: https://issues.apache.org/jira/browse/KYLIN-2964 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_2964.patch > > > When user add/update/delete access for AclEntity (project, model, cube, job), > which will check user exist. But if there are two user not exist, which will > cause issue. Admin want to delete the notExistsUser1, it will throws > notExistsUser2 not exist. The other operation has same issues for this check. > Could we add another method for checkExistUser and just add the method for > add or update? It should be fix this issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3033) Provide API compatibility for hbase 2.0 release
[ https://issues.apache.org/jira/browse/KYLIN-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KYLIN-3033: -- Labels: compatibility (was: ) > Provide API compatibility for hbase 2.0 release > --- > > Key: KYLIN-3033 > URL: https://issues.apache.org/jira/browse/KYLIN-3033 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu > Labels: compatibility > > Compiling against hbase 2.0.0-alpha4 release, I got the following compilation > errors: > https://pastebin.com/yfejnTBE > We should start preparing migration to hbase 2.0 compatible APIs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3046) Consider introducing log4j-extras
[ https://issues.apache.org/jira/browse/KYLIN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KYLIN-3046: -- Labels: log (was: ) > Consider introducing log4j-extras > -- > > Key: KYLIN-3046 > URL: https://issues.apache.org/jira/browse/KYLIN-3046 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu > Labels: log > > log4j-extras allows log rotation as well as compression. > https://logging.apache.org/log4j/extras/download.html > We should consider using log4j-extras. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3093) Upgrade curator to 2.10.0
Ted Yu created KYLIN-3093: - Summary: Upgrade curator to 2.10.0 Key: KYLIN-3093 URL: https://issues.apache.org/jira/browse/KYLIN-3093 Project: Kylin Issue Type: Improvement Reporter: Ted Yu curator-2.10.0 has several bug fixes over current version (2.7.1), updating would help improve stability. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3062) Hide RAW measure
[ https://issues.apache.org/jira/browse/KYLIN-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284490#comment-16284490 ] nichunen commented on KYLIN-3062: - [~Zhixiong Chen] I forgot to set the config for hiding raw measure as default in last patch, please review my patch of KYLIN-3062-2.patch > Hide RAW measure > > > Key: KYLIN-3062 > URL: https://issues.apache.org/jira/browse/KYLIN-3062 > Project: Kylin > Issue Type: Task > Components: Web >Reporter: Shaofeng SHI >Assignee: Zhixiong Chen > Fix For: v2.3.0 > > Attachments: KYLIN-3062-2.patch, KYLIN-3062.patch > > > See the discussion here: > http://apache-kylin.74782.x6.nabble.com/Discuss-Disable-hide-quot-RAW-quot-measure-in-Kylin-web-GUI-td6636.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3062) Hide RAW measure
[ https://issues.apache.org/jira/browse/KYLIN-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen updated KYLIN-3062: Attachment: KYLIN-3062-2.patch > Hide RAW measure > > > Key: KYLIN-3062 > URL: https://issues.apache.org/jira/browse/KYLIN-3062 > Project: Kylin > Issue Type: Task > Components: Web >Reporter: Shaofeng SHI >Assignee: Zhixiong Chen > Fix For: v2.3.0 > > Attachments: KYLIN-3062-2.patch, KYLIN-3062.patch > > > See the discussion here: > http://apache-kylin.74782.x6.nabble.com/Discuss-Disable-hide-quot-RAW-quot-measure-in-Kylin-web-GUI-td6636.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (KYLIN-3062) Hide RAW measure
[ https://issues.apache.org/jira/browse/KYLIN-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen reopened KYLIN-3062: - > Hide RAW measure > > > Key: KYLIN-3062 > URL: https://issues.apache.org/jira/browse/KYLIN-3062 > Project: Kylin > Issue Type: Task > Components: Web >Reporter: Shaofeng SHI >Assignee: Zhixiong Chen > Fix For: v2.3.0 > > Attachments: KYLIN-3062.patch > > > See the discussion here: > http://apache-kylin.74782.x6.nabble.com/Discuss-Disable-hide-quot-RAW-quot-measure-in-Kylin-web-GUI-td6636.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3070) Add a config property for flat table storage format
[ https://issues.apache.org/jira/browse/KYLIN-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284471#comment-16284471 ] Shaofeng SHI commented on KYLIN-3070: - yeah I will review it soon; Thanks for the reminder. > Add a config property for flat table storage format > --- > > Key: KYLIN-3070 > URL: https://issues.apache.org/jira/browse/KYLIN-3070 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.6, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Vsevolod Ostapenko >Priority: Minor > Labels: newbie > Attachments: KYLIN-3070.master.001.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Flat table storage format is currently hard-coded as SEQUENCEFILE in the > core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java > That prevents using Impala as a SQL engine while using beeline CLI (via > custom JDBC URL), as Impala cannot write sequence files. > Adding a parameter to kylin.properties to override the default setting would > address the issue. > Removing a hard-coded value for storage format might be good idea in and on > itself. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3070) Add a config property for flat table storage format
[ https://issues.apache.org/jira/browse/KYLIN-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284311#comment-16284311 ] Vsevolod Ostapenko commented on KYLIN-3070: --- [~yimingliu] or [~Shaofengshi], could one of you guys review my changes and provide feedback or, if the changes are ok, commit them into the master? > Add a config property for flat table storage format > --- > > Key: KYLIN-3070 > URL: https://issues.apache.org/jira/browse/KYLIN-3070 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.6, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Vsevolod Ostapenko >Priority: Minor > Labels: newbie > Attachments: KYLIN-3070.master.001.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Flat table storage format is currently hard-coded as SEQUENCEFILE in the > core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java > That prevents using Impala as a SQL engine while using beeline CLI (via > custom JDBC URL), as Impala cannot write sequence files. > Adding a parameter to kylin.properties to override the default setting would > address the issue. > Removing a hard-coded value for storage format might be good idea in and on > itself. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3092) Synchronize read/write operations on Managers
liyang created KYLIN-3092: - Summary: Synchronize read/write operations on Managers Key: KYLIN-3092 URL: https://issues.apache.org/jira/browse/KYLIN-3092 Project: Kylin Issue Type: Improvement Reporter: liyang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283684#comment-16283684 ] Shaofeng SHI commented on KYLIN-3088: - I have to say, this change is too minor to worth a dedicated JIRA. Please try to consolidate more such changes together, or combine it with other changes. Thanks for the understanding. > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3087) DistributedLock in GlobalDictionaryBuilder may not release
[ https://issues.apache.org/jira/browse/KYLIN-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283535#comment-16283535 ] kangkaisen commented on KYLIN-3087: --- Hi Fangyuan, Thanks you. This patch looks good to me, But doesn't have your author info. Please re-submit a new patch with your author info by following the guide here: https://kylin.apache.org/development/howto_contribute.html. I will merge your patch to master branch, Thanks you. > DistributedLock in GlobalDictionaryBuilder may not release > -- > > Key: KYLIN-3087 > URL: https://issues.apache.org/jira/browse/KYLIN-3087 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.2.0 >Reporter: Fangyuan Deng >Assignee: Fangyuan Deng > Attachments: KYLIN-3087.patch > > > In GlobalDictionaryBuilder.init(), > this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, > true); > if this line has exception, the DistributedLock will not release, and other > jobs can not run. > so,I added a try catch. > try { > this.builder = new AppendTrieDictionaryBuilder(baseDir, > maxEntriesPerSlice, true); > } catch (Throwable e) { > lock.unlock(getLockPath(sourceColumn)); > throw new RuntimeException(String.format("Failed to create global > dictionary on %s ", sourceColumn), e); > } -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2941) Configuration setting for SSO
[ https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283530#comment-16283530 ] Billy Liu commented on KYLIN-2941: -- Is there any document needs to be updated? [~julianpan] > Configuration setting for SSO > - > > Key: KYLIN-2941 > URL: https://issues.apache.org/jira/browse/KYLIN-2941 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN_2941.patch > > > I noticed there is kylin.security.saml.metadata-file properties in > kylin.properties but never used. > And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration > in kylinSecurity.xml. > Could we config both of them in kylin.properties? > And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (KYLIN-3091) A problem about retention rate analyze
[ https://issues.apache.org/jira/browse/KYLIN-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3091: --- Assignee: Yerui Sun (was: liyang) > A problem about retention rate analyze > -- > > Key: KYLIN-3091 > URL: https://issues.apache.org/jira/browse/KYLIN-3091 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v2.0.0 > Environment: hbase 0.98.8-hadoop2 >Reporter: WangSheng >Assignee: Yerui Sun > > I found that kylin supported retention rate analyze function, so I made some > test for this function. The following SQL executed successful: > {code:java} > select city, version, > intersect_count(uuid, dt, array['20161014', '20161015']) as retention_oneday, > intersect_count(uuid, dt, array['20161014', '20161015', '20161016']) as > retention_twoday > from visit_log > where dt in ('2016104', '20161015', '20161016') > group by city, version > {code} > but, other SQLs executed failed like this: > {code:java} > select city, > intersect_count(uuid, dt, array['20161014', '20161015']) as retention_oneday > from visit_log > where dt in ('2016104', '20161015',) > group by city, version > select city, version, > intersect_count(uuid, dt, array['20161014', '20161015', '20161016']) as > retention_twoday > from visit_log > where dt in ('2016104', '20161015', '20161016') > group by city, version > {code} > which means I cannot use just one intersect_count UDAF in a SQL, at lease two > intersect_count. My kylin version is kylin 2.0.0-hbase 0.98.8, and here is > the error log: > {code:java} > Caused by: java.lang.IndexOutOfBoundsException: Index: 2, Size: 2 > at java.util.ArrayList.rangeCheck(ArrayList.java:635) > at java.util.ArrayList.get(ArrayList.java:411) > at > org.apache.kylin.query.relnode.ColumnRowType.getColumnByIndex(ColumnRowType.java:49) > at > org.apache.kylin.query.relnode.OLAPAggregateRel.fillbackOptimizedColumn(OLAPAggregateRel.java:396) > at > org.apache.kylin.query.relnode.OLAPAggregateRel.buildRewriteFieldsAndMetricsColumns(OLAPAggregateRel.java:347) > at > org.apache.kylin.query.relnode.OLAPAggregateRel.implementRewrite(OLAPAggregateRel.java:283) > at > org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:158) > at > org.apache.kylin.query.relnode.OLAPLimitRel.implementRewrite(OLAPLimitRel.java:107) > at > org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:158) > at > org.apache.kylin.query.relnode.OLAPToEnumerableConverter.implement(OLAPToEnumerableConverter.java:100) > at > org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.implementRoot(EnumerableRelImplementor.java:108) > at > org.apache.calcite.adapter.enumerable.EnumerableInterpretable.toBindable(EnumerableInterpretable.java:92) > at > org.apache.calcite.prepare.CalcitePrepareImpl$CalcitePreparingStmt.implement(CalcitePrepareImpl.java:1248) > at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:306) > at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:203) > at > org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:776) > at > org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:632) > at > org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:602) > at > org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:214) > at > org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:595) > at > org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:615) > at > org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:148) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3091) A problem about retention rate analyze
[ https://issues.apache.org/jira/browse/KYLIN-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283526#comment-16283526 ] Shaofeng SHI commented on KYLIN-3091: - [~sunyerui]] Yerui, could you please check this issue? Thanks! > A problem about retention rate analyze > -- > > Key: KYLIN-3091 > URL: https://issues.apache.org/jira/browse/KYLIN-3091 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v2.0.0 > Environment: hbase 0.98.8-hadoop2 >Reporter: WangSheng >Assignee: liyang > > I found that kylin supported retention rate analyze function, so I made some > test for this function. The following SQL executed successful: > {code:java} > select city, version, > intersect_count(uuid, dt, array['20161014', '20161015']) as retention_oneday, > intersect_count(uuid, dt, array['20161014', '20161015', '20161016']) as > retention_twoday > from visit_log > where dt in ('2016104', '20161015', '20161016') > group by city, version > {code} > but, other SQLs executed failed like this: > {code:java} > select city, > intersect_count(uuid, dt, array['20161014', '20161015']) as retention_oneday > from visit_log > where dt in ('2016104', '20161015',) > group by city, version > select city, version, > intersect_count(uuid, dt, array['20161014', '20161015', '20161016']) as > retention_twoday > from visit_log > where dt in ('2016104', '20161015', '20161016') > group by city, version > {code} > which means I cannot use just one intersect_count UDAF in a SQL, at lease two > intersect_count. My kylin version is kylin 2.0.0-hbase 0.98.8, and here is > the error log: > {code:java} > Caused by: java.lang.IndexOutOfBoundsException: Index: 2, Size: 2 > at java.util.ArrayList.rangeCheck(ArrayList.java:635) > at java.util.ArrayList.get(ArrayList.java:411) > at > org.apache.kylin.query.relnode.ColumnRowType.getColumnByIndex(ColumnRowType.java:49) > at > org.apache.kylin.query.relnode.OLAPAggregateRel.fillbackOptimizedColumn(OLAPAggregateRel.java:396) > at > org.apache.kylin.query.relnode.OLAPAggregateRel.buildRewriteFieldsAndMetricsColumns(OLAPAggregateRel.java:347) > at > org.apache.kylin.query.relnode.OLAPAggregateRel.implementRewrite(OLAPAggregateRel.java:283) > at > org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:158) > at > org.apache.kylin.query.relnode.OLAPLimitRel.implementRewrite(OLAPLimitRel.java:107) > at > org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:158) > at > org.apache.kylin.query.relnode.OLAPToEnumerableConverter.implement(OLAPToEnumerableConverter.java:100) > at > org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.implementRoot(EnumerableRelImplementor.java:108) > at > org.apache.calcite.adapter.enumerable.EnumerableInterpretable.toBindable(EnumerableInterpretable.java:92) > at > org.apache.calcite.prepare.CalcitePrepareImpl$CalcitePreparingStmt.implement(CalcitePrepareImpl.java:1248) > at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:306) > at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:203) > at > org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:776) > at > org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:632) > at > org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:602) > at > org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:214) > at > org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:595) > at > org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:615) > at > org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:148) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3087) DistributedLock in GlobalDictionaryBuilder may not release
[ https://issues.apache.org/jira/browse/KYLIN-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283525#comment-16283525 ] Shaofeng SHI commented on KYLIN-3087: - [~kangkaisen] Kaisen, could you please review this patch? thanks. > DistributedLock in GlobalDictionaryBuilder may not release > -- > > Key: KYLIN-3087 > URL: https://issues.apache.org/jira/browse/KYLIN-3087 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.2.0 >Reporter: Fangyuan Deng >Assignee: Fangyuan Deng > Attachments: KYLIN-3087.patch > > > In GlobalDictionaryBuilder.init(), > this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, > true); > if this line has exception, the DistributedLock will not release, and other > jobs can not run. > so,I added a try catch. > try { > this.builder = new AppendTrieDictionaryBuilder(baseDir, > maxEntriesPerSlice, true); > } catch (Throwable e) { > lock.unlock(getLockPath(sourceColumn)); > throw new RuntimeException(String.format("Failed to create global > dictionary on %s ", sourceColumn), e); > } -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-2882) Disable datepicker input avoid user typing issue
[ https://issues.apache.org/jira/browse/KYLIN-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-2882. - Resolution: Not A Problem > Disable datepicker input avoid user typing issue > > > Key: KYLIN-2882 > URL: https://issues.apache.org/jira/browse/KYLIN-2882 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > When user typing in input for datepicker, which will cause date error issue. > Could we add the attribute read-only for datepicker input? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-2941) Configuration setting for SSO
[ https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-2941. - Resolution: Fixed Merged in master > Configuration setting for SSO > - > > Key: KYLIN-2941 > URL: https://issues.apache.org/jira/browse/KYLIN-2941 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN_2941.patch > > > I noticed there is kylin.security.saml.metadata-file properties in > kylin.properties but never used. > And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration > in kylinSecurity.xml. > Could we config both of them in kylin.properties? > And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2941) Configuration setting for SSO
[ https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2941: Fix Version/s: v2.3.0 > Configuration setting for SSO > - > > Key: KYLIN-2941 > URL: https://issues.apache.org/jira/browse/KYLIN-2941 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN_2941.patch > > > I noticed there is kylin.security.saml.metadata-file properties in > kylin.properties but never used. > And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration > in kylinSecurity.xml. > Could we config both of them in kylin.properties? > And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2882) Disable datepicker input avoid user typing issue
[ https://issues.apache.org/jira/browse/KYLIN-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283520#comment-16283520 ] Shaofeng SHI commented on KYLIN-2882: - Enter with keyboard is important for people who don't like or don't have a mouse. Besides, it is more efficient to enter a value than select from GUI sometimes. > Disable datepicker input avoid user typing issue > > > Key: KYLIN-2882 > URL: https://issues.apache.org/jira/browse/KYLIN-2882 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > When user typing in input for datepicker, which will cause date error issue. > Could we add the attribute read-only for datepicker input? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2883) Add broken reason in SQL tab for broken cube
[ https://issues.apache.org/jira/browse/KYLIN-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283517#comment-16283517 ] Shaofeng SHI commented on KYLIN-2883: - Hi, as a REST API, the '/{cubeName}/sql' should return a valid SQL, or report error; it is inproper to return success but with a broken reason. So I don't agree to change in this way. Maybe the front end can catch the error and then display something else. > Add broken reason in SQL tab for broken cube > > > Key: KYLIN-2883 > URL: https://issues.apache.org/jira/browse/KYLIN-2883 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_2883.patch > > > When user hit sql tab for 'descbroken' cube, which will throws exception. > It's better to put the broken reason for user. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2953) List readable project not correct if add limit and offset
[ https://issues.apache.org/jira/browse/KYLIN-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2953: Fix Version/s: v2.3.0 Merged in master branch; Thanks! > List readable project not correct if add limit and offset > - > > Key: KYLIN-2953 > URL: https://issues.apache.org/jira/browse/KYLIN-2953 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2953.patch > > > There is one line getReadableProjects in ProjectController: > List projectInstances = > projectService.listAllProjects(limit, offset); > That means just the part of projects, then validate the ACL. > If user's project beyond the limit, then he will never get the projects if he > put limit and offset. > It should be similar with cube list, get all the projects then validate the > ACL, at last get the sub list by limit and offset. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-2953) List readable project not correct if add limit and offset
[ https://issues.apache.org/jira/browse/KYLIN-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-2953. - Resolution: Fixed > List readable project not correct if add limit and offset > - > > Key: KYLIN-2953 > URL: https://issues.apache.org/jira/browse/KYLIN-2953 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2953.patch > > > There is one line getReadableProjects in ProjectController: > List projectInstances = > projectService.listAllProjects(limit, offset); > That means just the part of projects, then validate the ACL. > If user's project beyond the limit, then he will never get the projects if he > put limit and offset. > It should be similar with cube list, get all the projects then validate the > ACL, at last get the sub list by limit and offset. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2959) SAML logout issue
[ https://issues.apache.org/jira/browse/KYLIN-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2959: Fix Version/s: v2.3.0 Merged in master branch; Thanks! > SAML logout issue > - > > Key: KYLIN-2959 > URL: https://issues.apache.org/jira/browse/KYLIN-2959 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN_2959.patch > > > When user click logout in portal, which will cause this issue for SAML mode. > User can not logout successful, the session did not disconnect and still user > can see the menu. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-2959) SAML logout issue
[ https://issues.apache.org/jira/browse/KYLIN-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-2959. - Resolution: Fixed > SAML logout issue > - > > Key: KYLIN-2959 > URL: https://issues.apache.org/jira/browse/KYLIN-2959 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN_2959.patch > > > When user click logout in portal, which will cause this issue for SAML mode. > User can not logout successful, the session did not disconnect and still user > can see the menu. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-2940) List job restful throw NPE when time filter not set
[ https://issues.apache.org/jira/browse/KYLIN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-2940. - Resolution: Fixed > List job restful throw NPE when time filter not set > --- > > Key: KYLIN-2940 > URL: https://issues.apache.org/jira/browse/KYLIN-2940 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2940.patch > > > Here is the error response: > {"code":"999","data":null,"msg":null,"stacktrace":"java.lang.NullPointerException\n\tat > > org.apache.kylin.rest.controller.JobController.list(JobController.java:72)\n\tat > sun.reflect.GeneratedMethodAccessor283.invoke(Unknown Source)\n\tat > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat > java.lang.reflect.Method.invoke(Method.java:606)\n\tat > org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)\n\tat > > org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)\n\tat > > org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)\n\tat > > org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:832)\n\tat > > org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:743)\n\tat > > org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\n\tat > > org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:961)\n\tat > > org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:895)\n\tat > > org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)\n\tat > > org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:858)\n\tat > javax.servlet.http.HttpServlet.service(HttpServlet.java:624)\n\tat > org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)\n\tat > javax.servlet.http.HttpServlet.service(HttpServlet.java:731)\n\tat > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)\n\tat > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat > org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\tat > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)\n\tat > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:316)\n\tat > > org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:126)\n\tat > > org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:90)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:122)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:48)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilterInternal(BasicAuthenticationFilter.java:213)\n\tat > >
[jira] [Updated] (KYLIN-2940) List job restful throw NPE when time filter not set
[ https://issues.apache.org/jira/browse/KYLIN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2940: Fix Version/s: v2.3.0 Merged in master branch; Thanks! > List job restful throw NPE when time filter not set > --- > > Key: KYLIN-2940 > URL: https://issues.apache.org/jira/browse/KYLIN-2940 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2940.patch > > > Here is the error response: > {"code":"999","data":null,"msg":null,"stacktrace":"java.lang.NullPointerException\n\tat > > org.apache.kylin.rest.controller.JobController.list(JobController.java:72)\n\tat > sun.reflect.GeneratedMethodAccessor283.invoke(Unknown Source)\n\tat > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat > java.lang.reflect.Method.invoke(Method.java:606)\n\tat > org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)\n\tat > > org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)\n\tat > > org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)\n\tat > > org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:832)\n\tat > > org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:743)\n\tat > > org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\n\tat > > org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:961)\n\tat > > org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:895)\n\tat > > org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)\n\tat > > org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:858)\n\tat > javax.servlet.http.HttpServlet.service(HttpServlet.java:624)\n\tat > org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)\n\tat > javax.servlet.http.HttpServlet.service(HttpServlet.java:731)\n\tat > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)\n\tat > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat > org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\tat > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)\n\tat > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:316)\n\tat > > org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:126)\n\tat > > org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:90)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:122)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > > org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:48)\n\tat > > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat > >
[jira] [Resolved] (KYLIN-2875) Cube e-mail notification Validation
[ https://issues.apache.org/jira/browse/KYLIN-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-2875. - Resolution: Fixed > Cube e-mail notification Validation > --- > > Key: KYLIN-2875 > URL: https://issues.apache.org/jira/browse/KYLIN-2875 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2875.patch > > > Validation e-mail notification list avoid EmailException: > 2017-03-28 20:01:56,453 INFO [pool-10-thread-8] > execution.AbstractExecutable:250 : notify > list:[us...@apache.com;us...@apache.com;, dl-user-gr...@apache.com] > 2017-03-28 20:01:56,453 ERROR [pool-10-thread-8] util.MailService:112 : > Illegal semicolon, not in group > org.apache.commons.mail.EmailException: Illegal semicolon, not in group > at org.apache.commons.mail.Email.createInternetAddress(Email.java:541) > at org.apache.commons.mail.Email.addTo(Email.java:653) > at org.apache.commons.mail.Email.addTo(Email.java:636) > at org.apache.commons.mail.Email.addTo(Email.java:618) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:97) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:70) > at > org.apache.kylin.job.execution.AbstractExecutable.notifyUserStatusChange(AbstractExecutable.java:251) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onStatusChange(DefaultChainedExecutable.java:105) > at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:296) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:89) > at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:292) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:135) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:133) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) > Caused by: javax.mail.internet.AddressException: Illegal semicolon, not in > group in string > ``cais...@ebay.com;kalagupack...@ebay.com;cb...@ebay.com;cb...@ebay.com;'' at > position 16 > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:780) > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:555) > at javax.mail.internet.InternetAddress.(InternetAddress.java:91) > at org.apache.commons.mail.Email.createInternetAddress(Email.java:514) > ... 15 more -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2875) Cube e-mail notification Validation
[ https://issues.apache.org/jira/browse/KYLIN-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2875: Attachment: (was: KYLIN_2875_CUBE_EMAIL_NOTIFICATION_VALIDATION.patch) > Cube e-mail notification Validation > --- > > Key: KYLIN-2875 > URL: https://issues.apache.org/jira/browse/KYLIN-2875 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2875.patch > > > Validation e-mail notification list avoid EmailException: > 2017-03-28 20:01:56,453 INFO [pool-10-thread-8] > execution.AbstractExecutable:250 : notify > list:[us...@apache.com;us...@apache.com;, dl-user-gr...@apache.com] > 2017-03-28 20:01:56,453 ERROR [pool-10-thread-8] util.MailService:112 : > Illegal semicolon, not in group > org.apache.commons.mail.EmailException: Illegal semicolon, not in group > at org.apache.commons.mail.Email.createInternetAddress(Email.java:541) > at org.apache.commons.mail.Email.addTo(Email.java:653) > at org.apache.commons.mail.Email.addTo(Email.java:636) > at org.apache.commons.mail.Email.addTo(Email.java:618) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:97) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:70) > at > org.apache.kylin.job.execution.AbstractExecutable.notifyUserStatusChange(AbstractExecutable.java:251) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onStatusChange(DefaultChainedExecutable.java:105) > at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:296) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:89) > at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:292) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:135) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:133) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) > Caused by: javax.mail.internet.AddressException: Illegal semicolon, not in > group in string > ``cais...@ebay.com;kalagupack...@ebay.com;cb...@ebay.com;cb...@ebay.com;'' at > position 16 > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:780) > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:555) > at javax.mail.internet.InternetAddress.(InternetAddress.java:91) > at org.apache.commons.mail.Email.createInternetAddress(Email.java:514) > ... 15 more -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2875) Cube e-mail notification Validation
[ https://issues.apache.org/jira/browse/KYLIN-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2875: Fix Version/s: v2.3.0 Merged in master branch; Thanks! > Cube e-mail notification Validation > --- > > Key: KYLIN-2875 > URL: https://issues.apache.org/jira/browse/KYLIN-2875 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2875.patch > > > Validation e-mail notification list avoid EmailException: > 2017-03-28 20:01:56,453 INFO [pool-10-thread-8] > execution.AbstractExecutable:250 : notify > list:[us...@apache.com;us...@apache.com;, dl-user-gr...@apache.com] > 2017-03-28 20:01:56,453 ERROR [pool-10-thread-8] util.MailService:112 : > Illegal semicolon, not in group > org.apache.commons.mail.EmailException: Illegal semicolon, not in group > at org.apache.commons.mail.Email.createInternetAddress(Email.java:541) > at org.apache.commons.mail.Email.addTo(Email.java:653) > at org.apache.commons.mail.Email.addTo(Email.java:636) > at org.apache.commons.mail.Email.addTo(Email.java:618) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:97) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:70) > at > org.apache.kylin.job.execution.AbstractExecutable.notifyUserStatusChange(AbstractExecutable.java:251) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onStatusChange(DefaultChainedExecutable.java:105) > at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:296) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:89) > at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:292) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:135) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:133) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) > Caused by: javax.mail.internet.AddressException: Illegal semicolon, not in > group in string > ``cais...@ebay.com;kalagupack...@ebay.com;cb...@ebay.com;cb...@ebay.com;'' at > position 16 > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:780) > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:555) > at javax.mail.internet.InternetAddress.(InternetAddress.java:91) > at org.apache.commons.mail.Email.createInternetAddress(Email.java:514) > ... 15 more -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-3062) Hide RAW measure
[ https://issues.apache.org/jira/browse/KYLIN-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhixiong Chen resolved KYLIN-3062. -- Resolution: Fixed Fix Version/s: v2.3.0 > Hide RAW measure > > > Key: KYLIN-3062 > URL: https://issues.apache.org/jira/browse/KYLIN-3062 > Project: Kylin > Issue Type: Task > Components: Web >Reporter: Shaofeng SHI >Assignee: Zhixiong Chen > Fix For: v2.3.0 > > Attachments: KYLIN-3062.patch > > > See the discussion here: > http://apache-kylin.74782.x6.nabble.com/Discuss-Disable-hide-quot-RAW-quot-measure-in-Kylin-web-GUI-td6636.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2939) Get config properties not correct in UI
[ https://issues.apache.org/jira/browse/KYLIN-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283324#comment-16283324 ] Shaofeng SHI commented on KYLIN-2939: - Zhixiong, please review and merge the patch. > Get config properties not correct in UI > --- > > Key: KYLIN-2939 > URL: https://issues.apache.org/jira/browse/KYLIN-2939 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: KYLIN_2939.patch > > > When I want to get kylin.env by getDeployEnv(), it will return > kylin.env.hdfs-working-dir value. There is a bug in getProperty in > kylinProperties.js. > This function will return first properties will contains this name. > Here is the fix: > this.getProperty = function (name) { > var keyIndex = _config.indexOf('\n' + name + '='); > var keyLength = name.length; > var partialResult = _config.substr(keyIndex); > var preValueIndex = partialResult.indexOf("="); > var sufValueIndex = partialResult.indexOf("\n", 2); > return partialResult.substring(preValueIndex + 1, sufValueIndex); > } > If necessary, I can create a patch for it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3062) Hide RAW measure
[ https://issues.apache.org/jira/browse/KYLIN-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283323#comment-16283323 ] Zhixiong Chen commented on KYLIN-3062: -- I have reviewed this patch. It's fine to me. > Hide RAW measure > > > Key: KYLIN-3062 > URL: https://issues.apache.org/jira/browse/KYLIN-3062 > Project: Kylin > Issue Type: Task > Components: Web >Reporter: Shaofeng SHI >Assignee: Zhixiong Chen > Attachments: KYLIN-3062.patch > > > See the discussion here: > http://apache-kylin.74782.x6.nabble.com/Discuss-Disable-hide-quot-RAW-quot-measure-in-Kylin-web-GUI-td6636.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3091) A problem about retention rate analyze
WangSheng created KYLIN-3091: Summary: A problem about retention rate analyze Key: KYLIN-3091 URL: https://issues.apache.org/jira/browse/KYLIN-3091 Project: Kylin Issue Type: Bug Components: Query Engine Affects Versions: v2.0.0 Environment: hbase 0.98.8-hadoop2 Reporter: WangSheng Assignee: liyang I found that kylin supported retention rate analyze function, so I made some test for this function. The following SQL executed successful: {code:java} select city, version, intersect_count(uuid, dt, array['20161014', '20161015']) as retention_oneday, intersect_count(uuid, dt, array['20161014', '20161015', '20161016']) as retention_twoday from visit_log where dt in ('2016104', '20161015', '20161016') group by city, version {code} but, other SQLs executed failed like this: {code:java} select city, intersect_count(uuid, dt, array['20161014', '20161015']) as retention_oneday from visit_log where dt in ('2016104', '20161015',) group by city, version select city, version, intersect_count(uuid, dt, array['20161014', '20161015', '20161016']) as retention_twoday from visit_log where dt in ('2016104', '20161015', '20161016') group by city, version {code} which means I cannot use just one intersect_count UDAF in a SQL, at lease two intersect_count. My kylin version is kylin 2.0.0-hbase 0.98.8, and here is the error log: {code:java} Caused by: java.lang.IndexOutOfBoundsException: Index: 2, Size: 2 at java.util.ArrayList.rangeCheck(ArrayList.java:635) at java.util.ArrayList.get(ArrayList.java:411) at org.apache.kylin.query.relnode.ColumnRowType.getColumnByIndex(ColumnRowType.java:49) at org.apache.kylin.query.relnode.OLAPAggregateRel.fillbackOptimizedColumn(OLAPAggregateRel.java:396) at org.apache.kylin.query.relnode.OLAPAggregateRel.buildRewriteFieldsAndMetricsColumns(OLAPAggregateRel.java:347) at org.apache.kylin.query.relnode.OLAPAggregateRel.implementRewrite(OLAPAggregateRel.java:283) at org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:158) at org.apache.kylin.query.relnode.OLAPLimitRel.implementRewrite(OLAPLimitRel.java:107) at org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:158) at org.apache.kylin.query.relnode.OLAPToEnumerableConverter.implement(OLAPToEnumerableConverter.java:100) at org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.implementRoot(EnumerableRelImplementor.java:108) at org.apache.calcite.adapter.enumerable.EnumerableInterpretable.toBindable(EnumerableInterpretable.java:92) at org.apache.calcite.prepare.CalcitePrepareImpl$CalcitePreparingStmt.implement(CalcitePrepareImpl.java:1248) at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:306) at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:203) at org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:776) at org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:632) at org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:602) at org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:214) at org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:595) at org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:615) at org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:148) {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283290#comment-16283290 ] Yang Hao commented on KYLIN-3088: - OK > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Hao updated KYLIN-3088: Attachment: (was: KYLIN-3088.apache-master.002.patch) > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Hao updated KYLIN-3088: Attachment: KYLIN-3088.apache-master.001.patch > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch, > KYLIN-3088.apache-master.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3004) Delete cube segment validation
[ https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283220#comment-16283220 ] Shaofeng SHI commented on KYLIN-3004: - Hi Julian, one comment: I see you removed that check condition completely; but if report a warning in log, that would be nice for debugging. Could you update the patch? thanks! > Delete cube segment validation > -- > > Key: KYLIN-3004 > URL: https://issues.apache.org/jira/browse/KYLIN-3004 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_3004.patch > > > In version 2.1, kylin allow hole between segment. > But currently, there is validation for delete segment. > Here is the code in CubeService: > if (!segmentName.equals(cube.getSegments().get(0).getName()) > && > !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - > 1).getName())) { > throw new > BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), > segmentName)); > } > Does it make sense? Should we remove the limit? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2941) Configuration setting for SSO
[ https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283216#comment-16283216 ] Shaofeng SHI commented on KYLIN-2941: - Hi Julian, LGTM; besides, I think you have verified this change in your SSO environment, right? > Configuration setting for SSO > - > > Key: KYLIN-2941 > URL: https://issues.apache.org/jira/browse/KYLIN-2941 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Attachments: KYLIN_2941.patch > > > I noticed there is kylin.security.saml.metadata-file properties in > kylin.properties but never used. > And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration > in kylinSecurity.xml. > Could we config both of them in kylin.properties? > And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3004) Delete cube segment validation
[ https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283212#comment-16283212 ] Pan, Julian commented on KYLIN-3004: Upload a patch to remove this logic. > Delete cube segment validation > -- > > Key: KYLIN-3004 > URL: https://issues.apache.org/jira/browse/KYLIN-3004 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_3004.patch > > > In version 2.1, kylin allow hole between segment. > But currently, there is validation for delete segment. > Here is the code in CubeService: > if (!segmentName.equals(cube.getSegments().get(0).getName()) > && > !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - > 1).getName())) { > throw new > BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), > segmentName)); > } > Does it make sense? Should we remove the limit? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3062) Hide RAW measure
[ https://issues.apache.org/jira/browse/KYLIN-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283211#comment-16283211 ] nichunen commented on KYLIN-3062: - [~Zhixiong Chen] Please review the patch for me, thanks > Hide RAW measure > > > Key: KYLIN-3062 > URL: https://issues.apache.org/jira/browse/KYLIN-3062 > Project: Kylin > Issue Type: Task > Components: Web >Reporter: Shaofeng SHI >Assignee: Zhixiong Chen > Attachments: KYLIN-3062.patch > > > See the discussion here: > http://apache-kylin.74782.x6.nabble.com/Discuss-Disable-hide-quot-RAW-quot-measure-in-Kylin-web-GUI-td6636.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3004) Delete cube segment validation
[ https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3004: --- Attachment: KYLIN_3004.patch > Delete cube segment validation > -- > > Key: KYLIN-3004 > URL: https://issues.apache.org/jira/browse/KYLIN-3004 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_3004.patch > > > In version 2.1, kylin allow hole between segment. > But currently, there is validation for delete segment. > Here is the code in CubeService: > if (!segmentName.equals(cube.getSegments().get(0).getName()) > && > !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - > 1).getName())) { > throw new > BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), > segmentName)); > } > Does it make sense? Should we remove the limit? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2941) Configuration setting for SSO
[ https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2941: --- Attachment: KYLIN_2941.patch Here is the patch, please review. > Configuration setting for SSO > - > > Key: KYLIN-2941 > URL: https://issues.apache.org/jira/browse/KYLIN-2941 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Attachments: KYLIN_2941.patch > > > I noticed there is kylin.security.saml.metadata-file properties in > kylin.properties but never used. > And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration > in kylinSecurity.xml. > Could we config both of them in kylin.properties? > And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (KYLIN-2941) Configuration setting for SSO
[ https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian reassigned KYLIN-2941: -- Assignee: Pan, Julian > Configuration setting for SSO > - > > Key: KYLIN-2941 > URL: https://issues.apache.org/jira/browse/KYLIN-2941 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > I noticed there is kylin.security.saml.metadata-file properties in > kylin.properties but never used. > And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration > in kylinSecurity.xml. > Could we config both of them in kylin.properties? > And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file} -- This message was sent by Atlassian JIRA (v6.4.14#64029)