[jira] [Commented] (KYLIN-1403) Kylin Hive Column Cardinality Job unable to read bucketed table

2018-01-02 Thread Wang, Gang (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309196#comment-16309196
 ] 

Wang, Gang commented on KYLIN-1403:
---

Tested in Hive 1.2 Kylin 2.1, HCatlog works good in format TXT, Parquet and ORC.
This may be not a issue anymore.

set hive.enforce.bucketing = true;
set hive.exec.dynamic.partition=true;
set hive.exec.dynamic.partition.mode=nostrick;
create table testBucket_parquet (x int,y int) partitioned by(z int) clustered 
by(x) into 10 buckets STORED AS PARQUET;
insert into table testBucket_parquet partition(z) values (1, 1, 1);
insert into table testBucket_parquet partition(z) values (2, 1, 1);
insert into table testBucket_parquet partition(z) values (2, 1, 2);
insert into table testBucket_parquet partition(z) values (1, 1, 2);


> Kylin Hive Column Cardinality Job unable to read bucketed table
> ---
>
> Key: KYLIN-1403
> URL: https://issues.apache.org/jira/browse/KYLIN-1403
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v1.2, v1.3.0
> Environment: - Tested against 
> apache-kylin-1.2-HBase1.1-incubating-SNAPSHOT-bin and 
> apache-kylin-1.3-HBase-1.1-SNAPSHOT-bin
> - Environment is HDP 2.3.4 
> - Hive version: hive-1.2.1.2.3.4.0
> - HBase version: HBase 1.1.2.2.3.4.0-3485
>Reporter: Sebastian Zimmermann
>Assignee: Wang, Gang
>  Labels: newbie
>
> This issue is connected with https://issues.apache.org/jira/browse/KYLIN-1402 
> and states the findings while investigating on the 
> StringIndexOutOfBoundsException.
> While trying to find out why the outputfile created in the cardinality job is 
> empty, we discovered that the only difference between this non-working job 
> and all our other jobs (which work without problems), is that the underlying 
> table is bucketed. 
> The data folder is dbfolder/db/table/partition/bucketfolder/file
> Kylin checks for data in dbfolder/db/table/partition and so is unable to find 
> the data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Zhong Yanghong (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309191#comment-16309191
 ] 

Zhong Yanghong commented on KYLIN-2909:
---

Hi [~lidong_sjtu], there're emails related to other parts. For example, 
one-click migration.

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Shaofeng SHI (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309183#comment-16309183
 ] 

Shaofeng SHI commented on KYLIN-2909:
-

+1 Looks great

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport

2018-01-02 Thread Shaofeng SHI (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309181#comment-16309181
 ] 

Shaofeng SHI commented on KYLIN-3081:
-

LGTM, and passed UT; staged in master; thanks kaige!

> Ineffective null check in CubeController#cuboidsExport
> --
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: KYLIN-3081-fix-potential-npe-02.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + 
> cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids 
> less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have 
> effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport

2018-01-02 Thread Shaofeng SHI (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-3081.
-
Resolution: Fixed

> Ineffective null check in CubeController#cuboidsExport
> --
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: KYLIN-3081-fix-potential-npe-02.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + 
> cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids 
> less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have 
> effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport

2018-01-02 Thread Shaofeng SHI (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3081:

Attachment: (was: KYLIN-3081-fix-potential-npe.patch)

> Ineffective null check in CubeController#cuboidsExport
> --
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: KYLIN-3081-fix-potential-npe-02.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + 
> cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids 
> less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have 
> effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport

2018-01-02 Thread Shaofeng SHI (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3081:

Fix Version/s: v2.3.0
  Component/s: Metadata

> Ineffective null check in CubeController#cuboidsExport
> --
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: KYLIN-3081-fix-potential-npe-02.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + 
> cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids 
> less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have 
> effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Dong Li (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309178#comment-16309178
 ] 

Dong Li edited comment on KYLIN-2909 at 1/3/18 5:36 AM:


Hi [~yaho], I saw all these templates are related to jobs. How about put these 
templates and freemarker dependency to core-job module rather than core-common?


was (Author: lidong_sjtu):
Hi [~yaho], I saw all these templates are related to jobs. How about put these 
templates and freemarker to core-job module rather than core-common?

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Dong Li (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309178#comment-16309178
 ] 

Dong Li commented on KYLIN-2909:


Hi [~yaho], I saw all these templates are related to jobs. How about put these 
templates and freemarker to core-job module rather than core-common?

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (KYLIN-1925) Do not allow cross project clone for cube

2018-01-02 Thread Kaige Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

 Kaige Liu reassigned KYLIN-1925:
-

Assignee:  Kaige Liu  (was: Zhong,Jason)

> Do not allow cross project clone for cube
> -
>
> Key: KYLIN-1925
> URL: https://issues.apache.org/jira/browse/KYLIN-1925
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v1.5.3
>Reporter: Zhong,Jason
>Assignee:  Kaige Liu
> Fix For: Backlog
>
>
> Currently we should only support clone cube in one project, cross project is 
> not  allowed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Zhong Yanghong (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309174#comment-16309174
 ] 

Zhong Yanghong commented on KYLIN-2909:
---

https://github.com/apache/kylin/pull/91 

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Issue Comment Deleted] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Zhong Yanghong (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-2909:
--
Comment: was deleted

(was: https://github.com/apache/kylin/pull/91)

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Zhong Yanghong (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309154#comment-16309154
 ] 

Zhong Yanghong commented on KYLIN-2909:
---

Example emails are attached.

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Zhong Yanghong (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-2909:
--
Attachment: JOB-SUCCEED.png
JOB-DISCARDED.png
JOB_ERROR.png

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Attachments: JOB-DISCARDED.png, JOB-SUCCEED.png, JOB_ERROR.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3110) The dashboard page has some display problems.

2018-01-02 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309126#comment-16309126
 ] 

Zhixiong Chen commented on KYLIN-3110:
--

Hi,[~peng.jianhua]
Could you check display problems in all dashboard feature?
If you find others, please put into patch.
Thanks!

> The dashboard page has some display problems.
> -
>
> Key: KYLIN-3110
> URL: https://issues.apache.org/jira/browse/KYLIN-3110
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3110-The-dashboard-page-has-some-display-probl.patch, 
> incomplete_display_and_message_not_right.png
>
>
> The dashboard page has some display problems.
> 1. The 'Monthly' and 'Weekly' display incompletely;
> 2. The 'showValue' should be 'Show Value'.
> refer to [^incomplete_display_and_message_not_right.png]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KYLIN-2878) Add ability for non-admins to sync tables at project level

2018-01-02 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-2878.
--
Resolution: Fixed

> Add ability for non-admins to sync tables at project level
> --
>
> Key: KYLIN-2878
> URL: https://issues.apache.org/jira/browse/KYLIN-2878
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v1.6.0
>Reporter: Pushpinder Heer
>Assignee: Zhong,Jason
>  Labels: scope
> Fix For: v2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2909) Refine Email Template for notification by freemarker

2018-01-02 Thread Zhong Yanghong (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309120#comment-16309120
 ] 

Zhong Yanghong commented on KYLIN-2909:
---

https://github.com/apache/kylin/pull/91

> Refine Email Template for notification by freemarker
> 
>
> Key: KYLIN-2909
> URL: https://issues.apache.org/jira/browse/KYLIN-2909
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-2878) Add ability for non-admins to sync tables at project level

2018-01-02 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen updated KYLIN-2878:
-
Fix Version/s: v2.2.0

> Add ability for non-admins to sync tables at project level
> --
>
> Key: KYLIN-2878
> URL: https://issues.apache.org/jira/browse/KYLIN-2878
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v1.6.0
>Reporter: Pushpinder Heer
>Assignee: Zhong,Jason
>  Labels: scope
> Fix For: v2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-1686) Get "Access is denied" error on clicking "Admin" tab

2018-01-02 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen updated KYLIN-1686:
-
Fix Version/s: v2.2.0

> Get "Access is denied" error on clicking "Admin" tab
> 
>
> Key: KYLIN-1686
> URL: https://issues.apache.org/jira/browse/KYLIN-1686
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Shaofeng SHI
>Assignee: Zhong,Jason
> Fix For: v2.2.0
>
>
> Enable LDAP authentication, login with an analyst account, when clicking the 
> "Admin" tab, the page shows an exception:
> {code}
> org.springframework.security.access.AccessDeniedException: Access is denied
>   at 
> org.springframework.security.access.vote.AffirmativeBased.decide(AffirmativeBased.java:83)
>   at 
> org.springframework.security.access.intercept.AbstractSecurityInterceptor.beforeInvocation(AbstractSecurityInterceptor.java:206)
>   at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:60)
>   at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>   at 
> org.springframework.aop.framework.Cglib2AopProxy$DynamicAdvisedInterceptor.intercept(Cglib2AopProxy.java:622)
>   at 
> org.apache.kylin.rest.service.DiagnosisService$$EnhancerByCGLIB$$6cb9c74a.getProjectBadQueryHistory()
>   at 
> io.kyligence.kap.rest.controller.BadQueryController.getBadQuerySql(BadQueryController.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invoke(InvocableHandlerMethod.java:213)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:126)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:96)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:617)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:578)
>   at 
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:80)
>   at 
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:923)
>   at 
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:852)
>   at 
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882)
>   at 
> org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:778)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-1686) Get "Access is denied" error on clicking "Admin" tab

2018-01-02 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309110#comment-16309110
 ] 

Zhixiong Chen commented on KYLIN-1686:
--

this issue had been resolved in KYLIN 2.2.0.

> Get "Access is denied" error on clicking "Admin" tab
> 
>
> Key: KYLIN-1686
> URL: https://issues.apache.org/jira/browse/KYLIN-1686
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Shaofeng SHI
>Assignee: Zhong,Jason
> Fix For: v2.2.0
>
>
> Enable LDAP authentication, login with an analyst account, when clicking the 
> "Admin" tab, the page shows an exception:
> {code}
> org.springframework.security.access.AccessDeniedException: Access is denied
>   at 
> org.springframework.security.access.vote.AffirmativeBased.decide(AffirmativeBased.java:83)
>   at 
> org.springframework.security.access.intercept.AbstractSecurityInterceptor.beforeInvocation(AbstractSecurityInterceptor.java:206)
>   at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:60)
>   at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>   at 
> org.springframework.aop.framework.Cglib2AopProxy$DynamicAdvisedInterceptor.intercept(Cglib2AopProxy.java:622)
>   at 
> org.apache.kylin.rest.service.DiagnosisService$$EnhancerByCGLIB$$6cb9c74a.getProjectBadQueryHistory()
>   at 
> io.kyligence.kap.rest.controller.BadQueryController.getBadQuerySql(BadQueryController.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invoke(InvocableHandlerMethod.java:213)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:126)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:96)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:617)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:578)
>   at 
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:80)
>   at 
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:923)
>   at 
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:852)
>   at 
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882)
>   at 
> org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:778)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KYLIN-1686) Get "Access is denied" error on clicking "Admin" tab

2018-01-02 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-1686.
--
Resolution: Fixed

> Get "Access is denied" error on clicking "Admin" tab
> 
>
> Key: KYLIN-1686
> URL: https://issues.apache.org/jira/browse/KYLIN-1686
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Shaofeng SHI
>Assignee: Zhong,Jason
>
> Enable LDAP authentication, login with an analyst account, when clicking the 
> "Admin" tab, the page shows an exception:
> {code}
> org.springframework.security.access.AccessDeniedException: Access is denied
>   at 
> org.springframework.security.access.vote.AffirmativeBased.decide(AffirmativeBased.java:83)
>   at 
> org.springframework.security.access.intercept.AbstractSecurityInterceptor.beforeInvocation(AbstractSecurityInterceptor.java:206)
>   at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:60)
>   at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>   at 
> org.springframework.aop.framework.Cglib2AopProxy$DynamicAdvisedInterceptor.intercept(Cglib2AopProxy.java:622)
>   at 
> org.apache.kylin.rest.service.DiagnosisService$$EnhancerByCGLIB$$6cb9c74a.getProjectBadQueryHistory()
>   at 
> io.kyligence.kap.rest.controller.BadQueryController.getBadQuerySql(BadQueryController.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invoke(InvocableHandlerMethod.java:213)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:126)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:96)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:617)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:578)
>   at 
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:80)
>   at 
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:923)
>   at 
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:852)
>   at 
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882)
>   at 
> org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:778)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2878) Add ability for non-admins to sync tables at project level

2018-01-02 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309108#comment-16309108
 ] 

Zhixiong Chen commented on KYLIN-2878:
--

This  issue had fixed in KYLIN 2.2.0.
So I resolved this jira.

> Add ability for non-admins to sync tables at project level
> --
>
> Key: KYLIN-2878
> URL: https://issues.apache.org/jira/browse/KYLIN-2878
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v1.6.0
>Reporter: Pushpinder Heer
>Assignee: Zhong,Jason
>  Labels: scope
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KYLIN-1663) Project Level Cube admin isn't shown at Cube Level admin list

2018-01-02 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-1663.
--
   Resolution: Fixed
Fix Version/s: v2.2.0

> Project Level Cube admin isn't shown at Cube Level admin list
> -
>
> Key: KYLIN-1663
> URL: https://issues.apache.org/jira/browse/KYLIN-1663
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v1.4.0
>Reporter: qianqiaoneng
>Assignee: qianqiaoneng
> Fix For: v2.2.0
>
>
> The cube admin that is added at manage project page, isn't shown at cube 
> access tab page.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-1663) Project Level Cube admin isn't shown at Cube Level admin list

2018-01-02 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309107#comment-16309107
 ] 

Zhixiong Chen commented on KYLIN-1663:
--

Cube access tab had been removed in KYLIN 2.2.0.
So I resolve this jira.

> Project Level Cube admin isn't shown at Cube Level admin list
> -
>
> Key: KYLIN-1663
> URL: https://issues.apache.org/jira/browse/KYLIN-1663
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v1.4.0
>Reporter: qianqiaoneng
>Assignee: qianqiaoneng
>
> The cube admin that is added at manage project page, isn't shown at cube 
> access tab page.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (KYLIN-1533) UI doesn't support drop a cube for who is admin for that cube

2018-01-02 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264230#comment-16264230
 ] 

Zhixiong Chen edited comment on KYLIN-1533 at 1/3/18 3:31 AM:
--

This issue had fixed in 2.2.0.
So I resolve it.



was (Author: zhixiong chen):
Sorry for late to review this patch.
This patch is fine for me.


> UI doesn't support drop a cube for who is admin for that cube
> -
>
> Key: KYLIN-1533
> URL: https://issues.apache.org/jira/browse/KYLIN-1533
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Fix For: v2.2.0
>
> Attachments: addDropFunc.patch
>
>
> For a cube, its admin can drop it through rest API. However, UI doesn't 
> support it for the admin. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (KYLIN-1533) UI doesn't support drop a cube for who is admin for that cube

2018-01-02 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-1533.
--
   Resolution: Fixed
Fix Version/s: v2.2.0

> UI doesn't support drop a cube for who is admin for that cube
> -
>
> Key: KYLIN-1533
> URL: https://issues.apache.org/jira/browse/KYLIN-1533
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
> Fix For: v2.2.0
>
> Attachments: addDropFunc.patch
>
>
> For a cube, its admin can drop it through rest API. However, UI doesn't 
> support it for the admin. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport

2018-01-02 Thread Kaige Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaige Liu updated KYLIN-3081:
-
Attachment: KYLIN-3081-fix-potential-npe-02.patch

Ah...sorry about that. Already updated. Thanks [~Shaofengshi]

> Ineffective null check in CubeController#cuboidsExport
> --
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Attachments: KYLIN-3081-fix-potential-npe-02.patch, 
> KYLIN-3081-fix-potential-npe.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + 
> cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids 
> less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have 
> effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3146) Response code and exception should be standardised for cube checking

2018-01-02 Thread Kaige Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309084#comment-16309084
 ] 

 Kaige Liu commented on KYLIN-3146:
---

I think if we narrow the scope to REST API, 404 might be a better choice for 
"cube not found". Cube name is part of URI, a 404 error will give client a 
clear hint. 

According to [RFC2616|https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html]:
{quote}10.4.1 400 Bad Request
The request could not be understood by the server due to malformed syntax. The 
client SHOULD NOT repeat the request without modifications.{quote}

{quote}10.4.5 404 Not Found
The server has not found anything matching the Request-URI. No indication is 
given of whether the condition is temporary or permanent. The 410 (Gone) status 
code SHOULD be used if the server knows, through some internally configurable 
mechanism, that an old resource is permanently unavailable and has no 
forwarding address. This status code is commonly used when the server does not 
wish to reveal exactly why the request has been refused, or when no other 
response is applicable.{quote}

> Response code and exception should be standardised for cube checking   
> ---
>
> Key: KYLIN-3146
> URL: https://issues.apache.org/jira/browse/KYLIN-3146
> Project: Kylin
>  Issue Type: Improvement
>Reporter:  Kaige Liu
>Assignee:  Kaige Liu
>Priority: Minor
>
> Checking if cubes exist or not is a common behaviour in some APIs. But we 
> have lots of different responses for the same behaviour.
> Let's take CubeController as an example. When can not find a cube with its 
> name, someone gives a *400* as response code, someone returns *404*, and 
> others send back a *500*. Not only HTTP response code is not standard, which 
> kind of exception should be thrown is not unified as well. Still using the 
> above example, we can find *IllegalArgumentException*, *BadRequestException*, 
> *InternalErrorException*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-2903) Support cardinality calculation for Hive view

2018-01-02 Thread Wang, Gang (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309078#comment-16309078
 ] 

Wang, Gang commented on KYLIN-2903:
---

Yes, Shaofeng. I will take this ticket.

> Support cardinality calculation for Hive view
> -
>
> Key: KYLIN-2903
> URL: https://issues.apache.org/jira/browse/KYLIN-2903
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Reporter: Wang, Gang
>Assignee: Wang, Gang
>Priority: Minor
> Attachments: 
> 0001-KYLIN-2903-support-cardinality-calculation-for-Hive-.patch
>
>
> Currently, Kylin leverage HCatlog to calculate column cardinality for Hive 
> tables. While, HCatlog does not support Hive view actually. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (KYLIN-1403) Kylin Hive Column Cardinality Job unable to read bucketed table

2018-01-02 Thread Wang, Gang (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wang, Gang reassigned KYLIN-1403:
-

Assignee: Wang, Gang  (was: hongbin ma)

> Kylin Hive Column Cardinality Job unable to read bucketed table
> ---
>
> Key: KYLIN-1403
> URL: https://issues.apache.org/jira/browse/KYLIN-1403
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v1.2, v1.3.0
> Environment: - Tested against 
> apache-kylin-1.2-HBase1.1-incubating-SNAPSHOT-bin and 
> apache-kylin-1.3-HBase-1.1-SNAPSHOT-bin
> - Environment is HDP 2.3.4 
> - Hive version: hive-1.2.1.2.3.4.0
> - HBase version: HBase 1.1.2.2.3.4.0-3485
>Reporter: Sebastian Zimmermann
>Assignee: Wang, Gang
>  Labels: newbie
>
> This issue is connected with https://issues.apache.org/jira/browse/KYLIN-1402 
> and states the findings while investigating on the 
> StringIndexOutOfBoundsException.
> While trying to find out why the outputfile created in the cardinality job is 
> empty, we discovered that the only difference between this non-working job 
> and all our other jobs (which work without problems), is that the underlying 
> table is bucketed. 
> The data folder is dbfolder/db/table/partition/bucketfolder/file
> Kylin checks for data in dbfolder/db/table/partition and so is unable to find 
> the data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3146) Response code and exception should be standardised for cube checking

2018-01-02 Thread Shaofeng SHI (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309077#comment-16309077
 ] 

Shaofeng SHI commented on KYLIN-3146:
-

+1 

> Response code and exception should be standardised for cube checking   
> ---
>
> Key: KYLIN-3146
> URL: https://issues.apache.org/jira/browse/KYLIN-3146
> Project: Kylin
>  Issue Type: Improvement
>Reporter:  Kaige Liu
>Assignee:  Kaige Liu
>Priority: Minor
>
> Checking if cubes exist or not is a common behaviour in some APIs. But we 
> have lots of different responses for the same behaviour.
> Let's take CubeController as an example. When can not find a cube with its 
> name, someone gives a *400* as response code, someone returns *404*, and 
> others send back a *500*. Not only HTTP response code is not standard, which 
> kind of exception should be thrown is not unified as well. Still using the 
> above example, we can find *IllegalArgumentException*, *BadRequestException*, 
> *InternalErrorException*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (KYLIN-3147) Response code and exception should be standardised for cube checking

2018-01-02 Thread Kaige Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaige Liu closed KYLIN-3147.

Resolution: Duplicate

> Response code and exception should be standardised for cube checking   
> ---
>
> Key: KYLIN-3147
> URL: https://issues.apache.org/jira/browse/KYLIN-3147
> Project: Kylin
>  Issue Type: Improvement
>Reporter:  Kaige Liu
>Assignee:  Kaige Liu
>Priority: Minor
>
> Checking if cubes exist or not is a common behaviour in some APIs. But we 
> have lots of different responses for the same behaviour.
> Let's take CubeController as an example. When can not find a cube with its 
> name, someone gives a *400* as response code, someone returns *404*, and 
> others send back a *500*. Not only HTTP response code is not standard, which 
> kind of exception should be thrown is not unified as well. Still using the 
> above example, we can find *IllegalArgumentException*, *BadRequestException*, 
> *InternalErrorException*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3147) Response code and exception should be standardised for cube checking

2018-01-02 Thread Kaige Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309072#comment-16309072
 ] 

 Kaige Liu commented on KYLIN-3147:
---

Double submit due to network issue. Duplicated with KYLIN-3146.

> Response code and exception should be standardised for cube checking   
> ---
>
> Key: KYLIN-3147
> URL: https://issues.apache.org/jira/browse/KYLIN-3147
> Project: Kylin
>  Issue Type: Improvement
>Reporter:  Kaige Liu
>Assignee:  Kaige Liu
>Priority: Minor
>
> Checking if cubes exist or not is a common behaviour in some APIs. But we 
> have lots of different responses for the same behaviour.
> Let's take CubeController as an example. When can not find a cube with its 
> name, someone gives a *400* as response code, someone returns *404*, and 
> others send back a *500*. Not only HTTP response code is not standard, which 
> kind of exception should be thrown is not unified as well. Still using the 
> above example, we can find *IllegalArgumentException*, *BadRequestException*, 
> *InternalErrorException*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KYLIN-3146) Response code and exception should be standardised for cube checking

2018-01-02 Thread Kaige Liu (JIRA)
 Kaige Liu created KYLIN-3146:
-

 Summary: Response code and exception should be standardised for 
cube checking   
 Key: KYLIN-3146
 URL: https://issues.apache.org/jira/browse/KYLIN-3146
 Project: Kylin
  Issue Type: Improvement
Reporter:  Kaige Liu
Assignee:  Kaige Liu
Priority: Minor


Checking if cubes exist or not is a common behaviour in some APIs. But we have 
lots of different responses for the same behaviour.
Let's take CubeController as an example. When can not find a cube with its 
name, someone gives a *400* as response code, someone returns *404*, and others 
send back a *500*. Not only HTTP response code is not standard, which kind of 
exception should be thrown is not unified as well. Still using the above 
example, we can find *IllegalArgumentException*, *BadRequestException*, 
*InternalErrorException*.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KYLIN-3147) Response code and exception should be standardised for cube checking

2018-01-02 Thread Kaige Liu (JIRA)
 Kaige Liu created KYLIN-3147:
-

 Summary: Response code and exception should be standardised for 
cube checking   
 Key: KYLIN-3147
 URL: https://issues.apache.org/jira/browse/KYLIN-3147
 Project: Kylin
  Issue Type: Improvement
Reporter:  Kaige Liu
Assignee:  Kaige Liu
Priority: Minor


Checking if cubes exist or not is a common behaviour in some APIs. But we have 
lots of different responses for the same behaviour.
Let's take CubeController as an example. When can not find a cube with its 
name, someone gives a *400* as response code, someone returns *404*, and others 
send back a *500*. Not only HTTP response code is not standard, which kind of 
exception should be thrown is not unified as well. Still using the above 
example, we can find *IllegalArgumentException*, *BadRequestException*, 
*InternalErrorException*.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport

2018-01-02 Thread Kaige Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaige Liu updated KYLIN-3081:
-
Attachment: KYLIN-3081-fix-potential-npe.patch

Patch attached. [~Shaofengshi] [~lidong_sjtu] please help review. Thanks.

> Ineffective null check in CubeController#cuboidsExport
> --
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Attachments: KYLIN-3081-fix-potential-npe.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + 
> cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids 
> less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have 
> effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)