[jira] [Updated] (KYLIN-3071) Add config to reuse dict to reduce dict size
[ https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Hao updated KYLIN-3071: Attachment: KYLIN-3071.apache-master.001.patch > Add config to reuse dict to reduce dict size > - > > Key: KYLIN-3071 > URL: https://issues.apache.org/jira/browse/KYLIN-3071 > Project: Kylin > Issue Type: Improvement >Reporter: Yang Hao >Assignee: Yang Hao >Priority: Major > Attachments: KYLIN-3071.apache-master.001.patch > > > When calling DictionaryManager.trySaveNewDict, and growing dict is not > enabled, it only use the history dict which is equal, it may generate many > dict. We should supply a config to use contains instead of equal to reuse old > dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3071) Add config to reuse dict to reduce dict size
[ https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Hao updated KYLIN-3071: Summary: Add config to reuse dict to reduce dict size (was: Add config of reusing dict to reduce dict size ) > Add config to reuse dict to reduce dict size > - > > Key: KYLIN-3071 > URL: https://issues.apache.org/jira/browse/KYLIN-3071 > Project: Kylin > Issue Type: Improvement >Reporter: Yang Hao >Assignee: Yang Hao >Priority: Major > > When calling DictionaryManager.trySaveNewDict, and growing dict is not > enabled, it only use the history dict which is equal, it may generate many > dict. We should supply a config to use contains instead of equal to reuse old > dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3071) Add config of reusing dict to reduce dict size
[ https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Hao updated KYLIN-3071: Summary: Add config of reusing dict to reduce dict size (was: Use contains instead of equls to reduce dict size ) > Add config of reusing dict to reduce dict size > --- > > Key: KYLIN-3071 > URL: https://issues.apache.org/jira/browse/KYLIN-3071 > Project: Kylin > Issue Type: Improvement >Reporter: Yang Hao >Assignee: Yang Hao >Priority: Major > > When calling DictionaryManager.trySaveNewDict, and growing dict is not > enabled, it only use the history dict which is equal, it may generate many > dict. We should supply a config to use contains instead of equal to reuse old > dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3071) Use contains instead of equls to reduce dict size
[ https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346218#comment-16346218 ] Yang Hao commented on KYLIN-3071: - [~yimingliu] I have not updated on it. The feature may be useful for kylin env with many cubes > Use contains instead of equls to reduce dict size > -- > > Key: KYLIN-3071 > URL: https://issues.apache.org/jira/browse/KYLIN-3071 > Project: Kylin > Issue Type: Improvement >Reporter: Yang Hao >Assignee: Yang Hao >Priority: Major > > When calling DictionaryManager.trySaveNewDict, and growing dict is not > enabled, it only use the history dict which is equal, it may generate many > dict. We should supply a config to use contains instead of equal to reuse old > dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346156#comment-16346156
]
Kaige Liu edited comment on KYLIN-3135 at 1/31/18 2:34 AM:
Hi [~hahayuan], you are right. The commit is not correct according to
[https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#predef]
||Predefined character classes||
|{{.}}|Any character (may or may not match [line
terminators|https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#lt])|
|{{\s}}|A whitespace character: {{[ \t\n\x0B\f\r]}}|
|{{\S}}|A non-whitespace character: {{[^\s]}}|
So *"/\\*.*?*/"* won't match multiple lines comment.
was (Author: liukaige):
Hi [~hahayuan], you are right. The commit is not correct according to
[https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#predef]
||Predefined character classes||
|{{.}}|Any character (may or may not match [line
terminators|https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#lt])|
|{{\s}}|A whitespace character: {{[ \t\n\x0B\f\r]}}|
|{{\S}}|A non-whitespace character: {{[^\s]}}|
So "/\\*.*?\\*/" won't match multiple lines comment.
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346156#comment-16346156
]
Kaige Liu commented on KYLIN-3135:
---
Hi [~hahayuan], you are right. The commit is not correct according to
[https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#predef]
||Predefined character classes||
|{{.}}|Any character (may or may not match [line
terminators|https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#lt])|
|{{\s}}|A whitespace character: {{[ \t\n\x0B\f\r]}}|
|{{\S}}|A non-whitespace character: {{[^\s]}}|
So "/\\*.*?\\*/" won't match multiple lines comment.
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hahayuan updated KYLIN-3135:
Attachment: (was: one_line_comments.PNG)
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hahayuan updated KYLIN-3135:
Comment: was deleted
(was: !one_line_comments.PNG!)
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG, one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346139#comment-16346139
]
hahayuan commented on KYLIN-3135:
-
!one_line_comments.PNG!
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hahayuan updated KYLIN-3135:
Attachment: one_line_comments.PNG
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG, one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hahayuan updated KYLIN-3135:
Attachment: one_line_comments.PNG
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG,
> one_line_comments.PNG, one_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'
[ https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346113#comment-16346113 ] hahayuan commented on KYLIN-3131: - Hi,[~yimingliu].ok. And the total cube number is not the size of all cubes,it's the size of cubes on the page. > After refresh the page,the cubes can't sort by 'create_time' > > > Key: KYLIN-3131 > URL: https://issues.apache.org/jira/browse/KYLIN-3131 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Major > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG, 05.PNG > > > When we open the page 'localhost:7070/kylin/models',the cubes was > disordered.Please refer to 01.png. > Therefore,after we add or clone a new cube,then the page will be refreshed,we > may not find the cube that just add. > And through debug the code,I find that the cubes were sorted by 'create_time' > default.But the cubes' attributes are not contain 'create_time'. > So the cubes were disordered.Please refer to 02.png. > Besides,in the back-end, cubes was sorted by created time from early to > late,so the cubes we get were not latest. > At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get > first were c1-c15,not c36-c50. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'
[ https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346115#comment-16346115 ] peng.jianhua commented on KYLIN-3131: - Hi,[~yimingliu].ok. And the total cube number is not the size of all cubes,it's the size of cubes on the page. > After refresh the page,the cubes can't sort by 'create_time' > > > Key: KYLIN-3131 > URL: https://issues.apache.org/jira/browse/KYLIN-3131 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Major > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG, 05.PNG > > > When we open the page 'localhost:7070/kylin/models',the cubes was > disordered.Please refer to 01.png. > Therefore,after we add or clone a new cube,then the page will be refreshed,we > may not find the cube that just add. > And through debug the code,I find that the cubes were sorted by 'create_time' > default.But the cubes' attributes are not contain 'create_time'. > So the cubes were disordered.Please refer to 02.png. > Besides,in the back-end, cubes was sorted by created time from early to > late,so the cubes we get were not latest. > At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get > first were c1-c15,not c36-c50. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'
[ https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hahayuan updated KYLIN-3131: Comment: was deleted (was: Hi,[~yimingliu].ok. And the total cube number is not the size of all cubes,it's the size of cubes on the page. ) > After refresh the page,the cubes can't sort by 'create_time' > > > Key: KYLIN-3131 > URL: https://issues.apache.org/jira/browse/KYLIN-3131 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Major > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG, 05.PNG > > > When we open the page 'localhost:7070/kylin/models',the cubes was > disordered.Please refer to 01.png. > Therefore,after we add or clone a new cube,then the page will be refreshed,we > may not find the cube that just add. > And through debug the code,I find that the cubes were sorted by 'create_time' > default.But the cubes' attributes are not contain 'create_time'. > So the cubes were disordered.Please refer to 02.png. > Besides,in the back-end, cubes was sorted by created time from early to > late,so the cubes we get were not latest. > At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get > first were c1-c15,not c36-c50. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346092#comment-16346092
]
hahayuan edited comment on KYLIN-3135 at 1/31/18 1:30 AM:
--
[~yimingliu],this commit :
[https://github.com/apache/kylin/commit/7d5fb855064e2b81cd3b154cdeeafec4e64f63c9]
was wrong.
please refer the picture above.
And one more
{code:java}
sql1 = sql1.replaceAll(commentPatterns[i], "");{code}
is improper.
I'll add the test case later.
was (Author: hahayuan):
[~yimingliu],this commit :
[https://github.com/apache/kylin/commit/7d5fb855064e2b81cd3b154cdeeafec4e64f63c9]
was wrong.
please refer the picture above.
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346092#comment-16346092
]
hahayuan commented on KYLIN-3135:
-
[~yimingliu],this commit :
[https://github.com/apache/kylin/commit/7d5fb855064e2b81cd3b154cdeeafec4e64f63c9]
was wrong.
please refer the picture above.
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-3135) Fix regular expression bug in SQL comments
[
https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hahayuan updated KYLIN-3135:
Attachment: multi_line_comments.PNG
> Fix regular expression bug in SQL comments
> --
>
> Key: KYLIN-3135
> URL: https://issues.apache.org/jira/browse/KYLIN-3135
> Project: Kylin
> Issue Type: Bug
>Reporter: hahayuan
>Assignee: hahayuan
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3135.patch, multi_line_comments.PNG
>
>
> Hi,all.
> Recently,I was testing query function of kylin,
> sometimes I just comment with /**/ instead of delete the sql,cause I need to
> query and compare again.
> And I was confused that the results says it was "No Support Sql",but it can
> query success without comments.
> For example,
> {code:java}
> /*
> select count(*) from kylin_sales;
> */
> select * from kylin_sales;
> {code}
> So I view the code and find the commentPatterns of /\**/ was
> {code:java}
> /\\*[^\\*/]*
> {code}
> ,clearly it was wrong.
> The regular expression of [abc] means any character in abc,such as a or b.
> So the [^\\*/] means that * or / can't appear,
> But under this circumstances the */ need to be as a string not separated
> character.
> the */ can't appear not * or / can't appear.
> I rewrite the regular expression,
> {code:java}
> /\\*[\\s\\S]*?\\*/
> {code}
> if you think it's necessary to change the old code,please review and replace
> it.
> Thank for you time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (KYLIN-2880) Enhance BadQueryDetector to include query id
[ https://issues.apache.org/jira/browse/KYLIN-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Li resolved KYLIN-2880. Resolution: Fixed Fix Version/s: v2.3.0 Thanks Yanghong. Patch merged, see commit https://github.com/apache/kylin/commit/6a2ee80c9ec19be1d7e72ed8b587fbc48a195867 > Enhance BadQueryDetector to include query id > > > Key: KYLIN-2880 > URL: https://issues.apache.org/jira/browse/KYLIN-2880 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v2.3.0 > > Attachments: APACHE-KYLIN-2880.patch > > > To better correlate bad queries with the bottom physical execution > information, it's better to let BadQueryDetector include query id -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-2908) Add one option for migration tool to indicate whether to migrate segment data
[ https://issues.apache.org/jira/browse/KYLIN-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Li resolved KYLIN-2908. Resolution: Fixed Fix Version/s: v2.3.0 thanks yanghong! patch merged to master branch. https://github.com/apache/kylin/commit/c704f7cda79921c5a22645492a52c94734847541 > Add one option for migration tool to indicate whether to migrate segment data > - > > Key: KYLIN-2908 > URL: https://issues.apache.org/jira/browse/KYLIN-2908 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v2.3.0 > > Attachments: APACHE-KYLIN-2908.patch > > > Current migration tool will migrate segment data to the destination. However, > in some cases, we only want to migrate cube schema without segment data. For > example, when we do some compatibility testing for upgrade. This can also > avoid two env refer the same htable, which may leading to some issue when dst > env do some fresh to delete the htable which src env still refers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2932) Simplify the thread model for in-memory cubing
[ https://issues.apache.org/jira/browse/KYLIN-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-2932: -- Attachment: APACHE-KYLIN-2932.patch > Simplify the thread model for in-memory cubing > -- > > Key: KYLIN-2932 > URL: https://issues.apache.org/jira/browse/KYLIN-2932 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Wang Ken >Assignee: Wang Ken >Priority: Major > Attachments: APACHE-KYLIN-2932.patch > > > The current implementation uses split threads, task threads and main thread > to do the cube building, there is complex join and error handling logic. > The new implement leverages the ForkJoinPool from JDK, the event split logic > is handled in > main thread. Cuboid task and sub-tasks are handled in fork join pool, cube > results are collected > async and can be write to output earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2932) Simplify the thread model for in-memory cubing
[
https://issues.apache.org/jira/browse/KYLIN-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344869#comment-16344869
]
Zhong Yanghong commented on KYLIN-2932:
---
To enable this feature, we need to config
{{kylin.job.cube-inmem-builder-class}} to be
{{org.apache.kylin.cube.inmemcubing2.DoggedCubeBuilder2}}
> Simplify the thread model for in-memory cubing
> --
>
> Key: KYLIN-2932
> URL: https://issues.apache.org/jira/browse/KYLIN-2932
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
>Reporter: Wang Ken
>Assignee: Wang Ken
>Priority: Major
> Attachments: APACHE-KYLIN-2932.patch
>
>
> The current implementation uses split threads, task threads and main thread
> to do the cube building, there is complex join and error handling logic.
> The new implement leverages the ForkJoinPool from JDK, the event split logic
> is handled in
> main thread. Cuboid task and sub-tasks are handled in fork join pool, cube
> results are collected
> async and can be write to output earlier.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-2932) Simplify the thread model for in-memory cubing
[ https://issues.apache.org/jira/browse/KYLIN-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-2932: -- Attachment: (was: APACHE-KYLIN-2932.patch) > Simplify the thread model for in-memory cubing > -- > > Key: KYLIN-2932 > URL: https://issues.apache.org/jira/browse/KYLIN-2932 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Wang Ken >Assignee: Wang Ken >Priority: Major > Attachments: APACHE-KYLIN-2932.patch > > > The current implementation uses split threads, task threads and main thread > to do the cube building, there is complex join and error handling logic. > The new implement leverages the ForkJoinPool from JDK, the event split logic > is handled in > main thread. Cuboid task and sub-tasks are handled in fork join pool, cube > results are collected > async and can be write to output earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3204) Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
[
https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Li resolved KYLIN-3204.
Resolution: Fixed
Fix Version/s: v2.3.0
Thanks Kaige! Patch merged with a minor refine commit:
[https://github.com/apache/kylin/commit/fee5730258a5082999bcf8d3141aa4cb179b693c]
> Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
>
>
> Key: KYLIN-3204
> URL: https://issues.apache.org/jira/browse/KYLIN-3204
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Kaige Liu
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-3204-fix-potentially-unclosed-resources.patch
>
>
> {code}
> Connection con = SqlUtil.getConnection(dbconf);
> DatabaseMetaData dbmd = con.getMetaData();
> ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return even if there is exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3199) The login dialog should be closed when ldap user with no permission login correctly
[
https://issues.apache.org/jira/browse/KYLIN-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344724#comment-16344724
]
Peng Xing commented on KYLIN-3199:
--
Hi, [~Zhixiong Chen] and [~Aron.tao], I have found out the reason.
After refactor with follow issue.
[KYLIN-2960|https://issues.apache.org/jira/browse/KYLIN-2960]
The 'curUser.userDetails.authorities' contains only one group named 'xpGroup',
which is not configured for 'kylin.security.acl.admin-role' in
kylin.properties, so the user 'xp' who belongs to 'xpGroup' has no permission.
Then you login in with user 'xp', 'roles[authority.authority]' is undefined.
But before refactor, every user has at least two default roles which is
configured in kylin.properties as follow.
{code:java}
kylin.security.acl.default-role=ROLE_ANALYST,ROLE_MODELER
{code}
so the user 'xp' who belongs to 'xpGroup' has two default roles 'ROLE_ANALYST'
and 'ROLE_MODELER'.
Then you login in with user 'xp', 'roles[authority.authority]' is '/models'.
So I think the real reason is that the return value of background interface has
changed.
Before: the user has two default roles 'ROLE_ANALYST' and 'ROLE_MODELER'.
After:the user has no default role.
So [~Zhixiong Chen] and [~Aron.tao], can you give a suggestion? can I modified
the web code or backgroud code? thanks!
> The login dialog should be closed when ldap user with no permission login
> correctly
> ---
>
> Key: KYLIN-3199
> URL: https://issues.apache.org/jira/browse/KYLIN-3199
> Project: Kylin
> Issue Type: Bug
> Components: Web
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Labels: patch
> Attachments:
> 0001-KYLIN-3199-The-login-dialog-should-be-closed-when-ld.patch,
> ldap_user_login.png
>
>
> 1. Open ldap authentication, but I do not give the admin permission to group
> 'xpGroup';
> 2. Create a ldap user 'xp', who belongs to group 'xpGroup', so this user has
> none permission.
> 3. When user 'xp' login in, the above bar has showed and been enabled, but
> the login dialog still show.
> 4. Then you can click any button on above bar.
> Please refer to 'ldap_user_login.png'
> I think the login dialog should be closed when you login in correctly, and
> redirect to the 'Model' page, but this user has no permission.
> I have modified this issue, please review the patch, thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.
[
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344728#comment-16344728
]
Peng Xing commented on KYLIN-3197:
--
Hi [~Aron.tao], could you please review this patch? thanks very much!
> When ldap is opened, I use an ignored case user to login, the page does not
> respond.
>
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
> Issue Type: Bug
> Components: General
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
> Labels: patch
> Attachments:
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch,
> image-2018-01-25-17-22-39-970.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use
> '{color:#ff}wkh{color}' to login in, which is normal.
> But when I use '{color:#ff}WKH{color}' to login in, the page does not
> respond.
> I analyze the backgroud code, and find the function of
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
> String)' has problem.
> When userDn is
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and
> username is "{color:#ff}WKH{color}", then authorities will be null by the
> follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn,
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
> I have test the patch, please review, thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-3204) Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
[
https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaige Liu updated KYLIN-3204:
-
Attachment: KYLIN-3204-fix-potentially-unclosed-resources.patch
> Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
>
>
> Key: KYLIN-3204
> URL: https://issues.apache.org/jira/browse/KYLIN-3204
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Major
> Attachments: KYLIN-3204-fix-potentially-unclosed-resources.patch
>
>
> {code}
> Connection con = SqlUtil.getConnection(dbconf);
> DatabaseMetaData dbmd = con.getMetaData();
> ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return even if there is exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-3199) The login dialog should be closed when ldap user with no permission login correctly
[
https://issues.apache.org/jira/browse/KYLIN-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344724#comment-16344724
]
Peng Xing edited comment on KYLIN-3199 at 1/30/18 9:19 AM:
---
Hi, [~Zhixiong Chen] and [~Aron.tao], I have found out the reason.
After refactor with follow issue.
[KYLIN-2960|https://issues.apache.org/jira/browse/KYLIN-2960]
The 'curUser.userDetails.authorities' contains only one group named
'{color:red}xpGroup{color}', which is not configured for
'{color:red}kylin.security.acl.admin-role{color}' in kylin.properties, so the
user '{color:red}xp{color}' who belongs to '{color:red}xpGroup{color}' has no
permission.
Then you login in with user '{color:red}xp{color}',
'{color:#205081}roles[authority.authority]{color}' is undefined.
But before refactor, every user has at least two default roles which is
configured in kylin.properties as follow.
{code:java}
kylin.security.acl.default-role=ROLE_ANALYST,ROLE_MODELER
{code}
so the user '{color:#d04437}xp{color}' who belongs to 'xpGroup' has two default
roles '{color:#d04437}ROLE_ANALYST{color}' and
'{color:#d04437}ROLE_MODELER{color}'.
Then you login in with user '{color:#d04437}xp{color}',
'{color:#205081}roles[authority.authority]{color}' is
'{color:#d04437}/models{color}'.
So I think the real reason is that the return value of background interface has
changed.
Before: the user has two default roles 'ROLE_ANALYST' and 'ROLE_MODELER'.
After:the user has no default role.
So [~Zhixiong Chen] and [~Aron.tao], can you give a suggestion? can I modified
the web code or backgroud code? thanks!
was (Author: xingpeng1):
Hi, [~Zhixiong Chen] and [~Aron.tao], I have found out the reason.
After refactor with follow issue.
[KYLIN-2960|https://issues.apache.org/jira/browse/KYLIN-2960]
The 'curUser.userDetails.authorities' contains only one group named 'xpGroup',
which is not configured for 'kylin.security.acl.admin-role' in
kylin.properties, so the user 'xp' who belongs to 'xpGroup' has no permission.
Then you login in with user 'xp', 'roles[authority.authority]' is undefined.
But before refactor, every user has at least two default roles which is
configured in kylin.properties as follow.
{code:java}
kylin.security.acl.default-role=ROLE_ANALYST,ROLE_MODELER
{code}
so the user 'xp' who belongs to 'xpGroup' has two default roles 'ROLE_ANALYST'
and 'ROLE_MODELER'.
Then you login in with user 'xp', 'roles[authority.authority]' is '/models'.
So I think the real reason is that the return value of background interface has
changed.
Before: the user has two default roles 'ROLE_ANALYST' and 'ROLE_MODELER'.
After:the user has no default role.
So [~Zhixiong Chen] and [~Aron.tao], can you give a suggestion? can I modified
the web code or backgroud code? thanks!
> The login dialog should be closed when ldap user with no permission login
> correctly
> ---
>
> Key: KYLIN-3199
> URL: https://issues.apache.org/jira/browse/KYLIN-3199
> Project: Kylin
> Issue Type: Bug
> Components: Web
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Labels: patch
> Attachments:
> 0001-KYLIN-3199-The-login-dialog-should-be-closed-when-ld.patch,
> ldap_user_login.png
>
>
> 1. Open ldap authentication, but I do not give the admin permission to group
> 'xpGroup';
> 2. Create a ldap user 'xp', who belongs to group 'xpGroup', so this user has
> none permission.
> 3. When user 'xp' login in, the above bar has showed and been enabled, but
> the login dialog still show.
> 4. Then you can click any button on above bar.
> Please refer to 'ldap_user_login.png'
> I think the login dialog should be closed when you login in correctly, and
> redirect to the 'Model' page, but this user has no permission.
> I have modified this issue, please review the patch, thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (KYLIN-3089) Query exception on SortedIteratorMergerWithLimit
[
https://issues.apache.org/jira/browse/KYLIN-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Hao reassigned KYLIN-3089:
---
Assignee: liyang (was: Yang Hao)
> Query exception on SortedIteratorMergerWithLimit
>
>
> Key: KYLIN-3089
> URL: https://issues.apache.org/jira/browse/KYLIN-3089
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Yang Hao
>Assignee: liyang
>Priority: Major
>
> The executing error only exists on some special case. I have a simple sql,
> and the query is routing onto SortedIteratorMergerWithLimit. When iterate
> data, it triggers such error
> {code:java}
>//TODO: remove this check when validated
> if (last != null) {
> if (comparator.compare(last, fetched) > 0)
> throw new IllegalStateException("Not sorted! last: " +
> last + " fetched: " + fetched);
> }
> {code}
> sql is as belows.
> {code:java}
> select "DATE",appid,dim_1,dim_2, sum(uv) as uv
> from table_1
> where appid = and "DATE" = 2017
> group by "DATE",appid,dim_1,dim_2
> limit 5
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (KYLIN-3204) Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
[
https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaige Liu reassigned KYLIN-3204:
-
Assignee: Kaige Liu
> Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
>
>
> Key: KYLIN-3204
> URL: https://issues.apache.org/jira/browse/KYLIN-3204
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Kaige Liu
>Priority: Major
> Attachments: KYLIN-3204-fix-potentially-unclosed-resources.patch
>
>
> {code}
> Connection con = SqlUtil.getConnection(dbconf);
> DatabaseMetaData dbmd = con.getMetaData();
> ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return even if there is exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3204) Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
[
https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344716#comment-16344716
]
Kaige Liu commented on KYLIN-3204:
---
Patch attached. [~lidong_sjtu], please help review. Thanks.
> Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
>
>
> Key: KYLIN-3204
> URL: https://issues.apache.org/jira/browse/KYLIN-3204
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Major
> Attachments: KYLIN-3204-fix-potentially-unclosed-resources.patch
>
>
> {code}
> Connection con = SqlUtil.getConnection(dbconf);
> DatabaseMetaData dbmd = con.getMetaData();
> ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return even if there is exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-3214) Initialize ExternalAclProvider when starting kylin
[ https://issues.apache.org/jira/browse/KYLIN-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3214: Attachment: 0001-KYLIN-3214.patch > Initialize ExternalAclProvider when starting kylin > -- > > Key: KYLIN-3214 > URL: https://issues.apache.org/jira/browse/KYLIN-3214 > Project: Kylin > Issue Type: Improvement > Components: General >Affects Versions: v2.2.0 >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Attachments: 0001-KYLIN-3214.patch > > > Currently, ExternalAclProvider is initialized only when calling acl related > api. > Manage ACL through Ranger，ranger can not get the status of the > ExternalAclProvider in time because of ExternalAclProvider not initialized > when starting kylin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3214) Initialize ExternalAclProvider when starting kylin
peng.jianhua created KYLIN-3214: --- Summary: Initialize ExternalAclProvider when starting kylin Key: KYLIN-3214 URL: https://issues.apache.org/jira/browse/KYLIN-3214 Project: Kylin Issue Type: Improvement Components: General Affects Versions: v2.2.0 Reporter: peng.jianhua Assignee: peng.jianhua Currently, ExternalAclProvider is initialized only when calling acl related api. Manage ACL through Ranger，ranger can not get the status of the ExternalAclProvider in time because of ExternalAclProvider not initialized when starting kylin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2999) One click migrate cube in web
[ https://issues.apache.org/jira/browse/KYLIN-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344657#comment-16344657 ] kangkaisen commented on KYLIN-2999: --- Thanks Kaige. this patch looks good to me. As to the two defects, I think there are not defects about this feature. # If dest env is totally fresh, The Kylin Admin need to mkdir and chmod a lot of dirs both in HDFS and HBase cluster manually, which is necessary even if without this feature. This feature needn't and couldn't do these things. # I think this not a issue, because the normal user update and build cube must be in jobServer, the queryServer couldn't run cubing job. Besides, whether enable this feature relays on server's config. > One click migrate cube in web > - > > Key: KYLIN-2999 > URL: https://issues.apache.org/jira/browse/KYLIN-2999 > Project: Kylin > Issue Type: New Feature > Components: Tools, Build and Test, Web >Reporter: kangkaisen >Assignee: kangkaisen >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2999-fix-cube-automigration-1.patch, > KYLIN-2999.patch > > > Currently, the cube migration must be done by Kylin Admin, which will waste > a lot of time for Kylin Admin. So, we should allow use to migrate cube by one > click in web. Of Course, which is configurable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3210) The project shows '_null' in result page.
[ https://issues.apache.org/jira/browse/KYLIN-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhixiong Chen resolved KYLIN-3210. -- Resolution: Fixed Fix Version/s: v2.3.0 > The project shows '_null' in result page. > - > > Key: KYLIN-3210 > URL: https://issues.apache.org/jira/browse/KYLIN-3210 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.3.0 >Reporter: Peng Xing >Assignee: Peng Xing >Priority: Minor > Labels: patch > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3210-The-project-shows-_null-in-result-page.patch, > _null_project_with_ldap_user.png > > > 1. Open ldap authentication, but I do not give the admin permission to group > 'xpGroup'; > 2. Create a ldap user 'xp', who belongs to group 'xpGroup', so this user has > none permission. > 3. When user 'xp' login in, click the 'Insight' tab page. > 4. Input a any query sql, and click 'Submit'. > 5. The project shows '_null' in result page, refer to > '_null_project_with_ldap_user.png' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3210) The project shows '_null' in result page.
[ https://issues.apache.org/jira/browse/KYLIN-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344648#comment-16344648 ] Zhixiong Chen commented on KYLIN-3210: -- Hi, [~xingpeng1] This patch is fine with me. I will merge it into Kylin master. Thanks! > The project shows '_null' in result page. > - > > Key: KYLIN-3210 > URL: https://issues.apache.org/jira/browse/KYLIN-3210 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.3.0 >Reporter: Peng Xing >Assignee: Peng Xing >Priority: Minor > Labels: patch > Attachments: > 0001-KYLIN-3210-The-project-shows-_null-in-result-page.patch, > _null_project_with_ldap_user.png > > > 1. Open ldap authentication, but I do not give the admin permission to group > 'xpGroup'; > 2. Create a ldap user 'xp', who belongs to group 'xpGroup', so this user has > none permission. > 3. When user 'xp' login in, click the 'Insight' tab page. > 4. Input a any query sql, and click 'Submit'. > 5. The project shows '_null' in result page, refer to > '_null_project_with_ldap_user.png' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
