[jira] [Commented] (KYLIN-2686) The same project's computed column's definition can not be same.

2018-02-07 Thread jiatao.tao (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356615#comment-16356615
 ] 

jiatao.tao commented on KYLIN-2686:
---

Here are the commit : 
https://github.com/apache/kylin/commit/a0b7e74c16718bb7bab3eb093d6953c393f3444a

> The same project's computed column's definition can not be same.
> 
>
> Key: KYLIN-2686
> URL: https://issues.apache.org/jira/browse/KYLIN-2686
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Affects Versions: Future
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Major
> Fix For: Future
>
>
> The computed columns defined in the same project's definition can not be the 
> same.Like in project "learn_kyiln",you may define computed columns like "cc1: 
> a + b","cc2:a + b" in one cube or in multiple cubes.This shall be forbidden 
> cuz cc1 ande cc2 's definition is same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu resolved KYLIN-3131.
--
Resolution: Fixed

LGTM. Merged at 
https://git1-us-west.apache.org/repos/asf?p=kylin.git;a=commit;h=d06b72e3

> After refresh the page,the cubes can't sort by 'create_time'
> 
>
> Key: KYLIN-3131
> URL: https://issues.apache.org/jira/browse/KYLIN-3131
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 
> 0001-KYLIN-3131.patch, 01.PNG, 02.PNG, 03.PNG, 04.PNG, 05.PNG
>
>
> When we open the page 'localhost:7070/kylin/models',the cubes was 
> disordered.Please refer to 01.png.
> Therefore,after we add or clone a new cube,then the page will be refreshed,we 
> may not find the cube that just add.
> And through debug the code,I find that the cubes were sorted by 'create_time' 
> default.But the cubes' attributes are not contain 'create_time'.
> So the cubes were disordered.Please refer to 02.png.
> Besides,in the back-end, cubes was sorted by created time from early to 
> late,so the cubes we get were not latest.
> At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get 
> first were c1-c15,not c36-c50.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3246) Add manager for user.

2018-02-07 Thread jiatao.tao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao reassigned KYLIN-3246:
-

Assignee: jiatao.tao

> Add manager for user.
> -
>
> Key: KYLIN-3246
> URL: https://issues.apache.org/jira/browse/KYLIN-3246
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-07 Thread jiatao.tao (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356600#comment-16356600
 ] 

jiatao.tao edited comment on KYLIN-3197 at 2/8/18 7:42 AM:
---

Hi [~xingpeng1],

I run the latest Kylin code. The user in LDAP is jenny, and I use JENNY and 
jenny, even if jeNNY, all can login.

 

!image-2018-02-08-15-33-07-277.png|width=881,height=101!

!image-2018-02-08-15-35-03-902.png|width=881,height=93!

!image-2018-02-08-15-33-54-480.png|width=885,height=100!

 

!image-2018-02-08-15-32-25-030.png!

 

[http://kylin.apache.org/docs21/howto/howto_ldap_and_sso.html]

 

This is our LDAP document and you can confirm your configuration about LDAP.

 


was (Author: aron.tao):
Hi [~xingpeng1],

I run the latest Kylin code. The user in LDAP is jenny, and I use JENNY and 
jenny, even if jeNNY, all can login.

 

!image-2018-02-08-15-33-07-277.png|width=881,height=101!

!image-2018-02-08-15-35-03-902.png|width=881,height=93!

!image-2018-02-08-15-33-54-480.png|width=885,height=100!

 

!image-2018-02-08-15-32-25-030.png!

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png, 
> image-2018-02-08-15-32-25-030.png, image-2018-02-08-15-33-07-277.png, 
> image-2018-02-08-15-33-54-480.png, image-2018-02-08-15-35-03-902.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be empty Set 
> by the follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-2960) Support user/group and role authentication for LDAP

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-2960:
-
Component/s: (was: Others)
 Security

> Support user/group and role authentication for LDAP
> ---
>
> Key: KYLIN-2960
> URL: https://issues.apache.org/jira/browse/KYLIN-2960
> Project: Kylin
>  Issue Type: New Feature
>  Components: Security
>Reporter: peng.jianhua
>Assignee: jiatao.tao
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-2960-Submit-a-new-feature-that-it-supports-the.patch
>
>
> Currently, the user authentication interface that was provided by kylin to 
> the third party only supports user and role authentication. However only user 
> and group have authentication function when we use the LDAP authentication. 
> In fact the authentication for user and role and the authentication for user 
> and group have the same functional characteristics between different 
> appplication system. So we should submit a new feature that it support the 
> authentication for user and role and the authentication for user and group 
> when the LDAP authentication was enabled.
> We supplied the checkPermission interface to implement the new feature. In 
> the interface we set user groups information to the userRoles parameter when 
> the LDAP was enabled, on the contrary we set user roles information to the 
> userRoles parameter. The interface is as following:
> /**
>  * Checks if a user has permission on an entity.
>  * 
>  * @param user
>  * @param userRoles
>  * @param entityType String constants defined in AclEntityType 
>  * @param entityUuid
>  * @param permission
>  * 
>  * @return true if has permission
>  */
> abstract public boolean checkPermission(String user, List userRoles, 
> //
>   String entityType, String entityUuid, Permission permission);



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3234) ResourceStore should add a API that can recursively list path.

2018-02-07 Thread jiatao.tao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao reassigned KYLIN-3234:
-

Assignee: jiatao.tao

> ResourceStore should add a API that can recursively list path.
> --
>
> Key: KYLIN-3234
> URL: https://issues.apache.org/jira/browse/KYLIN-3234
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-07 Thread jiatao.tao (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356600#comment-16356600
 ] 

jiatao.tao commented on KYLIN-3197:
---

Hi [~xingpeng1],

I run the latest Kylin code. The user in LDAP is jenny, and I use JENNY and 
jenny, even if jeNNY, all can login.

 

!image-2018-02-08-15-33-07-277.png|width=881,height=101!

!image-2018-02-08-15-35-03-902.png|width=881,height=93!

!image-2018-02-08-15-33-54-480.png|width=885,height=100!

 

!image-2018-02-08-15-32-25-030.png!

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png, 
> image-2018-02-08-15-32-25-030.png, image-2018-02-08-15-33-07-277.png, 
> image-2018-02-08-15-33-54-480.png, image-2018-02-08-15-35-03-902.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be empty Set 
> by the follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-07 Thread jiatao.tao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao updated KYLIN-3197:
--
Attachment: image-2018-02-08-15-35-03-902.png

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png, 
> image-2018-02-08-15-32-25-030.png, image-2018-02-08-15-33-07-277.png, 
> image-2018-02-08-15-33-54-480.png, image-2018-02-08-15-35-03-902.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be empty Set 
> by the follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-07 Thread jiatao.tao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao updated KYLIN-3197:
--
Attachment: image-2018-02-08-15-33-07-277.png

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png, 
> image-2018-02-08-15-32-25-030.png, image-2018-02-08-15-33-07-277.png, 
> image-2018-02-08-15-33-54-480.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be empty Set 
> by the follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-07 Thread jiatao.tao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao updated KYLIN-3197:
--
Attachment: image-2018-02-08-15-33-54-480.png

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png, 
> image-2018-02-08-15-32-25-030.png, image-2018-02-08-15-33-07-277.png, 
> image-2018-02-08-15-33-54-480.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be empty Set 
> by the follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-07 Thread jiatao.tao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao updated KYLIN-3197:
--
Attachment: image-2018-02-08-15-32-25-030.png

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png, 
> image-2018-02-08-15-32-25-030.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be empty Set 
> by the follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-2744) Should return correct type for SUM measure in web

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-2744:
-
Fix Version/s: (was: v2.3.0)
   Future

> Should return correct type for SUM measure in web
> -
>
> Key: KYLIN-2744
> URL: https://issues.apache.org/jira/browse/KYLIN-2744
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.0.0
>Reporter: kangkaisen
>Assignee: kangkaisen
>Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-2744.patch
>
>
> Currently, Kylin return decimal type for the  sum measure of double type, 
> which will result in wrong result. So, We should return correct type for SUM 
> measure in web.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3130.
--
Resolution: Fixed

> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 
> 0001-KYLIN-3241.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356578#comment-16356578
 ] 

Zhixiong Chen commented on KYLIN-3130:
--

Ok,thinks [~xingpeng1]. 

It is fine with me.

I will merge it into Kylin.

> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 
> 0001-KYLIN-3241.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3227) Automatically remove the blank at the end of lines in properties files

2018-02-07 Thread Guangyao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guangyao Li updated KYLIN-3227:
---
Attachment: KYLIN-3227-Automatically-remove-the-blank-at-the-end.patch

> Automatically remove the blank at the end of lines in properties files
> --
>
> Key: KYLIN-3227
> URL: https://issues.apache.org/jira/browse/KYLIN-3227
> Project: Kylin
>  Issue Type: Bug
>  Components: Environment 
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Assignee: Wang Cheng
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3227-Automatically-remove-the-blank-at-the-end.patch
>
>
> In the 'kylin.properties' file:
> eg: kylin.engine.spark-conf.spark.executor.instances=1 
> There is a blank space bebind "1"
> The Kylin will startup failure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'

2018-02-07 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356573#comment-16356573
 ] 

peng.jianhua commented on KYLIN-3131:
-

hi,[~yimingliu],sorry late for this,the patch has been updated.

> After refresh the page,the cubes can't sort by 'create_time'
> 
>
> Key: KYLIN-3131
> URL: https://issues.apache.org/jira/browse/KYLIN-3131
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 
> 0001-KYLIN-3131.patch, 01.PNG, 02.PNG, 03.PNG, 04.PNG, 05.PNG
>
>
> When we open the page 'localhost:7070/kylin/models',the cubes was 
> disordered.Please refer to 01.png.
> Therefore,after we add or clone a new cube,then the page will be refreshed,we 
> may not find the cube that just add.
> And through debug the code,I find that the cubes were sorted by 'create_time' 
> default.But the cubes' attributes are not contain 'create_time'.
> So the cubes were disordered.Please refer to 02.png.
> Besides,in the back-end, cubes was sorted by created time from early to 
> late,so the cubes we get were not latest.
> At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get 
> first were c1-c15,not c36-c50.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'

2018-02-07 Thread peng.jianhua (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3131:

Attachment: 0001-KYLIN-3131.patch

> After refresh the page,the cubes can't sort by 'create_time'
> 
>
> Key: KYLIN-3131
> URL: https://issues.apache.org/jira/browse/KYLIN-3131
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 
> 0001-KYLIN-3131.patch, 01.PNG, 02.PNG, 03.PNG, 04.PNG, 05.PNG
>
>
> When we open the page 'localhost:7070/kylin/models',the cubes was 
> disordered.Please refer to 01.png.
> Therefore,after we add or clone a new cube,then the page will be refreshed,we 
> may not find the cube that just add.
> And through debug the code,I find that the cubes were sorted by 'create_time' 
> default.But the cubes' attributes are not contain 'create_time'.
> So the cubes were disordered.Please refer to 02.png.
> Besides,in the back-end, cubes was sorted by created time from early to 
> late,so the cubes we get were not latest.
> At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get 
> first were c1-c15,not c36-c50.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-2964) AclEntity operation issue

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-2964:
-
Fix Version/s: (was: v2.3.0)
   Future

> AclEntity operation issue 
> --
>
> Key: KYLIN-2964
> URL: https://issues.apache.org/jira/browse/KYLIN-2964
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: Future
>
> Attachments: KYLIN_2964.patch
>
>
> When user add/update/delete access for AclEntity (project, model, cube, job), 
> which will check user exist. But if there are two user not exist, which will 
> cause issue. Admin want to delete the notExistsUser1, it will throws 
> notExistsUser2 not exist. The other operation has same issues for this check. 
> Could we add another method for checkExistUser and just add the method for 
> add or update? It should be fix this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356567#comment-16356567
 ] 

peng.jianhua commented on KYLIN-3130:
-

Ok,thinks [~xingpeng1]. 
Hi [~Zhixiong Chen], please help to review it. Thanks!

> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 
> 0001-KYLIN-3241.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3071) Add config to reuse dict to reduce dict size

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3071:
-
Fix Version/s: (was: v2.3.0)

> Add config to reuse dict to reduce dict size 
> -
>
> Key: KYLIN-3071
> URL: https://issues.apache.org/jira/browse/KYLIN-3071
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Yang Hao
>Assignee: Yang Hao
>Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-3071.apache-master.001.patch
>
>
> When calling DictionaryManager.trySaveNewDict, and growing dict is not 
> enabled, it only use the history dict which is equal, it may generate many 
> dict. We should supply a config to use contains instead of equal to reuse old 
> dict.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3071) Add config to reuse dict to reduce dict size

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3071:
-
Fix Version/s: Future

> Add config to reuse dict to reduce dict size 
> -
>
> Key: KYLIN-3071
> URL: https://issues.apache.org/jira/browse/KYLIN-3071
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Yang Hao
>Assignee: Yang Hao
>Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-3071.apache-master.001.patch
>
>
> When calling DictionaryManager.trySaveNewDict, and growing dict is not 
> enabled, it only use the history dict which is equal, it may generate many 
> dict. We should supply a config to use contains instead of equal to reuse old 
> dict.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3107) An alert dialog will pop up warning "Failed to load bar chat" when the user enter or log out from the "Dashboard" page.

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3107:
-
Fix Version/s: (was: v2.3.0)

> An alert dialog will pop up warning "Failed to load bar chat" when the user 
> enter or log out from the "Dashboard" page.
> ---
>
> Key: KYLIN-3107
> URL: https://issues.apache.org/jira/browse/KYLIN-3107
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Attachments: alert_dialog_pop_up_when_enter_Dashboard_page.PNG, 
> alert_dialog_pop_up_when_log_out_from_Dashboard_page.PNG
>
>
> An alert dialog will pop up warning "Failed to load bar chat" when the user 
> enter or log out from the "Dashboard" page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3071) Add config to reuse dict to reduce dict size

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3071:
-
Component/s: Metadata

> Add config to reuse dict to reduce dict size 
> -
>
> Key: KYLIN-3071
> URL: https://issues.apache.org/jira/browse/KYLIN-3071
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Yang Hao
>Assignee: Yang Hao
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-3071.apache-master.001.patch
>
>
> When calling DictionaryManager.trySaveNewDict, and growing dict is not 
> enabled, it only use the history dict which is equal, it may generate many 
> dict. We should supply a config to use contains instead of equal to reuse old 
> dict.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3131) After refresh the page,the cubes can't sort by 'create_time'

2018-02-07 Thread Billy Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356557#comment-16356557
 ] 

Billy Liu commented on KYLIN-3131:
--

I'd like to fix this issue in Kylin 2.3 [~peng.jianhua] do you have updates? 

> After refresh the page,the cubes can't sort by 'create_time'
> 
>
> Key: KYLIN-3131
> URL: https://issues.apache.org/jira/browse/KYLIN-3131
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3131-After-refresh-the-page-the-cubes-can-t-so.patch, 01.PNG, 
> 02.PNG, 03.PNG, 04.PNG, 05.PNG
>
>
> When we open the page 'localhost:7070/kylin/models',the cubes was 
> disordered.Please refer to 01.png.
> Therefore,after we add or clone a new cube,then the page will be refreshed,we 
> may not find the cube that just add.
> And through debug the code,I find that the cubes were sorted by 'create_time' 
> default.But the cubes' attributes are not contain 'create_time'.
> So the cubes were disordered.Please refer to 02.png.
> Besides,in the back-end, cubes was sorted by created time from early to 
> late,so the cubes we get were not latest.
> At this time,I add 50 cubes,from c1 to c50,add in order,but the cubes we get 
> first were c1-c15,not c36-c50.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-07 Thread Billy Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356552#comment-16356552
 ] 

Billy Liu commented on KYLIN-3224:
--

Hi [~peng.jianhua], any update on this issue? I think it could be a blocking 
issue for Kylin 2.3

> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-07 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356550#comment-16356550
 ] 

peng.jianhua commented on KYLIN-3239:
-

Hi [~yimingliu], this issue is a non-functional optimization.  From the code 
point of view, this issue is justified. I will merge it after reviewed the 
issue. Thanks [~Guangyao Li]

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Assignee: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3239-Refactor-the-ACL-code-about-checkPermissi.patch
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3245) Searching cube support fuzzy search

2018-02-07 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3245.
--
Resolution: Fixed

> Searching cube support fuzzy search
> ---
>
> Key: KYLIN-3245
> URL: https://issues.apache.org/jira/browse/KYLIN-3245
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3245-Searching-cube-support-fuzzy-search.patch
>
>
> Rest API:
> List cubes 
> GET /kylin/api/cubes
> Searching cube support fuzzy search



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3243) Optimize the code and keep the code consistent in the access.html

2018-02-07 Thread Zhixiong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3243.
--
Resolution: Fixed

> Optimize the code and keep the code consistent in the access.html
> -
>
> Key: KYLIN-3243
> URL: https://issues.apache.org/jira/browse/KYLIN-3243
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Trivial
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3243.patch
>
>
> Using "$rootScope.permissions.xxx.mask" instead of figure will be more uniform



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (KYLIN-3244) Is it allowable to add qualified users to kylin when they have not logged in kylin before

2018-02-07 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355029#comment-16355029
 ] 

peng.jianhua edited comment on KYLIN-3244 at 2/8/18 6:32 AM:
-

The issue had been fixed. Please refer to 
https://github.com/apache/kylin/commit/577d0c62fbc7798e26c57bc57cadda3ae1e00649.
 

Please close the issue. Thanks!


was (Author: peng.jianhua):
The issue had been fixed. Please refer to 
https://github.com/apache/kylin/commit/577d0c62fbc7798e26c57bc57cadda3ae1e00649

> Is it allowable to add qualified users to kylin when they have not logged in 
> kylin before
> -
>
> Key: KYLIN-3244
> URL: https://issues.apache.org/jira/browse/KYLIN-3244
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Reporter: Zhong Yanghong
>Priority: Major
>
> For current design, it's not allowed unless users have ever logged in kylin. 
> However, this makes the process to grant acl for a new user a bit trivial.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (KYLIN-3244) Is it allowable to add qualified users to kylin when they have not logged in kylin before

2018-02-07 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355029#comment-16355029
 ] 

peng.jianhua edited comment on KYLIN-3244 at 2/8/18 6:32 AM:
-

The issue had been fixed. Please refer to 
https://github.com/apache/kylin/commit/577d0c62fbc7798e26c57bc57cadda3ae1e00649.
 

Please close this issue. Thanks!


was (Author: peng.jianhua):
The issue had been fixed. Please refer to 
https://github.com/apache/kylin/commit/577d0c62fbc7798e26c57bc57cadda3ae1e00649.
 

Please close the issue. Thanks!

> Is it allowable to add qualified users to kylin when they have not logged in 
> kylin before
> -
>
> Key: KYLIN-3244
> URL: https://issues.apache.org/jira/browse/KYLIN-3244
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Reporter: Zhong Yanghong
>Priority: Major
>
> For current design, it's not allowed unless users have ever logged in kylin. 
> However, this makes the process to grant acl for a new user a bit trivial.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread Peng Xing (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356535#comment-16356535
 ] 

Peng Xing commented on KYLIN-3130:
--

Hi [~Zhixiong Chen], [~peng.jianhua], I have moved 0001-KYLIN-3241.patch to 
this jira

> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 
> 0001-KYLIN-3241.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread Peng Xing (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3130:
-
Attachment: 0001-KYLIN-3241.patch

> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 
> 0001-KYLIN-3241.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-07 Thread Billy Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu reassigned KYLIN-3239:


Assignee: Guangyao Li

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Assignee: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3239-Refactor-the-ACL-code-about-checkPermissi.patch
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3245) Searching cube support fuzzy search

2018-02-07 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356531#comment-16356531
 ] 

Zhixiong Chen commented on KYLIN-3245:
--

OK, Thanks.

I will merge it into Kylin master.

> Searching cube support fuzzy search
> ---
>
> Key: KYLIN-3245
> URL: https://issues.apache.org/jira/browse/KYLIN-3245
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3245-Searching-cube-support-fuzzy-search.patch
>
>
> Rest API:
> List cubes 
> GET /kylin/api/cubes
> Searching cube support fuzzy search



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-07 Thread Billy Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356527#comment-16356527
 ] 

Billy Liu commented on KYLIN-3239:
--

[~peng.jianhua], you are the security component owner. Could you help review 
this update?

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Assignee: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3239-Refactor-the-ACL-code-about-checkPermissi.patch
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356456#comment-16356456
 ] 

peng.jianhua commented on KYLIN-3130:
-

[~Zhixiong Chen],it has same problem,the engine_type is also  undefined.




> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 01.PNG, 
> 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3130) If we add new cube then refresh the page,the page is blank

2018-02-07 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356444#comment-16356444
 ] 

Zhixiong Chen commented on KYLIN-3130:
--

Hi, [~xingpeng1]

I remember you had attach a patch about this issue.

Could you move it to this jira?

> If we add new cube then refresh the page,the page is blank
> --
>
> Key: KYLIN-3130
> URL: https://issues.apache.org/jira/browse/KYLIN-3130
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3130-If-we-add-new-cube-then-refresh-the-page-.patch, 01.PNG, 
> 02.PNG, 03.PNG
>
>
> reproduce steps:
> 01:click 'New Cube' button.
> 02:refresh the page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3223) Query for the list of hybrid cubes results in NPE

2018-02-07 Thread Vsevolod Ostapenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vsevolod Ostapenko updated KYLIN-3223:
--
Description: 
Calling REST API to get the list of hybrid cubes returns stack trace with NPE 
exception.
{quote}curl -u ADMIN:KYLIN -X GET -H 'Content-Type: application/json'  -d {}  
[http://localhost:7070/kylin/api/hybrids]
 {quote}
 

If a parameter project without a value is specified, call succeeds. E.g.
{quote}curl -u ADMIN:KYLIN -X GET -H 'Content-Type: application/json'  -d {} 
[http://localhost:7070/kylin/api/hybrids?project]
{quote}
Quick look at the HybridService.java suggests that there is a bug in the code, 
where the very first line tries to check ACLs on the project using the project 
name, which is NULL, when project parameter is not specified as part of the URL.
 If parameter is specified without a value, ACL check is not performed, so it's 
another bug, as the list of projects is retrieved without read permission 
checking.

  was:
Calling REST API to get the list of hybrid cubes returns stack trace with NPE 
exception.
{quote}curl -u ADMIN:KYLIN -X GET -H 'Content-Type: application/json'  -d {} 
[http://localhost:7070/kylin/api/hybrids]

{"code":"999","data":null,"msg":null,"stacktrace":"java.lang.NullPointerException\n\tat
 
java.util.concurrent.ConcurrentSkipListMap.doGet(ConcurrentSkipListMap.java:778)\n\tat
 
java.util.concurrent.ConcurrentSkipListMap.get(ConcurrentSkipListMap.java:1546)\n\tat
 
org.apache.kylin.metadata.cachesync.SingleValueCache.get(SingleValueCache.java:85)\n\tat
 
org.apache.kylin.metadata.project.ProjectManager.getProject(ProjectManager.java:172)\n\tat
 
org.apache.kylin.rest.util.AclEvaluate.getProjectInstance(AclEvaluate.java:39)\n\tat
 
org.apache.kylin.rest.util.AclEvaluate.checkProjectReadPermission(AclEvaluate.java:61)\n\tat
 
org.apache.kylin.rest.service.HybridService.listHybrids(HybridService.java:115)\n\tat
 
org.apache.kylin.rest.controller.HybridController.list(HybridController.java:76)\n\tat
 sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat
 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
 java.lang.reflect.Method.invoke(Method.java:497)\n\tat 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)\n\tat
 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)\n\tat
 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)\n\tat
 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)\n\tat
 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)\n\tat
 
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\n\tat
 
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:967)\n\tat
 
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:901)\n\tat
 
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)\n\tat
 
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861)\n\tat
 javax.servlet.http.HttpServlet.service(HttpServlet.java:624)\n\tat 
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)\n\tat
 javax.servlet.http.HttpServlet.service(HttpServlet.java:731)\n\tat 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
 org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\tat 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)\n\tat
 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127)\n\tat
 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)\n\tat
 
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)\n\tat
 

[jira] [Created] (KYLIN-3246) Add manager for user.

2018-02-07 Thread jiatao.tao (JIRA)
jiatao.tao created KYLIN-3246:
-

 Summary: Add manager for user.
 Key: KYLIN-3246
 URL: https://issues.apache.org/jira/browse/KYLIN-3246
 Project: Kylin
  Issue Type: Improvement
Reporter: jiatao.tao






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-2683) Support reloading kerberos token of BeelineHiveClient

2018-02-07 Thread Kanta Kuramoto (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355239#comment-16355239
 ] 

Kanta Kuramoto commented on KYLIN-2683:
---

Sorry for my late reply. I have been busy with other work so far. I'll confirm 
[~liyang.g...@gmail.com]'s concern.

> Support reloading kerberos token of BeelineHiveClient
> -
>
> Key: KYLIN-2683
> URL: https://issues.apache.org/jira/browse/KYLIN-2683
> Project: Kylin
>  Issue Type: Bug
>Reporter: Kanta Kuramoto
>Assignee: Kanta Kuramoto
>Priority: Minor
>  Labels: scope, security
> Attachments: KYLIN-2683.patch, kerberos_auth.png
>
>
> When the datasource is kerberized, the behavior of reloading kerberos token 
> is different between "Cube Build" and "Load Hive Table".
> I summarized the detail of this behavior in the attached image.
>  
> I think BeelineHiveClient#init shuold be implementad like following.
> http://appcrawler.com/wordpress/2015/06/18/examples-of-connecting-to-kerberos-hive-in-jdbc/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3245) Searching cube support fuzzy search

2018-02-07 Thread Peng Xing (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3245:
-
Description: 
Rest API:
List cubes 
GET /kylin/api/cubes
Searching cube support fuzzy search

  was:
Rest API:
List cubes 
GET /kylin/api/cubes
support fuzzy search


> Searching cube support fuzzy search
> ---
>
> Key: KYLIN-3245
> URL: https://issues.apache.org/jira/browse/KYLIN-3245
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3245-Searching-cube-support-fuzzy-search.patch
>
>
> Rest API:
> List cubes 
> GET /kylin/api/cubes
> Searching cube support fuzzy search



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3245) Searching cube support fuzzy search

2018-02-07 Thread Peng Xing (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3245:
-
Attachment: 0001-KYLIN-3245-Searching-cube-support-fuzzy-search.patch

> Searching cube support fuzzy search
> ---
>
> Key: KYLIN-3245
> URL: https://issues.apache.org/jira/browse/KYLIN-3245
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3245-Searching-cube-support-fuzzy-search.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3245) Searching cube support fuzzy search

2018-02-07 Thread Peng Xing (JIRA)
Peng Xing created KYLIN-3245:


 Summary: Searching cube support fuzzy search
 Key: KYLIN-3245
 URL: https://issues.apache.org/jira/browse/KYLIN-3245
 Project: Kylin
  Issue Type: Improvement
  Components: REST Service
Reporter: Peng Xing
Assignee: Peng Xing
 Fix For: v2.3.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-07 Thread Guangyao Li (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355110#comment-16355110
 ] 

Guangyao Li commented on KYLIN-3239:


Hello [~liyang.g...@gmail.com], If you have time, please review this patch.

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3239-Refactor-the-ACL-code-about-checkPermissi.patch
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-07 Thread Guangyao Li (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355108#comment-16355108
 ] 

Guangyao Li commented on KYLIN-3239:


Hello [~peng.jianhua], You've got a point there.

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3239-Refactor-the-ACL-code-about-checkPermissi.patch
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)