[jira] [Commented] (KYLIN-2899) Enable segment level query cache
[ https://issues.apache.org/jira/browse/KYLIN-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379763#comment-16379763 ] liyang commented on KYLIN-2899: --- Segment level cache is a new idea. Can we have an elaboration of design and some performance comparison here? > Enable segment level query cache > > > Key: KYLIN-2899 > URL: https://issues.apache.org/jira/browse/KYLIN-2899 > Project: Kylin > Issue Type: Sub-task > Components: Query Engine >Affects Versions: v2.1.0 >Reporter: Zhong Yanghong >Assignee: Ma Gang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3119) A few bugs in the function 'massageSql' of 'QueryUtil.java'
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379643#comment-16379643
]
Roger Shi commented on KYLIN-3119:
--
Thank you [~peng.jianhua], I have some comments in the PR. Would you please
have a check?
> A few bugs in the function 'massageSql' of 'QueryUtil.java'
> ---
>
> Key: KYLIN-3119
> URL: https://issues.apache.org/jira/browse/KYLIN-3119
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Attachments:
> 0001-KYLIN-3119-A-few-bugs-in-the-function-massageSql-of-.patch,
> 0001-KYLIN-3119-add-test-cases.patch,
> 0001-kylin-3119-add-more-test-cases-with-enter-and-space.patch,
> 0001-kylin-3119.patch, 01.PNG, 02.PNG
>
>
> in the function 'massageSql' of 'QueryUtil.java',there are a few bugs:
> 01:
> {code:java}
> while (sql.endsWith(";"))
> sql = sql.substring(0, sql.length() - 1);
> {code}
> if the sql end with ';' and after the ';' still has comments,will be
> error.Because the sql will add ("\nLIMIT " + limit) at the end.
> 02:
> {code:java}
> if (limit > 0 && !sql.toLowerCase().contains("limit")) {
> sql += ("\nLIMIT " + limit);
> }
> if (offset > 0 && !sql.toLowerCase().contains("offset")) {
> sql += ("\nOFFSET " + offset);
> }
> {code}
> if the sql already has word 'limit' in it,such as Alias,Subquery,Comments,the
> ‘limit’ in the Input box will be invalid.
> for example,the sql has subquery,and there is 'limit' in subquery.
> {code:java}
> select KYLIN_SALES.PART_DT, count(KYLIN_SALES.PRICE)
> from KYLIN_SALES
> inner join (select ACCOUNT_ID, ACCOUNT_BUYER_LEVEL from KYLIN_ACCOUNT where
> ACCOUNT_COUNTRY = 'US' limit 1) as TT
> on KYLIN_SALES.BUYER_ID = TT.ACCOUNT_ID
> group by KYLIN_SALES.PART_DT
> {code}
> the ‘limit’ in the Input box will be invalid.please refer to 01.png and
> 02.png.
> 03:
> {code:java}
> // https://issues.apache.org/jira/browse/KYLIN-2649
> if (kylinConfig.getForceLimit() > 0 &&
> !sql.toLowerCase().contains("limit")
> && sql.toLowerCase().contains("*")) {
> sql += ("\nLIMIT " + kylinConfig.getForceLimit());
> }
> {code}
> Because KYLIN-2649 is still unresolved,so I didn't change the code,but it
> has same 'limit' word bugs like above.
> And there are some situations that the sql contains \*,such as
> {code:java}count(*),kylin_sales.*{code}
> Maybe the \* in subquery too.
> it seems improperly to deal with the sql just use {code:java}
> sql.toLowerCase().contains("*")
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3268) Tomcat Security Vulnerability Alert. The version of the tomcat for kylin should upgrade to 7.0.85.
[ https://issues.apache.org/jira/browse/KYLIN-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379641#comment-16379641 ] Billy Liu commented on KYLIN-3268: -- All security vulnerabilities should be fixed with high priority. Let's do it. > Tomcat Security Vulnerability Alert. The version of the tomcat for kylin > should upgrade to 7.0.85. > -- > > Key: KYLIN-3268 > URL: https://issues.apache.org/jira/browse/KYLIN-3268 > Project: Kylin > Issue Type: Bug > Components: Security >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Major > Labels: patch > > [SECURITY] CVE-2018-1305 Security constraint annotations applied too late > CVE-2018-1305 Security constraint annotations applied too late > Severity: High > Versions Affected: Apache Tomcat 9.0.0.M1 to 9.0.4 Apache Tomcat 8.5.0 to > 8.5.27 Apache Tomcat 8.0.0.RC1 to 8.0.49 Apache Tomcat 7.0.0 to 7.0.84 > Description: Security constraints defined by annotations of Servlets were > only applied once a Servlet had been loaded. Because security constraints > defined in this way apply to the URL pattern and any URLs below that point, > it was possible - depending on the order Servlets were loaded - for some > security constraints not to be applied. This could have exposed resources to > users who were not authorised to access them. > Mitigation: Users of the affected versions should apply one of the following > mitigations. Upgrade to: - Apache Tomcat 9.0.5 or later - Apache Tomcat > 8.5.28 or later - Apache Tomcat 8.0.50 or later - Apache Tomcat 7.0.85 or > later > References:https://lists.apache.org/thread.html/d3354bb0a4eda4acc0a66f3eb24a213fdb75d12c7d16060b23e65781@%3Cannounce.tomcat.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3262) Produce jacoco exec files for integration test
[ https://issues.apache.org/jira/browse/KYLIN-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378210#comment-16378210 ] Zhong Yanghong commented on KYLIN-3262: --- Hi [~yimingliu], do you have better solution for this jacocoagent.jar? > Produce jacoco exec files for integration test > -- > > Key: KYLIN-3262 > URL: https://issues.apache.org/jira/browse/KYLIN-3262 > Project: Kylin > Issue Type: Task >Reporter: Zhong Yanghong >Priority: Major > Attachments: APACHE-KYLIN-3262.patch > > > Currently to calculate code coverage, kylin only considers UT. However, IT > also covers lots of code. It's better to include this for code coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
