[GitHub] [kylin] nithyamb4790 opened a new pull request #501: Document for Viewing Kylin Cube in Tableau/Power BI

2019-03-05 Thread GitBox
nithyamb4790 opened a new pull request #501: Document for Viewing Kylin Cube in 
Tableau/Power BI
URL: https://github.com/apache/kylin/pull/501
 
 
   Hi,
   I am new to Kylin and have few below queries.
   1. Is it possible to connect directly to Kylin Cube in Tableau or Power BI? 
- **When I login to Tableau, I can only see hive source tables but not the cube 
names.**
   2. How to use hierarchies/Measures of Kylin Cube  in Tableau or Power BI? - 
Will the hierarchies appear as a tree structure? Can we access measures created 
in Kylin directly from Tableau or power BI?
Please share any documents on the above queries. 
   
   Regards,
   Nithya


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asfgit commented on issue #501: Document for Viewing Kylin Cube in Tableau/Power BI

2019-03-05 Thread GitBox
asfgit commented on issue #501: Document for Viewing Kylin Cube in 
Tableau/Power BI
URL: https://github.com/apache/kylin/pull/501#issuecomment-470006413
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3808) RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and exec_interrupt_time fields

2019-03-05 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785257#comment-16785257
 ] 

ASF subversion and git services commented on KYLIN-3808:


Commit e3d9909343c926055ea6a97ab5ea0cc5098f8957 in kylin's branch 
refs/heads/2.5.x from yaozhongqiang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=e3d9909 ]

KYLIN-3808 fix RestAPI /api/jobs always returns 0 for exec_start_time and 
exec_end_time and exec_interrupt_time fields

Signed-off-by: shaofengshi 


> RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and 
> exec_interrupt_time fields
> ---
>
> Key: KYLIN-3808
> URL: https://issues.apache.org/jira/browse/KYLIN-3808
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Affects Versions: v2.5.2
>Reporter: yaozq
>Assignee: yaozq
>Priority: Minor
> Fix For: v2.6.2
>
> Attachments: 
> 0001-KYLIN-3808-fix-RestAPI-api-jobs-always-returns-0-for.patch
>
>
> GET 
> [http://kylin-host:7070/kylin/api/jobs?cubeName=xxx=0=0=1]
> [
> {
> "uuid":"a89cf2d4-caaf-21fe-5cb9-63f1725d0e02",
> "last_modified":1549917430155,
> "version":"2.5.2.20500",
> "name":"BUILD CUBE - - 2019021100_2019021200 - GMT+08:00 
> 2019-02-12 04:10:32",
> "type":"BUILD",
> "duration":1583,
> "related_cube":"",
> "display_cube_name":"",
> "related_segment":"898fc7c8-5e30-927c-da26-816ab4dbff08",
> {color:#FF}"exec_start_time":0,{color}
> {color:#FF}"exec_end_time":0,{color}
> {color:#FF}"exec_interrupt_time":0,{color}
> "mr_waiting":179,
> ..
>  
>  exec_start_time, exec_end_time and exec_interrupt_time fields always return 0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785261#comment-16785261
 ] 

ASF subversion and git services commented on KYLIN-3842:


Commit a280db22b7235ec231b54b82e1f109a6803edad4 in kylin's branch 
refs/heads/2.5.x from yuzhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a280db2 ]

KYLIN-3842 kylinProperties.js Unable to get the public configuration of the 
first line in the front end


> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Assignee: Yuzhang QIU
>Priority: Minor
> Fix For: v2.6.2
>
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3808) RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and exec_interrupt_time fields

2019-03-05 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785260#comment-16785260
 ] 

ASF subversion and git services commented on KYLIN-3808:


Commit 501951c9a8e09038c529656a315d6303c553f6bf in kylin's branch 
refs/heads/2.6.x from yaozhongqiang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=501951c ]

KYLIN-3808 fix RestAPI /api/jobs always returns 0 for exec_start_time and 
exec_end_time and exec_interrupt_time fields

Signed-off-by: shaofengshi 


> RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and 
> exec_interrupt_time fields
> ---
>
> Key: KYLIN-3808
> URL: https://issues.apache.org/jira/browse/KYLIN-3808
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Affects Versions: v2.5.2
>Reporter: yaozq
>Assignee: yaozq
>Priority: Minor
> Fix For: v2.6.2
>
> Attachments: 
> 0001-KYLIN-3808-fix-RestAPI-api-jobs-always-returns-0-for.patch
>
>
> GET 
> [http://kylin-host:7070/kylin/api/jobs?cubeName=xxx=0=0=1]
> [
> {
> "uuid":"a89cf2d4-caaf-21fe-5cb9-63f1725d0e02",
> "last_modified":1549917430155,
> "version":"2.5.2.20500",
> "name":"BUILD CUBE - - 2019021100_2019021200 - GMT+08:00 
> 2019-02-12 04:10:32",
> "type":"BUILD",
> "duration":1583,
> "related_cube":"",
> "display_cube_name":"",
> "related_segment":"898fc7c8-5e30-927c-da26-816ab4dbff08",
> {color:#FF}"exec_start_time":0,{color}
> {color:#FF}"exec_end_time":0,{color}
> {color:#FF}"exec_interrupt_time":0,{color}
> "mr_waiting":179,
> ..
>  
>  exec_start_time, exec_end_time and exec_interrupt_time fields always return 0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3842:

Fix Version/s: v2.6.2

> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Assignee: Yuzhang QIU
>Priority: Minor
> Fix For: v2.6.2
>
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-3842:
---

Assignee: Yuzhang QIU

> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Assignee: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] coveralls commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

2019-03-05 Thread GitBox
coveralls commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration …
URL: https://github.com/apache/kylin/pull/500#issuecomment-469963679
 
 
   ## Pull Request Test Coverage Report for [Build 
4203](https://coveralls.io/builds/22010290)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.006%**) to **26.954%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22010290/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22010290/badge)](https://coveralls.io/builds/22010290)
 |
   | :-- | --: |
   | Change from base [Build 4201](https://coveralls.io/builds/21985216): |  
0.006% |
   | Covered Lines: | 18961 |
   | Relevant Lines: | 70347 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3845) Kylin build error If the Kafka data source lacks selected dimensions or metrics in the kylin stream build.

2019-03-05 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785204#comment-16785204
 ] 

zhao jintao commented on KYLIN-3845:


I fix this bug. Can I push my code to the master of Kylin code?

> Kylin build error If the Kafka data source lacks selected dimensions or 
> metrics in the kylin stream build.
> --
>
> Key: KYLIN-3845
> URL: https://issues.apache.org/jira/browse/KYLIN-3845
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.5.2
> Environment: Fusion Insight
>Reporter: zhao jintao
>Priority: Major
>  Labels: easyfix
> Fix For: Future
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Hi dear team:
> I'm developing OLAP Platform based on Kylin2.5.2. During my work, I build a 
> streaming cube from Kafka source using kafka demo.
> In my streaming project, I set country、currency as dimensions and userId as 
> metrics. But the cube build failed in 3rd step("Extract Fact Table Distinct 
> Columns"). The exception is java.lang.ArrayIndexOutOfBoundsException.
> This is logs:
> 2019-03-02 14:21:01,492 INFO [main] org.apache.kylin.engine.mr.KylinReducer: 
> Do cleanup, available memory: 1334m
> 2019-03-02 14:21:01,492 INFO [main] org.apache.kylin.engine.mr.KylinReducer: 
> Total rows: 127
> 2019-03-02 14:21:01,492 INFO [main] org.apache.hadoop.mapred.MapTask: 
> Finished spill 0
> 2019-03-02 14:21:01,492 INFO [main] org.apache.hadoop.mapred.YarnChild: 
> Exception running child: java.lang.ArrayIndexOutOfBoundsException:2
> 2019-03-02 14:21:01,492 INFO [main] org.apache.kylin.engine.mr.KylinReducer: 
> Do cleanup, available memory: 1334m
>  at 
> org.apache.kylin.engine.mr.steps.FactDistinctColumnsMapper.doMap(FactDistinctColumnsMapper.java:177)
>  at org.apache.kylin.engine.mr.KylinMapper.map(KylinMapper.java:77)
>  at org.apache.hadoop.mapreduce.Mapper.run(MapperTask.java:146)
>  at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:793)
>  at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341)
>  at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:187)
>  at java.security.AccessController.doPrivileged(Native Method)
>  at javax.security.auth.Subject.doAs(Subject.java:422)
>  at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1781)
>  at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java;180)
>  
> Then I find that in Kafka datasource, some streaming data lack the userId 
> column. Most of the streaming data(contry, currency,userId) is 
> ("China","CNY","843c4d");but a small amount of data lack userId, some data is 
> ("China","CNY"). so when run the 3rd step("Extract Fact Table Distinct 
> Columns"),MR engine will throw exception if the streaming data lack userId.
> The I check the source of Kylin, FactDistinctColumnsMapper.java:
> public void doMap(KEYIN key, Object record, Context context) throws 
> IOException, InterruptedException {
>  Collection rowCollection = 
> flatTableInputFormat.parseMapperInput(record);
> for (String[] row : rowCollection) {
>  context.getCounter(RawDataCounter.BYTES).increment(countSizeInBytes(row));
>  for (int i = 0; i < allCols.size(); i++) {
>  String fieldValue = row[columnIndex[i]];
>  if (fieldValue == null)
>  continue;
> final DataType type = allCols.get(i).getType();
>  ...
> I find that columnIndex[i] is equal with the size of row if the streaming 
> data lack one column. So the row[columnIndex[i]] will throw the 
> ArrayIndexOutOfBoundsException. So I change this code, check the 
> columnIndex[i] and the size of row. If columnIndex[i] is equal with or larger 
> than the size of row, I set fieldValue empty value. And After I change my 
> code, the 3rd step("Extract Fact Table Distinct Columns") will run success.
> Those are what I found, which will cause problem for developers.
> How do you think?
> Best regard
> jintao



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3845) Kylin build error If the Kafka data source lacks selected dimensions or metrics in the kylin stream build.

2019-03-05 Thread zhao jintao (JIRA)
zhao jintao created KYLIN-3845:
--

 Summary: Kylin build error If the Kafka data source lacks selected 
dimensions or metrics in the kylin stream build.
 Key: KYLIN-3845
 URL: https://issues.apache.org/jira/browse/KYLIN-3845
 Project: Kylin
  Issue Type: Bug
  Components: Job Engine
Affects Versions: v2.5.2
 Environment: Fusion Insight
Reporter: zhao jintao
 Fix For: Future


Hi dear team:
I'm developing OLAP Platform based on Kylin2.5.2. During my work, I build a 
streaming cube from Kafka source using kafka demo.
In my streaming project, I set country、currency as dimensions and userId as 
metrics. But the cube build failed in 3rd step("Extract Fact Table Distinct 
Columns"). The exception is java.lang.ArrayIndexOutOfBoundsException.
This is logs:
2019-03-02 14:21:01,492 INFO [main] org.apache.kylin.engine.mr.KylinReducer: Do 
cleanup, available memory: 1334m
2019-03-02 14:21:01,492 INFO [main] org.apache.kylin.engine.mr.KylinReducer: 
Total rows: 127
2019-03-02 14:21:01,492 INFO [main] org.apache.hadoop.mapred.MapTask: Finished 
spill 0
2019-03-02 14:21:01,492 INFO [main] org.apache.hadoop.mapred.YarnChild: 
Exception running child: java.lang.ArrayIndexOutOfBoundsException:2
2019-03-02 14:21:01,492 INFO [main] org.apache.kylin.engine.mr.KylinReducer: Do 
cleanup, available memory: 1334m
 at 
org.apache.kylin.engine.mr.steps.FactDistinctColumnsMapper.doMap(FactDistinctColumnsMapper.java:177)
 at org.apache.kylin.engine.mr.KylinMapper.map(KylinMapper.java:77)
 at org.apache.hadoop.mapreduce.Mapper.run(MapperTask.java:146)
 at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:793)
 at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341)
 at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:187)
 at java.security.AccessController.doPrivileged(Native Method)
 at javax.security.auth.Subject.doAs(Subject.java:422)
 at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1781)
 at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java;180)
 
Then I find that in Kafka datasource, some streaming data lack the userId 
column. Most of the streaming data(contry, currency,userId) is 
("China","CNY","843c4d");but a small amount of data lack userId, some data is 
("China","CNY"). so when run the 3rd step("Extract Fact Table Distinct 
Columns"),MR engine will throw exception if the streaming data lack userId.

The I check the source of Kylin, FactDistinctColumnsMapper.java:

public void doMap(KEYIN key, Object record, Context context) throws 
IOException, InterruptedException {
 Collection rowCollection = 
flatTableInputFormat.parseMapperInput(record);

for (String[] row : rowCollection) {
 context.getCounter(RawDataCounter.BYTES).increment(countSizeInBytes(row));
 for (int i = 0; i < allCols.size(); i++) {
 String fieldValue = row[columnIndex[i]];
 if (fieldValue == null)
 continue;

final DataType type = allCols.get(i).getType();
 ...

I find that columnIndex[i] is equal with the size of row if the streaming data 
lack one column. So the row[columnIndex[i]] will throw the 
ArrayIndexOutOfBoundsException. So I change this code, check the columnIndex[i] 
and the size of row. If columnIndex[i] is equal with or larger than the size of 
row, I set fieldValue empty value. And After I change my code, the 3rd 
step("Extract Fact Table Distinct Columns") will run success.

Those are what I found, which will cause problem for developers.
How do you think?

Best regard
jintao



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] coveralls commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
coveralls commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499#issuecomment-469956847
 
 
   ## Pull Request Test Coverage Report for [Build 
4202](https://coveralls.io/builds/21994378)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.004%**) to **26.952%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21994378/badge)](https://coveralls.io/builds/21994378)
 |
   | :-- | --: |
   | Change from base [Build 4201](https://coveralls.io/builds/21985216): |  
0.004% |
   | Covered Lines: | 18960 |
   | Relevant Lines: | 70347 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls commented on issue #490: Added small Unit Tests

2019-03-05 Thread GitBox
coveralls commented on issue #490: Added small Unit Tests
URL: https://github.com/apache/kylin/pull/490#issuecomment-469950261
 
 
   ## Pull Request Test Coverage Report for [Build 
4200](https://coveralls.io/builds/21973360)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **1313** unchanged lines in **40** files lost coverage.
   * Overall coverage decreased (**-0.005%**) to **26.955%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/LogicalTupleFilter.java](https://coveralls.io/builds/21973360/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FLogicalTupleFilter.java#L78)
 | 1 | 45.21% |
   | 
[core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java](https://coveralls.io/builds/21973360/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHiveCmdBuilder.java#L100)
 | 1 | 86.11% |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21973360/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   | 
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/21973360/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
 | 1 | 47.62% |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java](https://coveralls.io/builds/21973360/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FConstantTupleFilter.java#L73)
 | 1 | 81.08% |
   | 
[core-metadata/src/main/java/org/apache/kylin/measure/topn/DoubleDeltaSerializer.java](https://coveralls.io/builds/21973360/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FDoubleDeltaSerializer.java#L145)
 | 2 | 97.92% |
   | 
[core-metadata/src/main/java/org/apache/kylin/measure/percentile/PercentileSerializer.java](https://coveralls.io/builds/21973360/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fpercentile%2FPercentileSerializer.java#L39)
 | 3 | 85.0% |
   | 
[core-job/src/main/java/org/apache/kylin/job/SchedulerFactory.java](https://coveralls.io/builds/21973360/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FSchedulerFactory.java#L24)
 | 4 | 0.0% |
   | 
[core-storage/src/main/java/org/apache/kylin/storage/StorageFactory.java](https://coveralls.io/builds/21973360/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2FStorageFactory.java#L29)
 | 4 | 54.55% |
   | 
[cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedChunkingCache.java](https://coveralls.io/builds/21973360/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fmemcached%2FMemcachedChunkingCache.java#L88)
 | 5 | 49.64% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21973360/badge)](https://coveralls.io/builds/21973360)
 |
   | :-- | --: |
   | Change from base [Build 4170](https://coveralls.io/builds/21871775): |  
-0.005% |
   | Covered Lines: | 18962 |
   | Relevant Lines: | 70347 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785165#comment-16785165
 ] 

ASF GitHub Bot commented on KYLIN-3842:
---

luguosheng1314 commented on pull request #500: KYLIN-3842 kylinProperties.js 
Unable to get the public configuration …
URL: https://github.com/apache/kylin/pull/500
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785166#comment-16785166
 ] 

ASF subversion and git services commented on KYLIN-3842:


Commit 0234301b68a3dab8952be2be4f51cb5c66043c48 in kylin's branch 
refs/heads/master from yuzhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=0234301 ]

KYLIN-3842 kylinProperties.js Unable to get the public configuration of the 
first line in the front end


> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] luguosheng1314 merged pull request #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

2019-03-05 Thread GitBox
luguosheng1314 merged pull request #500: KYLIN-3842 kylinProperties.js Unable 
to get the public configuration …
URL: https://github.com/apache/kylin/pull/500
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls edited a comment on issue #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler

2019-03-05 Thread GitBox
coveralls edited a comment on issue #491: KYLIN-3820 KYLIN-3834 Add a 
curator-based scheduler 
URL: https://github.com/apache/kylin/pull/491#issuecomment-468589908
 
 
   ## Pull Request Test Coverage Report for [Build 
4197](https://coveralls.io/builds/21964549)
   
   * **114** of **177**   **(64.41%)**  changed or added relevant lines in 
**4** files are covered.
   * **9** unchanged lines in **5** files lost coverage.
   * Overall coverage increased (+**0.09%**) to **27.045%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/21964549/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L366)
 | 0 | 4 | 0.0%
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorLeaderSelector.java](https://coveralls.io/builds/21964549/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorLeaderSelector.java#L56)
 | 30 | 43 | 69.77%
   | 
[core-common/src/main/java/org/apache/kylin/common/ServerMode.java](https://coveralls.io/builds/21964549/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FServerMode.java#L21)
 | 0 | 17 | 0.0%
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java](https://coveralls.io/builds/21964549/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorScheduler.java#L89)
 | 84 | 113 | 74.34%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/LogicalTupleFilter.java](https://coveralls.io/builds/21964549/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FLogicalTupleFilter.java#L78)
 | 1 | 45.21% |
   | 
[core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java](https://coveralls.io/builds/21964549/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHiveCmdBuilder.java#L100)
 | 1 | 86.11% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21964549/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553)
 | 1 | 78.12% |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java](https://coveralls.io/builds/21964549/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FConstantTupleFilter.java#L73)
 | 1 | 81.08% |
   | 
[cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedChunkingCache.java](https://coveralls.io/builds/21964549/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fmemcached%2FMemcachedChunkingCache.java#L88)
 | 5 | 49.64% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21964549/badge)](https://coveralls.io/builds/21964549)
 |
   | :-- | --: |
   | Change from base [Build 4187](https://coveralls.io/builds/21942261): |  
0.09% |
   | Covered Lines: | 18830 |
   | Relevant Lines: | 69625 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls edited a comment on issue #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler

2019-03-05 Thread GitBox
coveralls edited a comment on issue #491: KYLIN-3820 KYLIN-3834 Add a 
curator-based scheduler 
URL: https://github.com/apache/kylin/pull/491#issuecomment-468589908
 
 
   ## Pull Request Test Coverage Report for [Build 
4196](https://coveralls.io/builds/21963996)
   
   * **114** of **177**   **(64.41%)**  changed or added relevant lines in 
**4** files are covered.
   * **68** unchanged lines in **9** files lost coverage.
   * Overall coverage increased (+**0.08%**) to **27.042%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/21963996/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L366)
 | 0 | 4 | 0.0%
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorLeaderSelector.java](https://coveralls.io/builds/21963996/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorLeaderSelector.java#L56)
 | 30 | 43 | 69.77%
   | 
[core-common/src/main/java/org/apache/kylin/common/ServerMode.java](https://coveralls.io/builds/21963996/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FServerMode.java#L21)
 | 0 | 17 | 0.0%
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java](https://coveralls.io/builds/21963996/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorScheduler.java#L89)
 | 84 | 113 | 74.34%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/LogicalTupleFilter.java](https://coveralls.io/builds/21963996/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FLogicalTupleFilter.java#L78)
 | 1 | 45.21% |
   | 
[core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java](https://coveralls.io/builds/21963996/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHiveCmdBuilder.java#L100)
 | 1 | 86.11% |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21963996/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   | 
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/21963996/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
 | 1 | 47.62% |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java](https://coveralls.io/builds/21963996/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FConstantTupleFilter.java#L73)
 | 1 | 81.08% |
   | 
[cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedChunkingCache.java](https://coveralls.io/builds/21963996/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fmemcached%2FMemcachedChunkingCache.java#L88)
 | 5 | 49.64% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21963996/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/BulkLoadJob.java](https://coveralls.io/builds/21963996/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FBulkLoadJob.java#L42)
 | 24 | 0.0% |
   | 
[core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java](https://coveralls.io/builds/21963996/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FStringUtil.java#L79)
 | 29 | 20.62% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21963996/badge)](https://coveralls.io/builds/21963996)
 |
   | :-- | --: |
   | Change from base [Build 4170](https://coveralls.io/builds/21871775): |  
0.08% |
   | Covered Lines: | 18828 |
   | Relevant Lines: | 69625 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls commented on issue #497: KYLIN-3795 Submit Spark jobs via Apache Livy

2019-03-05 Thread GitBox
coveralls commented on issue #497: KYLIN-3795 Submit Spark jobs via Apache Livy
URL: https://github.com/apache/kylin/pull/497#issuecomment-469937703
 
 
   ## Pull Request Test Coverage Report for [Build 
4194](https://coveralls.io/builds/21962172)
   
   * **0** of **481**   **(0.0%)**  changed or added relevant lines in **15** 
files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.2%**) to **26.772%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseSparkSteps.java](https://coveralls.io/builds/21962172/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHBaseSparkSteps.java#L43)
 | 0 | 1 | 0.0%
   | 
[core-common/src/main/java/org/apache/kylin/common/livy/LivyStateEnum.java](https://coveralls.io/builds/21962172/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Flivy%2FLivyStateEnum.java#L23)
 | 0 | 2 | 0.0%
   | 
[core-common/src/main/java/org/apache/kylin/common/livy/LivyTypeEnum.java](https://coveralls.io/builds/21962172/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Flivy%2FLivyTypeEnum.java#L23)
 | 0 | 2 | 0.0%
   | 
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkBatchCubingJobBuilder2.java](https://coveralls.io/builds/21962172/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkBatchCubingJobBuilder2.java#L91)
 | 0 | 2 | 0.0%
   | 
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkBatchMergeJobBuilder2.java](https://coveralls.io/builds/21962172/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkBatchMergeJobBuilder2.java#L80)
 | 0 | 2 | 0.0%
   | 
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutableFactory.java](https://coveralls.io/builds/21962172/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutableFactory.java#L24)
 | 0 | 3 | 0.0%
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/21962172/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1369)
 | 0 | 5 | 0.0%
   | 
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkSqlOnLivyBatch.scala](https://coveralls.io/builds/21962172/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkSqlOnLivyBatch.scala#L26)
 | 0 | 14 | 0.0%
   | 
[source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/21962172/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L88)
 | 0 | 25 | 0.0%
   | 
[source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableByLivyStep.java](https://coveralls.io/builds/21962172/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCreateFlatHiveTableByLivyStep.java#L50)
 | 0 | 42 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21962172/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553)
 | 1 | 78.12% |
   | 
[source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/21962172/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L115)
 | 1 | 14.29% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21962172/badge)](https://coveralls.io/builds/21962172)
 |
   | :-- | --: |
   | Change from base [Build 4187](https://coveralls.io/builds/21942261): |  
-0.2% |
   | Covered Lines: | 18719 |
   | Relevant Lines: | 69921 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

2019-03-05 Thread GitBox
codecov-io commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration …
URL: https://github.com/apache/kylin/pull/500#issuecomment-469935346
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/500?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@69c2c17`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/500/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/500?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #500   +/-   ##
   =
 Coverage  ?   24.47%   
 Complexity? 5029   
   =
 Files ? 1161   
 Lines ?70347   
 Branches  ?10014   
   =
 Hits  ?17217   
 Misses?51390   
 Partials  ? 1740
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/500?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/500?src=pr=footer). Last 
update 
[69c2c17...3690c68](https://codecov.io/gh/apache/kylin/pull/500?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785132#comment-16785132
 ] 

ASF GitHub Bot commented on KYLIN-3842:
---

Qsimple commented on pull request #500: KYLIN-3842 kylinProperties.js Unable to 
get the public configuration …
URL: https://github.com/apache/kylin/pull/500
 
 
   sorry for the last pr, please check this one
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785135#comment-16785135
 ] 

ASF GitHub Bot commented on KYLIN-3842:
---

Qsimple commented on pull request #499: KYLIN-3842 kylinProperties.js Unable to 
get the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3788) Kylin's internal time zone conversions are various and confusing

2019-03-05 Thread zhao jintao (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

zhao jintao updated KYLIN-3788:
---
Description: 
Hi, All team

I found that Kylin has a variety of time zone conversions inside, which is 
confusing. In some code, the time zone is "GMT" when converting time, and some 
code uses the time zone specified in the configuration file 
("TimeZone.getTimeZone("GMT")" );

For Example:

in CubingJob.java, use TimeZone from configuration file:  
format.setTimeZone(TimeZone.getTimeZone(

config.getTimeZone())),

but in TimeUtil.java, use GMT TimeZone:private static TimeZone gmt = 
TimeZone.getTimeZone("GMT")

 

When inport data from Kafka Streaming Data,kylin generate "Data_Start", 
"Hour_Start" uses the GMT time zone,  They are  some time zones later than the 
real time. Why not use the time zone specified in the configuration file?

  was:
I found that Kylin has a variety of time zone conversions inside, which is 
confusing. In some code, the time zone is "GMT" when converting time, and some 
code uses the time zone specified in the configuration file 
("TimeZone.getTimeZone("GMT")" );

For Example:

in CubingJob.java, use TimeZone from configuration file:  
format.setTimeZone(TimeZone.getTimeZone(

config.getTimeZone())),

but in TimeUtil.java, use GMT TimeZone:private static TimeZone gmt = 
TimeZone.getTimeZone("GMT")

 

When inport data from Kafka Streaming Data,kylin generate "Data_Start", 
"Hour_Start" uses the GMT time zone,  They are  some time zones later than the 
real time. Why not use the time zone specified in the configuration file?


>  Kylin's internal time zone conversions are various and confusing
> -
>
> Key: KYLIN-3788
> URL: https://issues.apache.org/jira/browse/KYLIN-3788
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service, Web 
>Affects Versions: v2.5.2
> Environment: Huawei FI
>Reporter: zhao jintao
>Priority: Major
>  Labels: TimeZone
>
> Hi, All team
> I found that Kylin has a variety of time zone conversions inside, which is 
> confusing. In some code, the time zone is "GMT" when converting time, and 
> some code uses the time zone specified in the configuration file 
> ("TimeZone.getTimeZone("GMT")" );
> For Example:
> in CubingJob.java, use TimeZone from configuration file:  
> format.setTimeZone(TimeZone.getTimeZone(
> config.getTimeZone())),
> but in TimeUtil.java, use GMT TimeZone:private static TimeZone gmt = 
> TimeZone.getTimeZone("GMT")
>  
> When inport data from Kafka Streaming Data,kylin generate "Data_Start", 
> "Hour_Start" uses the GMT time zone,  They are  some time zones later than 
> the real time. Why not use the time zone specified in the configuration file?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (KYLIN-3788) Kylin's internal time zone conversions are various and confusing

2019-03-05 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784376#comment-16784376
 ] 

zhao jintao edited comment on KYLIN-3788 at 3/6/19 1:34 AM:


I found that hour_start is 8 hours behind the real time.Day_start is also 8 
behind the real time. I fix this bug. And I want to push my code to github.


was (Author: zhao jintao):
I found that hour_start is 8 hours behind the real time.Day_start is also 8 
behind the real time. I deal this bugfix. And I want to push my code to github.

>  Kylin's internal time zone conversions are various and confusing
> -
>
> Key: KYLIN-3788
> URL: https://issues.apache.org/jira/browse/KYLIN-3788
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service, Web 
>Affects Versions: v2.5.2
> Environment: Huawei FI
>Reporter: zhao jintao
>Priority: Major
>  Labels: TimeZone
>
> I found that Kylin has a variety of time zone conversions inside, which is 
> confusing. In some code, the time zone is "GMT" when converting time, and 
> some code uses the time zone specified in the configuration file 
> ("TimeZone.getTimeZone("GMT")" );
> For Example:
> in CubingJob.java, use TimeZone from configuration file:  
> format.setTimeZone(TimeZone.getTimeZone(
> config.getTimeZone())),
> but in TimeUtil.java, use GMT TimeZone:private static TimeZone gmt = 
> TimeZone.getTimeZone("GMT")
>  
> When inport data from Kafka Streaming Data,kylin generate "Data_Start", 
> "Hour_Start" uses the GMT time zone,  They are  some time zones later than 
> the real time. Why not use the time zone specified in the configuration file?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] Qsimple commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

2019-03-05 Thread GitBox
Qsimple commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration …
URL: https://github.com/apache/kylin/pull/500#issuecomment-469929591
 
 
   improve input parameter check.
   remove '\n' before key string for parttern match


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] Qsimple commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
Qsimple commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499#issuecomment-469929478
 
 
   sorry for that, I submit another pull request and close this one


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] Qsimple closed pull request #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
Qsimple closed pull request #499: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asfgit commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

2019-03-05 Thread GitBox
asfgit commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get the 
public configuration …
URL: https://github.com/apache/kylin/pull/500#issuecomment-469929152
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] Qsimple opened a new pull request #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

2019-03-05 Thread GitBox
Qsimple opened a new pull request #500: KYLIN-3842 kylinProperties.js Unable to 
get the public configuration …
URL: https://github.com/apache/kylin/pull/500
 
 
   sorry for the last pr, please check this one


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls edited a comment on issue #495: KYLIN-3818 After Cube disabled, auto-merge cube job still running

2019-03-05 Thread GitBox
coveralls edited a comment on issue #495: KYLIN-3818 After Cube disabled, 
auto-merge cube job still running
URL: https://github.com/apache/kylin/pull/495#issuecomment-469800693
 
 
   ## Pull Request Test Coverage Report for [Build 
4190](https://coveralls.io/builds/21953069)
   
   * **1** of **1**   **(100.0%)**  changed or added relevant line in **1** 
file are covered.
   * **94** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.002%**) to **26.955%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21953069/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/21953069/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L658)
 | 89 | 0.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21953069/badge)](https://coveralls.io/builds/21953069)
 |
   | :-- | --: |
   | Change from base [Build 4187](https://coveralls.io/builds/21942261): |  
0.002% |
   | Covered Lines: | 18720 |
   | Relevant Lines: | 69449 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls commented on issue #495: KYLIN-3818 After Cube disabled, auto-merge cube job still running

2019-03-05 Thread GitBox
coveralls commented on issue #495: KYLIN-3818 After Cube disabled, auto-merge 
cube job still running
URL: https://github.com/apache/kylin/pull/495#issuecomment-469800693
 
 
   ## Pull Request Test Coverage Report for [Build 
4195](https://coveralls.io/builds/21963310)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at ?**%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21963310/badge)](https://coveralls.io/builds/21963310)
 |
   | :-- | --: |
   | Change from base [Build 4187](https://coveralls.io/builds/21942261): |  
0.0% |
   | Covered Lines: |  |
   | Relevant Lines: | 0 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] shaofengshi commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
shaofengshi commented on issue #499: KYLIN-3842 kylinProperties.js Unable to 
get the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499#issuecomment-469690544
 
 
   Please keep the PR clean, only 1 or 2 commits are allowed, and no merge 
commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
codecov-io commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499#issuecomment-469672932
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/499?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@69c2c17`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/499/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/499?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #499   +/-   ##
   =
 Coverage  ?   24.47%   
 Complexity? 5029   
   =
 Files ? 1161   
 Lines ?70347   
 Branches  ?10014   
   =
 Hits  ?17216   
 Misses?51391   
 Partials  ? 1740
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/499?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/499?src=pr=footer). Last 
update 
[69c2c17...aedc39f](https://codecov.io/gh/apache/kylin/pull/499?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784385#comment-16784385
 ] 

ASF GitHub Bot commented on KYLIN-3842:
---

Qsimple commented on pull request #499: KYLIN-3842 kylinProperties.js Unable to 
get the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499
 
 
   1. improve input parameter check. 
   2. remove '\n' before key string for parttern match
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] asfgit commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
asfgit commented on issue #499: KYLIN-3842 kylinProperties.js Unable to get the 
public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499#issuecomment-469666011
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] Qsimple opened a new pull request #499: KYLIN-3842 kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread GitBox
Qsimple opened a new pull request #499: KYLIN-3842 kylinProperties.js Unable to 
get the public configuration of the first line in the front end
URL: https://github.com/apache/kylin/pull/499
 
 
   1. improve input parameter check. 
   2. remove '\n' before key string for parttern match


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Comment Edited] (KYLIN-3788) Kylin's internal time zone conversions are various and confusing

2019-03-05 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784376#comment-16784376
 ] 

zhao jintao edited comment on KYLIN-3788 at 3/5/19 12:33 PM:
-

I found that hour_start is 8 hours behind the real time.Day_start is also 8 
behind the real time. I deal this bugfix. And I want to push my code to github.


was (Author: zhao jintao):
I found that hour_start is 8 hours behind the real time.Day_start is also 8 
behind the real time. I deal this bugfix. 

>  Kylin's internal time zone conversions are various and confusing
> -
>
> Key: KYLIN-3788
> URL: https://issues.apache.org/jira/browse/KYLIN-3788
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service, Web 
>Affects Versions: v2.5.2
> Environment: Huawei FI
>Reporter: zhao jintao
>Priority: Major
>  Labels: TimeZone
>
> I found that Kylin has a variety of time zone conversions inside, which is 
> confusing. In some code, the time zone is "GMT" when converting time, and 
> some code uses the time zone specified in the configuration file 
> ("TimeZone.getTimeZone("GMT")" );
> For Example:
> in CubingJob.java, use TimeZone from configuration file:  
> format.setTimeZone(TimeZone.getTimeZone(
> config.getTimeZone())),
> but in TimeUtil.java, use GMT TimeZone:private static TimeZone gmt = 
> TimeZone.getTimeZone("GMT")
>  
> When inport data from Kafka Streaming Data,kylin generate "Data_Start", 
> "Hour_Start" uses the GMT time zone,  They are  some time zones later than 
> the real time. Why not use the time zone specified in the configuration file?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3788) Kylin's internal time zone conversions are various and confusing

2019-03-05 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784376#comment-16784376
 ] 

zhao jintao commented on KYLIN-3788:


I found that hour_start is 8 hours behind the real time.Day_start is also 8 
behind the real time. I deal this bugfix. 

>  Kylin's internal time zone conversions are various and confusing
> -
>
> Key: KYLIN-3788
> URL: https://issues.apache.org/jira/browse/KYLIN-3788
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service, Web 
>Affects Versions: v2.5.2
> Environment: Huawei FI
>Reporter: zhao jintao
>Priority: Major
>  Labels: TimeZone
>
> I found that Kylin has a variety of time zone conversions inside, which is 
> confusing. In some code, the time zone is "GMT" when converting time, and 
> some code uses the time zone specified in the configuration file 
> ("TimeZone.getTimeZone("GMT")" );
> For Example:
> in CubingJob.java, use TimeZone from configuration file:  
> format.setTimeZone(TimeZone.getTimeZone(
> config.getTimeZone())),
> but in TimeUtil.java, use GMT TimeZone:private static TimeZone gmt = 
> TimeZone.getTimeZone("GMT")
>  
> When inport data from Kafka Streaming Data,kylin generate "Data_Start", 
> "Hour_Start" uses the GMT time zone,  They are  some time zones later than 
> the real time. Why not use the time zone specified in the configuration file?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3319) exceeds threshold 5000000 while executing SQL

2019-03-05 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784334#comment-16784334
 ] 

zhao jintao commented on KYLIN-3319:


Hi May Zhou; What's May Zhou's view is currect. You can set 
kylin.query.max-return-row

> exceeds threshold 500 while executing SQL
> -
>
> Key: KYLIN-3319
> URL: https://issues.apache.org/jira/browse/KYLIN-3319
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.3.0
>Reporter: cc
>Priority: Blocker
> Attachments: image.png, sql_limit_result.png
>
>
> {color:#d04437}hello,what is the reason of the errors?{color}
> {color:#d04437}Query returned 5008662 rows exceeds threshold 500 while 
> executing SQL: "select * from USER_FREQ_DAY_TEST LIMIT 5"{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3762) 构建cube出现error

2019-03-05 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784332#comment-16784332
 ] 

zhao jintao commented on KYLIN-3762:


这是构建的哪一步出现的?

> 构建cube出现error 
> --
>
> Key: KYLIN-3762
> URL: https://issues.apache.org/jira/browse/KYLIN-3762
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.5.2
>Reporter: 王振强
>Priority: Blocker
> Attachments: mr_error_log.jpg
>
>
> 构建cube出现error,以下是mr的log
> 2019-01-09 14:06:43,552 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.Fetcher: fetcher#1 about to shuffle 
> output of map attempt_1544413042966_0495_m_02_0 decomp: 59732393 len: 
> 9306880 to MEMORY
> 2019-01-09 14:06:43,595 INFO [fetcher#2] 
> org.apache.hadoop.mapreduce.task.reduce.Fetcher: fetcher#2 about to shuffle 
> output of map attempt_1544413042966_0495_m_03_0 decomp: 61855877 len: 
> 9709575 to MEMORY
> 2019-01-09 14:06:43,625 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.InMemoryMapOutput: Read 59732393 
> bytes from map-output for attempt_1544413042966_0495_m_02_0
> 2019-01-09 14:06:43,625 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: closeInMemoryFile 
> -> map-output of size: 59732393, inMemoryMapOutputs.size() -> 1, commitMemory 
> -> 0, usedMemory ->121588270
> 2019-01-09 14:06:43,872 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.Fetcher: fetcher#1 about to shuffle 
> output of map attempt_1544413042966_0495_m_01_0 decomp: 60219839 len: 
> 9341252 to MEMORY
> 2019-01-09 14:06:43,889 INFO [fetcher#2] 
> org.apache.hadoop.mapreduce.task.reduce.InMemoryMapOutput: Read 61855877 
> bytes from map-output for attempt_1544413042966_0495_m_03_0
> 2019-01-09 14:06:43,889 INFO [fetcher#2] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: closeInMemoryFile 
> -> map-output of size: 61855877, inMemoryMapOutputs.size() -> 2, commitMemory 
> -> 59732393, usedMemory ->181808109
> 2019-01-09 14:06:43,889 INFO [fetcher#2] 
> org.apache.hadoop.mapreduce.task.reduce.ShuffleSchedulerImpl: ap-cdh04:13562 
> freed by fetcher#2 in 579ms
> 2019-01-09 14:06:43,938 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.InMemoryMapOutput: Read 60219839 
> bytes from map-output for attempt_1544413042966_0495_m_01_0
> 2019-01-09 14:06:43,938 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: closeInMemoryFile 
> -> map-output of size: 60219839, inMemoryMapOutputs.size() -> 3, commitMemory 
> -> 121588270, usedMemory ->181808109
> 2019-01-09 14:06:43,949 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.Fetcher: fetcher#1 about to shuffle 
> output of map attempt_1544413042966_0495_m_00_0 decomp: 61659651 len: 
> 9657307 to MEMORY
> 2019-01-09 14:06:43,994 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.InMemoryMapOutput: Read 61659651 
> bytes from map-output for attempt_1544413042966_0495_m_00_0
> 2019-01-09 14:06:43,995 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: closeInMemoryFile 
> -> map-output of size: 61659651, inMemoryMapOutputs.size() -> 4, commitMemory 
> -> 181808109, usedMemory ->243467760
> 2019-01-09 14:06:43,995 INFO [fetcher#1] 
> org.apache.hadoop.mapreduce.task.reduce.ShuffleSchedulerImpl: ap-cdh03:13562 
> freed by fetcher#1 in 685ms
> 2019-01-09 14:06:44,001 INFO [EventFetcher for fetching Map Completion 
> Events] org.apache.hadoop.mapreduce.task.reduce.EventFetcher: EventFetcher is 
> interrupted.. Returning
> 2019-01-09 14:06:44,014 INFO [main] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: finalMerge called 
> with 4 in-memory map-outputs and 0 on-disk map-outputs
> 2019-01-09 14:06:44,024 INFO [main] org.apache.hadoop.mapred.Merger: Merging 
> 4 sorted segments
> 2019-01-09 14:06:44,026 INFO [main] org.apache.hadoop.mapred.Merger: Down to 
> the last merge-pass, with 4 segments left of total size: 243467522 bytes
> 2019-01-09 14:06:47,997 INFO [main] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: Merged 4 segments, 
> 243467760 bytes to disk to satisfy reduce memory limit
> 2019-01-09 14:06:47,998 INFO [main] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: Merging 1 files, 
> 35816160 bytes from disk
> 2019-01-09 14:06:47,998 INFO [main] 
> org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl: Merging 0 segments, 
> 0 bytes from memory into reduce
> 2019-01-09 14:06:47,999 INFO [main] org.apache.hadoop.mapred.Merger: Merging 
> 1 sorted segments
> 2019-01-09 14:06:48,004 INFO [main] org.apache.hadoop.mapred.Merger: Down to 
> the last merge-pass, with 1 segments left of total size: 243467668 bytes
> ^@^A^@^@^V^@
>  
> 

[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784245#comment-16784245
 ] 

Shaofeng SHI commented on KYLIN-3842:
-

Awsome, thank you Yuzhang!

> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread Yuzhang QIU (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784244#comment-16784244
 ] 

Yuzhang QIU commented on KYLIN-3842:


Yes, I'll commit bugfix through pull request shortly.

> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3842) kylinProperties.js Unable to get the public configuration of the first line in the front end

2019-03-05 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784237#comment-16784237
 ] 

Shaofeng SHI commented on KYLIN-3842:
-

It is a bug; Would you like to contribute a patch? Thank you!

> kylinProperties.js Unable to get the public configuration of the first line 
> in the front end
> 
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi dear team:
>   I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found 
> that kylinProperties.js:37(getProperty(name)) can't get the property of the 
> first line in the '_config' which initialized through /admin/public_config. 
>   For example, the public config is 
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'.  I expected to get 20 
> but got '' when I want to get config by key 
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by 
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at 
> kylinProperties.js:37) return -1 for those names before which don't have an 
> \n(at the first line).
>   Then, I debug the AdminService.java, KylinConfig.java and found that the  
> KylinConfig.java:517(around this line, in method 
> exportToString(Collection propertyKeys)) build the public config 
> string with a char '\n' after each property, which cause the first property 
> don't has '\n' before it.
>   Those are what I found, which will cause problem for developers.
>   How do you think? 
> Best regard
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3808) RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and exec_interrupt_time fields

2019-03-05 Thread yaozq (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784227#comment-16784227
 ] 

yaozq commented on KYLIN-3808:
--

Sorry for the mistake! I update the repo and create a new 
[patch|[^0001-KYLIN-3808-fix-RestAPI-api-jobs-always-returns-0-for.patch].] 
Please review the code![~Shaofengshi]

> RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and 
> exec_interrupt_time fields
> ---
>
> Key: KYLIN-3808
> URL: https://issues.apache.org/jira/browse/KYLIN-3808
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Affects Versions: v2.5.2
>Reporter: yaozq
>Assignee: yaozq
>Priority: Minor
> Fix For: v2.6.2
>
> Attachments: 
> 0001-KYLIN-3808-fix-RestAPI-api-jobs-always-returns-0-for.patch
>
>
> GET 
> [http://kylin-host:7070/kylin/api/jobs?cubeName=xxx=0=0=1]
> [
> {
> "uuid":"a89cf2d4-caaf-21fe-5cb9-63f1725d0e02",
> "last_modified":1549917430155,
> "version":"2.5.2.20500",
> "name":"BUILD CUBE - - 2019021100_2019021200 - GMT+08:00 
> 2019-02-12 04:10:32",
> "type":"BUILD",
> "duration":1583,
> "related_cube":"",
> "display_cube_name":"",
> "related_segment":"898fc7c8-5e30-927c-da26-816ab4dbff08",
> {color:#FF}"exec_start_time":0,{color}
> {color:#FF}"exec_end_time":0,{color}
> {color:#FF}"exec_interrupt_time":0,{color}
> "mr_waiting":179,
> ..
>  
>  exec_start_time, exec_end_time and exec_interrupt_time fields always return 0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3808) RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and exec_interrupt_time fields

2019-03-05 Thread yaozq (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yaozq updated KYLIN-3808:
-
Attachment: 0001-KYLIN-3808-fix-RestAPI-api-jobs-always-returns-0-for.patch

> RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and 
> exec_interrupt_time fields
> ---
>
> Key: KYLIN-3808
> URL: https://issues.apache.org/jira/browse/KYLIN-3808
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Affects Versions: v2.5.2
>Reporter: yaozq
>Assignee: yaozq
>Priority: Minor
> Fix For: v2.6.2
>
> Attachments: 
> 0001-KYLIN-3808-fix-RestAPI-api-jobs-always-returns-0-for.patch
>
>
> GET 
> [http://kylin-host:7070/kylin/api/jobs?cubeName=xxx=0=0=1]
> [
> {
> "uuid":"a89cf2d4-caaf-21fe-5cb9-63f1725d0e02",
> "last_modified":1549917430155,
> "version":"2.5.2.20500",
> "name":"BUILD CUBE - - 2019021100_2019021200 - GMT+08:00 
> 2019-02-12 04:10:32",
> "type":"BUILD",
> "duration":1583,
> "related_cube":"",
> "display_cube_name":"",
> "related_segment":"898fc7c8-5e30-927c-da26-816ab4dbff08",
> {color:#FF}"exec_start_time":0,{color}
> {color:#FF}"exec_end_time":0,{color}
> {color:#FF}"exec_interrupt_time":0,{color}
> "mr_waiting":179,
> ..
>  
>  exec_start_time, exec_end_time and exec_interrupt_time fields always return 0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3808) RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and exec_interrupt_time fields

2019-03-05 Thread yaozq (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yaozq updated KYLIN-3808:
-
Attachment: (was: 
fix_RestAPI__api_jobs_always_returns_0_for_exec_start_time_and_exec_end_time_and_exec_inte.patch)

> RestAPI /api/jobs always returns 0 for exec_start_time and exec_end_time and 
> exec_interrupt_time fields
> ---
>
> Key: KYLIN-3808
> URL: https://issues.apache.org/jira/browse/KYLIN-3808
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Affects Versions: v2.5.2
>Reporter: yaozq
>Assignee: yaozq
>Priority: Minor
> Fix For: v2.6.2
>
>
> GET 
> [http://kylin-host:7070/kylin/api/jobs?cubeName=xxx=0=0=1]
> [
> {
> "uuid":"a89cf2d4-caaf-21fe-5cb9-63f1725d0e02",
> "last_modified":1549917430155,
> "version":"2.5.2.20500",
> "name":"BUILD CUBE - - 2019021100_2019021200 - GMT+08:00 
> 2019-02-12 04:10:32",
> "type":"BUILD",
> "duration":1583,
> "related_cube":"",
> "display_cube_name":"",
> "related_segment":"898fc7c8-5e30-927c-da26-816ab4dbff08",
> {color:#FF}"exec_start_time":0,{color}
> {color:#FF}"exec_end_time":0,{color}
> {color:#FF}"exec_interrupt_time":0,{color}
> "mr_waiting":179,
> ..
>  
>  exec_start_time, exec_end_time and exec_interrupt_time fields always return 0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'

2019-03-05 Thread Yuzhang QIU (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784207#comment-16784207
 ] 

Yuzhang QIU commented on KYLIN-3844:


And for extensibility and robustness, Implementing a interface of extending an 
abstract class for hbaseMappingAdapter may be more appropriate rather then any 
class which contain static method 'initHBaseMapping(CubeDesc)' and 
'initMeasureReferenceToColumnFailyWithChecking(CubeDesc)'.

> some instruction about config 'kylin.metadata.hbasemapping-adapter'
> ---
>
> Key: KYLIN-3844
> URL: https://issues.apache.org/jira/browse/KYLIN-3844
> Project: Kylin
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Minor
>
> Hi team:
> When someone want to self-define hbase column family mapping, they may 
> need to know how to config 'kylin.metadata.hbasemapping-adapter'.
> Although tracing the code at CubeDesc:around 678 will show the usage of 
> this configuration, some official instruction in document may be better.
> Just a small suggestion. :)
>   
>Best regards
>   
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)