[GitHub] [kylin] GuoNingNing commented on issue #624: Allow user-specified time format using real-time

2019-04-29 Thread GitBox
GuoNingNing commented on issue #624: Allow user-specified time format using 
real-time
URL: https://github.com/apache/kylin/pull/624#issuecomment-487814406
 
 
   I am really sorry, this is the first time I submitted the source code to the 
open source community. I skipped checkstyle, and now this version has been 
checked by checkstyle.xml.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] nichunen commented on issue #582: Read password from file for Beeline

2019-04-29 Thread GitBox
nichunen commented on issue #582: Read password from file for Beeline
URL: https://github.com/apache/kylin/pull/582#issuecomment-487806832
 
 
   @dekarlab Hi, your pr build failed due to
   [ERROR] Forbidden class/interface use: java.io.FileReader [Uses default 
charset]
   [ERROR]   in org.apache.kylin.source.hive.BeelineHiveClient 
(BeelineHiveClient.java:69)
   reliance on default encoding of reader is not recommended in Kylin
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (KYLIN-3988) Weighted Average does not work on cube

2019-04-29 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-3988.
-
Resolution: Invalid

> Weighted Average does not work on cube
> --
>
> Key: KYLIN-3988
> URL: https://issues.apache.org/jira/browse/KYLIN-3988
> Project: Kylin
>  Issue Type: Bug
>  Components: Driver - ODBC
>Affects Versions: v2.6.1
>Reporter: Anoop Krishnaswamy
>Priority: Critical
>
> When we try to get aggregate over multiplication of 2 metrics it throws an 
> error:
> That both of the two sides of the BinaryTupleExpression own columns is not 
> supported for * while executing SQL: "select 
> sum(riskscoreinitial*cyc_xxx_balanceAdb), cyc_xxx_cyclesdelinquent from 
> fct_profit_table_monthly group by cyc_xxx_cyclesdelinquent LIMIT 5"
>  
> My query looks something like this :
>  
> select sum(*),  from  group by 
> Any guidance will help



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3993) Sum over a case statement fails with integer data type

2019-04-29 Thread Chao Long (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829898#comment-16829898
 ] 

Chao Long commented on KYLIN-3993:
--

Hi [~anoop.krishnaswamy], 

Is the return type of sum measure the same as the real type of column 
'accountmonthsopen'?

If not, you can take a look at this issue KYLIN-3957, it's similar to yours.

> Sum over a case statement fails with integer data type
> --
>
> Key: KYLIN-3993
> URL: https://issues.apache.org/jira/browse/KYLIN-3993
> Project: Kylin
>  Issue Type: Bug
>  Components: Driver - ODBC
>Affects Versions: v2.6.1
>Reporter: Anoop Krishnaswamy
>Priority: Major
>
> Hi,
> When we use sum over a case statement, it works when the field is of a 
> certain type like decimal(19,3). But the same fails when used with integer 
> field:
> This works:
> select sum(case when balance_indicator='1' then cyc_xxx_balanceadbavg else 0 
> end) , balance_indicator from fct_profit_table_quarterly
> group by balance_indicator
> Whereas the below sql fails
> select sum(case when balance_indicator='1' then accountmonthsopen else 0 end) 
> , balance_indicator from fct_profit_table_quarterly
> group by balance_indicator
>  
> with the error message:
> {color:#b94a48}java.math.BigDecimal cannot be cast to java.lang.Integer while 
> executing SQL: "select sum(case when balance_indicator='1' then 
> accountmonthsopen else 0 end) , balance_indicator from 
> fct_profit_table_quarterly group by balance_indicator LIMIT 5"{color}
>  
> {color:#b94a48}The difference between 1st sql and 2nd sql being - in the 
> first query the metric used in the case statement is of decimal(19,4) and the 
> metric used in 2nd statement is of type int.{color}
>  
> {color:#b94a48}Kindly help{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web

2019-04-29 Thread Jack (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829893#comment-16829893
 ] 

Jack commented on KYLIN-3968:
-

[~nichunen] It's my pleasure :) . Thank you for your advise and help. 

> Customized precision doesn't work in web
> 
>
> Key: KYLIN-3968
> URL: https://issues.apache.org/jira/browse/KYLIN-3968
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Jack
>Priority: Minor
> Fix For: v2.6.2
>
>
> In the cubeMeasures.js, It will withdraw precision and scale by using Regular 
> Expression. The scale parameter is ok, but precision use the magic number 19.
> So we fixed it, In cubeMeasures.js, around line 469:
> “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
> and we test ok including building cube and querying when the column is 
> decimal(38,18).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] nichunen commented on issue #582: Read password from file for Beeline

2019-04-29 Thread GitBox
nichunen commented on issue #582: Read password from file for Beeline
URL: https://github.com/apache/kylin/pull/582#issuecomment-487801156
 
 
   Jenkins, test this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3957) Query system_cube get exception Cannot cast "java.math.BigDecimal" to "java.lang.Double"

2019-04-29 Thread Chao Long (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chao Long updated KYLIN-3957:
-
Affects Version/s: v2.6.1

> Query system_cube get exception Cannot cast "java.math.BigDecimal" to 
> "java.lang.Double"
> 
>
> Key: KYLIN-3957
> URL: https://issues.apache.org/jira/browse/KYLIN-3957
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.6.1
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v3.0.0, v2.6.2
>
>
> In system cube, the return dataType of column whose real dataType is Double 
> will be converted to Decimal in SUM measure.
> {code:java}
> FunctionDesc function = new FunctionDesc();
> function.setExpression(FunctionDesc.FUNC_SUM);
> function.setParameter(parameterDesc);
> 
> function.setReturnType(dataType.equals(HiveTableCreator.HiveTypeEnum.HDOUBLE.toString())
> ? HiveTableCreator.HiveTypeEnum.HDECIMAL.toString()
> : dataType);
> {code}
> but query with that measure will get exception:
> {code}
> Caused by: org.codehaus.commons.compiler.CompileException: Line 108, Column 
> 44: Cannot cast "java.math.BigDecimal" to "java.lang.Double"
>   at 
> org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:10092)
>   at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:3839)
>   at org.codehaus.janino.UnitCompiler.access$6400(UnitCompiler.java:183)
>   at org.codehaus.janino.UnitCompiler$10.visitCast(UnitCompiler.java:3246)
>   at org.codehaus.janino.Java$Cast.accept(Java.java:3802)
>   at org.codehaus.janino.UnitCompiler.compileGet(UnitCompiler.java:3278)
>   at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:3845)
>   at org.codehaus.janino.UnitCompiler.access$8600(UnitCompiler.java:183)
>   at 
> org.codehaus.janino.UnitCompiler$10.visitParenthesizedExpression(UnitCompiler.java:3274)
>   at 
> org.codehaus.janino.Java$ParenthesizedExpression.accept(Java.java:3830)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3993) Sum over a case statement fails with integer data type

2019-04-29 Thread Anoop Krishnaswamy (JIRA)
Anoop Krishnaswamy created KYLIN-3993:
-

 Summary: Sum over a case statement fails with integer data type
 Key: KYLIN-3993
 URL: https://issues.apache.org/jira/browse/KYLIN-3993
 Project: Kylin
  Issue Type: Bug
  Components: Driver - ODBC
Affects Versions: v2.6.1
Reporter: Anoop Krishnaswamy


Hi,

When we use sum over a case statement, it works when the field is of a certain 
type like decimal(19,3). But the same fails when used with integer field:

This works:

select sum(case when balance_indicator='1' then cyc_xxx_balanceadbavg else 0 
end) , balance_indicator from fct_profit_table_quarterly
group by balance_indicator

Whereas the below sql fails

select sum(case when balance_indicator='1' then accountmonthsopen else 0 end) , 
balance_indicator from fct_profit_table_quarterly
group by balance_indicator

 

with the error message:

{color:#b94a48}java.math.BigDecimal cannot be cast to java.lang.Integer while 
executing SQL: "select sum(case when balance_indicator='1' then 
accountmonthsopen else 0 end) , balance_indicator from 
fct_profit_table_quarterly group by balance_indicator LIMIT 5"{color}

 

{color:#b94a48}The difference between 1st sql and 2nd sql being - in the first 
query the metric used in the case statement is of decimal(19,4) and the metric 
used in 2nd statement is of type int.{color}

 

{color:#b94a48}Kindly help{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3968) Customized precision doesn't work in web

2019-04-29 Thread nichunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen resolved KYLIN-3968.
-
Resolution: Fixed

> Customized precision doesn't work in web
> 
>
> Key: KYLIN-3968
> URL: https://issues.apache.org/jira/browse/KYLIN-3968
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Jack
>Priority: Minor
> Fix For: v2.6.2
>
>
> In the cubeMeasures.js, It will withdraw precision and scale by using Regular 
> Expression. The scale parameter is ok, but precision use the magic number 19.
> So we fixed it, In cubeMeasures.js, around line 469:
> “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
> and we test ok including building cube and querying when the column is 
> decimal(38,18).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web

2019-04-29 Thread nichunen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829250#comment-16829250
 ] 

nichunen commented on KYLIN-3968:
-

[~maji...@163.com] Hi, Jack. Pr reviewed, it's fine to me. Code merged. Thanks 
for your contribution.

> Customized precision doesn't work in web
> 
>
> Key: KYLIN-3968
> URL: https://issues.apache.org/jira/browse/KYLIN-3968
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Jack
>Priority: Minor
> Fix For: v2.6.2
>
>
> In the cubeMeasures.js, It will withdraw precision and scale by using Regular 
> Expression. The scale parameter is ok, but precision use the magic number 19.
> So we fixed it, In cubeMeasures.js, around line 469:
> “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
> and we test ok including building cube and querying when the column is 
> decimal(38,18).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web

2019-04-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829249#comment-16829249
 ] 

ASF subversion and git services commented on KYLIN-3968:


Commit 956ecde679285a8bac7289779b091e2e7f4d1b04 in kylin's branch 
refs/heads/master from majie
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=956ecde ]

KYLIN-3968 Customized precision doesn't work in web


> Customized precision doesn't work in web
> 
>
> Key: KYLIN-3968
> URL: https://issues.apache.org/jira/browse/KYLIN-3968
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Jack
>Priority: Minor
> Fix For: v2.6.2
>
>
> In the cubeMeasures.js, It will withdraw precision and scale by using Regular 
> Expression. The scale parameter is ok, but precision use the magic number 19.
> So we fixed it, In cubeMeasures.js, around line 469:
> “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
> and we test ok including building cube and querying when the column is 
> decimal(38,18).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web

2019-04-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829248#comment-16829248
 ] 

ASF GitHub Bot commented on KYLIN-3968:
---

nichunen commented on pull request #623: KYLIN-3968 Customized precision 
doesn't work in web
URL: https://github.com/apache/kylin/pull/623
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Customized precision doesn't work in web
> 
>
> Key: KYLIN-3968
> URL: https://issues.apache.org/jira/browse/KYLIN-3968
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: Jack
>Priority: Minor
> Fix For: v2.6.2
>
>
> In the cubeMeasures.js, It will withdraw precision and scale by using Regular 
> Expression. The scale parameter is ok, but precision use the magic number 19.
> So we fixed it, In cubeMeasures.js, around line 469:
> “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
> and we test ok including building cube and querying when the column is 
> decimal(38,18).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] nichunen merged pull request #623: KYLIN-3968 Customized precision doesn't work in web

2019-04-29 Thread GitBox
nichunen merged pull request #623: KYLIN-3968 Customized precision doesn't work 
in web
URL: https://github.com/apache/kylin/pull/623
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3967) sum along with case expression does not work in query

2019-04-29 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829174#comment-16829174
 ] 

Shaofeng SHI commented on KYLIN-3967:
-

Hi hejian, "derived_column" is a "virtual" dimension which depends on the 
hosting dimension (the foreign key); Filterings on derived dimension can not be 
pushed down to storage engine, so there is some limitation for its use. In this 
case, please make "drived_dimension" as a normal dimension.

> sum along with case expression does not work in query
> -
>
> Key: KYLIN-3967
> URL: https://issues.apache.org/jira/browse/KYLIN-3967
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Reporter: Gladson Vas
>Priority: Blocker
> Attachments: notworkingcase.jpg, workingcase.jpg
>
>
> When i try to run a query with a sum case expression combination,
> eg: select sum(case when col1<0 then 0 else col1 end ) from table 
> i get the following error:
> No realization found for OLAPContext, CUBE_UNMATCHED_AGGREGATION[FunctionDesc 
> [expression=SUM, parameter=CASE(<($8, 0), 0, $8), returnType=null]], 
> rel#36838:OLAPTableScan.OLAP.[](table=[DEFAULT, table],ctx=,fields=[0, 1, 2, 
> 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 
> 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 
> 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 
> 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 
> 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 
> 100, 101, 102, 103, 104, 105, 106]) while executing SQL: "select sum (case 
> when col1 <0 then 0 else col1 end ) from table LIMIT 5"
>  
> is there any way to support this sum case expression in the query engine?
> Also I get the same error when the sum operation is done on a column derived 
> from a case expression in a subquery.
> eg: select sum(a.col1) from (select case when col1<0 then 0 else col1 end as 
> col1 from table) a
> Thanks,
> Gladson
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3967) sum along with case expression does not work in query

2019-04-29 Thread hejian (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829150#comment-16829150
 ] 

hejian commented on KYLIN-3967:
---

[~Shaofengshi] looking forwarding to your replay :D

> sum along with case expression does not work in query
> -
>
> Key: KYLIN-3967
> URL: https://issues.apache.org/jira/browse/KYLIN-3967
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Reporter: Gladson Vas
>Priority: Blocker
> Attachments: notworkingcase.jpg, workingcase.jpg
>
>
> When i try to run a query with a sum case expression combination,
> eg: select sum(case when col1<0 then 0 else col1 end ) from table 
> i get the following error:
> No realization found for OLAPContext, CUBE_UNMATCHED_AGGREGATION[FunctionDesc 
> [expression=SUM, parameter=CASE(<($8, 0), 0, $8), returnType=null]], 
> rel#36838:OLAPTableScan.OLAP.[](table=[DEFAULT, table],ctx=,fields=[0, 1, 2, 
> 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 
> 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 
> 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 
> 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 
> 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 
> 100, 101, 102, 103, 104, 105, 106]) while executing SQL: "select sum (case 
> when col1 <0 then 0 else col1 end ) from table LIMIT 5"
>  
> is there any way to support this sum case expression in the query engine?
> Also I get the same error when the sum operation is done on a column derived 
> from a case expression in a subquery.
> eg: select sum(a.col1) from (select case when col1<0 then 0 else col1 end as 
> col1 from table) a
> Thanks,
> Gladson
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3992) easy exceeds 'max-return-row' when gouping by a high-cardinality dimension with a long day span filter

2019-04-29 Thread hejian (JIRA)
hejian created KYLIN-3992:
-

 Summary: easy exceeds 'max-return-row' when gouping by a 
high-cardinality dimension with a long day span filter
 Key: KYLIN-3992
 URL: https://issues.apache.org/jira/browse/KYLIN-3992
 Project: Kylin
  Issue Type: Bug
Reporter: hejian


In my case, a dimension with 3million cardinality called seller_id, 
{code:java}
select seller_id, sum(volume) as count_num from tab_orders where 
day_id>='2019-04-07' and day_id<'2019-04-27' group by seller_id order by 
count_num desc offset 0 limit 10{code}
I think it relates to both the *cardinality(seller_id)* and 
*cardinality(day_id)* ?

Hard to determine the suitable value to 'kylin.query.max-return-row', any good 
solution to handle this issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] asfgit commented on issue #624: Allow user-specified time format using real-time

2019-04-29 Thread GitBox
asfgit commented on issue #624: Allow user-specified time format using real-time
URL: https://github.com/apache/kylin/pull/624#issuecomment-487491048
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] GuoNingNing opened a new pull request #624: Allow user-specified time format using real-time

2019-04-29 Thread GitBox
GuoNingNing opened a new pull request #624: Allow user-specified time format 
using real-time
URL: https://github.com/apache/kylin/pull/624
 
 
   Allow user-specified time format using real-time
   If your data source is  : 
   `{ "timestamp":"2019-04-29 11:11:11","gmv":1.1 }`
   You can specify
   - tsParser=org.apache.kylin.stream.source.kafka.DateTimeParser
   - TSPattern=-MM-dd HH:mm:ss


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services