[GitHub] [kylin] nichunen merged pull request #648: KYLIN-3958 MrHive-Dict support build by livy
nichunen merged pull request #648: KYLIN-3958 MrHive-Dict support build by livy URL: https://github.com/apache/kylin/pull/648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] coveralls commented on issue #658: add overwrite method getKafkaConsumer in KafkaClient
coveralls commented on issue #658: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/658#issuecomment-495075661 ## Pull Request Test Coverage Report for [Build 4538](https://coveralls.io/builds/23556391) * **0** of **4** **(0.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.003%**) to **28.302%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaClient.java](https://coveralls.io/builds/23556391/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaClient.java#L48) | 0 | 4 | 0.0% | Totals | [](https://coveralls.io/builds/23556391) | | :-- | --: | | Change from base [Build 4532](https://coveralls.io/builds/2323): | 0.003% | | Covered Lines: | 23249 | | Relevant Lines: | 82147 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #658: add overwrite method getKafkaConsumer in KafkaClient
codecov-io commented on issue #658: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/658#issuecomment-495075564 # [Codecov](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=h1) Report > Merging [#658](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/4e7b242b3009f1f194d2e66dae9b368330b89a7b?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#658 +/- ## === + Coverage 25.8% 25.8% +<.01% Complexity 60096009 === Files 13821382 Lines 82145 82147 +2 Branches 11509 11509 === + Hits 21196 21200 +4 + Misses58902 58901 -1 + Partials 20472046 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/kylin/source/kafka/util/KafkaClient.java](https://codecov.io/gh/apache/kylin/pull/658/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYUNsaWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/658/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/658/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/658/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `7% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=footer). Last update [4e7b242...e7b7f31](https://codecov.io/gh/apache/kylin/pull/658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #658: add overwrite method getKafkaConsumer in KafkaClient
liuzx32 opened a new pull request #658: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/658 ### Description Add an overwrite method getKafkaConsumer() for KafkaClient. ### Improvement Add method getKafkaConsumer() with the default properties from KafkaConsumerProperties. The class KafkaConsumerProperties can load kafka config from conf/kylin-kafka-consumer.xml. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #658: add overwrite method getKafkaConsumer in KafkaClient
asfgit commented on issue #658: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/658#issuecomment-495070074 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #655: add overwrite method getKafkaConsumer in KafkaClient
liuzx32 closed pull request #655: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic
liuzx32 closed pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #657: adjust HBase tableName toUpperCase for HFile
liuzx32 opened a new pull request #657: adjust HBase tableName toUpperCase for HFile URL: https://github.com/apache/kylin/pull/657 ### Description HBase is case sensitive, tableName.toUpperCase() will lead to the created table can not be found. ### Improvement Just remove the toUppderCase() in CubeHFileJob. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #657: adjust HBase tableName toUpperCase for HFile
asfgit commented on issue #657: adjust HBase tableName toUpperCase for HFile URL: https://github.com/apache/kylin/pull/657#issuecomment-495064316 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #648: KYLIN-3958 MrHive-Dict support build by livy
codecov-io edited a comment on issue #648: KYLIN-3958 MrHive-Dict support build by livy URL: https://github.com/apache/kylin/pull/648#issuecomment-493773496 # [Codecov](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=h1) Report > Merging [#648](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/4e7b242b3009f1f194d2e66dae9b368330b89a7b?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#648 +/- ## === + Coverage 25.8% 25.8% +<.01% Complexity 60096009 === Files 13821382 Lines 82145 82155 +10 Branches 11509 11511 +2 === + Hits 21196 21199 +3 - Misses58902 58910 +8 + Partials 20472046 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...urce/hive/RedistributeFlatHiveTableByLivyStep.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL1JlZGlzdHJpYnV0ZUZsYXRIaXZlVGFibGVCeUxpdnlTdGVwLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/kylin/source/hive/CreateMrHiveDictStep.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZU1ySGl2ZURpY3RTdGVwLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/common/livy/LivyRestClient.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9saXZ5L0xpdnlSZXN0Q2xpZW50LmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...lin/source/hive/CreateFlatHiveTableByLivyStep.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZUZsYXRIaXZlVGFibGVCeUxpdnlTdGVwLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `81.08% <0%> (-1.12%)` | `12 <0> (ø)` | | | [...a/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL01SSGl2ZURpY3RVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/648/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=footer). Last update [4e7b242...d1a788e](https://codecov.io/gh/apache/kylin/pull/648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] coveralls commented on issue #648: KYLIN-3958 MrHive-Dict support build by livy
coveralls commented on issue #648: KYLIN-3958 MrHive-Dict support build by livy URL: https://github.com/apache/kylin/pull/648#issuecomment-495058959 ## Pull Request Test Coverage Report for [Build 4534](https://coveralls.io/builds/2357) * **0** of **48** **(0.0%)** changed or added relevant lines in **6** files are covered. * **6** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.001%**) to **28.298%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java](https://coveralls.io/builds/2357/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHiveCmdBuilder.java#L142) | 0 | 1 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/livy/LivyRestClient.java](https://coveralls.io/builds/2357/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Flivy%2FLivyRestClient.java#L73) | 0 | 2 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/RedistributeFlatHiveTableByLivyStep.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FRedistributeFlatHiveTableByLivyStep.java#L53) | 0 | 2 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableByLivyStep.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCreateFlatHiveTableByLivyStep.java#L41) | 0 | 4 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/CreateMrHiveDictStep.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCreateMrHiveDictStep.java#L129) | 0 | 8 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FMRHiveDictUtil.java#L46) | 0 | 31 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [source-hive/src/main/java/org/apache/kylin/source/hive/RedistributeFlatHiveTableByLivyStep.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FRedistributeFlatHiveTableByLivyStep.java#L56) | 1 | 0.0% | | [source-hive/src/main/java/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FMRHiveDictUtil.java#L118) | 1 | 0.0% | | [source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableByLivyStep.java](https://coveralls.io/builds/2357/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCreateFlatHiveTableByLivyStep.java#L45) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/2357/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/2357) | | :-- | --: | | Change from base [Build 4532](https://coveralls.io/builds/2323): | -0.001% | | Covered Lines: | 23248 | | Relevant Lines: | 82155 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic
liuzx32 opened a new pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656 **Description** HBase is case sensitive, tableName.toUpperCase() will lead to the created table can not be found. **Improvement** Just remove the toUppderCase() in CubeHFileJob. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic
liuzx32 closed pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic
liuzx32 closed pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic
liuzx32 opened a new pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656 **Description** HBase is case sensitive, tableName.toUpperCase() will lead to the created table can not be found. **Improvement** Just remove the toUppderCase() in CubeHFileJob. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #654: Bug Fix: remove HBase tableName toUpperCase()
liuzx32 closed pull request #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #655: add overwrite method getKafkaConsumer in KafkaClient
codecov-io commented on issue #655: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/655#issuecomment-495047475 # [Codecov](https://codecov.io/gh/apache/kylin/pull/655?src=pr&el=h1) Report > Merging [#655](https://codecov.io/gh/apache/kylin/pull/655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/4e7b242b3009f1f194d2e66dae9b368330b89a7b?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/655?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#655 +/- ## == + Coverage 25.7% 25.8% +0.1% - Complexity 59766009 +33 == Files 13821382 Lines 82144 82147 +3 Branches 11509 11509 == + Hits 21112 21196 +84 + Misses58985 58904 -81 Partials 20472047 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/655?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/kylin/source/kafka/util/KafkaClient.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYUNsaWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...eam/core/storage/columnar/DataSegmentFragment.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRGF0YVNlZ21lbnRGcmFnbWVudC5qYXZh) | `57.37% <0%> (-1.64%)` | `17% <0%> (-1%)` | | | [...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh) | `75.38% <0%> (-1.03%)` | `27% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/measure/MeasureTypeFactory.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9NZWFzdXJlVHlwZUZhY3RvcnkuamF2YQ==) | `57.14% <0%> (ø)` | `14% <0%> (ø)` | :arrow_down: | | [...am/core/storage/columnar/ColumnarSegmentStore.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTZWdtZW50U3RvcmUuamF2YQ==) | `58.69% <0%> (+0.43%)` | `28% <0%> (+1%)` | :arrow_up: | | [.../apache/kylin/common/persistence/ResourceTool.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVRvb2wuamF2YQ==) | `22.54% <0%> (+0.45%)` | `14% <0%> (ø)` | :arrow_down: | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `51.16% <0%> (+2.32%)` | `8% <0%> (+1%)` | :arrow_up: | | [...rg/apache/kylin/storage/hybrid/HybridInstance.java](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2h5YnJpZC9IeWJyaWRJbnN0YW5jZS5qYXZh) | `44.27% <0%> (+6.1%)` | `17% <0%> (+4%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/kylin/pull/655/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/655?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/655?src=pr&el=footer). Last update [4e7b242...f641d14](https://codeco
[GitHub] [kylin] liuzx32 opened a new pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic
liuzx32 opened a new pull request #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656 **Description** HBase is case sensitive, tableName.toUpperCase() will lead to the created table can not be found. **Improvement** Just remove the toUppderCase() in CubeHFileJob. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #656: Bug Fix: adjust HBase tableName toUpperCase logic
asfgit commented on issue #656: Bug Fix: adjust HBase tableName toUpperCase logic URL: https://github.com/apache/kylin/pull/656#issuecomment-495043652 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on issue #654: Bug Fix: remove HBase tableName toUpperCase()
nichunen commented on issue #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654#issuecomment-495042083 @liuzx32 Hi, looks the pr has conflicts. Would you please rebase master and re-submit it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #655: add overwrite method getKafkaConsumer in KafkaClient
asfgit commented on issue #655: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/655#issuecomment-495041674 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #655: add overwrite method getKafkaConsumer in KafkaClient
liuzx32 opened a new pull request #655: add overwrite method getKafkaConsumer in KafkaClient URL: https://github.com/apache/kylin/pull/655 **Description** Add an overwrite method getKafkaConsumer() for KafkaClient. **Improvement** Add method getKafkaConsumer() with the default properties from KafkaConsumerProperties. The class KafkaConsumerProperties can load kafka config from conf/kylin-kafka-consumer.xml. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #650: add overwrite method KafkaClient.getKafkaConsumer()
liuzx32 closed pull request #650: add overwrite method KafkaClient.getKafkaConsumer() URL: https://github.com/apache/kylin/pull/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on issue #615: KYLIN-3958 MrHive-Dict support build by livy
nichunen commented on issue #615: KYLIN-3958 MrHive-Dict support build by livy URL: https://github.com/apache/kylin/pull/615#issuecomment-495039619 Re-submit with https://github.com/apache/kylin/pull/648, close this one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3958) MrHive-Dict support build by livy
[ https://issues.apache.org/jira/browse/KYLIN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846366#comment-16846366 ] ASF GitHub Bot commented on KYLIN-3958: --- nichunen commented on pull request #615: KYLIN-3958 MrHive-Dict support build by livy URL: https://github.com/apache/kylin/pull/615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MrHive-Dict support build by livy > - > > Key: KYLIN-3958 > URL: https://issues.apache.org/jira/browse/KYLIN-3958 > Project: Kylin > Issue Type: Improvement >Reporter: jinguowei >Assignee: jinguowei >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] nichunen closed pull request #615: KYLIN-3958 MrHive-Dict support build by livy
nichunen closed pull request #615: KYLIN-3958 MrHive-Dict support build by livy URL: https://github.com/apache/kylin/pull/615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #654: Bug Fix: remove HBase tableName toUpperCase()
liuzx32 opened a new pull request #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654 **Description** HBase is case sensitive，tableName.toUpperCase() will lead to the created table could not be found. **Improvement** just remove toUpperCase() for HBase tableName on master-hadoop3.1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #653: minor, switch to openjdk8 for travis
nichunen merged pull request #653: minor, switch to openjdk8 for travis URL: https://github.com/apache/kylin/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 closed pull request #654: Bug Fix: remove HBase tableName toUpperCase()
liuzx32 closed pull request #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #654: Bug Fix: remove HBase tableName toUpperCase()
asfgit commented on issue #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654#issuecomment-495036021 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] liuzx32 opened a new pull request #654: Bug Fix: remove HBase tableName toUpperCase()
liuzx32 opened a new pull request #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654 **Description** HBase is case sensitive，tableName.toUpperCase() will lead to the created table could not be found. **Improvement** just remove toUpperCase() for HBase tableName on master-hadoop3.1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (KYLIN-1210) Allowing segment overlap to solve streaming data completeness problem
[ https://issues.apache.org/jira/browse/KYLIN-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI closed KYLIN-1210. --- Resolution: Fixed Fix Version/s: v1.6.0 The problem was based on Kylin 1.5, it has already been solved in Kylin v1.6.0 with the new NRT streaming. > Allowing segment overlap to solve streaming data completeness problem > - > > Key: KYLIN-1210 > URL: https://issues.apache.org/jira/browse/KYLIN-1210 > Project: Kylin > Issue Type: Improvement >Reporter: hongbin ma >Assignee: hongbin ma >Priority: Major > Fix For: v1.6.0 > > > Previously cube segments in one cube are not allowed to overlap with each > other. This constraint to more intuitive and simple to maintain. This > constraint makes cube segments immutable, which is acceptable in batch cubing > scenarios. > In streaming cubing scenarios, however, there may exist late coming data due > to upstream latencies. It's best we can still consume those late data rather > than simply ignore it. To accomplish this we have to relief the above > constraint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-4011) Kyling grouping function
[
https://issues.apache.org/jira/browse/KYLIN-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845946#comment-16845946
]
Shaofeng SHI commented on KYLIN-4011:
-
Does this help? [https://kylin.apache.org/blog/2016/11/16/window-function/]
> Kyling grouping function
>
>
> Key: KYLIN-4011
> URL: https://issues.apache.org/jira/browse/KYLIN-4011
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.6.2
>Reporter: tag
>Priority: Major
>
> {{```}}
> {{select dim1, case grouping(dim2) when 1 then 'ALL' else dim2 end, sum(col)
> as metric1 from table group by grouping sets((dim1, dim2), (dim1));}}
> {{```}}
> {{`case grouping(dim2) when 2 then 'All' else dim2 end` can work in version
> v2.5.2, but invalid in version v2.6.2. }}
> {{How to query aggregate by grouping sets?}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [kylin] shaofengshi opened a new pull request #653: minor, switch to openjdk8 for travis
shaofengshi opened a new pull request #653: minor, switch to openjdk8 for travis URL: https://github.com/apache/kylin/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #653: minor, switch to openjdk8 for travis
asfgit commented on issue #653: minor, switch to openjdk8 for travis URL: https://github.com/apache/kylin/pull/653#issuecomment-494814406 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3990) java.lang.ClassCastException: org.apache.hadoop.io.IntWritable cannot be cast to org.apache.hadoop.io.Text
[
https://issues.apache.org/jira/browse/KYLIN-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845680#comment-16845680
]
Colin Luo commented on KYLIN-3990:
--
create table dm_customer_type as select * from dm_customer_type_old; every
time the build fails, bulid succeeds after rebuilding the table use like this
SQL, and ETL loads the snapshot data again, and the build may fail again
> java.lang.ClassCastException: org.apache.hadoop.io.IntWritable cannot be cast
> to org.apache.hadoop.io.Text
> --
>
> Key: KYLIN-3990
> URL: https://issues.apache.org/jira/browse/KYLIN-3990
> Project: Kylin
> Issue Type: Bug
>Reporter: Colin Luo
>Priority: Major
>
> HDP 3.1 Kylin 2.6.1
> Error in build cube step 4
> 2019-04-28 19:32:31,762 INFO [Scheduler 2100016947 Job
> 16f753e8-5444-1f03-178a-5cca4f3cd10f-202] orc.OrcInputFormat:1737 : ORC
> pushdown predicate: null
> 2019-04-28 19:32:32,139 INFO [ORC_GET_SPLITS #1] impl.OrcCodecPool:56 : Got
> brand-new codec ZLIB
> 2019-04-28 19:32:32,261 INFO [Scheduler 2100016947 Job
> 16f753e8-5444-1f03-178a-5cca4f3cd10f-202] orc.OrcInputFormat:1855 :
> FooterCacheHitRatio: 0/1
> 2019-04-28 19:32:32,321 INFO [Scheduler 2100016947 Job
> 16f753e8-5444-1f03-178a-5cca4f3cd10f-202] orc.ReaderImpl:82 : Reading ORC
> rows from
> hdfs://master1:8020/warehouse/tablespace/managed/hive/wmdp_etl_dm.db/dm_customer_type/base_011/bucket_0
> with \{include: null, offset: 3, length: 725, schema:
> struct,
> includeAcidColumns: true}
> 2019-04-28 19:32:32,391 INFO [Scheduler 2100016947 Job
> 16f753e8-5444-1f03-178a-5cca4f3cd10f-202] mapreduce.InternalUtil:156 :
> Initializing org.apache.hadoop.hive.ql.io.orc.OrcSerde with properties
> \{columns.types=string,string,string,string, comment=客户类型维度,
> columns=customer_type_cd,customer_type_desc,customer_cate_cd,customer_cate_desc,
> transactional_properties=default,
> COLUMN_STATS_ACCURATE={"BASIC_STATS":"true","COLUMN_STATS":{"customer_cate_cd":"true","customer_cate_desc":"true","customer_type_cd":"true","customer_type_desc":"true"}},
> serialization.format=1, numRows=11, numFiles=1,
> transient_lastDdlTime=1556442134, rawDataSize=0, columns.comments=客户类型代码
> 客户类型描述 客户大类代码 客户大类描述, totalSize=1306,
> serialization.lib=org.apache.hadoop.hive.ql.io.orc.OrcSerde,
> serialization.null.format=\N, bucketing_version=2, transactional=true,
> column.name.delimiter=,, name=WMDP_ETL_DM.DM_CUSTOMER_TYPE}
> 2019-04-28 19:32:32,402 ERROR [Scheduler 2100016947 Job
> 16f753e8-5444-1f03-178a-5cca4f3cd10f-202] common.HadoopShellExecutable:65 :
> error execute
> HadoopShellExecutable\{id=16f753e8-5444-1f03-178a-5cca4f3cd10f-03, name=Build
> Dimension Dictionary, state=RUNNING}
> java.lang.ClassCastException: org.apache.hadoop.io.IntWritable cannot be cast
> to org.apache.hadoop.io.Text
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.WritableStringObjectInspector.getPrimitiveJavaObject(WritableStringObjectInspector.java:46)
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.WritableStringObjectInspector.getPrimitiveJavaObject(WritableStringObjectInspector.java:26)
> at
> org.apache.hive.hcatalog.data.HCatRecordSerDe.serializePrimitiveField(HCatRecordSerDe.java:278)
> at
> org.apache.hive.hcatalog.data.HCatRecordSerDe.serializeField(HCatRecordSerDe.java:199)
> at org.apache.hive.hcatalog.data.LazyHCatRecord.get(LazyHCatRecord.java:53)
> at org.apache.hive.hcatalog.data.LazyHCatRecord.get(LazyHCatRecord.java:97)
> at
> org.apache.hive.hcatalog.mapreduce.HCatRecordReader.nextKeyValue(HCatRecordReader.java:204)
> at
> org.apache.hive.hcatalog.data.transfer.impl.HCatInputFormatReader$HCatRecordItr.hasNext(HCatInputFormatReader.java:107)
> at org.apache.kylin.source.hive.HiveTableReader.next(HiveTableReader.java:90)
> at
> org.apache.kylin.dict.lookup.SnapshotTable.takeSnapshot(SnapshotTable.java:98)
> at
> org.apache.kylin.dict.lookup.SnapshotManager.buildSnapshot(SnapshotManager.java:133)
> at
> org.apache.kylin.cube.CubeManager$DictionaryAssist.buildSnapshotTable(CubeManager.java:1174)
> at
> org.apache.kylin.cube.CubeManager.buildSnapshotTable(CubeManager.java:1090)
> at
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:97)
> at
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:55)
> at
> org.apache.kylin.engine.mr.steps.CreateDictionaryJob.run(CreateDictionaryJob.java:73)
> at org.apache.kylin.engine.mr.MRUtil.runMRJob(MRUtil.java:93)
> at
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63)
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:166)
>
