[jira] [Commented] (KYLIN-4062) Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

2019-06-30 Thread JIRA


[ 
https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875904#comment-16875904
 ] 

王汝鹏 commented on KYLIN-4062:


Hi, Shaofeng, I can fix this. Can you assign this to me?

> Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType
> -
>
> Key: KYLIN-4062
> URL: https://issues.apache.org/jira/browse/KYLIN-4062
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Reporter: Shaofeng SHI
>Priority: Minor
>
> In this method, it has 30 "if else" which is low efficient; Should use a 
> static Hashmap, then only need 1 check.
>  
> {code:java}
> if ("string".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("varchar".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("char".equalsIgnoreCase(type)) {
> return Types.CHAR;
> } else if
> ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3999) Enable dynamic column by default

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-3999:
---

Assignee: haifeng wang

> Enable dynamic column by default
> 
>
> Key: KYLIN-3999
> URL: https://issues.apache.org/jira/browse/KYLIN-3999
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Reporter: Shaofeng SHI
>Assignee: haifeng wang
>Priority: Minor
> Fix For: v2.6.3
>
>
> More and more user expects to use "SUM(Case when)" feature, and got error. 
> The reason is the dynamic column is disabled by default. We should consider 
> to enable it by default:
>  
> kylin.query.enable-dynamic-column=true



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-4004) Multi user groups table permission error

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-4004.
-
Resolution: Fixed

> Multi user groups table permission error
> 
>
> Key: KYLIN-4004
> URL: https://issues.apache.org/jira/browse/KYLIN-4004
> Project: Kylin
>  Issue Type: Bug
>  Components: Others
>Affects Versions: all
>Reporter: haifeng wang
>Assignee: haifeng wang
>Priority: Major
> Fix For: v2.6.3
>
>
> When a user has multiple user groups, When collecting the blacklist of the 
> table, Using the union of the blacklists of each group



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-4004) Multi user groups table permission error

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-4004:
---

Assignee: haifeng wang

> Multi user groups table permission error
> 
>
> Key: KYLIN-4004
> URL: https://issues.apache.org/jira/browse/KYLIN-4004
> Project: Kylin
>  Issue Type: Bug
>  Components: Others
>Affects Versions: all
>Reporter: haifeng wang
>Assignee: haifeng wang
>Priority: Major
> Fix For: v2.6.3
>
>
> When a user has multiple user groups, When collecting the blacklist of the 
> table, Using the union of the blacklists of each group



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-4020) Fix_length rowkey encode without sepecified length can be saved but cause CreateHTable step failed

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-4020:
---

Assignee: Yuzhang QIU
Priority: Minor  (was: Major)
 Summary: Fix_length rowkey encode without sepecified length can be saved 
but cause CreateHTable step failed  (was: fix_length rowkey encode without 
sepecified length can be saved but cause CreateHTable step failed)

> Fix_length rowkey encode without sepecified length can be saved but cause 
> CreateHTable step failed
> --
>
> Key: KYLIN-4020
> URL: https://issues.apache.org/jira/browse/KYLIN-4020
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Assignee: Yuzhang QIU
>Priority: Minor
> Fix For: v2.6.3
>
>
> Hi dear team:
> Just as title said.  
> Maybe there should have more strict check for advanced settings, I think.
> How do you think about this?
> If there already have same JIRA,please inform me and close this one.
>   
>  Best regards
>   
>  yuzhang



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-4030) ResourceStore deleteResource by comparing timestamp may be failed to delete caused by time precision loose

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-4030.
-
Resolution: Fixed

> ResourceStore deleteResource by comparing timestamp may be failed to delete 
> caused by time precision loose
> --
>
> Key: KYLIN-4030
> URL: https://issues.apache.org/jira/browse/KYLIN-4030
> Project: Kylin
>  Issue Type: Bug
>Reporter: PENG Zhengshuai
>Assignee: PENG Zhengshuai
>Priority: Minor
> Fix For: v2.6.3
>
>
> In ResourceStore, the interface *deleteResourceImpl(String resPath, long 
> timestamp)* maybe failed to delete the resource because the resource 
> timestamp may lose the precision.
> For example, if we use *$KYLIN_HOME/bin/metastore.sh* to backup from 
> metastore to Local OS filesystem, and restore from local filesystem to 
> metastore. The resource timestamp will lose precision in Millis Second.
> An example here: 
> original timestamp: 1559564381
> after precision lost: 1559564000
> The fix design is to tolerate [0-999] ms difference when comparing the 
> timestamp



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-4023) Timestamp and date with timezone in jdbc

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-4023:

Summary: Timestamp and date with timezone in jdbc  (was: timestamp and date 
with timezone in jdbc)

> Timestamp and date with timezone in jdbc
> 
>
> Key: KYLIN-4023
> URL: https://issues.apache.org/jira/browse/KYLIN-4023
> Project: Kylin
>  Issue Type: Improvement
>  Components: Driver - JDBC
>Reporter: Zhixiong Chen
>Assignee: Zhixiong Chen
>Priority: Major
> Fix For: v2.6.3
>
>
> query with timestamp or date type column
> the result with timezone in jdbc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-4022) Pushdown error "unrecognized column type: DECIMAL(xx,xx)"

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-4022:

Summary: Pushdown error "unrecognized column type: DECIMAL(xx,xx)"  (was: 
when Adhoc Push Down then Unrecognized column type: DECIMAL(xx,xx))

> Pushdown error "unrecognized column type: DECIMAL(xx,xx)"
> -
>
> Key: KYLIN-4022
> URL: https://issues.apache.org/jira/browse/KYLIN-4022
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jinguowei
>Assignee: jinguowei
>Priority: Major
> Fix For: v2.6.3
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] codecov-io commented on issue #722: KYLIN-3628 Fix unexpected exception for select from Lookup Table

2019-06-30 Thread GitBox
codecov-io commented on issue #722: KYLIN-3628 Fix unexpected exception for 
select from Lookup Table
URL: https://github.com/apache/kylin/pull/722#issuecomment-507040425
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/722?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@6f12aaf`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/722/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/722?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #722   +/-   ##
   =
 Coverage  ?   25.71%   
 Complexity? 6017   
   =
 Files ? 1386   
 Lines ?82720   
 Branches  ?11602   
   =
 Hits  ?21268   
 Misses?59400   
 Partials  ? 2052
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/722?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../kylin/query/enumerator/LookupTableEnumerator.java](https://codecov.io/gh/apache/kylin/pull/722/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L2VudW1lcmF0b3IvTG9va3VwVGFibGVFbnVtZXJhdG9yLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/722/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=)
 | `37.03% <0%> (ø)` | `44 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/722?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/722?src=pr=footer). Last 
update 
[6f12aaf...6dfb583](https://codecov.io/gh/apache/kylin/pull/722?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2019-06-30 Thread weibin0516 (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875792#comment-16875792
 ] 

weibin0516 commented on KYLIN-3832:
---

[~Shaofengshi], thanks for assigning to me, i will try to implement this.

> Kylin pushdown to support postgresql
> 
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: New Feature
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) Query with lookup table always use latest snapshot

2019-06-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875791#comment-16875791
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

hit-lacus commented on pull request #722: KYLIN-3628 Fix unexpected exception 
for select from Lookup Table
URL: https://github.com/apache/kylin/pull/722
 
 
   In some case, cube returned by findLatestSnapshot didn't contains the 
snapshot table
   for what you need. Because some dimension which exists in model but was 
removed in cube design phase, query such as "select * from LookupTable" will 
throw unexpected exception and confused user.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Query with lookup table always use latest snapshot
> --
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> If user queries a lookup table, Kylin will randomly selects a Cube (which has 
> the snapshot of this lookup table) to answer it. This causes uncertainty when 
> there are multiple cubes (share the same lookup): some cubes are newly built, 
> some not. If Kylin picks an old cube, the query result is old.
> To remove this uncertainty, for such queries, either always use latest 
> snapshot, or use earlist snapshot. We believe the "latest" version is better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] hit-lacus opened a new pull request #722: KYLIN-3628 Fix unexpected exception for select from Lookup Table

2019-06-30 Thread GitBox
hit-lacus opened a new pull request #722: KYLIN-3628 Fix unexpected exception 
for select from Lookup Table
URL: https://github.com/apache/kylin/pull/722
 
 
   In some case, cube returned by findLatestSnapshot didn't contains the 
snapshot table
   for what you need. Because some dimension which exists in model but was 
removed in cube design phase, query such as "select * from LookupTable" will 
throw unexpected exception and confused user.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asfgit commented on issue #722: KYLIN-3628 Fix unexpected exception for select from Lookup Table

2019-06-30 Thread GitBox
asfgit commented on issue #722: KYLIN-3628 Fix unexpected exception for select 
from Lookup Table
URL: https://github.com/apache/kylin/pull/722#issuecomment-507037866
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4061) Swap inner join's left side, right side table will get different result when query

2019-06-30 Thread weibin0516 (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875789#comment-16875789
 ] 

weibin0516 commented on KYLIN-4061:
---

[~Shaofengshi], thanks for explaining.

> Swap inner join's left side, right side table will get different result when 
> query
> --
>
> Key: KYLIN-4061
> URL: https://issues.apache.org/jira/browse/KYLIN-4061
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: weibin0516
>Priority: Major
> Attachments: failed.png, succeed.png
>
>
> When the left side table of inner join is a fact table and the right side 
> table is a lookup table, will query cube and get correct result. Sql is as 
> follows.
> {code:java}
> SELECT KYLIN_SALES.TRANS_ID, SUM(KYLIN_SALES.PRICE), 
> COUNT(KYLIN_ACCOUNT.ACCOUNT_ID)
>  FROM KYLIN_SALES
>  INNER JOIN KYLIN_ACCOUNT ON KYLIN_SALES.BUYER_ID = KYLIN_ACCOUNT.ACCOUNT_ID
>  WHERE KYLIN_SALES.LSTG_SITE_ID != 1000
>  GROUP BY KYLIN_SALES.TRANS_ID
>  ORDER BY TRANS_ID
>  LIMIT 10;{code}
>  
> However,when swap the left and right side tables of the inner join will 
> failed due to no realization found. Sql is as follows.
> {code:java}
> SELECT KYLIN_SALES.TRANS_ID, SUM(KYLIN_SALES.PRICE), 
> COUNT(KYLIN_ACCOUNT.ACCOUNT_ID)
>  FROM KYLIN_ACCOUNT
>  INNER JOIN KYLIN_SALES ON KYLIN_SALES.BUYER_ID = KYLIN_ACCOUNT.ACCOUNT_ID
>  WHERE KYLIN_SALES.LSTG_SITE_ID != 1000
>  GROUP BY KYLIN_SALES.TRANS_ID
>  ORDER BY TRANS_ID
>  LIMIT 10;{code}
> We know that the above two sql semantics are consistent and should return the 
> same result. 
>  I looked at the source code, kylin will use context.firstTableScan(assigned 
> in OLAPTableScan.implementOLAP) as the fact table, whether it is or not. The 
> fact table will be the key evidence for choosing realization later. So, in 
> the second sql Regard a lookup table as a fact table can not find 
> corresponding realization.
> Is this a bug, do we need to fix it?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-4025) Add detail exception in kylin http response

2019-06-30 Thread nichunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen updated KYLIN-4025:

Issue Type: Improvement  (was: New Feature)

> Add detail exception in kylin http response 
> 
>
> Key: KYLIN-4025
> URL: https://issues.apache.org/jira/browse/KYLIN-4025
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Affects Versions: v2.5.2
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Fix For: v2.6.3
>
>
> Currently there is no detailed in http response when the requests go wrong, 
> because InternalErrorException in controller wrap the execption and remove 
> the exception stack.
> It's better add the detail exception in kylin http response 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-4023) timestamp and date with timezone in jdbc

2019-06-30 Thread nichunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen resolved KYLIN-4023.
-
   Resolution: Fixed
Fix Version/s: v2.6.3

> timestamp and date with timezone in jdbc
> 
>
> Key: KYLIN-4023
> URL: https://issues.apache.org/jira/browse/KYLIN-4023
> Project: Kylin
>  Issue Type: Improvement
>  Components: Driver - JDBC
>Reporter: Zhixiong Chen
>Assignee: Zhixiong Chen
>Priority: Major
> Fix For: v2.6.3
>
>
> query with timestamp or date type column
> the result with timezone in jdbc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-4023) timestamp and date with timezone in jdbc

2019-06-30 Thread nichunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen updated KYLIN-4023:

Issue Type: Improvement  (was: Bug)

> timestamp and date with timezone in jdbc
> 
>
> Key: KYLIN-4023
> URL: https://issues.apache.org/jira/browse/KYLIN-4023
> Project: Kylin
>  Issue Type: Improvement
>  Components: Driver - JDBC
>Reporter: Zhixiong Chen
>Assignee: Zhixiong Chen
>Priority: Major
>
> query with timestamp or date type column
> the result with timezone in jdbc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-4062) Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

2019-06-30 Thread Shaofeng SHI (JIRA)
Shaofeng SHI created KYLIN-4062:
---

 Summary: Too many "if else" clause in 
PushDownRunnerJdbcImpl#toSqlType
 Key: KYLIN-4062
 URL: https://issues.apache.org/jira/browse/KYLIN-4062
 Project: Kylin
  Issue Type: Improvement
  Components: Query Engine
Reporter: Shaofeng SHI


In this method, it has 30 "if else" which is low efficient; Should use a static 
Hashmap, then only need 1 check.

 
{code:java}
if ("string".equalsIgnoreCase(type)) {
return Types.VARCHAR;
} else if ("varchar".equalsIgnoreCase(type)) {
return Types.VARCHAR;
} else if ("char".equalsIgnoreCase(type)) {
return Types.CHAR;
} else if
...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-4061) Swap inner join's left side, right side table will get different result when query

2019-06-30 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875735#comment-16875735
 ] 

Shaofeng SHI commented on KYLIN-4061:
-

It is known issue I think, with low priority. Because in OLAP scenarios, most 
queries are started from fact table. Of course, enhancement patches are always 
welcomed.

> Swap inner join's left side, right side table will get different result when 
> query
> --
>
> Key: KYLIN-4061
> URL: https://issues.apache.org/jira/browse/KYLIN-4061
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: weibin0516
>Priority: Major
> Attachments: failed.png, succeed.png
>
>
> When the left side table of inner join is a fact table and the right side 
> table is a lookup table, will query cube and get correct result. Sql is as 
> follows.
> {code:java}
> SELECT KYLIN_SALES.TRANS_ID, SUM(KYLIN_SALES.PRICE), 
> COUNT(KYLIN_ACCOUNT.ACCOUNT_ID)
>  FROM KYLIN_SALES
>  INNER JOIN KYLIN_ACCOUNT ON KYLIN_SALES.BUYER_ID = KYLIN_ACCOUNT.ACCOUNT_ID
>  WHERE KYLIN_SALES.LSTG_SITE_ID != 1000
>  GROUP BY KYLIN_SALES.TRANS_ID
>  ORDER BY TRANS_ID
>  LIMIT 10;{code}
>  
> However,when swap the left and right side tables of the inner join will 
> failed due to no realization found. Sql is as follows.
> {code:java}
> SELECT KYLIN_SALES.TRANS_ID, SUM(KYLIN_SALES.PRICE), 
> COUNT(KYLIN_ACCOUNT.ACCOUNT_ID)
>  FROM KYLIN_ACCOUNT
>  INNER JOIN KYLIN_SALES ON KYLIN_SALES.BUYER_ID = KYLIN_ACCOUNT.ACCOUNT_ID
>  WHERE KYLIN_SALES.LSTG_SITE_ID != 1000
>  GROUP BY KYLIN_SALES.TRANS_ID
>  ORDER BY TRANS_ID
>  LIMIT 10;{code}
> We know that the above two sql semantics are consistent and should return the 
> same result. 
>  I looked at the source code, kylin will use context.firstTableScan(assigned 
> in OLAPTableScan.implementOLAP) as the fact table, whether it is or not. The 
> fact table will be the key evidence for choosing realization later. So, in 
> the second sql Regard a lookup table as a fact table can not find 
> corresponding realization.
> Is this a bug, do we need to fix it?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-4024) Pushdown to presto: Unrecognized column type: INTEGER,TIME,VARBINARY

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-4024:

Summary: Pushdown to presto: Unrecognized column type: 
INTEGER,TIME,VARBINARY  (was: when ad-hoc Push Down by presto engine  
Unrecognized column type: INTEGER,TIME,VARBINARY)

> Pushdown to presto: Unrecognized column type: INTEGER,TIME,VARBINARY
> 
>
> Key: KYLIN-4024
> URL: https://issues.apache.org/jira/browse/KYLIN-4024
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Affects Versions: all, v3.0.0, v2.6.2
>Reporter: wangxiaojing
>Assignee: XiaoXiang Yu
>Priority: Major
> Fix For: v2.6.3
>
>
>  Hello ,
>     When do ad-hoc Push Down query by presto engine ,it throws Unrecognized 
> column type,like INTEGER,TIME,VARBINARY 。
>     The field of the table that appears in the hive is defined as an int 
> type. If the Presto query is used, the INTEGER type will be returned. 
> At this time, kylin ad-hoc push down will not recognize this type.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3832) Kylin Pushdown query not support postgresql

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-3832:
---

Assignee: weibin0516

Weibin, please go ahead. Thank you!

> Kylin Pushdown query not support postgresql
> ---
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
> Fix For: Future
>
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3832) Kylin pushdown to support postgresql

2019-06-30 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3832:

Fix Version/s: (was: Future)
   Issue Type: New Feature  (was: Bug)
  Summary: Kylin pushdown to support postgresql  (was: Kylin Pushdown 
query not support postgresql)

> Kylin pushdown to support postgresql
> 
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: New Feature
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-4024) when ad-hoc Push Down by presto engine Unrecognized column type: INTEGER,TIME,VARBINARY

2019-06-30 Thread nichunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen updated KYLIN-4024:

Issue Type: Improvement  (was: Bug)

> when ad-hoc Push Down by presto engine  Unrecognized column type: 
> INTEGER,TIME,VARBINARY
> 
>
> Key: KYLIN-4024
> URL: https://issues.apache.org/jira/browse/KYLIN-4024
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Affects Versions: all, v3.0.0, v2.6.2
>Reporter: wangxiaojing
>Assignee: XiaoXiang Yu
>Priority: Major
> Fix For: v2.6.3
>
>
>  Hello ,
>     When do ad-hoc Push Down query by presto engine ,it throws Unrecognized 
> column type,like INTEGER,TIME,VARBINARY 。
>     The field of the table that appears in the hive is defined as an int 
> type. If the Presto query is used, the INTEGER type will be returned. 
> At this time, kylin ad-hoc push down will not recognize this type.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3893) Cube build failed for wrong row key column description

2019-06-30 Thread nichunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen updated KYLIN-3893:

Issue Type: Improvement  (was: Bug)

> Cube build failed for wrong row key column description
> --
>
> Key: KYLIN-3893
> URL: https://issues.apache.org/jira/browse/KYLIN-3893
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Fix For: v2.6.3
>
>
> User created wrong RowKeyColDesc, eg,
> RowKeyColDesc\{column=MYSQL_FEEDBACK_USER_AUDIT.DATE, 
> encoding=integer:undefined}
> which cause the cube build forever.
>  
> {code:java}
> org.apache.kylin.engine.mr.exception.HadoopShellException: 
> java.lang.NumberFormatException: For input string: "undefined"    at 
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) 
>    at java.lang.Integer.parseInt(Integer.java:580)    at 
> java.lang.Integer.parseInt(Integer.java:615)    at 
> org.apache.kylin.dimension.IntegerDimEnc$Factory.createDimensionEncoding(IntegerDimEnc.java:65)
>     at 
> org.apache.kylin.dimension.DimensionEncodingFactory.create(DimensionEncodingFactory.java:65)
>     at org.apache.kylin.cube.kv.CubeDimEncMap.get(CubeDimEncMap.java:74)    
> at 
> org.apache.kylin.engine.mr.common.CubeStatsReader.getCuboidSizeMapFromRowCount(CubeStatsReader.java:206)
>     at 
> org.apache.kylin.engine.mr.common.CubeStatsReader.getCuboidSizeMap(CubeStatsReader.java:170)
>     at 
> org.apache.kylin.storage.hbase.steps.CreateHTableJob.run(CreateHTableJob.java:102)
>     at org.apache.kylin.engine.mr.MRUtil.runMRJob(MRUtil.java:92)    at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63)
>     at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:178)
>     at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>     at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:178)
>     at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>     at java.lang.Thread.run(Thread.java:748)result code:2    at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73)
>     at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:178)
>     at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>     at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:178)
>     at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>     at java.lang.Thread.run(Thread.java:748){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-4046) Refine JDBC Source(source.default=8)

2019-06-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875709#comment-16875709
 ] 

ASF subversion and git services commented on KYLIN-4046:


Commit 6f12aaf5c62bfb10e2b3acf28520e259fce1a7a2 in kylin's branch 
refs/heads/master from hit-lacus
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6f12aaf ]

KYLIN-4046 Refine JDBC Source(source.default=8)

Currently, the function of ingest data from RDBMS(kylin.source.default=8) to 
Kylin has some problems , in this patch, I want to :

1. fix case-sensitive
2. fix weak dialect compatibility
3. fix mis-use quote character


> Refine JDBC Source(source.default=8)
> 
>
> Key: KYLIN-4046
> URL: https://issues.apache.org/jira/browse/KYLIN-4046
> Project: Kylin
>  Issue Type: Bug
>  Components: RDBMS Source
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
>
> Currently, the function of ingest from RDBMS(kylin.source.default=8) to Kylin 
> has some problem such as:
>  # case-sensitive 
>  # weak dialect compatibility
>  # mis-use quote character
> We need to fix this problem in  kylin.source.default=8.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-4046) Refine JDBC Source(source.default=8)

2019-06-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875708#comment-16875708
 ] 

ASF GitHub Bot commented on KYLIN-4046:
---

nichunen commented on pull request #710: KYLIN-4046 Refine JDBC 
Source(source.default=8)
URL: https://github.com/apache/kylin/pull/710
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Refine JDBC Source(source.default=8)
> 
>
> Key: KYLIN-4046
> URL: https://issues.apache.org/jira/browse/KYLIN-4046
> Project: Kylin
>  Issue Type: Bug
>  Components: RDBMS Source
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
>
> Currently, the function of ingest from RDBMS(kylin.source.default=8) to Kylin 
> has some problem such as:
>  # case-sensitive 
>  # weak dialect compatibility
>  # mis-use quote character
> We need to fix this problem in  kylin.source.default=8.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] nichunen merged pull request #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-30 Thread GitBox
nichunen merged pull request #710: KYLIN-4046 Refine JDBC 
Source(source.default=8)
URL: https://github.com/apache/kylin/pull/710
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3628) Query with lookup table always use latest snapshot

2019-06-30 Thread XiaoXiang Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875703#comment-16875703
 ] 

XiaoXiang Yu commented on KYLIN-3628:
-

I can reproduce what you report, I will fix it.

> Query with lookup table always use latest snapshot
> --
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> If user queries a lookup table, Kylin will randomly selects a Cube (which has 
> the snapshot of this lookup table) to answer it. This causes uncertainty when 
> there are multiple cubes (share the same lookup): some cubes are newly built, 
> some not. If Kylin picks an old cube, the query result is old.
> To remove this uncertainty, for such queries, either always use latest 
> snapshot, or use earlist snapshot. We believe the "latest" version is better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)