[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113770#comment-17113770 ] ASF GitHub Bot commented on KYLIN-3698: --- zhangayqian opened a new pull request #1227: URL: https://github.com/apache/kylin/pull/1227 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] zhangayqian opened a new pull request #1227: KYLIN-3698 Fix kylin.sh can't export spark/flink/kafka dependency
zhangayqian opened a new pull request #1227: URL: https://github.com/apache/kylin/pull/1227 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zzcclp commented on pull request #1226: KYLIN-4495 Support custom date format for partition date column
zzcclp commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632456654 > @zzcclp Hi, have you tested the pr with your data source with a specified date format? Yes, I have tested this pr locally, it builded cube successfully with custom data format: /MM/dd. And will add ut in PartitionDescTest. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113719#comment-17113719 ] ASF GitHub Bot commented on KYLIN-4495: --- zzcclp commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632456654 > @zzcclp Hi, have you tested the pr with your data source with a specified date format? Yes, I have tested this pr locally, it builded cube successfully with custom data format: /MM/dd. And will add ut in PartitionDescTest. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support custom date formats for partition date column. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113712#comment-17113712 ] ASF GitHub Bot commented on KYLIN-4495: --- nichunen commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632453394 @zzcclp Hi, have you tested the pr with your data source with a specified date format? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support custom date formats for partition date column. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] nichunen commented on pull request #1226: KYLIN-4495 Support custom date format for partition date column
nichunen commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632453394 @zzcclp Hi, have you tested the pr with your data source with a specified date format? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113703#comment-17113703 ] ASF subversion and git services commented on KYLIN-3698: Commit a471808626ee9349173255d329673c509b5f4037 in kylin's branch refs/heads/master from yaqian.zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a471808 ] KYLIN-3698 some enhancement for check-env.sh > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113704#comment-17113704 ] ASF GitHub Bot commented on KYLIN-3698: --- nichunen merged pull request #1222: URL: https://github.com/apache/kylin/pull/1222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] nichunen merged pull request #1222: KYLIN-3698 some enhancement for check-env.sh
nichunen merged pull request #1222: URL: https://github.com/apache/kylin/pull/1222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113404#comment-17113404 ] ASF GitHub Bot commented on KYLIN-4495: --- coveralls commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632233973 ## Pull Request Test Coverage Report for [Build 5930](https://coveralls.io/builds/30949870) * **0** of **0** changed or added relevant lines in **0** files are covered. * **9** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.004%**) to **27.289%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30949870/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/30949870/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30949870/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30949870/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/30949870) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.004% | | Covered Lines: | 24349 | | Relevant Lines: | 89225 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support custom date formats for partition date column. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] coveralls commented on pull request #1226: KYLIN-4495 Support custom date format for partition date column
coveralls commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632233973 ## Pull Request Test Coverage Report for [Build 5930](https://coveralls.io/builds/30949870) * **0** of **0** changed or added relevant lines in **0** files are covered. * **9** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.004%**) to **27.289%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30949870/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/30949870/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30949870/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30949870/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/30949870) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.004% | | Covered Lines: | 24349 | | Relevant Lines: | 89225 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113397#comment-17113397 ] ASF GitHub Bot commented on KYLIN-4495: --- codecov-commenter commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632231689 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=h1) Report > Merging [#1226](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1226 +/- ## - Coverage 24.85% 24.84% -0.02% + Complexity 6266 6264 -2 Files 1453 1453 Lines 8922589225 Branches 1245612456 - Hits 2218122168 -13 - Misses6486964879 +10 - Partials 2175 2178 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=footer). Last update [7886a24...b10eeab](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support custom date formats for partition date column. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] codecov-commenter commented on pull request #1226: KYLIN-4495 Support custom date format for partition date column
codecov-commenter commented on pull request #1226: URL: https://github.com/apache/kylin/pull/1226#issuecomment-632231689 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=h1) Report > Merging [#1226](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1226 +/- ## - Coverage 24.85% 24.84% -0.02% + Complexity 6266 6264 -2 Files 1453 1453 Lines 8922589225 Branches 1245612456 - Hits 2218122168 -13 - Misses6486964879 +10 - Partials 2175 2178 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1226/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=footer). Last update [7886a24...b10eeab](https://codecov.io/gh/apache/kylin/pull/1226?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113331#comment-17113331 ] ASF GitHub Bot commented on KYLIN-4495: --- zzcclp opened a new pull request #1226: URL: https://github.com/apache/kylin/pull/1226 Support custom date format for partition date column. ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support custom date formats for partition date column. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] zzcclp opened a new pull request #1226: KYLIN-4495 Support custom date format for partition date column
zzcclp opened a new pull request #1226: URL: https://github.com/apache/kylin/pull/1226 Support custom date format for partition date column. ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[ https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113313#comment-17113313 ] ASF GitHub Bot commented on KYLIN-2971: --- codecov-commenter edited a comment on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=h1) Report > Merging [#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1215 +/- ## - Coverage 24.85% 24.83% -0.03% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589237 +12 Branches 1245612458 +2 - Hits 2218122165 -16 - Misses6486964892 +23 - Partials 2175 2180 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=footer). Last update [7886a24...2ef96ec](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix the wrong "Realization Names" in logQuery when hit cache > > > Key: KYLIN-2971 > URL: https://issues.apache.org/jira/browse/KYLIN-2971 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > Attachments: APACHE-KYLIN-2971.patch > > > # The value of "Realization Names" in logQuery is wrong when query two > different sqls within the same thread and second sql hits cache: > Example: > 1). query Q1 hit project P1 and cube
[GitHub] [kylin] codecov-commenter edited a comment on pull request #1215: KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache
codecov-commenter edited a comment on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=h1) Report > Merging [#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1215 +/- ## - Coverage 24.85% 24.83% -0.03% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589237 +12 Branches 1245612458 +2 - Hits 2218122165 -16 - Misses6486964892 +23 - Partials 2175 2180 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=footer). Last update [7886a24...2ef96ec](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1215: KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache
coveralls edited a comment on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387 ## Pull Request Test Coverage Report for [Build 5929](https://coveralls.io/builds/30947782) * **0** of **13** **(0.0%)** changed or added relevant lines in **1** file are covered. * **5** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.009%**) to **27.285%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30947782/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L338) | 0 | 13 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30947782/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30947782/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30947782/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | Totals | [](https://coveralls.io/builds/30947782) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.009% | | Covered Lines: | 24348 | | Relevant Lines: | 89237 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113307#comment-17113307
]
ASF GitHub Bot commented on KYLIN-2971:
---
coveralls edited a comment on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387
## Pull Request Test Coverage Report for [Build
5929](https://coveralls.io/builds/30947782)
* **0** of **13** **(0.0%)** changed or added relevant lines in **1**
file are covered.
* **5** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.009%**) to **27.285%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-|--||---: |
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30947782/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L338)
| 0 | 13 | 0.0%
| Files with Coverage Reduction | New Missed Lines | % |
| :-|--|--: |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30947782/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
| 1 | 81.08% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30947782/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30947782/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
| 2 | 73.74% |
| Totals | [](https://coveralls.io/builds/30947782)
|
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): |
-0.009% |
| Covered Lines: | 24348 |
| Relevant Lines: | 89237 |
---
# - [Coveralls](https://coveralls.io)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhichao Zhang updated KYLIN-4495: -- Description: Support custom date formats for partition date column. (was: Support more date formats for partition date column, for example: /MM/dd.) > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support custom date formats for partition date column. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KYLIN-4495) Support custom date formats for partition date column
[ https://issues.apache.org/jira/browse/KYLIN-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhichao Zhang updated KYLIN-4495: -- Summary: Support custom date formats for partition date column (was: Support more date formats for partition date column) > Support custom date formats for partition date column > - > > Key: KYLIN-4495 > URL: https://issues.apache.org/jira/browse/KYLIN-4495 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Reporter: Zhichao Zhang >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > > Support more date formats for partition date column, for example: /MM/dd. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113207#comment-17113207 ] ASF GitHub Bot commented on KYLIN-4485: --- codecov-commenter edited a comment on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-631513549 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=h1) Report > Merging [#1218](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/a17419409199fc2fca3116718ce658040e0d6bbf=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0.68%`. [](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1218 +/- ## - Coverage 24.87% 24.85% -0.02% - Complexity 6264 6266 +2 Files 1453 1453 Lines 8912089225 +105 Branches 1243812456 +18 + Hits 2217222181 +9 - Misses6477164869 +98 + Partials 2177 2175 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.12% <0.00%> (-0.04%)` | `44.00 <0.00> (ø)` | | | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.44% <0.00%> (+0.23%)` | `2.00 <0.00> (ø)` | | | [...engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ29udmVyZ2VDdWJvaWREYXRhUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...lin/engine/mr/steps/FactDistinctColumnsMapper.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvRmFjdERpc3RpbmN0Q29sdW1uc01hcHBlci5qYXZh) | `5.17% <0.00%> (-0.05%)` | `0.00 <0.00> (ø)` | | | [...va/org/apache/kylin/source/kafka/KafkaMRInput.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvS2Fma2FNUklucHV0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...che/kylin/storage/hbase/steps/CreateHTableJob.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DcmVhdGVIVGFibGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSEZpbGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSFRhYmxlVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../kylin/storage/hbase/steps/HFileOutputFormat3.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IRmlsZU91dHB1dEZvcm1hdDMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/storage/hbase/lookup/HBaseLookupRowEncoder.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvSEJhc2VMb29rdXBSb3dFbmNvZGVyLmphdmE=) | `92.59% <100.00%> (ø)` | `11.00 <0.00> (ø)` | | | ... and [4 more](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
[GitHub] [kylin] codecov-commenter edited a comment on pull request #1218: KYLIN-4485 Create a self service interface for cube migration
codecov-commenter edited a comment on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-631513549 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=h1) Report > Merging [#1218](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/a17419409199fc2fca3116718ce658040e0d6bbf=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0.68%`. [](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1218 +/- ## - Coverage 24.87% 24.85% -0.02% - Complexity 6264 6266 +2 Files 1453 1453 Lines 8912089225 +105 Branches 1243812456 +18 + Hits 2217222181 +9 - Misses6477164869 +98 + Partials 2177 2175 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.12% <0.00%> (-0.04%)` | `44.00 <0.00> (ø)` | | | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.44% <0.00%> (+0.23%)` | `2.00 <0.00> (ø)` | | | [...engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ29udmVyZ2VDdWJvaWREYXRhUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...lin/engine/mr/steps/FactDistinctColumnsMapper.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvRmFjdERpc3RpbmN0Q29sdW1uc01hcHBlci5qYXZh) | `5.17% <0.00%> (-0.05%)` | `0.00 <0.00> (ø)` | | | [...va/org/apache/kylin/source/kafka/KafkaMRInput.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvS2Fma2FNUklucHV0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...che/kylin/storage/hbase/steps/CreateHTableJob.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DcmVhdGVIVGFibGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSEZpbGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSFRhYmxlVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../kylin/storage/hbase/steps/HFileOutputFormat3.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IRmlsZU91dHB1dEZvcm1hdDMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/storage/hbase/lookup/HBaseLookupRowEncoder.java](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvSEJhc2VMb29rdXBSb3dFbmNvZGVyLmphdmE=) | `92.59% <100.00%> (ø)` | `11.00 <0.00> (ø)` | | | ... and [4 more](https://codecov.io/gh/apache/kylin/pull/1218/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=footer). Last update [a174194...22ca85b](https://codecov.io/gh/apache/kylin/pull/1218?src=pr=lastupdated). Read the [comment
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113191#comment-17113191
]
ASF GitHub Bot commented on KYLIN-2971:
---
coveralls edited a comment on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387
## Pull Request Test Coverage Report for [Build
5927](https://coveralls.io/builds/30944339)
* **0** of **13** **(0.0%)** changed or added relevant lines in **1**
file are covered.
* **5** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.004%**) to **27.29%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-|--||---: |
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30944339/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L338)
| 0 | 13 | 0.0%
| Files with Coverage Reduction | New Missed Lines | % |
| :-|--|--: |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30944339/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
| 2 | 73.74% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30944339/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 3 | 78.42% |
| Totals | [](https://coveralls.io/builds/30944339)
|
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): |
-0.004% |
| Covered Lines: | 24353 |
| Relevant Lines: | 89237 |
---
# - [Coveralls](https://coveralls.io)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [kylin] coveralls edited a comment on pull request #1215: KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache
coveralls edited a comment on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387 ## Pull Request Test Coverage Report for [Build 5927](https://coveralls.io/builds/30944339) * **0** of **13** **(0.0%)** changed or added relevant lines in **1** file are covered. * **5** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.004%**) to **27.29%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30944339/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L338) | 0 | 13 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30944339/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30944339/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/30944339) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.004% | | Covered Lines: | 24353 | | Relevant Lines: | 89237 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (KYLIN-4450) Add the feature that adjusting spark driver memory adaptively
[
https://issues.apache.org/jira/browse/KYLIN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112849#comment-17112849
]
wangrupeng edited comment on KYLIN-4450 at 5/21/20, 7:13 AM:
-
Auto adujust spark driver memory is belong to the feature "Auto adjust spark
parameters" of Kylin on Parquet. See more about thie feature from
[https://github.com/Kyligence/kylin-on-parquet-v2/wiki#adaptively-adjust-spark-parameters]
was (Author: wangrupeng):
Auto adujust spark driver memory is belong to the feature "Auto adjust spark
parameters" of Kylin on Parquet. See more about thie feature from
[https://github.com/Kyligence/kylin-on-parquet-v2/wiki
|https://github.com/Kyligence/kylin-on-parquet-v2/wiki]
> Add the feature that adjusting spark driver memory adaptively
> -
>
> Key: KYLIN-4450
> URL: https://issues.apache.org/jira/browse/KYLIN-4450
> Project: Kylin
> Issue Type: Improvement
> Components: Storage - Parquet
>Reporter: xuekaiqi
>Assignee: wangrupeng
>Priority: Major
> Fix For: v4.0.0-beta
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> For now the cubing job can adaptively adjust the following spark properties
> to use of resources retionally, but the driver memory of the spark job
> uploaded to cluster haven't been done.
>
> {code:java}
> spark.executor.memory
> spark.executor.cores
> spark.executor.memoryOverhead
> spark.executor.instances
> spark.sql.shuffle.partitions
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (KYLIN-4450) Add the feature that adjusting spark driver memory adaptively
[
https://issues.apache.org/jira/browse/KYLIN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112849#comment-17112849
]
wangrupeng edited comment on KYLIN-4450 at 5/21/20, 6:54 AM:
-
Auto adujust spark driver memory is belong to the feature "Auto adjust spark
parameters" of Kylin on Parquet. See more about thie feature from
[https://github.com/Kyligence/kylin-on-parquet-v2/wiki
|https://github.com/Kyligence/kylin-on-parquet-v2/wiki]
was (Author: wangrupeng):
Auto adujust spark driver memory is belong to the feature "Auto adjust spark
parameters" of Kylin on Parquet. See more about thie feature from [GitHub
Wiki]([https://github.com/Kyligence/kylin-on-parquet-v2/wiki)|https://github.com/Kyligence/kylin-on-parquet-v2/wiki]
> Add the feature that adjusting spark driver memory adaptively
> -
>
> Key: KYLIN-4450
> URL: https://issues.apache.org/jira/browse/KYLIN-4450
> Project: Kylin
> Issue Type: Improvement
> Components: Storage - Parquet
>Reporter: xuekaiqi
>Assignee: wangrupeng
>Priority: Major
> Fix For: v4.0.0-beta
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> For now the cubing job can adaptively adjust the following spark properties
> to use of resources retionally, but the driver memory of the spark job
> uploaded to cluster haven't been done.
>
> {code:java}
> spark.executor.memory
> spark.executor.cores
> spark.executor.memoryOverhead
> spark.executor.instances
> spark.sql.shuffle.partitions
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4450) Add the feature that adjusting spark driver memory adaptively
[
https://issues.apache.org/jira/browse/KYLIN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112849#comment-17112849
]
wangrupeng commented on KYLIN-4450:
---
Auto adujust spark driver memory is belong to the feature "Auto adjust spark
parameters" of Kylin on Parquet. See more about thie feature from [GitHub
Wiki|[https://github.com/Kyligence/kylin-on-parquet-v2/wiki]]
> Add the feature that adjusting spark driver memory adaptively
> -
>
> Key: KYLIN-4450
> URL: https://issues.apache.org/jira/browse/KYLIN-4450
> Project: Kylin
> Issue Type: Improvement
> Components: Storage - Parquet
>Reporter: xuekaiqi
>Assignee: wangrupeng
>Priority: Major
> Fix For: v4.0.0-beta
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> For now the cubing job can adaptively adjust the following spark properties
> to use of resources retionally, but the driver memory of the spark job
> uploaded to cluster haven't been done.
>
> {code:java}
> spark.executor.memory
> spark.executor.cores
> spark.executor.memoryOverhead
> spark.executor.instances
> spark.sql.shuffle.partitions
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4450) Add the feature that adjusting spark driver memory adaptively
[
https://issues.apache.org/jira/browse/KYLIN-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112848#comment-17112848
]
wangrupeng commented on KYLIN-4450:
---
If "spark.driver.memory" is not set, kylin will auto adjust driver memory with
the number of cuboids.
> Add the feature that adjusting spark driver memory adaptively
> -
>
> Key: KYLIN-4450
> URL: https://issues.apache.org/jira/browse/KYLIN-4450
> Project: Kylin
> Issue Type: Improvement
> Components: Storage - Parquet
>Reporter: xuekaiqi
>Assignee: wangrupeng
>Priority: Major
> Fix For: v4.0.0-beta
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> For now the cubing job can adaptively adjust the following spark properties
> to use of resources retionally, but the driver memory of the spark job
> uploaded to cluster haven't been done.
>
> {code:java}
> spark.executor.memory
> spark.executor.cores
> spark.executor.memoryOverhead
> spark.executor.instances
> spark.sql.shuffle.partitions
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
