[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139008#comment-17139008
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus merged pull request #1272:
URL: https://github.com/apache/kylin/pull/1272


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin pushdown to support postgresql
> 
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: New Feature
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
> Fix For: v3.1.0
>
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus merged pull request #1272:
URL: https://github.com/apache/kylin/pull/1272


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139006#comment-17139006
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   
![image](https://user-images.githubusercontent.com/14030549/84975764-dc54ba00-b158-11ea-88f0-5a9b39003c99.png)
   
   
   - Build Success 
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - kylin.log
   ```sh
   2020-06-18 11:41:50,986 DEBUG [http-bio-8005-exec-4] 
extensible.JdbcHiveInputBase:129 : sqoop cmd: --connect 
"jdbc:postgresql://10.1.3.94:5432/kylin_test_db" --driver 
"org.postgresql.Driver" --username "postgres" --password "password" --query 
"SELECT FILM_PLAY.AUDIENCE_ID as FILM_PLAY_AUDIENCE_ID ,FILM_PLAY.FILM_ID as 
FILM_PLAY_FILM_ID ,FILM_PLAY.WATCH_TIME ,FILM_PLAY.PAYMENT as FILM_PLAY_PAYMENT 
 FROM SC1.FILM_PLAY as FILM_PLAY LEFT JOIN SC2.AUDIENCE as AUDIENCE ON 
FILM_PLAY.AUDIENCE_ID = AUDIENCE.AUDIENCE_ID LEFT JOIN PUBLIC.FILM as FILM ON 
FILM_PLAY.FILM_ID = FILM.FILM_ID WHERE 1=1 AND (FILM_PLAY.WATCH_TIME >= 
'2012-01-01 00:00:00' AND FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00')  AND 
\$CONDITIONS" --target-dir 
"hdfs://cdh-master:8020/LACUS/LACUS-tmp/kylin-ef6e4fd7-f72d-f7a0-fdca-b32bb0153493/kylin_intermediate_filmanalysis_5b0b0b6a_0ad3_14fd_30ed_27cf74504666"
 --split-by "FILM_PLAY.WATCH_TIME" --boundary-query "SELECT 
min(FILM_PLAY.WATCH_TIME), max(FILM_PLAY.WATCH_TIME) FROM SC1.FILM_PLAY as 
FILM_PLAY WHERE FILM_PLAY.WATCH_TIME >= '2012-01-01 00:00:00' AND 
FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00'" --null-string '' 
--fields-terminated-by '|' --num-mappers 4
   2020-06-18 11:41:51,046 DEBUG [http-bio-8005-exec-4] 
hbase.HBaseConnection:181 : Using the working dir FS for HBase: 
hdfs://cdh-master:8020
   2020-06-18 11:41:51,049 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,050 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute_output, 
event=create, cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,053 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,054 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute, event=create, 
cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,069 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,070 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:65 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} prepare to schedule and its priority is 20
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:69 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} scheduled
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.DefaultFetcherRunner:115 : Job Fetcher: 0 should running, 1 actual 
running, 0 stopped, 1 ready, 4 already succeed, 0 error, 7 discarded, 0 others
   2020-06-18 11:42:05,813 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] execution.AbstractExecutable:161 : 
Executing AbstractExecutable (BUILD CUBE - FilmAnalysis - 
2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50)
   2020-06-18 11:42:05,816 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] 

[GitHub] [kylin] hit-lacus edited a comment on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   
![image](https://user-images.githubusercontent.com/14030549/84975764-dc54ba00-b158-11ea-88f0-5a9b39003c99.png)
   
   
   - Build Success 
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - kylin.log
   ```sh
   2020-06-18 11:41:50,986 DEBUG [http-bio-8005-exec-4] 
extensible.JdbcHiveInputBase:129 : sqoop cmd: --connect 
"jdbc:postgresql://10.1.3.94:5432/kylin_test_db" --driver 
"org.postgresql.Driver" --username "postgres" --password "password" --query 
"SELECT FILM_PLAY.AUDIENCE_ID as FILM_PLAY_AUDIENCE_ID ,FILM_PLAY.FILM_ID as 
FILM_PLAY_FILM_ID ,FILM_PLAY.WATCH_TIME ,FILM_PLAY.PAYMENT as FILM_PLAY_PAYMENT 
 FROM SC1.FILM_PLAY as FILM_PLAY LEFT JOIN SC2.AUDIENCE as AUDIENCE ON 
FILM_PLAY.AUDIENCE_ID = AUDIENCE.AUDIENCE_ID LEFT JOIN PUBLIC.FILM as FILM ON 
FILM_PLAY.FILM_ID = FILM.FILM_ID WHERE 1=1 AND (FILM_PLAY.WATCH_TIME >= 
'2012-01-01 00:00:00' AND FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00')  AND 
\$CONDITIONS" --target-dir 
"hdfs://cdh-master:8020/LACUS/LACUS-tmp/kylin-ef6e4fd7-f72d-f7a0-fdca-b32bb0153493/kylin_intermediate_filmanalysis_5b0b0b6a_0ad3_14fd_30ed_27cf74504666"
 --split-by "FILM_PLAY.WATCH_TIME" --boundary-query "SELECT 
min(FILM_PLAY.WATCH_TIME), max(FILM_PLAY.WATCH_TIME) FROM SC1.FILM_PLAY as 
FILM_PLAY WHERE FILM_PLAY.WATCH_TIME >= '2012-01-01 00:00:00' AND 
FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00'" --null-string '' 
--fields-terminated-by '|' --num-mappers 4
   2020-06-18 11:41:51,046 DEBUG [http-bio-8005-exec-4] 
hbase.HBaseConnection:181 : Using the working dir FS for HBase: 
hdfs://cdh-master:8020
   2020-06-18 11:41:51,049 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,050 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute_output, 
event=create, cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,053 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,054 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute, event=create, 
cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,069 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,070 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:65 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} prepare to schedule and its priority is 20
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:69 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} scheduled
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.DefaultFetcherRunner:115 : Job Fetcher: 0 should running, 1 actual 
running, 0 stopped, 1 ready, 4 already succeed, 0 error, 7 discarded, 0 others
   2020-06-18 11:42:05,813 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] execution.AbstractExecutable:161 : 
Executing AbstractExecutable (BUILD CUBE - FilmAnalysis - 
2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50)
   2020-06-18 11:42:05,816 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] execution.ExecutableManager:479 : job 
id:ef6e4fd7-f72d-f7a0-fdca-b32bb0153493 from READY to RUNNING
   2020-06-18 11:42:05,816 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 

[GitHub] [kylin] hit-lacus edited a comment on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   
![image](https://user-images.githubusercontent.com/14030549/84975764-dc54ba00-b158-11ea-88f0-5a9b39003c99.png)
   
   
   - Build Success 
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   ```sh
   2020-06-18 11:41:50,986 DEBUG [http-bio-8005-exec-4] 
extensible.JdbcHiveInputBase:129 : sqoop cmd: --connect 
"jdbc:postgresql://10.1.3.94:5432/kylin_test_db" --driver 
"org.postgresql.Driver" --username "postgres" --password "password" --query 
"SELECT FILM_PLAY.AUDIENCE_ID as FILM_PLAY_AUDIENCE_ID ,FILM_PLAY.FILM_ID as 
FILM_PLAY_FILM_ID ,FILM_PLAY.WATCH_TIME ,FILM_PLAY.PAYMENT as FILM_PLAY_PAYMENT 
 FROM SC1.FILM_PLAY as FILM_PLAY LEFT JOIN SC2.AUDIENCE as AUDIENCE ON 
FILM_PLAY.AUDIENCE_ID = AUDIENCE.AUDIENCE_ID LEFT JOIN PUBLIC.FILM as FILM ON 
FILM_PLAY.FILM_ID = FILM.FILM_ID WHERE 1=1 AND (FILM_PLAY.WATCH_TIME >= 
'2012-01-01 00:00:00' AND FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00')  AND 
\$CONDITIONS" --target-dir 
"hdfs://cdh-master:8020/LACUS/LACUS-tmp/kylin-ef6e4fd7-f72d-f7a0-fdca-b32bb0153493/kylin_intermediate_filmanalysis_5b0b0b6a_0ad3_14fd_30ed_27cf74504666"
 --split-by "FILM_PLAY.WATCH_TIME" --boundary-query "SELECT 
min(FILM_PLAY.WATCH_TIME), max(FILM_PLAY.WATCH_TIME) FROM SC1.FILM_PLAY as 
FILM_PLAY WHERE FILM_PLAY.WATCH_TIME >= '2012-01-01 00:00:00' AND 
FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00'" --null-string '' 
--fields-terminated-by '|' --num-mappers 4
   2020-06-18 11:41:51,046 DEBUG [http-bio-8005-exec-4] 
hbase.HBaseConnection:181 : Using the working dir FS for HBase: 
hdfs://cdh-master:8020
   2020-06-18 11:41:51,049 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,050 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute_output, 
event=create, cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,053 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,054 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute, event=create, 
cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,069 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,070 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:65 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} prepare to schedule and its priority is 20
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:69 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} scheduled
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.DefaultFetcherRunner:115 : Job Fetcher: 0 should running, 1 actual 
running, 0 stopped, 1 ready, 4 already succeed, 0 error, 7 discarded, 0 others
   2020-06-18 11:42:05,813 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] execution.AbstractExecutable:161 : 
Executing AbstractExecutable (BUILD CUBE - FilmAnalysis - 
2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50)
   2020-06-18 11:42:05,816 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] execution.ExecutableManager:479 : job 
id:ef6e4fd7-f72d-f7a0-fdca-b32bb0153493 from READY to RUNNING
   2020-06-18 11:42:05,816 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:42:05,816 DEBUG 

[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139005#comment-17139005
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   
![image](https://user-images.githubusercontent.com/14030549/84975764-dc54ba00-b158-11ea-88f0-5a9b39003c99.png)
   
   
   - Build Success 
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   ```sh
   2020-06-18 11:41:50,986 DEBUG [http-bio-8005-exec-4] 
extensible.JdbcHiveInputBase:129 : sqoop cmd: --connect 
"jdbc:postgresql://10.1.3.94:5432/kylin_test_db" --driver 
"org.postgresql.Driver" --username "postgres" --password "password" --query 
"SELECT FILM_PLAY.AUDIENCE_ID as FILM_PLAY_AUDIENCE_ID ,FILM_PLAY.FILM_ID as 
FILM_PLAY_FILM_ID ,FILM_PLAY.WATCH_TIME ,FILM_PLAY.PAYMENT as FILM_PLAY_PAYMENT 
 FROM SC1.FILM_PLAY as FILM_PLAY LEFT JOIN SC2.AUDIENCE as AUDIENCE ON 
FILM_PLAY.AUDIENCE_ID = AUDIENCE.AUDIENCE_ID LEFT JOIN PUBLIC.FILM as FILM ON 
FILM_PLAY.FILM_ID = FILM.FILM_ID WHERE 1=1 AND (FILM_PLAY.WATCH_TIME >= 
'2012-01-01 00:00:00' AND FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00')  AND 
\$CONDITIONS" --target-dir 
"hdfs://cdh-master:8020/LACUS/LACUS-tmp/kylin-ef6e4fd7-f72d-f7a0-fdca-b32bb0153493/kylin_intermediate_filmanalysis_5b0b0b6a_0ad3_14fd_30ed_27cf74504666"
 --split-by "FILM_PLAY.WATCH_TIME" --boundary-query "SELECT 
min(FILM_PLAY.WATCH_TIME), max(FILM_PLAY.WATCH_TIME) FROM SC1.FILM_PLAY as 
FILM_PLAY WHERE FILM_PLAY.WATCH_TIME >= '2012-01-01 00:00:00' AND 
FILM_PLAY.WATCH_TIME < '2012-12-01 00:00:00'" --null-string '' 
--fields-terminated-by '|' --num-mappers 4
   2020-06-18 11:41:51,046 DEBUG [http-bio-8005-exec-4] 
hbase.HBaseConnection:181 : Using the working dir FS for HBase: 
hdfs://cdh-master:8020
   2020-06-18 11:41:51,049 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,050 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute_output, 
event=create, cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,053 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,054 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute_output, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:119 : 
Servers in the cluster: [localhost:8005]
   2020-06-18 11:41:51,066 DEBUG [pool-6-thread-1] cachesync.Broadcaster:129 : 
Announcing new broadcast to all: BroadcastEvent{entity=execute, event=create, 
cacheKey=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493}
   2020-06-18 11:41:51,069 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:267 : Broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:41:51,070 DEBUG [http-bio-8005-exec-3] 
cachesync.Broadcaster:301 : Done broadcasting CREATE, execute, 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:65 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} prepare to schedule and its priority is 20
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.FetcherRunner:69 : 
CubingJob{id=ef6e4fd7-f72d-f7a0-fdca-b32bb0153493, name=BUILD CUBE - 
FilmAnalysis - 2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50, 
state=READY} scheduled
   2020-06-18 11:42:05,813 INFO  [FetcherRunner 1308001235-46] 
threadpool.DefaultFetcherRunner:115 : Job Fetcher: 0 should running, 1 actual 
running, 0 stopped, 1 ready, 4 already succeed, 0 error, 7 discarded, 0 others
   2020-06-18 11:42:05,813 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] execution.AbstractExecutable:161 : 
Executing AbstractExecutable (BUILD CUBE - FilmAnalysis - 
2012010100_2012120100 - GMT+08:00 2020-06-18 11:41:50)
   2020-06-18 11:42:05,816 INFO  [Scheduler 1125220712 Job 
ef6e4fd7-f72d-f7a0-fdca-b32bb0153493-276] 

[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139003#comment-17139003
 ] 

ASF GitHub Bot commented on KYLIN-4511:
---

RupengWang edited a comment on pull request #1225:
URL: https://github.com/apache/kylin/pull/1225#issuecomment-643761762







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support project admin user to calculate column cardinality by web
> -
>
> Key: KYLIN-4511
> URL: https://issues.apache.org/jira/browse/KYLIN-4511
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: v3.1.0
>
> Attachments: image-2020-05-21-13-56-19-962.png, 
> image-2020-05-21-13-57-29-350.png
>
>
> Now only the administrator of kylin can recalculate the cardinality of the 
> hive table through the admin web, but the project administrator cannot.
> Add an entry to calculate cardinality on the table detail web
>  # add calculate cardinality button 
> !image-2020-05-21-13-56-19-962.png|width=902,height=303!
>  # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang edited a comment on pull request #1225: KYLIN-4511 Support project admin user to calculate column cardinality…

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #1225:
URL: https://github.com/apache/kylin/pull/1225#issuecomment-643761762







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138983#comment-17138983
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang removed a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-644650777


   ### Check list
   - [x] Step 1. [**OPTIONAL**]Understand background/root cause/design 
basically(one hour EST) . Its issue type is 
   - [ ] bug fix
   - [ ] new feature
   - [x] enhancement
   - [x] Step 2. Test cases are designed and documented (30 minutes EST).
   - [x] Step 3. Prepare specific env, for example:
   - mock data (maybe some specific data type)
   - test env (maybe install a RDBMS instance).
   - [x] Step 4. Verify and make sure test cases passed.
   - [x] Step 5. Paste manual important steps and screenshots here (20 minutes 
EST). 
   - If you find difficulty in pick most important evidence, please attach 
diagnosis package. 
   - [x] Step 6. Do more check in user perspective (20 minutes EST)
   - [x] Doc need be updated? And if it is updated? Ask help for release 
manager if so.
   - [x] If it is a breaking change so we should notify Kylin community? 
Ask help for release manager if so.
   - [x] Step 7.  Summarize this test (20 minutes EST).
   
   ### Total estimate
   - 4 hours for small issue from optimistic estimate. 
   
   ### Note
   If you find some unexpected and **unrelated** error/mistake, please DO 
report it if it is truly a mistake, I think we may research and fix it in the 
future.
   
   If you find background information/root cause analysis is not complete or 
ambiguous, please try to contact to author or do a quick research and record 
what you find. It is a good chance to learn something interesting.
   
   If you find it is not easy to design testcase, please notify release manager.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138982#comment-17138982
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-644650777







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang removed a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang removed a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-644650777


   ### Check list
   - [x] Step 1. [**OPTIONAL**]Understand background/root cause/design 
basically(one hour EST) . Its issue type is 
   - [ ] bug fix
   - [ ] new feature
   - [x] enhancement
   - [x] Step 2. Test cases are designed and documented (30 minutes EST).
   - [x] Step 3. Prepare specific env, for example:
   - mock data (maybe some specific data type)
   - test env (maybe install a RDBMS instance).
   - [x] Step 4. Verify and make sure test cases passed.
   - [x] Step 5. Paste manual important steps and screenshots here (20 minutes 
EST). 
   - If you find difficulty in pick most important evidence, please attach 
diagnosis package. 
   - [x] Step 6. Do more check in user perspective (20 minutes EST)
   - [x] Doc need be updated? And if it is updated? Ask help for release 
manager if so.
   - [x] If it is a breaking change so we should notify Kylin community? 
Ask help for release manager if so.
   - [x] Step 7.  Summarize this test (20 minutes EST).
   
   ### Total estimate
   - 4 hours for small issue from optimistic estimate. 
   
   ### Note
   If you find some unexpected and **unrelated** error/mistake, please DO 
report it if it is truly a mistake, I think we may research and fix it in the 
future.
   
   If you find background information/root cause analysis is not complete or 
ambiguous, please try to contact to author or do a quick research and record 
what you find. It is a good chance to learn something interesting.
   
   If you find it is not easy to design testcase, please notify release manager.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] RupengWang edited a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-644650777







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138978#comment-17138978
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success 
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   
   
![image](https://user-images.githubusercontent.com/14030549/84974029-0906d280-b155-11ea-99e2-fb58921c00bd.png)
   
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at 

[GitHub] [kylin] hit-lacus edited a comment on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success 
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   
   
![image](https://user-images.githubusercontent.com/14030549/84974029-0906d280-b155-11ea-99e2-fb58921c00bd.png)
   
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at 

[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138976#comment-17138976
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 

[GitHub] [kylin] hit-lacus edited a comment on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in `postgresql.xml`,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
at 

[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138975#comment-17138975
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in postgresql.xml,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 

[GitHub] [kylin] hit-lacus edited a comment on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   # Test Report
   
   ### Root cause
   
   From the documentation of pg, we know that when identifier is quoted, 
identifier is case sensitive, but Kylin use all upper-case, which make quoted 
identifier not identifiable by pg. 
   
   At my patch, I disable all quote switch in postgresql.xml,  so we cannot 
support reserved word as identifier, which is rare.
   
   ### Test Result
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
at 

[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138973#comment-17138973
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   ### Test Report
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
at 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
at 

[GitHub] [kylin] hit-lacus edited a comment on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   ### Test Report
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   
   
   - Build Success
   
![image](https://user-images.githubusercontent.com/14030549/84973189-1622c200-b153-11ea-90e1-beafd6b1c517.png)
   
   - Pushdown error
   
   ```sh
   
   2020-06-18 10:53:12,241 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] service.QueryService:679 : The 
corrected query: select * from (select film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5
   2020-06-18 10:53:12,301 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:63 : Find 
candidates by table SC1.FILM_PLAY and project=PgTestPrj : 
CUBE[name=FilmCube_clone_clone]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveBlackoutRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: 
[CUBE[name=FilmCube_clone_clone]]
   2020-06-18 10:53:12,302 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] cube.CubeCapabilityChecker:119 : 
Exclude cube FilmCube_clone_clone because unmatched aggregations: [FunctionDesc 
[expression=COUNT_DISTINCT, parameter=SC1.FILM_PLAY.PAYMENT, returnType=null]]
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class 
org.apache.kylin.query.routing.rules.RemoveUncapableRealizationsRule, 
realizations before: [CUBE[name=FilmCube_clone_clone]], realizations after: []
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] rules.RealizationSortRule:40 :
   2020-06-18 10:53:12,303 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.QueryRouter:51 : Applying 
rule: class org.apache.kylin.query.routing.rules.RealizationSortRule, 
realizations before: [], realizations after: []
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] routing.RealizationChooser:92 : Give 
up on model DataModelDesc [name=FilmModel] because no suitable realization is 
found
   2020-06-18 10:53:12,304 INFO  [Query 
72145593-a090-2676-9574-747a5df549db-64] util.PushDownExecutor:71 : Query 
failed to utilize pre-calculation, routing to other engines
   java.sql.SQLException: Error while executing SQL "select * from (select 
film_id, count(distinct payment)
   from sc1.film_play
   group by film_id) limit 5": No realization found for OLAPContext, 
CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=COUNT_DISTINCT, 
parameter=1_6906aea2:SC1.FILM_PLAY.PAYMENT, returnType=null]], CUBE_NOT_READY, 
CUBE_NOT_READY, rel#83:OLAPTableScan.OLAP.[](table=[SC1, 
FILM_PLAY],ctx=,fields=[0, 1, 2, 3, 4, 5])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
at 
org.apache.kylin.rest.service.QueryService.executeRequest(QueryService.java:1003)
at 
org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:699)
at 
org.apache.kylin.rest.service.QueryService.query(QueryService.java:221)
at 
org.apache.kylin.rest.service.QueryService.queryAndUpdateCache(QueryService.java:507)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:467)
at 
org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:398)
at 
org.apache.kylin.rest.controller.QueryController.query(QueryController.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
at 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:849)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:760)
   

[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138972#comment-17138972
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus commented on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   ### Test Report
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin pushdown to support postgresql
> 
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: New Feature
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
> Fix For: v3.1.0
>
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus commented on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus commented on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645741145


   ### Test Report
   After applied my patch, build from pg data source is fine, but pushdown is 
still not work, because it is caused by another patch from KYLIN-4068 .
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] coveralls commented on pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


coveralls commented on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645737742


   ## Pull Request Test Coverage Report for [Build 
6040](https://coveralls.io/builds/31527067)
   
   * **5** of **6**   **(83.33%)**  changed or added relevant lines in **2** 
files are covered.
   * **19** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.004%**) to **27.965%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[source-jdbc/src/main/java/org/apache/kylin/source/jdbc/extensible/JdbcHiveInputBase.java](https://coveralls.io/builds/31527067/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2Fextensible%2FJdbcHiveInputBase.java#L107)
 | 2 | 3 | 66.67%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31527067/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 1 | 83.33% |
   | 
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/DefaultConfigurer.java](https://coveralls.io/builds/31527067/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FDefaultConfigurer.java#L127)
 | 2 | 87.5% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31527067/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   | 
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/utils/ExpressionComparator.java](https://coveralls.io/builds/31527067/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Futils%2FExpressionComparator.java#L57)
 | 11 | 63.38% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31527067/badge)](https://coveralls.io/builds/31527067)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
-0.004% |
   | Covered Lines: | 26098 |
   | Relevant Lines: | 93324 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138969#comment-17138969
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

coveralls commented on pull request #1272:
URL: https://github.com/apache/kylin/pull/1272#issuecomment-645737742


   ## Pull Request Test Coverage Report for [Build 
6040](https://coveralls.io/builds/31527067)
   
   * **5** of **6**   **(83.33%)**  changed or added relevant lines in **2** 
files are covered.
   * **19** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.004%**) to **27.965%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[source-jdbc/src/main/java/org/apache/kylin/source/jdbc/extensible/JdbcHiveInputBase.java](https://coveralls.io/builds/31527067/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2Fextensible%2FJdbcHiveInputBase.java#L107)
 | 2 | 3 | 66.67%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31527067/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 1 | 83.33% |
   | 
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/DefaultConfigurer.java](https://coveralls.io/builds/31527067/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FDefaultConfigurer.java#L127)
 | 2 | 87.5% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31527067/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   | 
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/utils/ExpressionComparator.java](https://coveralls.io/builds/31527067/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Futils%2FExpressionComparator.java#L57)
 | 11 | 63.38% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31527067/badge)](https://coveralls.io/builds/31527067)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
-0.004% |
   | Covered Lines: | 26098 |
   | Relevant Lines: | 93324 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin pushdown to support postgresql
> 
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: New Feature
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
> Fix For: v3.1.0
>
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138963#comment-17138963
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

hit-lacus merged pull request #1271:
URL: https://github.com/apache/kylin/pull/1271


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4499) Extract kylin server self discovery service from CuratorScheduler

2020-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138962#comment-17138962
 ] 

ASF subversion and git services commented on KYLIN-4499:


Commit 121f8d23e3a918a6d93da716fe740bbcdaef56fc in kylin's branch 
refs/heads/master from Zhichao Zhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=121f8d2 ]

KYLIN-4499 Refine waiting time for initialization

yanghong's PR #1268


> Extract kylin server self discovery service from CuratorScheduler
> -
>
> Key: KYLIN-4499
> URL: https://issues.apache.org/jira/browse/KYLIN-4499
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Job Engine
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Fix For: v3.1.0
>
>
> It's better to extract the kylin server self discovery service to the common 
> module so that other places can benefit from it besides the CuratorScheduler.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138961#comment-17138961
 ] 

ASF subversion and git services commented on KYLIN-4577:


Commit 6fc39b4d77493ce83021c95766b5dca1513d in kylin's branch 
refs/heads/master from Zhichao Zhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6fc39b4 ]

KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery 
enables

Problem:
When server self discovery enables, it throws UnrecognizedPropertyException on 
some env, for example: cdh 5.7.

Root cause:
The json of ServiceInstance is incompatible, related to the issue of curator:  
https://issues.apache.org/jira/browse/CURATOR-394


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


hit-lacus merged pull request #1271:
URL: https://github.com/apache/kylin/pull/1271


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138960#comment-17138960
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

hit-lacus edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645732339


   LGTM, commit message is great, thank you @zzcclp .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138959#comment-17138959
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

hit-lacus commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645732339


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus edited a comment on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


hit-lacus edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645732339


   LGTM, commit message is great, thank you @zzcclp .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] hit-lacus commented on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


hit-lacus commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645732339


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-3832) Kylin pushdown to support postgresql

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138582#comment-17138582
 ] 

ASF GitHub Bot commented on KYLIN-3832:
---

hit-lacus opened a new pull request #1272:
URL: https://github.com/apache/kylin/pull/1272


   From the documentation, we know that when quoted, identifier is case 
sensitive, which is not easy to fix. So we cannot support reserved word as 
identifier, which is rare.
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin pushdown to support postgresql
> 
>
> Key: KYLIN-3832
> URL: https://issues.apache.org/jira/browse/KYLIN-3832
> Project: Kylin
>  Issue Type: New Feature
>  Components: Query Engine
>Affects Versions: v2.5.2
>Reporter: hailin.huang
>Assignee: weibin0516
>Priority: Major
> Fix For: v3.1.0
>
>
> when I run pushdown to postgresql in my env, I encount the below exception.
> it seems that kylin need support more JDBC Driver, 
> PushDownRunnerJdbcImpl.class should be more general.
> 2019-02-26 16:12:53,168 ERROR [Query 207dcf77-7c14-8078-ea8b-79644a0c576d-48] 
> service.QueryService:989 : pushdown engine failed current query too
> java.sql.SQLException: Unrecognized column type: int8
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.toSqlType(PushDownRunnerJdbcImpl.java:260)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.extractColumnMeta(PushDownRunnerJdbcImpl.java:192)
>   at 
> org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl.executeQuery(PushDownRunnerJdbcImpl.java:68)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownQuery(PushDownUtil.java:122)
>   at 
> org.apache.kylin.query.util.PushDownUtil.tryPushDownSelectQuery(PushDownUtil.java:69)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus opened a new pull request #1272: KYLIN-3832 Disable all convert and quote behavior for postgresql

2020-06-17 Thread GitBox


hit-lacus opened a new pull request #1272:
URL: https://github.com/apache/kylin/pull/1272


   From the documentation, we know that when quoted, identifier is case 
sensitive, which is not easy to fix. So we cannot support reserved word as 
identifier, which is rare.
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138509#comment-17138509
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

coveralls edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6038](https://coveralls.io/builds/31512762)
   
   * **19** of **20**   **(95.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.03%**) to **27.995%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java](https://coveralls.io/builds/31512762/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fzookeeper%2FKylinServerDiscovery.java#L129)
 | 19 | 20 | 95.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31512762/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31512762/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 1 | 83.33% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31512762/badge)](https://coveralls.io/builds/31512762)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.03% |
   | Covered Lines: | 26127 |
   | Relevant Lines: | 93326 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] coveralls edited a comment on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


coveralls edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6038](https://coveralls.io/builds/31512762)
   
   * **19** of **20**   **(95.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.03%**) to **27.995%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java](https://coveralls.io/builds/31512762/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fzookeeper%2FKylinServerDiscovery.java#L129)
 | 19 | 20 | 95.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31512762/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31512762/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 1 | 83.33% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31512762/badge)](https://coveralls.io/builds/31512762)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.03% |
   | Covered Lines: | 26127 |
   | Relevant Lines: | 93326 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] coveralls edited a comment on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


coveralls edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6036](https://coveralls.io/builds/31511834)
   
   * **19** of **20**   **(95.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.02%**) to **27.988%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java](https://coveralls.io/builds/31511834/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fzookeeper%2FKylinServerDiscovery.java#L129)
 | 19 | 20 | 95.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31511834/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31511834/badge)](https://coveralls.io/builds/31511834)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.02% |
   | Covered Lines: | 26120 |
   | Relevant Lines: | 93326 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138461#comment-17138461
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

coveralls edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6036](https://coveralls.io/builds/31511834)
   
   * **19** of **20**   **(95.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.02%**) to **27.988%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java](https://coveralls.io/builds/31511834/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fzookeeper%2FKylinServerDiscovery.java#L129)
 | 19 | 20 | 95.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31511834/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31511834/badge)](https://coveralls.io/builds/31511834)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.02% |
   | Covered Lines: | 26120 |
   | Relevant Lines: | 93326 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138387#comment-17138387
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

lgtm-com[bot] commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645337976


   This pull request **introduces 1 alert** when merging 
e3d265ac8c9ca170c89575c91fc1d7c335935a52 into 
d05a23fd9e2545521e24a18d1796b8fe65f8d16b - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-4d52ab759f4786961d21bf00878d49445a3fac1c)
   
   **new alerts:**
   
   * 1 for Result of multiplication cast to wider type



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] lgtm-com[bot] commented on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


lgtm-com[bot] commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645337976


   This pull request **introduces 1 alert** when merging 
e3d265ac8c9ca170c89575c91fc1d7c335935a52 into 
d05a23fd9e2545521e24a18d1796b8fe65f8d16b - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-4d52ab759f4786961d21bf00878d49445a3fac1c)
   
   **new alerts:**
   
   * 1 for Result of multiplication cast to wider type



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4499) Extract kylin server self discovery service from CuratorScheduler

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138384#comment-17138384
 ] 

ASF GitHub Bot commented on KYLIN-4499:
---

hit-lacus closed pull request #1268:
URL: https://github.com/apache/kylin/pull/1268


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract kylin server self discovery service from CuratorScheduler
> -
>
> Key: KYLIN-4499
> URL: https://issues.apache.org/jira/browse/KYLIN-4499
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Job Engine
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Fix For: v3.1.0
>
>
> It's better to extract the kylin server self discovery service to the common 
> module so that other places can benefit from it besides the CuratorScheduler.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus closed pull request #1268: KYLIN-4499 Refine waiting time for initialization

2020-06-17 Thread GitBox


hit-lacus closed pull request #1268:
URL: https://github.com/apache/kylin/pull/1268


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4499) Extract kylin server self discovery service from CuratorScheduler

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138383#comment-17138383
 ] 

ASF GitHub Bot commented on KYLIN-4499:
---

hit-lacus commented on pull request #1268:
URL: https://github.com/apache/kylin/pull/1268#issuecomment-645336041


   Close this because it is merged in #1271



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract kylin server self discovery service from CuratorScheduler
> -
>
> Key: KYLIN-4499
> URL: https://issues.apache.org/jira/browse/KYLIN-4499
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Job Engine
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Fix For: v3.1.0
>
>
> It's better to extract the kylin server self discovery service to the common 
> module so that other places can benefit from it besides the CuratorScheduler.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus commented on pull request #1268: KYLIN-4499 Refine waiting time for initialization

2020-06-17 Thread GitBox


hit-lacus commented on pull request #1268:
URL: https://github.com/apache/kylin/pull/1268#issuecomment-645336041


   Close this because it is merged in #1271



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138381#comment-17138381
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

coveralls edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6035](https://coveralls.io/builds/31509269)
   
   * **19** of **20**   **(95.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **8** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **27.978%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java](https://coveralls.io/builds/31509269/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fzookeeper%2FKylinServerDiscovery.java#L129)
 | 19 | 20 | 95.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31509269/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31509269/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193)
 | 7 | 76.29% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31509269/badge)](https://coveralls.io/builds/31509269)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.01% |
   | Covered Lines: | 26111 |
   | Relevant Lines: | 93326 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] coveralls edited a comment on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


coveralls edited a comment on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6035](https://coveralls.io/builds/31509269)
   
   * **19** of **20**   **(95.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **8** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **27.978%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/zookeeper/KylinServerDiscovery.java](https://coveralls.io/builds/31509269/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fzookeeper%2FKylinServerDiscovery.java#L129)
 | 19 | 20 | 95.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31509269/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31509269/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193)
 | 7 | 76.29% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31509269/badge)](https://coveralls.io/builds/31509269)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.01% |
   | Covered Lines: | 26111 |
   | Relevant Lines: | 93326 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] kyotoYaho commented on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


kyotoYaho commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645314263


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138350#comment-17138350
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

kyotoYaho commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645314263


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138339#comment-17138339
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

coveralls commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6034](https://coveralls.io/builds/31508133)
   
   * **13** of **13**   **(100.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.01%**) to **27.979%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31508133/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46)
 | 5 | 60.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31508133/badge)](https://coveralls.io/builds/31508133)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.01% |
   | Covered Lines: | 26110 |
   | Relevant Lines: | 93319 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] coveralls commented on pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


coveralls commented on pull request #1271:
URL: https://github.com/apache/kylin/pull/1271#issuecomment-645304727


   ## Pull Request Test Coverage Report for [Build 
6034](https://coveralls.io/builds/31508133)
   
   * **13** of **13**   **(100.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.01%**) to **27.979%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31508133/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46)
 | 5 | 60.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/31508133/badge)](https://coveralls.io/builds/31508133)
 |
   | :-- | --: |
   | Change from base [Build 6029](https://coveralls.io/builds/31488642): |  
0.01% |
   | Covered Lines: | 26110 |
   | Relevant Lines: | 93319 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4365) RDBMS pushdown failed with with clause

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138334#comment-17138334
 ] 

ASF GitHub Bot commented on KYLIN-4365:
---

zhangayqian commented on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645299393


   ## Verify test case
   https://user-images.githubusercontent.com/31064237/84888974-b08af300-b0ca-11ea-918d-091d41e4f4ff.png;>
   https://user-images.githubusercontent.com/31064237/84889033-c6001d00-b0ca-11ea-8cbc-c1608e490675.png;>
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RDBMS pushdown failed with with clause
> --
>
> Key: KYLIN-4365
> URL: https://issues.apache.org/jira/browse/KYLIN-4365
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, RDBMS Source
>Affects Versions: all
>Reporter: rongchuan.jin
>Assignee: rongchuan.jin
>Priority: Major
> Fix For: v3.1.0
>
>
> When use pushdown for RDBMS, I query with following sql:
> `with tmp as (select id from a),tmp2 as (select * from b) select * from 
> tmp,tmp2 where tmp.id = tmp2.id` it will cause exception like 'table tmp not 
> exists'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] zhangayqian commented on pull request #1086: KYLIN-4365 fix RDBMS pushdown with clause bug

2020-06-17 Thread GitBox


zhangayqian commented on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645299393


   ## Verify test case
   https://user-images.githubusercontent.com/31064237/84888974-b08af300-b0ca-11ea-918d-091d41e4f4ff.png;>
   https://user-images.githubusercontent.com/31064237/84889033-c6001d00-b0ca-11ea-8cbc-c1608e490675.png;>
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4365) RDBMS pushdown failed with with clause

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138332#comment-17138332
 ] 

ASF GitHub Bot commented on KYLIN-4365:
---

zhangayqian commented on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645298669


   ## Design test case
   
   ### Test case
   - Modify pushdown configuration in kylin.properties to pushdown query to 
SQLServer.
   ```
   
kylin.query.pushdown.runner-class-name=org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl
   #
   kylin.query.pushdown.update-enabled=false
   
kylin.query.pushdown.jdbc.url=jdbc:sqlserver://10.3.0.221:1433;databasename=temp
   kylin.query.pushdown.jdbc.driver=com.microsoft.sqlserver.jdbc.SQLServerDriver
   kylin.query.pushdown.jdbc.username=sa
   kylin.query.pushdown.jdbc.password=
   ```
   - Prepare `kylin_sales` table  in SQLserver
   - Setup kylin and disable all cube in `learn_kylin`
   - Execute sql
   ```
   with tmp as (select buyer_id from kylin_sales),
   tmp2 as (select * from kylin_sales) 
   select * from tmp,tmp2 where tmp.buyer_id = tmp2.buyer_id
   ```
   ### Expected result
   - SQL executed successfully and returned correct results.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RDBMS pushdown failed with with clause
> --
>
> Key: KYLIN-4365
> URL: https://issues.apache.org/jira/browse/KYLIN-4365
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, RDBMS Source
>Affects Versions: all
>Reporter: rongchuan.jin
>Assignee: rongchuan.jin
>Priority: Major
> Fix For: v3.1.0
>
>
> When use pushdown for RDBMS, I query with following sql:
> `with tmp as (select id from a),tmp2 as (select * from b) select * from 
> tmp,tmp2 where tmp.id = tmp2.id` it will cause exception like 'table tmp not 
> exists'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] zhangayqian commented on pull request #1086: KYLIN-4365 fix RDBMS pushdown with clause bug

2020-06-17 Thread GitBox


zhangayqian commented on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645298669


   ## Design test case
   
   ### Test case
   - Modify pushdown configuration in kylin.properties to pushdown query to 
SQLServer.
   ```
   
kylin.query.pushdown.runner-class-name=org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl
   #
   kylin.query.pushdown.update-enabled=false
   
kylin.query.pushdown.jdbc.url=jdbc:sqlserver://10.3.0.221:1433;databasename=temp
   kylin.query.pushdown.jdbc.driver=com.microsoft.sqlserver.jdbc.SQLServerDriver
   kylin.query.pushdown.jdbc.username=sa
   kylin.query.pushdown.jdbc.password=
   ```
   - Prepare `kylin_sales` table  in SQLserver
   - Setup kylin and disable all cube in `learn_kylin`
   - Execute sql
   ```
   with tmp as (select buyer_id from kylin_sales),
   tmp2 as (select * from kylin_sales) 
   select * from tmp,tmp2 where tmp.buyer_id = tmp2.buyer_id
   ```
   ### Expected result
   - SQL executed successfully and returned correct results.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4365) RDBMS pushdown failed with with clause

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138327#comment-17138327
 ] 

ASF GitHub Bot commented on KYLIN-4365:
---

zhangayqian commented on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645296255


   ### Check list
   - [ ] Step 1. [**OPTIONAL**]Understand background/root cause/design 
basically(one hour EST) . Its issue type is 
   - [ ] bug fix
   - [x] new feature
   - [ ] enhancement
   - [x] Step 2. Test cases are designed and documented (30 minutes EST).
   - [x] Step 3. Prepare specific env, for example:
   - mock data (maybe some specific data type)
   - test env (maybe install a RDBMS instance).
   - [x] Step 4. Verify and make sure test cases passed.
   - [x] Step 5. Paste manual important steps and screenshots here (20 minutes 
EST). 
   - If you find difficulty in pick most important evidence, please attach 
diagnosis package. 
   - [ ] Step 6. Do more check in user perspective (20 minutes EST)
   - [ ] Doc need be updated? And if it is updated? Ask help for release 
manager if so.
   - [ ] If it is a breaking change so we should notify Kylin community? 
Ask help for release manager if so.
   - [x] Step 7.  Summarize this test (20 minutes EST).
   
   ### Total estimate
   - 4 hours for small issue from optimistic estimate. 
   
   ### Note
   If you find some unexpected and **unrelated** error/mistake, please DO 
report it if it is truly a mistake, I think we may research and fix it in the 
future.
   
   If you find background information/root cause analysis is not complete or 
ambiguous, please try to contact to author or do a quick research and record 
what you find. It is a good chance to learn something interesting.
   
   If you find it is not easy to design testcase, please notify release manager.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RDBMS pushdown failed with with clause
> --
>
> Key: KYLIN-4365
> URL: https://issues.apache.org/jira/browse/KYLIN-4365
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, RDBMS Source
>Affects Versions: all
>Reporter: rongchuan.jin
>Assignee: rongchuan.jin
>Priority: Major
> Fix For: v3.1.0
>
>
> When use pushdown for RDBMS, I query with following sql:
> `with tmp as (select id from a),tmp2 as (select * from b) select * from 
> tmp,tmp2 where tmp.id = tmp2.id` it will cause exception like 'table tmp not 
> exists'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] zhangayqian commented on pull request #1086: KYLIN-4365 fix RDBMS pushdown with clause bug

2020-06-17 Thread GitBox


zhangayqian commented on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645296255


   ### Check list
   - [ ] Step 1. [**OPTIONAL**]Understand background/root cause/design 
basically(one hour EST) . Its issue type is 
   - [ ] bug fix
   - [x] new feature
   - [ ] enhancement
   - [x] Step 2. Test cases are designed and documented (30 minutes EST).
   - [x] Step 3. Prepare specific env, for example:
   - mock data (maybe some specific data type)
   - test env (maybe install a RDBMS instance).
   - [x] Step 4. Verify and make sure test cases passed.
   - [x] Step 5. Paste manual important steps and screenshots here (20 minutes 
EST). 
   - If you find difficulty in pick most important evidence, please attach 
diagnosis package. 
   - [ ] Step 6. Do more check in user perspective (20 minutes EST)
   - [ ] Doc need be updated? And if it is updated? Ask help for release 
manager if so.
   - [ ] If it is a breaking change so we should notify Kylin community? 
Ask help for release manager if so.
   - [x] Step 7.  Summarize this test (20 minutes EST).
   
   ### Total estimate
   - 4 hours for small issue from optimistic estimate. 
   
   ### Note
   If you find some unexpected and **unrelated** error/mistake, please DO 
report it if it is truly a mistake, I think we may research and fix it in the 
future.
   
   If you find background information/root cause analysis is not complete or 
ambiguous, please try to contact to author or do a quick research and record 
what you find. It is a good chance to learn something interesting.
   
   If you find it is not easy to design testcase, please notify release manager.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4365) RDBMS pushdown failed with with clause

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138328#comment-17138328
 ] 

ASF GitHub Bot commented on KYLIN-4365:
---

zhangayqian edited a comment on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645296255







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RDBMS pushdown failed with with clause
> --
>
> Key: KYLIN-4365
> URL: https://issues.apache.org/jira/browse/KYLIN-4365
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, RDBMS Source
>Affects Versions: all
>Reporter: rongchuan.jin
>Assignee: rongchuan.jin
>Priority: Major
> Fix For: v3.1.0
>
>
> When use pushdown for RDBMS, I query with following sql:
> `with tmp as (select id from a),tmp2 as (select * from b) select * from 
> tmp,tmp2 where tmp.id = tmp2.id` it will cause exception like 'table tmp not 
> exists'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] zhangayqian edited a comment on pull request #1086: KYLIN-4365 fix RDBMS pushdown with clause bug

2020-06-17 Thread GitBox


zhangayqian edited a comment on pull request #1086:
URL: https://github.com/apache/kylin/pull/1086#issuecomment-645296255







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] zzcclp opened a new pull request #1271: KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

2020-06-17 Thread GitBox


zzcclp opened a new pull request #1271:
URL: https://github.com/apache/kylin/pull/1271


   Problem:
   When server self discovery enables, it throws UnrecognizedPropertyException 
on some env, for example: cdh 5.7.
   
   Root cause:
   The json of ServiceInstance is incompatible, related to the issue of 
curator:  https://issues.apache.org/jira/browse/CURATOR-394
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138319#comment-17138319
 ] 

ASF GitHub Bot commented on KYLIN-4577:
---

zzcclp opened a new pull request #1271:
URL: https://github.com/apache/kylin/pull/1271


   Problem:
   When server self discovery enables, it throws UnrecognizedPropertyException 
on some env, for example: cdh 5.7.
   
   Root cause:
   The json of ServiceInstance is incompatible, related to the issue of 
curator:  https://issues.apache.org/jira/browse/CURATOR-394
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw UnrecognizedPropertyException when server self discovery enables on 
> cdh5.7 env
> 
>
> Key: KYLIN-4577
> URL: https://issues.apache.org/jira/browse/KYLIN-4577
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: v3.1.0
>
>
> When server self discovery enables, it throws UnrecognizedPropertyException 
> on some env, for example: cdh 5.7.
> The root cause is the json of ServiceInstance is incompatible, related to the 
> issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (KYLIN-4577) Throw UnrecognizedPropertyException when server self discovery enables on cdh5.7 env

2020-06-17 Thread Zhichao Zhang (Jira)
Zhichao  Zhang created KYLIN-4577:
-

 Summary: Throw UnrecognizedPropertyException when server self 
discovery enables on cdh5.7 env
 Key: KYLIN-4577
 URL: https://issues.apache.org/jira/browse/KYLIN-4577
 Project: Kylin
  Issue Type: Bug
  Components: Job Engine
Reporter: Zhichao  Zhang
Assignee: Zhichao  Zhang
 Fix For: v3.1.0


When server self discovery enables, it throws UnrecognizedPropertyException on 
some env, for example: cdh 5.7.

The root cause is the json of ServiceInstance is incompatible, related to the 
issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138156#comment-17138156
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645184882


   ## Verify test result
   
   ### Case - 1
   We can see that we submit build request from cdh-client node and the segment 
is built by cdh-worker-1, test past
   
![image](https://user-images.githubusercontent.com/9884693/84865533-f5069680-b0aa-11ea-93e6-c5b5371e3e67.png)
   
   
   ### Case - 1 
   The segment will be built by cdh-client, when 
kylin.cube.schedule.assigned-servers isn't set.
   
![image](https://user-images.githubusercontent.com/9884693/84864557-70674880-b0a9-11ea-89b8-70207bd00435.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang edited a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645184882


   ## Verify test result
   
   ### Case - 1
   We can see that we submit build request from cdh-client node and the segment 
is built by cdh-worker-1, test past
   
![image](https://user-images.githubusercontent.com/9884693/84865533-f5069680-b0aa-11ea-93e6-c5b5371e3e67.png)
   
   
   ### Case - 1 
   The segment will be built by cdh-client, when 
kylin.cube.schedule.assigned-servers isn't set.
   
![image](https://user-images.githubusercontent.com/9884693/84864557-70674880-b0a9-11ea-89b8-70207bd00435.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] RupengWang commented on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645186887


   ### Unexpected problem report
   There is  a misspelled word in the document which is uploaded by the 
assignee of the issue. It should be schedule not shedule.
   
![image](https://user-images.githubusercontent.com/9884693/84864623-81b05500-b0a9-11ea-81ae-0f92d2bb8296.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138154#comment-17138154
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645186887


   ### Unexpected problem report
   There is  a misspelled word in the document which is uploaded by the 
assignee of the issue. It should be schedule not shedule.
   
![image](https://user-images.githubusercontent.com/9884693/84864623-81b05500-b0a9-11ea-81ae-0f92d2bb8296.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138151#comment-17138151
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645184882


   ## Verify test result
   
   ### Case - 1
   We can see that we submit build request from cdh-client node and the segment 
is built by cdh-worker-1, test past
   
![image](https://user-images.githubusercontent.com/9884693/84864341-1b2b3700-b0a9-11ea-8c6b-d1df1a4e61b0.png)
   
   ### Case - 1 
   The segment will be built by cdh-client, when 
kylin.cube.schedule.assigned-servers isn't set.
   
![image](https://user-images.githubusercontent.com/9884693/84864557-70674880-b0a9-11ea-89b8-70207bd00435.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang edited a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645184882


   ## Verify test result
   
   ### Case - 1
   We can see that we submit build request from cdh-client node and the segment 
is built by cdh-worker-1, test past
   
![image](https://user-images.githubusercontent.com/9884693/84864341-1b2b3700-b0a9-11ea-8c6b-d1df1a4e61b0.png)
   
   ### Case - 1 
   The segment will be built by cdh-client, when 
kylin.cube.schedule.assigned-servers isn't set.
   
![image](https://user-images.githubusercontent.com/9884693/84864557-70674880-b0a9-11ea-89b8-70207bd00435.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] RupengWang edited a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   1. deploy 3 kylin instances in a cluster contains 3 nodes[cdh-master, 
cdh-client, cdh-worker-1]
   2. enable distributed schedule
 - kylin.job.scheduler.default=2
 - 
kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock
 - add all job servers and query servers to the 
kylin.server.cluster-servers
   3. clone the sample cube - kylin_sales_cube and set cube kylin property 
kylin.cube.schedule.assigned-servers=cdh-master,cdh-worker-1
 
![image](https://user-images.githubusercontent.com/9884693/84864001-89bbc500-b0a8-11ea-85f7-394add6f1013.png)
   
   4. build two segment (2012-01-01 ~ 2013-01-01) (2013-01-01 ~ 2014-01-01), 
the  build requests are submitted by cdh-client
   
   ### Case -1 
   check if these two build job are executed by cdh-master and cdh-worker-1
   
   ### Case -2
   Don't set kylin.cube.schedule.assigned-servers and submit build request in 
cdh-client, to see if the job will be built by cdh-client



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138148#comment-17138148
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   1. deploy 3 kylin instances in a cluster contains 3 nodes[cdh-master, 
cdh-client, cdh-worker-1]
   2. enable distributed schedule
 - kylin.job.scheduler.default=2
 - 
kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock
 - add all job servers and query servers to the 
kylin.server.cluster-servers
   3. clone the sample cube - kylin_sales_cube and set cube kylin property 
kylin.cube.schedule.assigned-servers=cdh-master,cdh-worker-1
 
![image](https://user-images.githubusercontent.com/9884693/84864001-89bbc500-b0a8-11ea-85f7-394add6f1013.png)
   
   4. build two segment (2012-01-01 ~ 2013-01-01) (2013-01-01 ~ 2014-01-01), 
the  build requests are submitted by cdh-client
   
   ### Case -1 
   check if these two build job are executed by cdh-master and cdh-worker-1
   
   ### Case -2
   Don't set kylin.cube.schedule.assigned-servers and submit build request in 
cdh-client, to see if the job will be built by cdh-client



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138145#comment-17138145
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645184882


   ### Verify test result
   
    Case
   We can see that we submit build request from cdh-client node and the segment 
is built by cdh-worker-1, test past
   
![image](https://user-images.githubusercontent.com/9884693/84864341-1b2b3700-b0a9-11ea-8c6b-d1df1a4e61b0.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang commented on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645184882


   ### Verify test result
   
    Case
   We can see that we submit build request from cdh-client node and the segment 
is built by cdh-worker-1, test past
   
![image](https://user-images.githubusercontent.com/9884693/84864341-1b2b3700-b0a9-11ea-8c6b-d1df1a4e61b0.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] RupengWang commented on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645183935


   ## Prepare data and env
   
   - [x] Built on commit_SHA : c14973b42dd7c45353160a6a9db381cb61b0bc1b
   - [x] Hadoop env : CDH 5.7 with 3 nodes
   - [x] Just sample cube is OK.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138143#comment-17138143
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645183935


   ## Prepare data and env
   
   - [x] Built on commit_SHA : c14973b42dd7c45353160a6a9db381cb61b0bc1b
   - [x] Hadoop env : CDH 5.7 with 3 nodes
   - [x] Just sample cube is OK.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang edited a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   1. deploy 3 kylin instances in a cluster contains 3 nodes[cdh-master, 
cdh-client, cdh-worker-1]
   2. enable distributed schedule
 - kylin.job.scheduler.default=2
 - 
kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock
 - add all job servers and query servers to the 
kylin.server.cluster-servers
   3. clone the sample cube - kylin_sales_cube and set cube kylin property 
kylin.cube.schedule.assigned-servers=cdh-master,cdh-worker-1
 
![image](https://user-images.githubusercontent.com/9884693/84864001-89bbc500-b0a8-11ea-85f7-394add6f1013.png)
   
   4. build two segment (2012-01-01 ~ 2013-01-01) (2013-01-01 ~ 2014-01-01), 
the  build requests are submitted by cdh-client
   
   ### Case
   check if these two build job are executed by cdh-master and cdh-worker-1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138142#comment-17138142
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   1. deploy 3 kylin instances in a cluster contains 3 nodes[cdh-master, 
cdh-client, cdh-worker-1]
   2. enable distributed schedule
 - kylin.job.scheduler.default=2
 - 
kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock
 - add all job servers and query servers to the 
kylin.server.cluster-servers
   3. clone the sample cube - kylin_sales_cube and set cube kylin property 
kylin.cube.schedule.assigned-servers=cdh-master,cdh-worker-1
 
![image](https://user-images.githubusercontent.com/9884693/84864001-89bbc500-b0a8-11ea-85f7-394add6f1013.png)
   
   4. build two segment (2012-01-01 ~ 2013-01-01) (2013-01-01 ~ 2014-01-01), 
the  build requests are submitted by cdh-client
   
   ### Case
   check if these two build job are executed by cdh-master and cdh-worker-1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138138#comment-17138138
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   1. deploy 3 kylin instances in a cluster contains 3 nodes[cdh-master, 
cdh-client, cdh-worker-1]
   2. enable distributed schedule
 - kylin.job.scheduler.default=2
 - 
kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock
 - add all job servers and query servers to the 
kylin.server.cluster-servers
   3. clone the sample cube - kylin_sales_cube and set cube kylin property 
kylin.cube.shedule.assigned-servers=cdh-master,cdh-worker-1
 
![image](https://user-images.githubusercontent.com/9884693/84863194-28dfbd00-b0a7-11ea-958b-adb0101a33a7.png)
   4. build two segment (2012-01-01 ~ 2013-01-01) (2013-01-01 ~ 2014-01-01), 
the  build requests are submitted by cdh-client
   
   ### Case
   check if these two build job are executed by cdh-master and cdh-worker-1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang edited a comment on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang edited a comment on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   1. deploy 3 kylin instances in a cluster contains 3 nodes[cdh-master, 
cdh-client, cdh-worker-1]
   2. enable distributed schedule
 - kylin.job.scheduler.default=2
 - 
kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock
 - add all job servers and query servers to the 
kylin.server.cluster-servers
   3. clone the sample cube - kylin_sales_cube and set cube kylin property 
kylin.cube.shedule.assigned-servers=cdh-master,cdh-worker-1
 
![image](https://user-images.githubusercontent.com/9884693/84863194-28dfbd00-b0a7-11ea-958b-adb0101a33a7.png)
   4. build two segment (2012-01-01 ~ 2013-01-01) (2013-01-01 ~ 2014-01-01), 
the  build requests are submitted by cdh-client
   
   ### Case
   check if these two build job are executed by cdh-master and cdh-worker-1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138134#comment-17138134
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   - create cube and build segment (2012-01-01 ~ 2013-01-01)
 - dimension : LSTG_FORMAT_NAME, ops_region, part_dt
 - measure : sum(price)
   
   ### Case-1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4249) DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138132#comment-17138132
 ] 

ASF GitHub Bot commented on KYLIN-4249:
---

RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179093


   ### Check list
   - [x] Step 1. [**OPTIONAL**]Understand background/root cause/design 
basically(one hour EST) . Its issue type is 
   - [ ] bug fix
   - [ ] new feature
   - [x] enhancement
   - [x] Step 2. Test cases are designed and documented (30 minutes EST).
   - [x] Step 3. Prepare specific env, for example:
   - mock data (maybe some specific data type)
   - test env (maybe install a RDBMS instance).
   - [x] Step 4. Verify and make sure test cases passed.
   - [x] Step 5. Paste manual important steps and screenshots here (20 minutes 
EST). 
   - If you find difficulty in pick most important evidence, please attach 
diagnosis package. 
   - [x] Step 6. Do more check in user perspective (20 minutes EST)
   - [x] Doc need be updated? And if it is updated? Ask help for release 
manager if so.
   - [x] If it is a breaking change so we should notify Kylin community? 
Ask help for release manager if so.
   - [x] Step 7.  Summarize this test (20 minutes EST).
   
   ### Total estimate
   - 4 hours for small issue from optimistic estimate. 
   
   ### Note
   If you find some unexpected and **unrelated** error/mistake, please DO 
report it if it is truly a mistake, I think we may research and fix it in the 
future.
   
   If you find background information/root cause analysis is not complete or 
ambiguous, please try to contact to author or do a quick research and record 
what you find. It is a good chance to learn something interesting.
   
   If you find it is not easy to design testcase, please notify release manager.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DistributedScheduler can selectively assign task nodes according to cube 
> extra configuration
> 
>
> Key: KYLIN-4249
> URL: https://issues.apache.org/jira/browse/KYLIN-4249
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.6.0
>Reporter: xiang zhang
>Assignee: xiang zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: kylin-4249-usage-instructions.pdf
>
>
> The ability to selectively specify a task execution node for a cube in a 
> cluster can increase the convenience and flexibility of verification.
> Usually in cluster mode, there are applications in scenarios such as testing, 
> troubleshooting exceptions, and verifying new features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] RupengWang commented on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179227


   ## Design test cases
   
   ### Prepare test env
   - create cube and build segment (2012-01-01 ~ 2013-01-01)
 - dimension : LSTG_FORMAT_NAME, ops_region, part_dt
 - measure : sum(price)
   
   ### Case-1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] RupengWang commented on pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

2020-06-17 Thread GitBox


RupengWang commented on pull request #933:
URL: https://github.com/apache/kylin/pull/933#issuecomment-645179093


   ### Check list
   - [x] Step 1. [**OPTIONAL**]Understand background/root cause/design 
basically(one hour EST) . Its issue type is 
   - [ ] bug fix
   - [ ] new feature
   - [x] enhancement
   - [x] Step 2. Test cases are designed and documented (30 minutes EST).
   - [x] Step 3. Prepare specific env, for example:
   - mock data (maybe some specific data type)
   - test env (maybe install a RDBMS instance).
   - [x] Step 4. Verify and make sure test cases passed.
   - [x] Step 5. Paste manual important steps and screenshots here (20 minutes 
EST). 
   - If you find difficulty in pick most important evidence, please attach 
diagnosis package. 
   - [x] Step 6. Do more check in user perspective (20 minutes EST)
   - [x] Doc need be updated? And if it is updated? Ask help for release 
manager if so.
   - [x] If it is a breaking change so we should notify Kylin community? 
Ask help for release manager if so.
   - [x] Step 7.  Summarize this test (20 minutes EST).
   
   ### Total estimate
   - 4 hours for small issue from optimistic estimate. 
   
   ### Note
   If you find some unexpected and **unrelated** error/mistake, please DO 
report it if it is truly a mistake, I think we may research and fix it in the 
future.
   
   If you find background information/root cause analysis is not complete or 
ambiguous, please try to contact to author or do a quick research and record 
what you find. It is a good chance to learn something interesting.
   
   If you find it is not easy to design testcase, please notify release manager.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org