[jira] [Commented] (KYLIN-4850) Cube's override kylin_properties were ignored in building jobs
[ https://issues.apache.org/jira/browse/KYLIN-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255844#comment-17255844 ] ASF GitHub Bot commented on KYLIN-4850: --- zzcclp commented on a change in pull request #1523: URL: https://github.com/apache/kylin/pull/1523#discussion_r549593562 ## File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java ## @@ -105,7 +105,7 @@ protected ExecuteResult doWork(ExecutableContext context) throws ExecuteExceptio //context.setLogPath(getSparkDriverLogHdfsPath(context.getConfig())); CubeManager cubeMgr = CubeManager.getInstance(KylinConfig.getInstanceFromEnv()); CubeInstance cube = cubeMgr.getCube(this.getCubeName()); -KylinConfig config = cube.getConfig(); +KylinConfig config = KylinConfigExt.createInstance(cube.getConfig(), cube.getDescriptor().getOverrideKylinProps()); Review comment: Don't need to create a KylinConfigExt here, the returned value of 'cube.getConfig()' already is a KylinConfigExt object. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cube's override kylin_properties were ignored in building jobs > -- > > Key: KYLIN-4850 > URL: https://issues.apache.org/jira/browse/KYLIN-4850 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v4.0.0-alpha >Reporter: ShengJun Zheng >Priority: Minor > > Cube's override kylin_properties were ignored in building jobs, it prevent us > from optimizing spark configurations of some special cubes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] zzcclp commented on a change in pull request #1523: fix KYLIN-4850, merge Cube's override kylin_properties into building …
zzcclp commented on a change in pull request #1523: URL: https://github.com/apache/kylin/pull/1523#discussion_r549593562 ## File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java ## @@ -105,7 +105,7 @@ protected ExecuteResult doWork(ExecutableContext context) throws ExecuteExceptio //context.setLogPath(getSparkDriverLogHdfsPath(context.getConfig())); CubeManager cubeMgr = CubeManager.getInstance(KylinConfig.getInstanceFromEnv()); CubeInstance cube = cubeMgr.getCube(this.getCubeName()); -KylinConfig config = cube.getConfig(); +KylinConfig config = KylinConfigExt.createInstance(cube.getConfig(), cube.getDescriptor().getOverrideKylinProps()); Review comment: Don't need to create a KylinConfigExt here, the returned value of 'cube.getConfig()' already is a KylinConfigExt object. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1515: update find-xx-dependency.sh for macOS compatibility
hit-lacus edited a comment on pull request #1515: URL: https://github.com/apache/kylin/pull/1515#issuecomment-751924125 As far as I know, Mac OS is not the OS which Kylin going to support. And I am not really ensure this patch is compatible with current supported os (linux distribution) . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (KYLIN-4613) add buildCubeCLi as hadoop main class and jobRestClient
[ https://issues.apache.org/jira/browse/KYLIN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu updated KYLIN-4613: Fix Version/s: v3.1.2 > add buildCubeCLi as hadoop main class and jobRestClient > - > > Key: KYLIN-4613 > URL: https://issues.apache.org/jira/browse/KYLIN-4613 > Project: Kylin > Issue Type: Improvement > Components: Client - CLI >Reporter: chuxiao >Assignee: chuxiao >Priority: Minor > Fix For: v3.1.2 > > > support submit job and wait finish. retry 3 times when error。 > CubeBuildingCLIV2 不跟原来的兼容，是因为原来的依赖kylin部署环境，尤其是依赖kylin.properties，可以认为是给管理员用的。 > 而新的CubeBuildingCLIV2理念是给用户用的，参数完全在main方法里指定，不依赖kylin部署环境。所以无法合到一起。 > 至于 JobRestClient 不直接放到 RestClient里，是因为项目不同，放进去会有循环依赖。 > 后续一件事是把客户端单拎一个module，把包括建模在内的client都放进去，不依赖kylin其他非必要的module -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (KYLIN-4613) add buildCubeCLi as hadoop main class and jobRestClient
[ https://issues.apache.org/jira/browse/KYLIN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu resolved KYLIN-4613. - Resolution: Fixed > add buildCubeCLi as hadoop main class and jobRestClient > - > > Key: KYLIN-4613 > URL: https://issues.apache.org/jira/browse/KYLIN-4613 > Project: Kylin > Issue Type: Improvement > Components: Client - CLI >Reporter: chuxiao >Assignee: chuxiao >Priority: Minor > Fix For: v3.1.2 > > > support submit job and wait finish. retry 3 times when error。 > CubeBuildingCLIV2 不跟原来的兼容，是因为原来的依赖kylin部署环境，尤其是依赖kylin.properties，可以认为是给管理员用的。 > 而新的CubeBuildingCLIV2理念是给用户用的，参数完全在main方法里指定，不依赖kylin部署环境。所以无法合到一起。 > 至于 JobRestClient 不直接放到 RestClient里，是因为项目不同，放进去会有循环依赖。 > 后续一件事是把客户端单拎一个module，把包括建模在内的client都放进去，不依赖kylin其他非必要的module -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4613) add buildCubeCLi as hadoop main class and jobRestClient
[ https://issues.apache.org/jira/browse/KYLIN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255792#comment-17255792 ] ASF GitHub Bot commented on KYLIN-4613: --- hit-lacus commented on pull request #1299: URL: https://github.com/apache/kylin/pull/1299#issuecomment-751936883 This patch looks good to me, thanks @bigxiaochu . We should consider to write documentation for this tools. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add buildCubeCLi as hadoop main class and jobRestClient > - > > Key: KYLIN-4613 > URL: https://issues.apache.org/jira/browse/KYLIN-4613 > Project: Kylin > Issue Type: Improvement > Components: Client - CLI >Reporter: chuxiao >Assignee: chuxiao >Priority: Minor > > support submit job and wait finish. retry 3 times when error。 > CubeBuildingCLIV2 不跟原来的兼容，是因为原来的依赖kylin部署环境，尤其是依赖kylin.properties，可以认为是给管理员用的。 > 而新的CubeBuildingCLIV2理念是给用户用的，参数完全在main方法里指定，不依赖kylin部署环境。所以无法合到一起。 > 至于 JobRestClient 不直接放到 RestClient里，是因为项目不同，放进去会有循环依赖。 > 后续一件事是把客户端单拎一个module，把包括建模在内的client都放进去，不依赖kylin其他非必要的module -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4850) Cube's override kylin_properties were ignored in building jobs
[ https://issues.apache.org/jira/browse/KYLIN-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255795#comment-17255795 ] ASF GitHub Bot commented on KYLIN-4850: --- codecov-io commented on pull request #1523: URL: https://github.com/apache/kylin/pull/1523#issuecomment-751936937 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@39086e3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=tree) ```diff @@ Coverage Diff @@ ## kylin-on-parquet-v2#1523 +/- ## == Coverage ? 24.31% Complexity ? 4620 == Files ? 1138 Lines ?64438 Branches ? 9512 == Hits ?15669 Misses ?47134 Partials ? 1635 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=footer). Last update [39086e3...7c2b951](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cube's override kylin_properties were ignored in building jobs > -- > > Key: KYLIN-4850 > URL: https://issues.apache.org/jira/browse/KYLIN-4850 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v4.0.0-alpha >Reporter: ShengJun Zheng >Priority: Minor > > Cube's override kylin_properties were ignored in building jobs, it prevent us > from optimizing spark configurations of some special cubes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4613) add buildCubeCLi as hadoop main class and jobRestClient
[ https://issues.apache.org/jira/browse/KYLIN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255793#comment-17255793 ] ASF subversion and git services commented on KYLIN-4613: Commit fe04ca8d3be6c50742246663d6fd6767a568bcf8 in kylin's branch refs/heads/master from chuxiao [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=fe04ca8 ] KYLIN-4613 add build cubev2 and JobRestClient > add buildCubeCLi as hadoop main class and jobRestClient > - > > Key: KYLIN-4613 > URL: https://issues.apache.org/jira/browse/KYLIN-4613 > Project: Kylin > Issue Type: Improvement > Components: Client - CLI >Reporter: chuxiao >Assignee: chuxiao >Priority: Minor > > support submit job and wait finish. retry 3 times when error。 > CubeBuildingCLIV2 不跟原来的兼容，是因为原来的依赖kylin部署环境，尤其是依赖kylin.properties，可以认为是给管理员用的。 > 而新的CubeBuildingCLIV2理念是给用户用的，参数完全在main方法里指定，不依赖kylin部署环境。所以无法合到一起。 > 至于 JobRestClient 不直接放到 RestClient里，是因为项目不同，放进去会有循环依赖。 > 后续一件事是把客户端单拎一个module，把包括建模在内的client都放进去，不依赖kylin其他非必要的module -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4613) add buildCubeCLi as hadoop main class and jobRestClient
[ https://issues.apache.org/jira/browse/KYLIN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255794#comment-17255794 ] ASF GitHub Bot commented on KYLIN-4613: --- hit-lacus merged pull request #1299: URL: https://github.com/apache/kylin/pull/1299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add buildCubeCLi as hadoop main class and jobRestClient > - > > Key: KYLIN-4613 > URL: https://issues.apache.org/jira/browse/KYLIN-4613 > Project: Kylin > Issue Type: Improvement > Components: Client - CLI >Reporter: chuxiao >Assignee: chuxiao >Priority: Minor > > support submit job and wait finish. retry 3 times when error。 > CubeBuildingCLIV2 不跟原来的兼容，是因为原来的依赖kylin部署环境，尤其是依赖kylin.properties，可以认为是给管理员用的。 > 而新的CubeBuildingCLIV2理念是给用户用的，参数完全在main方法里指定，不依赖kylin部署环境。所以无法合到一起。 > 至于 JobRestClient 不直接放到 RestClient里，是因为项目不同，放进去会有循环依赖。 > 后续一件事是把客户端单拎一个module，把包括建模在内的client都放进去，不依赖kylin其他非必要的module -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] codecov-io commented on pull request #1523: fix KYLIN-4850, merge Cube's override kylin_properties into building …
codecov-io commented on pull request #1523: URL: https://github.com/apache/kylin/pull/1523#issuecomment-751936937 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@39086e3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=tree) ```diff @@ Coverage Diff @@ ## kylin-on-parquet-v2#1523 +/- ## == Coverage ? 24.31% Complexity ? 4620 == Files ? 1138 Lines ?64438 Branches ? 9512 == Hits ?15669 Misses ?47134 Partials ? 1635 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=footer). Last update [39086e3...7c2b951](https://codecov.io/gh/apache/kylin/pull/1523?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1299: KYLIN-4613 add build cubev2 and JobRestClient
hit-lacus merged pull request #1299: URL: https://github.com/apache/kylin/pull/1299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1299: KYLIN-4613 add build cubev2 and JobRestClient
hit-lacus commented on pull request #1299: URL: https://github.com/apache/kylin/pull/1299#issuecomment-751936883 This patch looks good to me, thanks @bigxiaochu . We should consider to write documentation for this tools. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-4833) use distcp to control the speed of writting hfile data to hbase cluster
[
https://issues.apache.org/jira/browse/KYLIN-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255784#comment-17255784
]
ASF GitHub Bot commented on KYLIN-4833:
---
hit-lacus commented on a change in pull request #1494:
URL: https://github.com/apache/kylin/pull/1494#discussion_r549549351
##
File path:
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseJobSteps.java
##
@@ -63,6 +64,13 @@ public HadoopShellExecutable createCreateHTableStep(String
jobId, CuboidModeEnum
appendExecCmdParameters(cmd, BatchConstants.ARG_SEGMENT_ID,
seg.getUuid());
appendExecCmdParameters(cmd, BatchConstants.ARG_PARTITION,
getRowkeyDistributionOutputPath(jobId) + "/part-r-0");
+if(this.seg.getConfig().isHFileDistCP()){
+String partitionOutputPath = getRealizationRootPath(jobId) +
"/rowkey_stats/part-r-0_hfile";
+appendExecCmdParameters(cmd, BatchConstants.ARG_PARTITION,
partitionOutputPath);
+}else {
+appendExecCmdParameters(cmd, BatchConstants.ARG_PARTITION,
Review comment:
Append paramters twice for `BatchConstants.ARG_PARTITION` .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> use distcp to control the speed of writting hfile data to hbase cluster
> ---
>
> Key: KYLIN-4833
> URL: https://issues.apache.org/jira/browse/KYLIN-4833
> Project: Kylin
> Issue Type: Improvement
> Components: Storage - HBase
>Affects Versions: v3.1.1
>Reporter: fengpod
>Assignee: fengpod
>Priority: Minor
> Fix For: v3.1.2
>
>
> When a large data is written to hbase cluster at the same time，the cluster
> load will become very high，which will affect the query performance. This pr
> allows data to be written data to hadoop hdfs when doing step “Convert Cuboid
> Data to HFile”，and then hfile will be transferred to the hbase cluster by
> DistCp。DistCp controls the speed of write data so as to reduce the pressure
> of cluster。 This pr adds a new step " HFile Distcp To HBase" between “Convert
> Cuboid Data to HFile” and "Load HFile to HBase Table" 。As look like this：
> !https://user-images.githubusercontent.com/4843586/100835711-013fae00-34a9-11eb-8de8-e69228ba0991.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [kylin] hit-lacus commented on a change in pull request #1494: KYLIN-4833 create hfile on hadoop hdfs and distcp to hbase hdfs
hit-lacus commented on a change in pull request #1494:
URL: https://github.com/apache/kylin/pull/1494#discussion_r549549351
##
File path:
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseJobSteps.java
##
@@ -63,6 +64,13 @@ public HadoopShellExecutable createCreateHTableStep(String
jobId, CuboidModeEnum
appendExecCmdParameters(cmd, BatchConstants.ARG_SEGMENT_ID,
seg.getUuid());
appendExecCmdParameters(cmd, BatchConstants.ARG_PARTITION,
getRowkeyDistributionOutputPath(jobId) + "/part-r-0");
+if(this.seg.getConfig().isHFileDistCP()){
+String partitionOutputPath = getRealizationRootPath(jobId) +
"/rowkey_stats/part-r-0_hfile";
+appendExecCmdParameters(cmd, BatchConstants.ARG_PARTITION,
partitionOutputPath);
+}else {
+appendExecCmdParameters(cmd, BatchConstants.ARG_PARTITION,
Review comment:
Append paramters twice for `BatchConstants.ARG_PARTITION` .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (KYLIN-4850) Cube's override kylin_properties were ignored in building jobs
[ https://issues.apache.org/jira/browse/KYLIN-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255781#comment-17255781 ] ASF GitHub Bot commented on KYLIN-4850: --- zhengshengjun opened a new pull request #1523: URL: https://github.com/apache/kylin/pull/1523 …job's configuration ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cube's override kylin_properties were ignored in building jobs > -- > > Key: KYLIN-4850 > URL: https://issues.apache.org/jira/browse/KYLIN-4850 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v4.0.0-alpha >Reporter: ShengJun Zheng >Priority: Minor > > Cube's override kylin_properties were ignored in building jobs, it prevent us > from optimizing spark configurations of some special cubes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] zhengshengjun opened a new pull request #1523: fix KYLIN-4850, merge Cube's override kylin_properties into building …
zhengshengjun opened a new pull request #1523: URL: https://github.com/apache/kylin/pull/1523 …job's configuration ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1515: update find-xx-dependency.sh for macOS compatibility
hit-lacus commented on pull request #1515: URL: https://github.com/apache/kylin/pull/1515#issuecomment-751924125 As far as I know, Mac OS is not a OS which Kylin going to support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (KYLIN-4850) Cube's override kylin_properties were ignored in building jobs
ShengJun Zheng created KYLIN-4850: - Summary: Cube's override kylin_properties were ignored in building jobs Key: KYLIN-4850 URL: https://issues.apache.org/jira/browse/KYLIN-4850 Project: Kylin Issue Type: Improvement Components: Job Engine Affects Versions: v4.0.0-alpha Reporter: ShengJun Zheng Cube's override kylin_properties were ignored in building jobs, it prevent us from optimizing spark configurations of some special cubes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (KYLIN-4849) Support sum(case when...), sum(2*price+1), count(column) and more for Kylin 4
Zhichao Zhang created KYLIN-4849: - Summary: Support sum(case when...), sum(2*price+1), count(column) and more for Kylin 4 Key: KYLIN-4849 URL: https://issues.apache.org/jira/browse/KYLIN-4849 Project: Kylin Issue Type: New Feature Components: Query Engine Affects Versions: v4.0.0-alpha Reporter: Zhichao Zhang Assignee: Zhichao Zhang Fix For: v4.0.0-beta Support sum(case when...), sum(2*price+1), count(column) and more Please reference to KYLIN-3358 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3392) Support NULL value in Sum, Max, Min Aggregation
[ https://issues.apache.org/jira/browse/KYLIN-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1726#comment-1726 ] Zhong Yanghong commented on KYLIN-3392: --- Hi [~wangrupeng], I applied the patch to 3.1.0 and it works well. Could you try it? > Support NULL value in Sum, Max, Min Aggregation > --- > > Key: KYLIN-3392 > URL: https://issues.apache.org/jira/browse/KYLIN-3392 > Project: Kylin > Issue Type: Bug >Reporter: Yifei Wu >Assignee: Yifei Wu >Priority: Major > Fix For: Future > > Attachments: KYLIN-3392-2.png, KYLIN-3392.png, kylin-3.0.0-alpha2.png > > > It is treated as 0 when confronted with NULL value in KYLIN's basic aggregate > measure (like sum, max, min). However, to distinguish the NULL value with 0 > is very necessary. > It should be like this > *sum(null, null) = null* > *sum(null, 1) = 1* > *max(null, null) = null* > *max(null, -1) = -1* > *min(null, -1）= -1* > in accordance with Hive and SparkSQL -- This message was sent by Atlassian Jira (v8.3.4#803005)
