[GitHub] [kylin] hit-lacus merged pull request #1544: KYLIn-4874 Fix CubeMigrationCLI bug for kylin4
hit-lacus merged pull request #1544: URL: https://github.com/apache/kylin/pull/1544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (KYLIN-4875) Remove executor configurations when execute resource detect step (local mode)
Zhichao Zhang created KYLIN-4875: - Summary: Remove executor configurations when execute resource detect step (local mode) Key: KYLIN-4875 URL: https://issues.apache.org/jira/browse/KYLIN-4875 Project: Kylin Issue Type: Improvement Components: Spark Engine Affects Versions: v4.0.0-alpha Reporter: Zhichao Zhang Assignee: Zhichao Zhang Fix For: v4.0.0-beta Remove executor configurations when execute resource detect step (local mode) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] codecov-io commented on pull request #1544: KYLIn-4874 Fix CubeMigrationCLI bug for kylin4
codecov-io commented on pull request #1544: URL: https://github.com/apache/kylin/pull/1544#issuecomment-762018937 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1544?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@dc5f295`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1544?src=pr=tree) ```diff @@ Coverage Diff @@ ## kylin-on-parquet-v2#1544 +/- ## == Coverage ? 24.27% Complexity ? 4624 == Files ? 1144 Lines ?65277 Branches ? 9584 == Hits ?15843 Misses ?47785 Partials ? 1649 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1544?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1544?src=pr=footer). Last update [dc5f295...bde7919](https://codecov.io/gh/apache/kylin/pull/1544?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zhangayqian opened a new pull request #1544: KYLIn-4874 Fix CubeMigrationCLI bug for kylin4
zhangayqian opened a new pull request #1544: URL: https://github.com/apache/kylin/pull/1544 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (KYLIN-4874) Fix CubeMigrationCLI bug for kylin4
Yaqian Zhang created KYLIN-4874: --- Summary: Fix CubeMigrationCLI bug for kylin4 Key: KYLIN-4874 URL: https://issues.apache.org/jira/browse/KYLIN-4874 Project: Kylin Issue Type: Bug Components: Client - CLI Reporter: Yaqian Zhang Assignee: Yaqian Zhang Fix For: v4.0.0-beta Solve the problem that the source cluster and the target cluster model are not in the same project and the project information of the model is not modified. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4873) Is it possible to browse kylin cubes directly
[ https://issues.apache.org/jira/browse/KYLIN-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266951#comment-17266951 ] Xiaoxiang Yu commented on KYLIN-4873: - Maybe via BI tools like Superset? > Is it possible to browse kylin cubes directly > - > > Key: KYLIN-4873 > URL: https://issues.apache.org/jira/browse/KYLIN-4873 > Project: Kylin > Issue Type: Improvement > Environment: AWS EMR >Reporter: vipul sikka >Priority: Major > > I want to access cubes directly with out writing the sql queries -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4653) Make the capacity for the LinkedBlockingQueue of BlockingReservoir configurable
[ https://issues.apache.org/jira/browse/KYLIN-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266807#comment-17266807 ] ASF subversion and git services commented on KYLIN-4653: Commit 5b3859c9d6871cd001a39ece43c856275215e01b in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5b3859c ] KYLIN-4653 Make the capacity for the LinkedBlockingQueue of BlockingReservoir configurable (cherry picked from commit 159a0fffe0aff2babd7d6f97bab7de6c7dc2be35) > Make the capacity for the LinkedBlockingQueue of BlockingReservoir > configurable > --- > > Key: KYLIN-4653 > URL: https://issues.apache.org/jira/browse/KYLIN-4653 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.1 > > > Currently the blocking queue capacity is 50K. It is too small, which easily > goes into being blocked and slows down queries. > It's better to make this value configurable and enlarge the default value. > For real usage, I strongly recommend to use unbounded LinkedBlockingQueue, > which is supposed not to block queries due to report query metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266803#comment-17266803 ] ASF subversion and git services commented on KYLIN-4496: Commit 7431240a7a8d868cbceba25cfb5b0d66c428cb66 in kylin's branch refs/heads/kylin-on-parquet-v2 from tianhui5 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7431240 ] KYLIN-4496: Metric data missing (cherry picked from commit 278aababa11fff222327ec6b6f73e659b147b8d7) > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4573) Add option to indicate whether to close file for every append for Hive Producer
[ https://issues.apache.org/jira/browse/KYLIN-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266804#comment-17266804 ] ASF subversion and git services commented on KYLIN-4573: Commit 3400338d7870c843e5ab2490c6767aa37e8092e4 in kylin's branch refs/heads/kylin-on-parquet-v2 from Zhong, Yanghong [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=3400338 ] KYLIN-4573 Add option to indicate whether to close file for every append for Hive Producer (cherry picked from commit 616e06675278a6857f3cbb353a4f9c2243eeccc1) > Add option to indicate whether to close file for every append for Hive > Producer > --- > > Key: KYLIN-4573 > URL: https://issues.apache.org/jira/browse/KYLIN-4573 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4857) Refactor system cube for kylin4
[ https://issues.apache.org/jira/browse/KYLIN-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266802#comment-17266802 ] ASF subversion and git services commented on KYLIN-4857: Commit af3a1b55ae1bbfb157ce9ec63a73651865c4c94a in kylin's branch refs/heads/kylin-on-parquet-v2 from yaqian.zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=af3a1b5 ] KYLIN-4857 Refactor system cube for kylin4 > Refactor system cube for kylin4 > --- > > Key: KYLIN-4857 > URL: https://issues.apache.org/jira/browse/KYLIN-4857 > Project: Kylin > Issue Type: Improvement > Components: Metrics >Affects Versions: v4.0.0-alpha >Reporter: Yaqian Zhang >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v4.0.0-beta > > > With the change of query engine and storage, the query related metrics > collected by system cube in kylin3 are no longer applicable to kylin4, so it > needs to be refactor to adapt to the spark query engine in kylin4. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4653) Make the capacity for the LinkedBlockingQueue of BlockingReservoir configurable
[ https://issues.apache.org/jira/browse/KYLIN-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266806#comment-17266806 ] ASF subversion and git services commented on KYLIN-4653: Commit 6f48ce8322e6e46df107564c7788e25bcd3abde0 in kylin's branch refs/heads/kylin-on-parquet-v2 from chuxiao [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6f48ce8 ] KYLIN-4653 Make the capacity for the LinkedBlockingQueue of BlockingReservoir configurable (cherry picked from commit 8e44f573be5905fe85f10241f0f7a7844e48f5f0) > Make the capacity for the LinkedBlockingQueue of BlockingReservoir > configurable > --- > > Key: KYLIN-4653 > URL: https://issues.apache.org/jira/browse/KYLIN-4653 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.1 > > > Currently the blocking queue capacity is 50K. It is too small, which easily > goes into being blocked and slows down queries. > It's better to make this value configurable and enlarge the default value. > For real usage, I strongly recommend to use unbounded LinkedBlockingQueue, > which is supposed not to block queries due to report query metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4857) Refactor system cube for kylin4
[ https://issues.apache.org/jira/browse/KYLIN-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266805#comment-17266805 ] ASF GitHub Bot commented on KYLIN-4857: --- hit-lacus merged pull request #1538: URL: https://github.com/apache/kylin/pull/1538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor system cube for kylin4 > --- > > Key: KYLIN-4857 > URL: https://issues.apache.org/jira/browse/KYLIN-4857 > Project: Kylin > Issue Type: Improvement > Components: Metrics >Affects Versions: v4.0.0-alpha >Reporter: Yaqian Zhang >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v4.0.0-beta > > > With the change of query engine and storage, the query related metrics > collected by system cube in kylin3 are no longer applicable to kylin4, so it > needs to be refactor to adapt to the spark query engine in kylin4. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] hit-lacus merged pull request #1538: KYLIN-4857 Refactor system cube for kylin4
hit-lacus merged pull request #1538: URL: https://github.com/apache/kylin/pull/1538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-4857) Refactor system cube for kylin4
[ https://issues.apache.org/jira/browse/KYLIN-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266801#comment-17266801 ] ASF GitHub Bot commented on KYLIN-4857: --- hit-lacus commented on pull request #1538: URL: https://github.com/apache/kylin/pull/1538#issuecomment-761828158 Thanks @zhangayqian for your great works, and thanks @zzcclp for review and verification, both you are excellect ! This patch looks good to me, I will merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor system cube for kylin4 > --- > > Key: KYLIN-4857 > URL: https://issues.apache.org/jira/browse/KYLIN-4857 > Project: Kylin > Issue Type: Improvement > Components: Metrics >Affects Versions: v4.0.0-alpha >Reporter: Yaqian Zhang >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v4.0.0-beta > > > With the change of query engine and storage, the query related metrics > collected by system cube in kylin3 are no longer applicable to kylin4, so it > needs to be refactor to adapt to the spark query engine in kylin4. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] hit-lacus commented on pull request #1538: KYLIN-4857 Refactor system cube for kylin4
hit-lacus commented on pull request #1538: URL: https://github.com/apache/kylin/pull/1538#issuecomment-761828158 Thanks @zhangayqian for your great works, and thanks @zzcclp for review and verification, both you are excellect ! This patch looks good to me, I will merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
