[jira] [Commented] (KYLIN-4970) Fix spark.executor.extraJavaOptions args

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341166#comment-17341166
 ] 

ASF subversion and git services commented on KYLIN-4970:


Commit 5a64ee1eec02156468a7f64f0536dc9995826aa1 in kylin's branch 
refs/heads/master from yangjiang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5a64ee1 ]

[KYLIN-4970]  fix spark.executor.extraJavaOptions args in SparkExecutable.


> Fix spark.executor.extraJavaOptions args
> 
>
> Key: KYLIN-4970
> URL: https://issues.apache.org/jira/browse/KYLIN-4970
> Project: Kylin
>  Issue Type: Bug
>  Components: Spark Engine
>Reporter: JiangYang
>Assignee: JiangYang
>Priority: Minor
> Fix For: v3.1.3
>
>
> in spark doc: spark.executor.extraJavaOption need surrond with "".
> !image-2021-04-09-10-18-58-294.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4970) Fix spark.executor.extraJavaOptions args

2021-05-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341167#comment-17341167
 ] 

ASF GitHub Bot commented on KYLIN-4970:
---

hit-lacus merged pull request #1632:
URL: https://github.com/apache/kylin/pull/1632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix spark.executor.extraJavaOptions args
> 
>
> Key: KYLIN-4970
> URL: https://issues.apache.org/jira/browse/KYLIN-4970
> Project: Kylin
>  Issue Type: Bug
>  Components: Spark Engine
>Reporter: JiangYang
>Assignee: JiangYang
>Priority: Minor
> Fix For: v3.1.3
>
>
> in spark doc: spark.executor.extraJavaOption need surrond with "".
> !image-2021-04-09-10-18-58-294.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1632: [KYLIN-4970] fix spark.executor.extraJavaOptions args in SparkExecut…

2021-05-07 Thread GitBox


hit-lacus merged pull request #1632:
URL: https://github.com/apache/kylin/pull/1632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4978) NPE: submit refresh request using restful api when there is no segments

2021-05-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341164#comment-17341164
 ] 

ASF GitHub Bot commented on KYLIN-4978:
---

hit-lacus merged pull request #1638:
URL: https://github.com/apache/kylin/pull/1638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> NPE: submit refresh request using restful api when there is no segments
> ---
>
> Key: KYLIN-4978
> URL: https://issues.apache.org/jira/browse/KYLIN-4978
> Project: Kylin
>  Issue Type: Bug
>Reporter: Kun Liu
>Assignee: Kun Liu
>Priority: Minor
> Fix For: v3.1.3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1638: [KYLIN-4978]NPE: refresh segment when there is no segments

2021-05-07 Thread GitBox


hit-lacus merged pull request #1638:
URL: https://github.com/apache/kylin/pull/1638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341163#comment-17341163
 ] 

ASF subversion and git services commented on KYLIN-4554:


Commit f5ec8f3dd1a70c5e1125966e144d492248030de4 in kylin's branch 
refs/heads/kylin-on-parquet-v2 from zheniantoushipashi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f5ec8f3 ]

 [KYLIN-4554] validate filter condition on model saving, fix bug added all the 
columns of all tables to the validate collection


> Validate "filter condition" on model saving
> ---
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Shao Feng Shi
>Assignee: Sun BiaoBiao
>Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341161#comment-17341161
 ] 

ASF subversion and git services commented on KYLIN-4554:


Commit 6d87071158cb9256552c880c0c29bc995eb2cb54 in kylin's branch 
refs/heads/kylin-on-parquet-v2 from zheniantoushipashi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6d87071 ]

[KYLIN-4554] validate filter condition on model saving

verify filter condition using the following login

1 select * from tableName where {filterCondition} pass   calcite  parse

2 all column in filter condition must be model table column


> Validate "filter condition" on model saving
> ---
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Shao Feng Shi
>Assignee: Sun BiaoBiao
>Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

2021-05-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341162#comment-17341162
 ] 

ASF GitHub Bot commented on KYLIN-4554:
---

hit-lacus merged pull request #1628:
URL: https://github.com/apache/kylin/pull/1628


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Validate "filter condition" on model saving
> ---
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Shao Feng Shi
>Assignee: Sun BiaoBiao
>Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1628: [KYLIN-4554] validate filter condition on model saving

2021-05-07 Thread GitBox


hit-lacus merged pull request #1628:
URL: https://github.com/apache/kylin/pull/1628


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4948) Provide an API to allow users to adjust cuboids manually

2021-05-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341160#comment-17341160
 ] 

ASF GitHub Bot commented on KYLIN-4948:
---

hit-lacus merged pull request #1630:
URL: https://github.com/apache/kylin/pull/1630


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide an API to allow users to adjust cuboids manually
> 
>
> Key: KYLIN-4948
> URL: https://issues.apache.org/jira/browse/KYLIN-4948
> Project: Kylin
>  Issue Type: New Feature
>  Components: REST Service
>Reporter: JiangYang
>Assignee: JiangYang
>Priority: Minor
> Fix For: v4.0.0-GA, v3.1.3
>
>
> This API should include the following info:
>  * Cuboids added
>  * Cuboids removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4948) Provide an API to allow users to adjust cuboids manually

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341159#comment-17341159
 ] 

ASF subversion and git services commented on KYLIN-4948:


Commit 91da578b0594aa0b7c9bcda25bd92e3a83e54d0c in kylin's branch 
refs/heads/master from yangjiang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=91da578 ]

[KYLIN-4948] Provide an API to allow users to adjust cuboids manually


> Provide an API to allow users to adjust cuboids manually
> 
>
> Key: KYLIN-4948
> URL: https://issues.apache.org/jira/browse/KYLIN-4948
> Project: Kylin
>  Issue Type: New Feature
>  Components: REST Service
>Reporter: JiangYang
>Assignee: JiangYang
>Priority: Minor
> Fix For: v4.0.0-GA, v3.1.3
>
>
> This API should include the following info:
>  * Cuboids added
>  * Cuboids removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341157#comment-17341157
 ] 

ASF subversion and git services commented on KYLIN-4554:


Commit b77c92a49d6a5cef116b15f78255fd811eccc3be in kylin's branch 
refs/heads/master from zheniantoushipashi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=b77c92a ]

 [KYLIN-4554] validate filter condition on model saving, fix bug added all the 
columns of all tables to the validate collection


> Validate "filter condition" on model saving
> ---
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Shao Feng Shi
>Assignee: Sun BiaoBiao
>Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

2021-05-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341158#comment-17341158
 ] 

ASF GitHub Bot commented on KYLIN-4554:
---

hit-lacus merged pull request #1626:
URL: https://github.com/apache/kylin/pull/1626


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Validate "filter condition" on model saving
> ---
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Shao Feng Shi
>Assignee: Sun BiaoBiao
>Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341156#comment-17341156
 ] 

ASF subversion and git services commented on KYLIN-4554:


Commit 9589802b4450a1a23047c4e26abdfe4e6b761a71 in kylin's branch 
refs/heads/master from zheniantoushipashi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=9589802 ]

[KYLIN-4554] validate filter condition on model saving

verify filter condition using the following login

1 select * from tableName where {filterCondition} pass   calcite  parse

2 all column in filter condition must be model table column


> Validate "filter condition" on model saving
> ---
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Shao Feng Shi
>Assignee: Sun BiaoBiao
>Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1630: [KYLIN-4948] Provide an API to allow users to adjust cuboids manually

2021-05-07 Thread GitBox


hit-lacus merged pull request #1630:
URL: https://github.com/apache/kylin/pull/1630


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] hit-lacus merged pull request #1626: [KYLIN-4554] validate filter condition on model saving

2021-05-07 Thread GitBox


hit-lacus merged pull request #1626:
URL: https://github.com/apache/kylin/pull/1626


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4971) Add new measure bitmap_map for count distinct measure in UI

2021-05-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341155#comment-17341155
 ] 

ASF GitHub Bot commented on KYLIN-4971:
---

hit-lacus merged pull request #1633:
URL: https://github.com/apache/kylin/pull/1633


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add new measure bitmap_map for count distinct  measure in UI
> 
>
> Key: KYLIN-4971
> URL: https://issues.apache.org/jira/browse/KYLIN-4971
> Project: Kylin
>  Issue Type: Task
>Reporter: JiangYang
>Assignee: JiangYang
>Priority: Minor
> Fix For: v3.1.3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4971) Add new measure bitmap_map for count distinct measure in UI

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341154#comment-17341154
 ] 

ASF subversion and git services commented on KYLIN-4971:


Commit b577521d93b049a65bdc3d7e0dd783018edd5c68 in kylin's branch 
refs/heads/master from yangjiang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=b577521 ]

[KYLIN-4971] Add new measure bitmap_map for count distinct at frontend. (#222)


> Add new measure bitmap_map for count distinct  measure in UI
> 
>
> Key: KYLIN-4971
> URL: https://issues.apache.org/jira/browse/KYLIN-4971
> Project: Kylin
>  Issue Type: Task
>Reporter: JiangYang
>Assignee: JiangYang
>Priority: Minor
> Fix For: v3.1.3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1633: [KYLIN-4971] Add new measure bitmap_map for count distinct at fronten…

2021-05-07 Thread GitBox


hit-lacus merged pull request #1633:
URL: https://github.com/apache/kylin/pull/1633


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (KYLIN-4591) Artifact shaded-guava break release:prepare

2021-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341148#comment-17341148
 ] 

ASF subversion and git services commented on KYLIN-4591:


Commit d45038077eb6235cfd2c405491fa31600f80deb2 in kylin's branch 
refs/heads/master from Chunen Ni
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=d450380 ]

KYLIN-4591 exclude external module


> Artifact shaded-guava break release:prepare
> ---
>
> Key: KYLIN-4591
> URL: https://issues.apache.org/jira/browse/KYLIN-4591
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Major
> Fix For: Future
>
>
> Let me try to explain the problem I faced:
> As I am the release manager of kylin 3.1.0, I am trying to use following 
> command to do the release.
> {code:bash}
> mvn release:prepare
> {code}
> And this maven-release-plugin will check a lot of pre-requirements, at the 
> end, it will throw an exception:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on 
> project kylin: Can't release project due to non released dependencies :
> [ERROR] org.apache.kylin:kylin-shaded-guava:jar:3.1.0-SNAPSHOT:compile
> [ERROR] in project 'Apache Kylin - Core Common' 
> (org.apache.kylin:kylin-core-common:jar:3.1.0-SNAPSHOT)
> [ERROR] -> [Help 1]
> {noformat}
> It means that a dependency which has a "X.Y.Z-SNAPSHOT" version and its 
> artifact/jar cannot be built from source code is forbidden.
> Unluckily, the "shaded-guava" is in this case.
> As a workaround, I remove the "SNAPSHOT" postfix for this "shaded-guava", and 
> install "shaded-guava" locally. After that, I execute _mvn release:prepare_ 
> command and everything look fine in my machine.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1648: Update version

2021-05-07 Thread GitBox


hit-lacus merged pull request #1648:
URL: https://github.com/apache/kylin/pull/1648


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kylin] hit-lacus opened a new pull request #1648: Update version

2021-05-07 Thread GitBox


hit-lacus opened a new pull request #1648:
URL: https://github.com/apache/kylin/pull/1648


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org