[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599871#comment-17599871 ] ASF GitHub Bot commented on KYLIN-5238: --- zhaoliu17 closed pull request #1952: KYLIN-5238 add cleanup cube_statistics URL: https://github.com/apache/kylin/pull/1952 > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599870#comment-17599870 ] ASF GitHub Bot commented on KYLIN-5238: --- zhaoliu17 opened a new pull request, #1966: URL: https://github.com/apache/kylin/pull/1966 ## Proposed changes 我认为在 kylin4 的StorageCleanupJob 中增加对无引用的 cube_stataistics 数据清理是有意义的： 1. 可以降低无用数据占用的存储空间，同时避免过多无用小文件对nn的压力 2. 默认情况下清理无引用的 cube_stataistics 数据，但可以通过 -cleanupCubeStatistics false 禁用 ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] zhaoliu17 closed pull request #1952: KYLIN-5238 add cleanup cube_statistics
zhaoliu17 closed pull request #1952: KYLIN-5238 add cleanup cube_statistics URL: https://github.com/apache/kylin/pull/1952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zhaoliu17 opened a new pull request, #1966: KYLIN-5238 add cleanup unreferenced cube_statistics
zhaoliu17 opened a new pull request, #1966: URL: https://github.com/apache/kylin/pull/1966 ## Proposed changes 我认为在 kylin4 的StorageCleanupJob 中增加对无引用的 cube_stataistics 数据清理是有意义的： 1. 可以降低无用数据占用的存储空间，同时避免过多无用小文件对nn的压力 2. 默认情况下清理无引用的 cube_stataistics 数据，但可以通过 -cleanupCubeStatistics false 禁用 ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success
[ https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599829#comment-17599829 ] ASF GitHub Bot commented on KYLIN-5245: --- zhaoliu17 commented on PR #1959: URL: https://github.com/apache/kylin/pull/1959#issuecomment-1236068041 好的，我将添加变更描述 > When a job is submitted with deployMode=cluster and the application driver is > abnormal, Kylin displays the job status as success > > > Key: KYLIN-5245 > URL: https://issues.apache.org/jira/browse/KYLIN-5245 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Major > Attachments: image-2022-08-31-14-34-56-081.png > > > !image-2022-08-31-14-34-56-081.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] zhaoliu17 commented on pull request #1959: KYLIN-5245 fix incorrect job status is displayed when deployMode is c…
zhaoliu17 commented on PR #1959: URL: https://github.com/apache/kylin/pull/1959#issuecomment-1236068041 好的，我将添加变更描述 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success
[ https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599822#comment-17599822 ] ASF GitHub Bot commented on KYLIN-5245: --- liyang-kylin commented on PR #1959: URL: https://github.com/apache/kylin/pull/1959#issuecomment-1236062567 需要更多信息在 PR 描述里，比如 Proposed changes 等。 > When a job is submitted with deployMode=cluster and the application driver is > abnormal, Kylin displays the job status as success > > > Key: KYLIN-5245 > URL: https://issues.apache.org/jira/browse/KYLIN-5245 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Major > Attachments: image-2022-08-31-14-34-56-081.png > > > !image-2022-08-31-14-34-56-081.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] liyang-kylin commented on pull request #1959: KYLIN-5245 fix incorrect job status is displayed when deployMode is c…
liyang-kylin commented on PR #1959: URL: https://github.com/apache/kylin/pull/1959#issuecomment-1236062567 需要更多信息在 PR 描述里，比如 Proposed changes 等。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (KYLIN-5246) long running job's log staying in mem, may cause job server oom
[
https://issues.apache.org/jira/browse/KYLIN-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liyang updated KYLIN-5246:
--
Summary: long running job's log staying in mem, may cause job server oom
(was: long running jobs may cause memory problems in the job server)
> long running job's log staying in mem, may cause job server oom
> ---
>
> Key: KYLIN-5246
> URL: https://issues.apache.org/jira/browse/KYLIN-5246
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: zhaoliu
>Priority: Minor
>
> {code:java}
> CliCommandExecutor
>
> BufferedReader reader = new BufferedReader(
> new InputStreamReader(proc.getInputStream(),
> StandardCharsets.UTF_8));
> String line;
> StringBuilder result = new StringBuilder();
> while ((line = reader.readLine()) != null &&
> !Thread.currentThread().isInterrupted()) {
> result.append(line).append('\n');
> if (logAppender != null) {
> logAppender.log(line);
> }
> }
> {code}
> job运行时间久，result 会非常大，可能会引起内存问题
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5246) long running jobs may cause memory problems in the job server
[
https://issues.apache.org/jira/browse/KYLIN-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599820#comment-17599820
]
liyang commented on KYLIN-5246:
---
Good suggestion!
> long running jobs may cause memory problems in the job server
> -
>
> Key: KYLIN-5246
> URL: https://issues.apache.org/jira/browse/KYLIN-5246
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: zhaoliu
>Priority: Minor
>
> {code:java}
> CliCommandExecutor
>
> BufferedReader reader = new BufferedReader(
> new InputStreamReader(proc.getInputStream(),
> StandardCharsets.UTF_8));
> String line;
> StringBuilder result = new StringBuilder();
> while ((line = reader.readLine()) != null &&
> !Thread.currentThread().isInterrupted()) {
> result.append(line).append('\n');
> if (logAppender != null) {
> logAppender.log(line);
> }
> }
> {code}
> job运行时间久，result 会非常大，可能会引起内存问题
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
