[jira] [Issue Comment Deleted] (KYLIN-3980) Cube planner cuboid id error when dimensions too many
[ https://issues.apache.org/jira/browse/KYLIN-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3980: --- Comment: was deleted (was: Here is the pull request: [https://github.com/apache/kylin/pull/628]) > Cube planner cuboid id error when dimensions too many > - > > Key: KYLIN-3980 > URL: https://issues.apache.org/jira/browse/KYLIN-3980 > Project: Kylin > Issue Type: Bug >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > Cube planner cuboid id error when dimensions beyond too many. > The issue due to cuboid is the Number and Number in javascript max value is > 2^53-1. > [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] > If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), > then it will get error cuboid in page, which impact optimize job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3980) Cube planner cuboid id error when dimensions too many
[ https://issues.apache.org/jira/browse/KYLIN-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833203#comment-16833203 ] Pan, Julian commented on KYLIN-3980: Here is the pull request: [https://github.com/apache/kylin/pull/628] > Cube planner cuboid id error when dimensions too many > - > > Key: KYLIN-3980 > URL: https://issues.apache.org/jira/browse/KYLIN-3980 > Project: Kylin > Issue Type: Bug >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > Cube planner cuboid id error when dimensions beyond too many. > The issue due to cuboid is the Number and Number in javascript max value is > 2^53-1. > [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] > If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), > then it will get error cuboid in page, which impact optimize job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3980) Cube planner cuboid id error when dimensions too many
[ https://issues.apache.org/jira/browse/KYLIN-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825736#comment-16825736 ] Pan, Julian commented on KYLIN-3980: The fix is change the type of cuboid from Number to String during the API. And will create a pull request to fix it. > Cube planner cuboid id error when dimensions too many > - > > Key: KYLIN-3980 > URL: https://issues.apache.org/jira/browse/KYLIN-3980 > Project: Kylin > Issue Type: Bug >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > Cube planner cuboid id error when dimensions beyond too many. > The issue due to cuboid is the Number and Number in javascript max value is > 2^53-1. > [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] > If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), > then it will get error cuboid in page, which impact optimize job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3980) Cube planner cuboid id error when dimensions too many
Pan, Julian created KYLIN-3980: -- Summary: Cube planner cuboid id error when dimensions too many Key: KYLIN-3980 URL: https://issues.apache.org/jira/browse/KYLIN-3980 Project: Kylin Issue Type: Bug Reporter: Pan, Julian Assignee: Pan, Julian Cube planner cuboid id error when dimensions beyond too many. The issue due to the Number in javascript max value is 2^53-1. [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), then it will get error cuboid in page, which impact optimize job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3980) Cube planner cuboid id error when dimensions too many
[ https://issues.apache.org/jira/browse/KYLIN-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3980: --- Description: Cube planner cuboid id error when dimensions beyond too many. The issue due to cuboid is the Number and Number in javascript max value is 2^53-1. [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), then it will get error cuboid in page, which impact optimize job. was: Cube planner cuboid id error when dimensions beyond too many. The issue due to the Number in javascript max value is 2^53-1. [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), then it will get error cuboid in page, which impact optimize job. > Cube planner cuboid id error when dimensions too many > - > > Key: KYLIN-3980 > URL: https://issues.apache.org/jira/browse/KYLIN-3980 > Project: Kylin > Issue Type: Bug >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > Cube planner cuboid id error when dimensions beyond too many. > The issue due to cuboid is the Number and Number in javascript max value is > 2^53-1. > [https://www.ecma-international.org/ecma-262/5.1/#sec-8.5] > If the cuboid id is greater than Number.MAX_SAFE_INTEGER(9007199254740991), > then it will get error cuboid in page, which impact optimize job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3916) Fix cube build action issue after streaming migrate
[ https://issues.apache.org/jira/browse/KYLIN-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3916: --- Summary: Fix cube build action issue after streaming migrate (was: Fix cube action issue after streaming migrate) > Fix cube build action issue after streaming migrate > --- > > Key: KYLIN-3916 > URL: https://issues.apache.org/jira/browse/KYLIN-3916 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > Cube cannot build after streaming migrate to master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3916) Fix cube action issue after streaming migrate
Pan, Julian created KYLIN-3916: -- Summary: Fix cube action issue after streaming migrate Key: KYLIN-3916 URL: https://issues.apache.org/jira/browse/KYLIN-3916 Project: Kylin Issue Type: Bug Components: Web Reporter: Pan, Julian Assignee: Pan, Julian Cube cannot build after streaming migrate to master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly
[ https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3804: --- Attachment: (was: after change-edit.png) > Advanced Snapshot Table save not friendly > - > > Key: KYLIN-3804 > URL: https://issues.apache.org/jira/browse/KYLIN-3804 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: new implementation-edit.png, new > implementation-saved.png, not save.png, save.png > > > The configuration for "Advanced Snapshot Table" in "Advance Setting" may > confuse customer. > User need click "+" to save the snapshot info. > Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly
[ https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3804: --- Attachment: after change-edit.png after change-saved.png > Advanced Snapshot Table save not friendly > - > > Key: KYLIN-3804 > URL: https://issues.apache.org/jira/browse/KYLIN-3804 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: after change-edit.png, after change-saved.png, not > save.png, save.png > > > The configuration for "Advanced Snapshot Table" in "Advance Setting" may > confuse customer. > User need click "+" to save the snapshot info. > Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly
[ https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3804: --- Attachment: new implementation-edit.png new implementation-saved.png > Advanced Snapshot Table save not friendly > - > > Key: KYLIN-3804 > URL: https://issues.apache.org/jira/browse/KYLIN-3804 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: new implementation-edit.png, new > implementation-saved.png, not save.png, save.png > > > The configuration for "Advanced Snapshot Table" in "Advance Setting" may > confuse customer. > User need click "+" to save the snapshot info. > Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly
[ https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3804: --- Attachment: (was: after change-saved.png) > Advanced Snapshot Table save not friendly > - > > Key: KYLIN-3804 > URL: https://issues.apache.org/jira/browse/KYLIN-3804 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: new implementation-edit.png, new > implementation-saved.png, not save.png, save.png > > > The configuration for "Advanced Snapshot Table" in "Advance Setting" may > confuse customer. > User need click "+" to save the snapshot info. > Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly
[ https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3804: --- Attachment: not save.png > Advanced Snapshot Table save not friendly > - > > Key: KYLIN-3804 > URL: https://issues.apache.org/jira/browse/KYLIN-3804 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: not save.png, save.png > > > The configuration for "Advanced Snapshot Table" in "Advance Setting" may > confuse customer. > User need click "+" to save the snapshot info. > Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly
[ https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3804: --- Attachment: save.png > Advanced Snapshot Table save not friendly > - > > Key: KYLIN-3804 > URL: https://issues.apache.org/jira/browse/KYLIN-3804 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Critical > Attachments: not save.png, save.png > > > The configuration for "Advanced Snapshot Table" in "Advance Setting" may > confuse customer. > User need click "+" to save the snapshot info. > Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3804) Advanced Snapshot Table save not friendly
Pan, Julian created KYLIN-3804: -- Summary: Advanced Snapshot Table save not friendly Key: KYLIN-3804 URL: https://issues.apache.org/jira/browse/KYLIN-3804 Project: Kylin Issue Type: Improvement Components: Web Reporter: Pan, Julian Assignee: Pan, Julian The configuration for "Advanced Snapshot Table" in "Advance Setting" may confuse customer. User need click "+" to save the snapshot info. Change the the implementation similar with "Advanced Dictionaries". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3789: --- Description: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # Update content for hover replica set behavior: remove the topic detail info. # Fix display issue for the assignment in streaming receiver page. # Update popover position for partition and segment in streaming receiver page. # Change detail trigger button from bottom to top. # Update edit replica set popup style. was: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # Update content for hover replica set behavior: remove the topic detail info. # Fix display issue for the assignment in streaming receiver page. # Update popover position for partition and segment in streaming receiver page. # Change detail trigger button from bottom to top. > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > # There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. > # Update content for hover replica set behavior: remove the topic detail > info. > # Fix display issue for the assignment in streaming receiver page. > # Update popover position for partition and segment in streaming receiver > page. > # Change detail trigger button from bottom to top. > # Update edit replica set popup style. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian resolved KYLIN-3789. Resolution: Fixed > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > # There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. > # Update content for hover replica set behavior: remove the topic detail > info. > # Fix display issue for the assignment in streaming receiver page. > # Update popover position for partition and segment in streaming receiver > page. > # Change detail trigger button from bottom to top. > # Update edit replica set popup style. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757064#comment-16757064 ] Pan, Julian commented on KYLIN-3789: Git commit: [https://github.com/apache/kylin/commit/f5a6b8dd2a1d692389fb30f67be0ba45e172e6bb] > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > # There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. > # Update content for hover replica set behavior: remove the topic detail > info. > # Fix display issue for the assignment in streaming receiver page. > # Update popover position for partition and segment in streaming receiver > page. > # Change detail trigger button from bottom to top. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3789: --- Description: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # Update content for hover replica set behavior: remove the topic detail info. # Fix display issue for the assignment in streaming receiver page. # Update popover position for partition and segment in streaming receiver page. # Change detail trigger button from bottom to top. was: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # Update content for hover replica set behavior: remove the topic detail info. # Fix display issue for the assignment in streaming receiver page. # Update popover position for partition and segment in streaming receiver page. # > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > # There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. > # Update content for hover replica set behavior: remove the topic detail > info. > # Fix display issue for the assignment in streaming receiver page. > # Update popover position for partition and segment in streaming receiver > page. > # Change detail trigger button from bottom to top. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3789: --- Description: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # Update content for hover replica set behavior: remove the topic detail info. # Fix display issue for the assignment in streaming receiver page. # Update popover position for partition and segment in streaming receiver page. # was: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > # There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. > # Update content for hover replica set behavior: remove the topic detail > info. > # Fix display issue for the assignment in streaming receiver page. > # Update popover position for partition and segment in streaming receiver > page. > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3789: --- Description: # There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. # was:There are two places to show streaming receiver info(system level and cube level), sometimes the receiver's FQDN is too long to show, maybe we can just show a limit length name, and give the full name when hover. > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > # There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3789) Stream receiver admin page issue fix
[ https://issues.apache.org/jira/browse/KYLIN-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3789: --- Summary: Stream receiver admin page issue fix (was: Stream receiver FQDN is too long to show on GUI) > Stream receiver admin page issue fix > > > Key: KYLIN-3789 > URL: https://issues.apache.org/jira/browse/KYLIN-3789 > Project: Kylin > Issue Type: Sub-task > Components: Real-time Streaming >Reporter: Ma Gang >Assignee: Pan, Julian >Priority: Major > > There are two places to show streaming receiver info(system level and cube > level), sometimes the receiver's FQDN is too long to show, maybe we can just > show a limit length name, and give the full name when hover. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3738) Edit cube measure may make the decimal type change unexpectly
[ https://issues.apache.org/jira/browse/KYLIN-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728548#comment-16728548 ] Pan, Julian commented on KYLIN-3738: Hi shaofeng, I test in my local: After revert the pervious commit, the topN measure ($scope.newMeasure) is same as before and the decimal issue will be resolved. > Edit cube measure may make the decimal type change unexpectly > - > > Key: KYLIN-3738 > URL: https://issues.apache.org/jira/browse/KYLIN-3738 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.5.2 >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > When edit cube's measure and click save, the origin return type maybe changed > from decimal(19,4) to decimal(19), that will cause cube build result not > correct and query result incorrectly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3738) Edit cube measure may make the decimal type change unexpectly
[ https://issues.apache.org/jira/browse/KYLIN-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728319#comment-16728319 ] Pan, Julian commented on KYLIN-3738: Hi [~Shaofengshi], should we revert the commit? I test in my local, the configuration attribute will cover encoding. > Edit cube measure may make the decimal type change unexpectly > - > > Key: KYLIN-3738 > URL: https://issues.apache.org/jira/browse/KYLIN-3738 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.5.2 >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > When edit cube's measure and click save, the origin return type maybe changed > from decimal(19,4) to decimal(19), that will cause cube build result not > correct and query result incorrectly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3738) Edit cube measure may make the decimal type change unexpectly
[ https://issues.apache.org/jira/browse/KYLIN-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3738: --- Description: When edit cube's measure and click save, the origin return type maybe changed from decimal(19,4) to decimal(19), that will cause cube build result not correct and query result incorrectly. (was: When edit cube's measure and click save, the origin return type maybe changed from decimal(19,4) to decimal(19), that will cause cube build result not correct and query incorrectly.) > Edit cube measure may make the decimal type change unexpectly > - > > Key: KYLIN-3738 > URL: https://issues.apache.org/jira/browse/KYLIN-3738 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.5.2 >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > When edit cube's measure and click save, the origin return type maybe changed > from decimal(19,4) to decimal(19), that will cause cube build result not > correct and query result incorrectly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3738) Edit cube measure may make the decimal type change unexpectly
[
https://issues.apache.org/jira/browse/KYLIN-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728292#comment-16728292
]
Pan, Julian commented on KYLIN-3738:
The bug is related by KYLIN-2243
{code:java}
$scope.newMeasure.function.returntype=$scope.newMeasure.function.returntype.replace(/\,\d+/,'');
{code}
The code in addNewMeasure will change decimal(19,4) to decimal(19).
> Edit cube measure may make the decimal type change unexpectly
> -
>
> Key: KYLIN-3738
> URL: https://issues.apache.org/jira/browse/KYLIN-3738
> Project: Kylin
> Issue Type: Bug
> Components: Web
>Affects Versions: v2.5.2
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
>
> When edit cube's measure and click save, the origin return type maybe changed
> from decimal(19,4) to decimal(19), that will cause cube build result not
> correct
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (KYLIN-3738) Edit cube measure may make the decimal type change unexpectly
Pan, Julian created KYLIN-3738: -- Summary: Edit cube measure may make the decimal type change unexpectly Key: KYLIN-3738 URL: https://issues.apache.org/jira/browse/KYLIN-3738 Project: Kylin Issue Type: Bug Components: Web Affects Versions: v2.5.2 Reporter: Pan, Julian Assignee: Pan, Julian When edit cube's measure and click save, the origin return type maybe changed from decimal(19,4) to decimal(19), that will cause cube build result not correct -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3426) visualization charts were not showing up in the insight page
[ https://issues.apache.org/jira/browse/KYLIN-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712277#comment-16712277 ] Pan, Julian commented on KYLIN-3426: It should be resolve by this commit. https://github.com/apache/kylin/commit/e5accc575cc78f25f54d3125b0796a933526e79b#diff-726d9f12d405fd43a5c99e480e462d20 > visualization charts were not showing up in the insight page > > > Key: KYLIN-3426 > URL: https://issues.apache.org/jira/browse/KYLIN-3426 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.3.1 >Reporter: Jayaraj >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.6.0 > > Attachments: visualization_missing.png > > > created model and cube in kylin using sample dataset. In insight tab, able to > query the cubes, but all the visualization charts were not showing up for the > query result. Please find the attached screen shot and suggest on this. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3397) Kylin UI Timestemp(GMT) issue
[ https://issues.apache.org/jira/browse/KYLIN-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706622#comment-16706622 ] Pan, Julian commented on KYLIN-3397: Sorry for late reply. The system cube is GMT based, such as your cube build time select on UI. If necessary, we can create a task for the change timestamp for cube build base on Web time. > Kylin UI Timestemp(GMT) issue > - > > Key: KYLIN-3397 > URL: https://issues.apache.org/jira/browse/KYLIN-3397 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: praveenece >Priority: Major > > > Kylin Version 2.3.1 > In Kylin React-the Data has inserted into System Cube table based on GMT > format,but the user > Changed option GMT to GMT+5.30 in kylin UI (Kylin.properties). > when we build segment wise in System Cube(Kylin UI).the system has generated > select statement in first step of build,its > taken internally GMT+5.30 format not for GMT. > below i given generated select query from First step of Create Intermediate > Flat Hive Table(log) > SELECT x,y,z > FROM KYLIN.HIVE_METRICS_QUERY_CUBE_QA as HIVE_METRICS_QUERY_CUBE_QA > WHERE 1=1 AND (((HIVE_METRICS_QUERY_CUBE_QA.KDAY_DATE = '2018-06-01' AND > HIVE_METRICS_QUERY_CUBE_QA.KDAY_TIME >= '17:10:00') > OR (HIVE_METRICS_QUERY_CUBE_QA.KDAY_DATE > '2018-06-01')) > AND ((HIVE_METRICS_QUERY_CUBE_QA.KDAY_DATE = '2018-06-04' AND > HIVE_METRICS_QUERY_CUBE_QA.KDAY_TIME < '16:27:00') > OR (HIVE_METRICS_QUERY_CUBE_QA.KDAY_DATE < '2018-06-04'))) > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3599) Bulk Add Measures
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3599: --- Description: If user want to add hundreds measure, user need add them one by one in currently website. Add a bulk add button to resolve this issues in measure step. P.S just include common measure (sum, max, min, raw, percentile), due to count_distinct, topN and extended_column need more setting. Image attached and the default name generate automatically by pattern [measure_columnName]. was: If user want to add hundreds measure, user need add them one by one in currently website. Add a bulk add button to resolve this issues in measure step. P.S just include common measure (sum, max, min, raw, percentile), due to count_distinct, topN and extended_column need more setting. Image attached and the default name generate automatically by pattern [measure_] > Bulk Add Measures > - > > Key: KYLIN-3599 > URL: https://issues.apache.org/jira/browse/KYLIN-3599 > Project: Kylin > Issue Type: Improvement > Components: Web , Website >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.5.1 > > Attachments: bluk add button.png, select all or clean.png > > > If user want to add hundreds measure, user need add them one by one in > currently website. > Add a bulk add button to resolve this issues in measure step. > P.S just include common measure (sum, max, min, raw, percentile), due to > count_distinct, topN and extended_column need more setting. Image attached > and the default name generate automatically by pattern [measure_columnName]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3599) Bulk Add Measures
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3599: --- Description: If user want to add hundreds measure, user need add them one by one in currently website. Add a bulk add button to resolve this issues in measure step. P.S just include common measure (sum, max, min, raw, percentile), due to count_distinct, topN and extended_column need more setting. Image attached and the default name generate automatically by pattern [measure_] was: If user want to add hundreds measure, user need add them one by one in currently website. Add a bulk add button to resolve this issues in measure step. P.S just include common measure (sum, max, min, raw, percentile), due to count_distinct, topN and extended_column need more setting. > Bulk Add Measures > - > > Key: KYLIN-3599 > URL: https://issues.apache.org/jira/browse/KYLIN-3599 > Project: Kylin > Issue Type: Improvement > Components: Web , Website >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.5.1 > > Attachments: bluk add button.png, select all or clean.png > > > If user want to add hundreds measure, user need add them one by one in > currently website. > Add a bulk add button to resolve this issues in measure step. > P.S just include common measure (sum, max, min, raw, percentile), due to > count_distinct, topN and extended_column need more setting. Image attached > and the default name generate automatically by pattern [measure_] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3599) Bulk Add Measures
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630149#comment-16630149 ] Pan, Julian commented on KYLIN-3599: Related pull request: https://github.com/apache/kylin/pull/265 > Bulk Add Measures > - > > Key: KYLIN-3599 > URL: https://issues.apache.org/jira/browse/KYLIN-3599 > Project: Kylin > Issue Type: Improvement > Components: Web , Website >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Attachments: bluk add button.png, select all or clean.png > > > If user want to add hundreds measure, user need add them one by one in > currently website. > Add a bulk add button to resolve this issues in measure step. > P.S just include common measure (sum, max, min, raw, percentile), due to > count_distinct, topN and extended_column need more setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3599) Bulk Add Measures
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3599: --- Attachment: select all or clean.png > Bulk Add Measures > - > > Key: KYLIN-3599 > URL: https://issues.apache.org/jira/browse/KYLIN-3599 > Project: Kylin > Issue Type: Improvement > Components: Web , Website >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Attachments: bluk add button.png, select all or clean.png > > > If user want to add hundreds measure, user need add them one by one in > currently website. > Add a bulk add button to resolve this issues in measure step. > P.S just include common measure (sum, max, min, raw, percentile), due to > count_distinct, topN and extended_column need more setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3599) Bulk Add Measures
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3599: --- Attachment: bluk add button.png > Bulk Add Measures > - > > Key: KYLIN-3599 > URL: https://issues.apache.org/jira/browse/KYLIN-3599 > Project: Kylin > Issue Type: Improvement > Components: Web , Website >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Attachments: bluk add button.png > > > If user want to add hundreds measure, user need add them one by one in > currently website. > Add a bulk add button to resolve this issues in measure step. > P.S just include common measure (sum, max, min, raw, percentile), due to > count_distinct, topN and extended_column need more setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3599) Bulk Add Measures
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3599: --- Priority: Major (was: Critical) > Bulk Add Measures > - > > Key: KYLIN-3599 > URL: https://issues.apache.org/jira/browse/KYLIN-3599 > Project: Kylin > Issue Type: Improvement > Components: Web , Website >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > If user want to add hundreds measure, user need add them one by one in > currently website. > Add a bulk add button to resolve this issues in measure step. > P.S just include common measure (sum, max, min, raw, percentile), due to > count_distinct, topN and extended_column need more setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3599) Bulk Add Measures
Pan, Julian created KYLIN-3599: -- Summary: Bulk Add Measures Key: KYLIN-3599 URL: https://issues.apache.org/jira/browse/KYLIN-3599 Project: Kylin Issue Type: Improvement Components: Web , Website Reporter: Pan, Julian Assignee: Pan, Julian If user want to add hundreds measure, user need add them one by one in currently website. Add a bulk add button to resolve this issues in measure step. P.S just include common measure (sum, max, min, raw, percentile), due to count_distinct, topN and extended_column need more setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598396#comment-16598396 ] Pan, Julian commented on KYLIN-3521: +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (KYLIN-1977) Update front end dependency (bower)
[ https://issues.apache.org/jira/browse/KYLIN-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian closed KYLIN-1977. -- Resolution: Invalid > Update front end dependency (bower) > --- > > Key: KYLIN-1977 > URL: https://issues.apache.org/jira/browse/KYLIN-1977 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Zhong,Jason >Priority: Major > > 1. There is warning "Code incompatibilities may occur.", when I install bower > component. [angular, nvd3, d3, moment, angular-cookies version not consistent] > 2. Some duplicate component: ng-grid & angular-ui-grid, > angular-chosen-localytics & angular-ui-select, font-awesome & > components-font-awesome > 3. angularjs-nvd3-directives is beta version, maybe we can replace it by > angular-nvd3. > 4. some components version are out of date, could we upgrade them such as > angular-bootstrap... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-1977) Update front end dependency (bower)
[ https://issues.apache.org/jira/browse/KYLIN-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509053#comment-16509053 ] Pan, Julian commented on KYLIN-1977: Yeah, I think it can be close. > Update front end dependency (bower) > --- > > Key: KYLIN-1977 > URL: https://issues.apache.org/jira/browse/KYLIN-1977 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Zhong,Jason >Priority: Major > > 1. There is warning "Code incompatibilities may occur.", when I install bower > component. [angular, nvd3, d3, moment, angular-cookies version not consistent] > 2. Some duplicate component: ng-grid & angular-ui-grid, > angular-chosen-localytics & angular-ui-select, font-awesome & > components-font-awesome > 3. angularjs-nvd3-directives is beta version, maybe we can replace it by > angular-nvd3. > 4. some components version are out of date, could we upgrade them such as > angular-bootstrap... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3366) Configure automatic enabling of cubes after a build process
[ https://issues.apache.org/jira/browse/KYLIN-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463569#comment-16463569 ] Pan, Julian commented on KYLIN-3366: We met same issue, so attach the patch for our solution. Add properties: kylin.job.cube-auto-ready-enabled to control enable or not. The default value is true. Please add this attribute to cube configuration overwrite and set it to false if user do not want auto enable the cube when finish build. Does it fit your requirement? > Configure automatic enabling of cubes after a build process > --- > > Key: KYLIN-3366 > URL: https://issues.apache.org/jira/browse/KYLIN-3366 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.3.1 > Environment: Kylin 2.3.1 and Hadoop EMR 5.7 >Reporter: Roberto Tardío Olmos >Assignee: Pan, Julian >Priority: Minor > Labels: features > Attachments: KYLIN-3366.patch > > > Kylin automatically enables the disabled cubes after a construction process. > This behavior forces us to constantly disable a new cube that is under > development to replace an existing and enabled cube. If we do not disable it, > we could have problems with the routing of the queries. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3366) Configure automatic enabling of cubes after a build process
[ https://issues.apache.org/jira/browse/KYLIN-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3366: --- Attachment: KYLIN-3366.patch > Configure automatic enabling of cubes after a build process > --- > > Key: KYLIN-3366 > URL: https://issues.apache.org/jira/browse/KYLIN-3366 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.3.1 > Environment: Kylin 2.3.1 and Hadoop EMR 5.7 >Reporter: Roberto Tardío Olmos >Assignee: Pan, Julian >Priority: Minor > Labels: features > Attachments: KYLIN-3366.patch > > > Kylin automatically enables the disabled cubes after a construction process. > This behavior forces us to constantly disable a new cube that is under > development to replace an existing and enabled cube. If we do not disable it, > we could have problems with the routing of the queries. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-3366) Configure automatic enabling of cubes after a build process
[ https://issues.apache.org/jira/browse/KYLIN-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian reassigned KYLIN-3366: -- Assignee: Pan, Julian > Configure automatic enabling of cubes after a build process > --- > > Key: KYLIN-3366 > URL: https://issues.apache.org/jira/browse/KYLIN-3366 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.3.1 > Environment: Kylin 2.3.1 and Hadoop EMR 5.7 >Reporter: Roberto Tardío Olmos >Assignee: Pan, Julian >Priority: Minor > Labels: features > > Kylin automatically enables the disabled cubes after a construction process. > This behavior forces us to constantly disable a new cube that is under > development to replace an existing and enabled cube. If we do not disable it, > we could have problems with the routing of the queries. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-3308) Improvement exception in REST
[ https://issues.apache.org/jira/browse/KYLIN-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407559#comment-16407559 ] Pan, Julian edited comment on KYLIN-3308 at 4/3/18 11:08 AM: - I'm not sure whether the controller2 will replace controller and I should enhance this issue in controller. was (Author: julianpan): I can lead the exception defined if needed. BTW, I'm not sure whether the controller2 will cover it or not. > Improvement exception in REST > - > > Key: KYLIN-3308 > URL: https://issues.apache.org/jira/browse/KYLIN-3308 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > There are kinds of exception throw by rest call, and we need better defined > the exception. > For example: > 1> There are three types of exception for cube equals null in CubeController: > NotFoundException (deleteCube) > InternalErrorException(getCube) > BadRequestException (cloneCube) > 2> And sometimes InternalErrorException will warp the BadRequestException in > CubeController.saveCubeDesc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3001) Fix the wrong Cache key issue
[
https://issues.apache.org/jira/browse/KYLIN-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423810#comment-16423810
]
Pan, Julian commented on KYLIN-3001:
It is replace for multiple space to one space, which will reduce the sql length.
> Fix the wrong Cache key issue
> --
>
> Key: KYLIN-3001
> URL: https://issues.apache.org/jira/browse/KYLIN-3001
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN_3001_Cache_key_issue.patch
>
>
> Currently the cacheKey generate by SQLRequest getCacheKey:
> cacheKey = Lists.newArrayList(sql.replaceAll("\\s+", ""), project, offset,
> limit, acceptPartial,
> backdoorToggles);
> Which will remove all the space and break line.
> If I have a sql:
> select a, sum(c) from table
> --where a > 0 group by a;
> and another sql:
> select a, sum(c) from table
> --where a > 0
> group by a;
> The two sql will share same cache key.
> But the first sql should be break. If you query second sql, and then query
> the first again. It will return result.
> And another issue is if remove all space, which will mix a as b and aasb.
> I think the better way is just replace multiple space to one space
> Should I create a patch? Or just provide the fix:
> cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " "), project, offset,
> limit, acceptPartial,
> backdoorToggles);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KYLIN-2914) Visualization tools for data lineage
[ https://issues.apache.org/jira/browse/KYLIN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2914: --- Priority: Minor (was: Major) > Visualization tools for data lineage > - > > Key: KYLIN-2914 > URL: https://issues.apache.org/jira/browse/KYLIN-2914 > Project: Kylin > Issue Type: New Feature >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > Visualization the relationship about table, model and cubes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3308) Improvement exception in REST
[ https://issues.apache.org/jira/browse/KYLIN-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407559#comment-16407559 ] Pan, Julian commented on KYLIN-3308: I can lead the exception defined if needed. BTW, I'm not sure whether the controller2 will cover it or not. > Improvement exception in REST > - > > Key: KYLIN-3308 > URL: https://issues.apache.org/jira/browse/KYLIN-3308 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > > There are kinds of exception throw by rest call, and we need better defined > the exception. > For example: > 1> There are three types of exception for cube equals null in CubeController: > NotFoundException (deleteCube) > InternalErrorException(getCube) > BadRequestException (cloneCube) > 2> And sometimes InternalErrorException will warp the BadRequestException in > CubeController.saveCubeDesc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3308) Improvement exception in REST
Pan, Julian created KYLIN-3308: -- Summary: Improvement exception in REST Key: KYLIN-3308 URL: https://issues.apache.org/jira/browse/KYLIN-3308 Project: Kylin Issue Type: Improvement Components: REST Service Reporter: Pan, Julian Assignee: Pan, Julian There are kinds of exception throw by rest call, and we need better defined the exception. For example: 1> There are three types of exception for cube equals null in CubeController: NotFoundException (deleteCube) InternalErrorException(getCube) BadRequestException (cloneCube) 2> And sometimes InternalErrorException will warp the BadRequestException in CubeController.saveCubeDesc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3307) Improve Kylin Code Quality
Pan, Julian created KYLIN-3307: -- Summary: Improve Kylin Code Quality Key: KYLIN-3307 URL: https://issues.apache.org/jira/browse/KYLIN-3307 Project: Kylin Issue Type: Task Components: Tools, Build and Test Reporter: Pan, Julian Improve test code coverage for Kylin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3265: --- Attachment: Screen Shot 2018-02-26 at 1.55.21 PM.png > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.002.patch, > KYLIN-3265.master.002.patch, KYLIN-3265.master.003.patch, Screen Shot > 2018-02-26 at 1.55.21 PM.png > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3265: --- Attachment: KYLIN-3265.master.003.patch > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.002.patch, > KYLIN-3265.master.002.patch, KYLIN-3265.master.003.patch, Screen Shot > 2018-02-26 at 1.55.21 PM.png > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (KYLIN-2964) AclEntity operation issue
[ https://issues.apache.org/jira/browse/KYLIN-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian closed KYLIN-2964. -- Resolution: Fixed The issue is resolved by KYLIN-2555, it is better this patch. > AclEntity operation issue > -- > > Key: KYLIN-2964 > URL: https://issues.apache.org/jira/browse/KYLIN-2964 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN_2964.patch > > > When user add/update/delete access for AclEntity (project, model, cube, job), > which will check user exist. But if there are two user not exist, which will > cause issue. Admin want to delete the notExistsUser1, it will throws > notExistsUser2 not exist. The other operation has same issues for this check. > Could we add another method for checkExistUser and just add the method for > add or update? It should be fix this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375348#comment-16375348 ] Pan, Julian commented on KYLIN-2884: Hi [~Zhixiong Chen], I create a pull request: [https://github.com/apache/kylin/pull/105] Please merge, thanks. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375284#comment-16375284 ] Pan, Julian commented on KYLIN-2884: Thanks for your reply, here is the patch attached. You are right, the reason I put the loadDetail(cube) in click action is related to our internal streaming branch (will contribute soon) which need dynamic change action menu. I will do some refactor when we contribute back for this part, but in this release it should be keep the same as previous we did. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374209#comment-16374209 ] Pan, Julian edited comment on KYLIN-2884 at 2/23/18 10:58 AM: -- I add new patch for it. I'm not sure whether it need combine or not. Please let me know, if it need combine 2 commits. was (Author: julianpan): I add new patch for it. I'm not sure whether it need separate or not. Please let me know, if it need separate 2 commit. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: (was: KYLIN-2884.patch) > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374209#comment-16374209 ] Pan, Julian commented on KYLIN-2884: I add new patch for it. I'm not sure whether it need separate or not. Please let me know, if it need separate 2 commit. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374058#comment-16374058 ] Pan, Julian commented on KYLIN-2884: Sorry for late reply, I forgot another patch for this. I will create a patch soon. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357987#comment-16357987 ] Pan, Julian commented on KYLIN-2884: Hi [~Zhixiong Chen], I recreated a patch according currently master branch. Please help to merge. Thanks! > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357854#comment-16357854 ] Pan, Julian commented on KYLIN-2884: Sorry for late reply, I have change the metaModel.model.partition_desc.partition_date_column to cube.model.partition_desc.partition_date_column, it should be resolve. New patch attached > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2939) Get config properties not correct in UI
[
https://issues.apache.org/jira/browse/KYLIN-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335324#comment-16335324
]
Pan, Julian commented on KYLIN-2939:
Thanks a lot, [~Zhixiong Chen]
> Get config properties not correct in UI
> ---
>
> Key: KYLIN-2939
> URL: https://issues.apache.org/jira/browse/KYLIN-2939
> Project: Kylin
> Issue Type: Bug
> Components: Web
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Fix For: v2.3.0
>
> Attachments: KYLIN_2939.patch
>
>
> When I want to get kylin.env by getDeployEnv(), it will return
> kylin.env.hdfs-working-dir value. There is a bug in getProperty in
> kylinProperties.js.
> This function will return first properties will contains this name.
> Here is the fix:
> this.getProperty = function (name) {
> var keyIndex = _config.indexOf('\n' + name + '=');
> var keyLength = name.length;
> var partialResult = _config.substr(keyIndex);
> var preValueIndex = partialResult.indexOf("=");
> var sufValueIndex = partialResult.indexOf("\n", 2);
> return partialResult.substring(preValueIndex + 1, sufValueIndex);
> }
> If necessary, I can create a patch for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-2849) duplicate segment，cannot be deleted and data cannot be refreshed and merged
[
https://issues.apache.org/jira/browse/KYLIN-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331876#comment-16331876
]
Pan, Julian commented on KYLIN-2849:
I'm not sure whether it is duplicate with
https://issues.apache.org/jira/browse/KYLIN-3004, which is resolved in version
2.3.0
> duplicate segment，cannot be deleted and data cannot be refreshed and merged
> ---
>
> Key: KYLIN-2849
> URL: https://issues.apache.org/jira/browse/KYLIN-2849
> Project: Kylin
> Issue Type: Bug
> Components: Job Engine, Metadata, REST Service
>Affects Versions: v2.0.0
> Environment: hadoop：hadoop-2.6.0-cdh5.8.2
> hive ：2.1.0
> hbase：0.98
>Reporter: 翟玉勇
>Assignee: Dong Li
>Priority: Major
> Labels: scope
> Attachments: kylin-1.png, kylin-2.png
>
>
> cube duplicate segments。
> cannot be deleted and data cannot be refreshed and merged
> {code}
> try
> curl -X DELETE
> "http://127.0.0.1:7070/kylin/api/cubes/Remain_Cube_2/segs/2017082200_2017082300;
> -H "Authorization: Basic QURNSU46S1lMSU4=" -H "Content-Type:
> application/json;charset=UTF-8"
> Cannot delete segment '2017082200_2017082300' as it is neither the
> first nor the last
> segment.","stacktrace":"org.apache.kylin.rest.exception.InternalErrorException:
> Cannot delete segment '2017082200_2017082300' as it is neither the
> first nor the last segment
> {code}
> 暂时解决办法：
> {code}
> public CubeInstance deleteSegment(CubeInstance cube, String segmentName)
> throws IOException {
> if (!segmentName.equals(cube.getSegments().get(0).getName()) &&
> !segmentName.equals(cube.getSegments().get(cube.getSegments().size() -
> 1).getName())) {
> //throw new IllegalArgumentException("Cannot delete segment '" +
> segmentName + "' as it is neither the first nor the last segment.");
> }
> CubeSegment toDelete = null;
> for (CubeSegment seg : cube.getSegments()) {
> if (seg.getName().equals(segmentName)) {
> toDelete = seg;
> }
> }
> if (toDelete == null) {
> throw new IllegalArgumentException("Cannot find segment '" +
> segmentName + "'");
> }
> if (toDelete.getStatus() != SegmentStatusEnum.READY) {
> //throw new IllegalArgumentException("Cannot delete segment '" +
> segmentName + "' as its status is not READY. Discard the on-going job for
> it.");
> }
> CubeUpdate update = new CubeUpdate(cube);
> update.setToRemoveSegs(new CubeSegment[] { toDelete });
> return CubeManager.getInstance(getConfig()).updateCube(update);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3004) Delete cube segment validation
[
https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304291#comment-16304291
]
Pan, Julian commented on KYLIN-3004:
Thanks a lot.
> Delete cube segment validation
> --
>
> Key: KYLIN-3004
> URL: https://issues.apache.org/jira/browse/KYLIN-3004
> Project: Kylin
> Issue Type: Bug
> Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
> Fix For: v2.3.0
>
> Attachments: KYLIN_3004.patch, KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
> if (!segmentName.equals(cube.getSegments().get(0).getName())
> &&
> !segmentName.equals(cube.getSegments().get(cube.getSegments().size() -
> 1).getName())) {
> throw new
> BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(),
> segmentName));
> }
> Does it make sense? Should we remove the limit?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KYLIN-3026) Can not see full cube names on insight page
[ https://issues.apache.org/jira/browse/KYLIN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304290#comment-16304290 ] Pan, Julian commented on KYLIN-3026: Thanks a lot. [~Zhixiong Chen] > Can not see full cube names on insight page > --- > > Key: KYLIN-3026 > URL: https://issues.apache.org/jira/browse/KYLIN-3026 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_3026.patch, screenshot.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3026) Can not see full cube names on insight page
[ https://issues.apache.org/jira/browse/KYLIN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297844#comment-16297844 ] Pan, Julian commented on KYLIN-3026: [~Zhixiong Chen] If I change the trigger to hover, which will not allow user copy the text if user want copy the cube name. > Can not see full cube names on insight page > --- > > Key: KYLIN-3026 > URL: https://issues.apache.org/jira/browse/KYLIN-3026 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_3026.patch, screenshot.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2939) Get config properties not correct in UI
[
https://issues.apache.org/jira/browse/KYLIN-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297834#comment-16297834
]
Pan, Julian commented on KYLIN-2939:
BTW, we have some special logic between different env (QA & PROD), which
reproduce this issue.
> Get config properties not correct in UI
> ---
>
> Key: KYLIN-2939
> URL: https://issues.apache.org/jira/browse/KYLIN-2939
> Project: Kylin
> Issue Type: Bug
> Components: Web
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: KYLIN_2939.patch
>
>
> When I want to get kylin.env by getDeployEnv(), it will return
> kylin.env.hdfs-working-dir value. There is a bug in getProperty in
> kylinProperties.js.
> This function will return first properties will contains this name.
> Here is the fix:
> this.getProperty = function (name) {
> var keyIndex = _config.indexOf('\n' + name + '=');
> var keyLength = name.length;
> var partialResult = _config.substr(keyIndex);
> var preValueIndex = partialResult.indexOf("=");
> var sufValueIndex = partialResult.indexOf("\n", 2);
> return partialResult.substring(preValueIndex + 1, sufValueIndex);
> }
> If necessary, I can create a patch for it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KYLIN-2939) Get config properties not correct in UI
[
https://issues.apache.org/jira/browse/KYLIN-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297831#comment-16297831
]
Pan, Julian commented on KYLIN-2939:
In the front-end, if I want to get kylin.env, it will return
kylin.env.hdfs-working-dir value. If kylin.env.hdfs-working-dir is before
kylin.env.
The code:
var keyIndex = _config.indexOf(name);
which will get index kylin.env.hdfs-working-dir, cause
kylin.env.hdfs-working-dir include kylin.env.
Then it will return kylin.env.hdfs-working-dir's value instead of kylin.env.
If there is no contain properties, it should works will for the old code. But
in 2.1 there are contain properties, which will produce this issue.
My patch is get index include = and break row:
var keyIndex = _config.indexOf('\n' + name + '=');
Which will resolve this issue.
> Get config properties not correct in UI
> ---
>
> Key: KYLIN-2939
> URL: https://issues.apache.org/jira/browse/KYLIN-2939
> Project: Kylin
> Issue Type: Bug
> Components: Web
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: KYLIN_2939.patch
>
>
> When I want to get kylin.env by getDeployEnv(), it will return
> kylin.env.hdfs-working-dir value. There is a bug in getProperty in
> kylinProperties.js.
> This function will return first properties will contains this name.
> Here is the fix:
> this.getProperty = function (name) {
> var keyIndex = _config.indexOf('\n' + name + '=');
> var keyLength = name.length;
> var partialResult = _config.substr(keyIndex);
> var preValueIndex = partialResult.indexOf("=");
> var sufValueIndex = partialResult.indexOf("\n", 2);
> return partialResult.substring(preValueIndex + 1, sufValueIndex);
> }
> If necessary, I can create a patch for it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch Patch added, please review. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN-2884.patch > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3004) Delete cube segment validation
[
https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian updated KYLIN-3004:
---
Attachment: KYLIN_3004.patch
Thanks, [~Shaofengshi]. Here is the new patch.
> Delete cube segment validation
> --
>
> Key: KYLIN-3004
> URL: https://issues.apache.org/jira/browse/KYLIN-3004
> Project: Kylin
> Issue Type: Bug
> Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
> Attachments: KYLIN_3004.patch, KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
> if (!segmentName.equals(cube.getSegments().get(0).getName())
> &&
> !segmentName.equals(cube.getSegments().get(cube.getSegments().size() -
> 1).getName())) {
> throw new
> BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(),
> segmentName));
> }
> Does it make sense? Should we remove the limit?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KYLIN-2953) List readable project not correct if add limit and offset
[ https://issues.apache.org/jira/browse/KYLIN-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285451#comment-16285451 ] Pan, Julian commented on KYLIN-2953: Thanks a lot, [~Shaofengshi] > List readable project not correct if add limit and offset > - > > Key: KYLIN-2953 > URL: https://issues.apache.org/jira/browse/KYLIN-2953 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2953.patch > > > There is one line getReadableProjects in ProjectController: > List projectInstances = > projectService.listAllProjects(limit, offset); > That means just the part of projects, then validate the ACL. > If user's project beyond the limit, then he will never get the projects if he > put limit and offset. > It should be similar with cube list, get all the projects then validate the > ACL, at last get the sub list by limit and offset. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2959) SAML logout issue
[ https://issues.apache.org/jira/browse/KYLIN-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285452#comment-16285452 ] Pan, Julian commented on KYLIN-2959: Thanks a lot, [~Shaofengshi] > SAML logout issue > - > > Key: KYLIN-2959 > URL: https://issues.apache.org/jira/browse/KYLIN-2959 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN_2959.patch > > > When user click logout in portal, which will cause this issue for SAML mode. > User can not logout successful, the session did not disconnect and still user > can see the menu. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2940) List job restful throw NPE when time filter not set
[
https://issues.apache.org/jira/browse/KYLIN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285450#comment-16285450
]
Pan, Julian commented on KYLIN-2940:
Thanks a lot, [~Shaofengshi]
> List job restful throw NPE when time filter not set
> ---
>
> Key: KYLIN-2940
> URL: https://issues.apache.org/jira/browse/KYLIN-2940
> Project: Kylin
> Issue Type: Improvement
> Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
> Fix For: v2.3.0
>
> Attachments: KYLIN_2940.patch
>
>
> Here is the error response:
> {"code":"999","data":null,"msg":null,"stacktrace":"java.lang.NullPointerException\n\tat
>
> org.apache.kylin.rest.controller.JobController.list(JobController.java:72)\n\tat
> sun.reflect.GeneratedMethodAccessor283.invoke(Unknown Source)\n\tat
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)\n\tat
>
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)\n\tat
>
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)\n\tat
>
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:832)\n\tat
>
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:743)\n\tat
>
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\n\tat
>
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:961)\n\tat
>
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:895)\n\tat
>
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)\n\tat
>
> org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:858)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:624)\n\tat
> org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:731)\n\tat
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)\n\tat
>
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\tat
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)\n\tat
>
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:316)\n\tat
>
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:126)\n\tat
>
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:90)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:122)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:48)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
>
[jira] [Commented] (KYLIN-2882) Disable datepicker input avoid user typing issue
[ https://issues.apache.org/jira/browse/KYLIN-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285448#comment-16285448 ] Pan, Julian commented on KYLIN-2882: OK, maybe we need find a better way to validation. > Disable datepicker input avoid user typing issue > > > Key: KYLIN-2882 > URL: https://issues.apache.org/jira/browse/KYLIN-2882 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > When user typing in input for datepicker, which will cause date error issue. > Could we add the attribute read-only for datepicker input? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2875) Cube e-mail notification Validation
[ https://issues.apache.org/jira/browse/KYLIN-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285447#comment-16285447 ] Pan, Julian commented on KYLIN-2875: Thanks a lot, [~Shaofengshi] > Cube e-mail notification Validation > --- > > Key: KYLIN-2875 > URL: https://issues.apache.org/jira/browse/KYLIN-2875 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Fix For: v2.3.0 > > Attachments: KYLIN_2875.patch > > > Validation e-mail notification list avoid EmailException: > 2017-03-28 20:01:56,453 INFO [pool-10-thread-8] > execution.AbstractExecutable:250 : notify > list:[us...@apache.com;us...@apache.com;, dl-user-gr...@apache.com] > 2017-03-28 20:01:56,453 ERROR [pool-10-thread-8] util.MailService:112 : > Illegal semicolon, not in group > org.apache.commons.mail.EmailException: Illegal semicolon, not in group > at org.apache.commons.mail.Email.createInternetAddress(Email.java:541) > at org.apache.commons.mail.Email.addTo(Email.java:653) > at org.apache.commons.mail.Email.addTo(Email.java:636) > at org.apache.commons.mail.Email.addTo(Email.java:618) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:97) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:70) > at > org.apache.kylin.job.execution.AbstractExecutable.notifyUserStatusChange(AbstractExecutable.java:251) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onStatusChange(DefaultChainedExecutable.java:105) > at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:296) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:89) > at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:292) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:135) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:133) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) > Caused by: javax.mail.internet.AddressException: Illegal semicolon, not in > group in string > ``cais...@ebay.com;kalagupack...@ebay.com;cb...@ebay.com;cb...@ebay.com;'' at > position 16 > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:780) > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:555) > at javax.mail.internet.InternetAddress.(InternetAddress.java:91) > at org.apache.commons.mail.Email.createInternetAddress(Email.java:514) > ... 15 more -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2941) Configuration setting for SSO
[
https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285445#comment-16285445
]
Pan, Julian commented on KYLIN-2941:
I'm not sure, whether the document describe kylin.properties?
I add a attribute(kylin.security.saml.keystore-file) in kylin.properties for
key store file path instead of kylinSecurity.xml directly.
> Configuration setting for SSO
> -
>
> Key: KYLIN-2941
> URL: https://issues.apache.org/jira/browse/KYLIN-2941
> Project: Kylin
> Issue Type: Improvement
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: KYLIN_2941.patch
>
>
> I noticed there is kylin.security.saml.metadata-file properties in
> kylin.properties but never used.
> And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration
> in kylinSecurity.xml.
> Could we config both of them in kylin.properties?
> And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KYLIN-3004) Delete cube segment validation
[
https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283212#comment-16283212
]
Pan, Julian commented on KYLIN-3004:
Upload a patch to remove this logic.
> Delete cube segment validation
> --
>
> Key: KYLIN-3004
> URL: https://issues.apache.org/jira/browse/KYLIN-3004
> Project: Kylin
> Issue Type: Bug
> Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
> Attachments: KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
> if (!segmentName.equals(cube.getSegments().get(0).getName())
> &&
> !segmentName.equals(cube.getSegments().get(cube.getSegments().size() -
> 1).getName())) {
> throw new
> BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(),
> segmentName));
> }
> Does it make sense? Should we remove the limit?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (KYLIN-3004) Delete cube segment validation
[
https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian updated KYLIN-3004:
---
Attachment: KYLIN_3004.patch
> Delete cube segment validation
> --
>
> Key: KYLIN-3004
> URL: https://issues.apache.org/jira/browse/KYLIN-3004
> Project: Kylin
> Issue Type: Bug
> Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
> Attachments: KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
> if (!segmentName.equals(cube.getSegments().get(0).getName())
> &&
> !segmentName.equals(cube.getSegments().get(cube.getSegments().size() -
> 1).getName())) {
> throw new
> BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(),
> segmentName));
> }
> Does it make sense? Should we remove the limit?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (KYLIN-2941) Configuration setting for SSO
[
https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian updated KYLIN-2941:
---
Attachment: KYLIN_2941.patch
Here is the patch, please review.
> Configuration setting for SSO
> -
>
> Key: KYLIN-2941
> URL: https://issues.apache.org/jira/browse/KYLIN-2941
> Project: Kylin
> Issue Type: Improvement
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Minor
> Attachments: KYLIN_2941.patch
>
>
> I noticed there is kylin.security.saml.metadata-file properties in
> kylin.properties but never used.
> And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration
> in kylinSecurity.xml.
> Could we config both of them in kylin.properties?
> And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (KYLIN-2941) Configuration setting for SSO
[
https://issues.apache.org/jira/browse/KYLIN-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian reassigned KYLIN-2941:
--
Assignee: Pan, Julian
> Configuration setting for SSO
> -
>
> Key: KYLIN-2941
> URL: https://issues.apache.org/jira/browse/KYLIN-2941
> Project: Kylin
> Issue Type: Improvement
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Minor
>
> I noticed there is kylin.security.saml.metadata-file properties in
> kylin.properties but never used.
> And there are classpath:samlKeystore.jks & sso_metadata.xml the configuration
> in kylinSecurity.xml.
> Could we config both of them in kylin.properties?
> And change them in kylinSecurity.xml. e.g ${kylin.security.saml.metadata-file}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (KYLIN-3026) Can not see full cube names on insight page
[ https://issues.apache.org/jira/browse/KYLIN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-3026: --- Attachment: KYLIN_3026.patch Here is the patch, please review. > Can not see full cube names on insight page > --- > > Key: KYLIN-3026 > URL: https://issues.apache.org/jira/browse/KYLIN-3026 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_3026.patch, screenshot.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (KYLIN-2938) Project Update ACL issue
[ https://issues.apache.org/jira/browse/KYLIN-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian closed KYLIN-2938. -- > Project Update ACL issue > > > Key: KYLIN-2938 > URL: https://issues.apache.org/jira/browse/KYLIN-2938 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > > I noticed there different security between updateProject and renameProject in > ProjectService. > @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or > hasPermission(#currentProject, 'ADMINISTRATION') or > hasPermission(#currentProject, 'MANAGEMENT')") > updateProject > @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or > hasPermission(#currentProject, 'ADMINISTRATION')") > renameProject > Even updateProject will call renameProject. Which will throws exception if > user is MANAGEMENT role. > The renameProject should be same security check with updateProject. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-2938) Project Update ACL issue
[ https://issues.apache.org/jira/browse/KYLIN-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian resolved KYLIN-2938. Resolution: Fixed Already change to @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or hasPermission(#currentProject, 'ADMINISTRATION')") in master branch > Project Update ACL issue > > > Key: KYLIN-2938 > URL: https://issues.apache.org/jira/browse/KYLIN-2938 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > > I noticed there different security between updateProject and renameProject in > ProjectService. > @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or > hasPermission(#currentProject, 'ADMINISTRATION') or > hasPermission(#currentProject, 'MANAGEMENT')") > updateProject > @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or > hasPermission(#currentProject, 'ADMINISTRATION')") > renameProject > Even updateProject will call renameProject. Which will throws exception if > user is MANAGEMENT role. > The renameProject should be same security check with updateProject. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (KYLIN-2938) Project Update ACL issue
[ https://issues.apache.org/jira/browse/KYLIN-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian reassigned KYLIN-2938: -- Assignee: Pan, Julian (was: Zhong,Jason) > Project Update ACL issue > > > Key: KYLIN-2938 > URL: https://issues.apache.org/jira/browse/KYLIN-2938 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > > I noticed there different security between updateProject and renameProject in > ProjectService. > @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or > hasPermission(#currentProject, 'ADMINISTRATION') or > hasPermission(#currentProject, 'MANAGEMENT')") > updateProject > @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or > hasPermission(#currentProject, 'ADMINISTRATION')") > renameProject > Even updateProject will call renameProject. Which will throws exception if > user is MANAGEMENT role. > The renameProject should be same security check with updateProject. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2959) SAML logout issue
[ https://issues.apache.org/jira/browse/KYLIN-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2959: --- Attachment: KYLIN_2959.patch > SAML logout issue > - > > Key: KYLIN-2959 > URL: https://issues.apache.org/jira/browse/KYLIN-2959 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > Attachments: KYLIN_2959.patch > > > When user click logout in portal, which will cause this issue for SAML mode. > User can not logout successful, the session did not disconnect and still user > can see the menu. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2959) SAML logout issue
[ https://issues.apache.org/jira/browse/KYLIN-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283009#comment-16283009 ] Pan, Julian commented on KYLIN-2959: BTW, cause we defined the after logout action in page.js. So I remove the same config in spring config xml in this patch. > SAML logout issue > - > > Key: KYLIN-2959 > URL: https://issues.apache.org/jira/browse/KYLIN-2959 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > When user click logout in portal, which will cause this issue for SAML mode. > User can not logout successful, the session did not disconnect and still user > can see the menu. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2959) SAML logout issue
[ https://issues.apache.org/jira/browse/KYLIN-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283001#comment-16283001 ] Pan, Julian commented on KYLIN-2959: The SAML filter config: And there is public static final String FILTER_URL = "/saml/logout"; Which means the default /saml/logout. And in UI we still use j_spring_security_logout. > SAML logout issue > - > > Key: KYLIN-2959 > URL: https://issues.apache.org/jira/browse/KYLIN-2959 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > When user click logout in portal, which will cause this issue for SAML mode. > User can not logout successful, the session did not disconnect and still user > can see the menu. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2882) Disable datepicker input avoid user typing issue
[ https://issues.apache.org/jira/browse/KYLIN-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282956#comment-16282956 ] Pan, Julian commented on KYLIN-2882: Do you have any good idea for check? The input use dateTimepickerTimezone directive, which will parse the value to long. If user typing error format, it parse failed. > Disable datepicker input avoid user typing issue > > > Key: KYLIN-2882 > URL: https://issues.apache.org/jira/browse/KYLIN-2882 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Minor > > When user typing in input for datepicker, which will cause date error issue. > Could we add the attribute read-only for datepicker input? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2964) AclEntity operation issue
[ https://issues.apache.org/jira/browse/KYLIN-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2964: --- Attachment: KYLIN_2964.patch Sorry for late reply, here is the patch. Please review. > AclEntity operation issue > -- > > Key: KYLIN-2964 > URL: https://issues.apache.org/jira/browse/KYLIN-2964 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_2964.patch > > > When user add/update/delete access for AclEntity (project, model, cube, job), > which will check user exist. But if there are two user not exist, which will > cause issue. Admin want to delete the notExistsUser1, it will throws > notExistsUser2 not exist. The other operation has same issues for this check. > Could we add another method for checkExistUser and just add the method for > add or update? It should be fix this issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2875) Cube e-mail notification Validation
[ https://issues.apache.org/jira/browse/KYLIN-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2875: --- Attachment: KYLIN_2875.patch Add UT for validate notify list. > Cube e-mail notification Validation > --- > > Key: KYLIN-2875 > URL: https://issues.apache.org/jira/browse/KYLIN-2875 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_2875.patch, > KYLIN_2875_CUBE_EMAIL_NOTIFICATION_VALIDATION.patch > > > Validation e-mail notification list avoid EmailException: > 2017-03-28 20:01:56,453 INFO [pool-10-thread-8] > execution.AbstractExecutable:250 : notify > list:[us...@apache.com;us...@apache.com;, dl-user-gr...@apache.com] > 2017-03-28 20:01:56,453 ERROR [pool-10-thread-8] util.MailService:112 : > Illegal semicolon, not in group > org.apache.commons.mail.EmailException: Illegal semicolon, not in group > at org.apache.commons.mail.Email.createInternetAddress(Email.java:541) > at org.apache.commons.mail.Email.addTo(Email.java:653) > at org.apache.commons.mail.Email.addTo(Email.java:636) > at org.apache.commons.mail.Email.addTo(Email.java:618) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:97) > at org.apache.kylin.common.util.MailService.sendMail(MailService.java:70) > at > org.apache.kylin.job.execution.AbstractExecutable.notifyUserStatusChange(AbstractExecutable.java:251) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onStatusChange(DefaultChainedExecutable.java:105) > at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:296) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:89) > at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:292) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:135) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:133) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) > Caused by: javax.mail.internet.AddressException: Illegal semicolon, not in > group in string > ``cais...@ebay.com;kalagupack...@ebay.com;cb...@ebay.com;cb...@ebay.com;'' at > position 16 > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:780) > at javax.mail.internet.InternetAddress.parse(InternetAddress.java:555) > at javax.mail.internet.InternetAddress.(InternetAddress.java:91) > at org.apache.commons.mail.Email.createInternetAddress(Email.java:514) > ... 15 more -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2940) List job restful throw NPE when time filter not set
[
https://issues.apache.org/jira/browse/KYLIN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian updated KYLIN-2940:
---
Attachment: KYLIN_2940.patch
Add patch for review.
> List job restful throw NPE when time filter not set
> ---
>
> Key: KYLIN-2940
> URL: https://issues.apache.org/jira/browse/KYLIN-2940
> Project: Kylin
> Issue Type: Improvement
> Components: REST Service
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
> Attachments: KYLIN_2940.patch
>
>
> Here is the error response:
> {"code":"999","data":null,"msg":null,"stacktrace":"java.lang.NullPointerException\n\tat
>
> org.apache.kylin.rest.controller.JobController.list(JobController.java:72)\n\tat
> sun.reflect.GeneratedMethodAccessor283.invoke(Unknown Source)\n\tat
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)\n\tat
>
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)\n\tat
>
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)\n\tat
>
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:832)\n\tat
>
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:743)\n\tat
>
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\n\tat
>
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:961)\n\tat
>
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:895)\n\tat
>
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)\n\tat
>
> org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:858)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:624)\n\tat
> org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:731)\n\tat
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)\n\tat
>
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\tat
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)\n\tat
>
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:316)\n\tat
>
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:126)\n\tat
>
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:90)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:122)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:48)\n\tat
>
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)\n\tat
>
> org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilterInternal(BasicAuthenticationFilter.java:213)\n\tat
>
>
[jira] [Updated] (KYLIN-2883) Add broken reason in SQL tab for broken cube
[ https://issues.apache.org/jira/browse/KYLIN-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2883: --- Attachment: KYLIN_2883.patch Add patch for review. > Add broken reason in SQL tab for broken cube > > > Key: KYLIN-2883 > URL: https://issues.apache.org/jira/browse/KYLIN-2883 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > Attachments: KYLIN_2883.patch > > > When user hit sql tab for 'descbroken' cube, which will throws exception. > It's better to put the broken reason for user. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-2883) Add broken reason in SQL tab for broken cube
[ https://issues.apache.org/jira/browse/KYLIN-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2883: --- Component/s: Web REST Service > Add broken reason in SQL tab for broken cube > > > Key: KYLIN-2883 > URL: https://issues.apache.org/jira/browse/KYLIN-2883 > Project: Kylin > Issue Type: Improvement > Components: REST Service, Web >Reporter: Pan, Julian >Assignee: Pan, Julian > > When user hit sql tab for 'descbroken' cube, which will throws exception. > It's better to put the broken reason for user. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (KYLIN-3003) Delete Cube Segment for UI
[ https://issues.apache.org/jira/browse/KYLIN-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian closed KYLIN-3003. -- Resolution: Duplicate > Delete Cube Segment for UI > -- > > Key: KYLIN-3003 > URL: https://issues.apache.org/jira/browse/KYLIN-3003 > Project: Kylin > Issue Type: Improvement > Components: Web >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > > Currently, just provide delete segment restful. > But no UI support for user. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3003) Delete Cube Segment for UI
[ https://issues.apache.org/jira/browse/KYLIN-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239797#comment-16239797 ] Pan, Julian commented on KYLIN-3003: Yes, sorry for duplicate, I close it and change add the link to KYLIN-2884 > Delete Cube Segment for UI > -- > > Key: KYLIN-3003 > URL: https://issues.apache.org/jira/browse/KYLIN-3003 > Project: Kylin > Issue Type: Improvement > Components: Web >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian > > Currently, just provide delete segment restful. > But no UI support for user. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3001) Cache key issue
[
https://issues.apache.org/jira/browse/KYLIN-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239796#comment-16239796
]
Pan, Julian commented on KYLIN-3001:
[~yimingliu] In my case, it is about break line issue. You can not suppose user
can not add any comments. Another reason kylin's sql parser calcite allow this
behavior, kylin should not forbidden comments behavior in SQL. Currently cache
key will remove all space and break line, which will lead this issue. In my
opinion, we should not remove break line, and change multiple space to one
space. That will make sure the cache key will not change the original SQL
behavior.
> Cache key issue
>
>
> Key: KYLIN-3001
> URL: https://issues.apache.org/jira/browse/KYLIN-3001
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: liyang
> Attachments: KYLIN_3001_Cache_key_issue.patch
>
>
> Currently the cacheKey generate by SQLRequest getCacheKey:
> cacheKey = Lists.newArrayList(sql.replaceAll("\\s+", ""), project, offset,
> limit, acceptPartial,
> backdoorToggles);
> Which will remove all the space and break line.
> If I have a sql:
> select a, sum(c) from table
> --where a > 0 group by a;
> and another sql:
> select a, sum(c) from table
> --where a > 0
> group by a;
> The two sql will share same cache key.
> But the first sql should be break. If you query second sql, and then query
> the first again. It will return result.
> And another issue is if remove all space, which will mix a as b and aasb.
> I think the better way is just replace multiple space to one space
> Should I create a patch? Or just provide the fix:
> cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " "), project, offset,
> limit, acceptPartial,
> backdoorToggles);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (KYLIN-3001) Cache key issue
[
https://issues.apache.org/jira/browse/KYLIN-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian updated KYLIN-3001:
---
Attachment: KYLIN_3001_Cache_key_issue.patch
Here is the patch.
> Cache key issue
>
>
> Key: KYLIN-3001
> URL: https://issues.apache.org/jira/browse/KYLIN-3001
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: liyang
>Priority: Major
> Attachments: KYLIN_3001_Cache_key_issue.patch
>
>
> Currently the cacheKey generate by SQLRequest getCacheKey:
> cacheKey = Lists.newArrayList(sql.replaceAll("\\s+", ""), project, offset,
> limit, acceptPartial,
> backdoorToggles);
> Which will remove all the space and break line.
> If I have a sql:
> select a, sum(c) from table
> --where a > 0 group by a;
> and another sql:
> select a, sum(c) from table
> --where a > 0
> group by a;
> The two sql will share same cache key.
> But the first sql should be break. If you query second sql, and then query
> the first again. It will return result.
> And another issue is if remove all space, which will mix a as b and aasb.
> I think the better way is just replace multiple space to one space
> Should I create a patch? Or just provide the fix:
> cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " "), project, offset,
> limit, acceptPartial,
> backdoorToggles);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (KYLIN-3001) Cache key issue
[
https://issues.apache.org/jira/browse/KYLIN-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pan, Julian updated KYLIN-3001:
---
Priority: Major (was: Critical)
> Cache key issue
>
>
> Key: KYLIN-3001
> URL: https://issues.apache.org/jira/browse/KYLIN-3001
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: liyang
>Priority: Major
>
> Currently the cacheKey generate by SQLRequest getCacheKey:
> cacheKey = Lists.newArrayList(sql.replaceAll("\\s+", ""), project, offset,
> limit, acceptPartial,
> backdoorToggles);
> Which will remove all the space and break line.
> If I have a sql:
> select a, sum(c) from table
> --where a > 0 group by a;
> and another sql:
> select a, sum(c) from table
> --where a > 0
> group by a;
> The two sql will share same cache key.
> But the first sql should be break. If you query second sql, and then query
> the first again. It will return result.
> And another issue is if remove all space, which will mix a as b and aasb.
> I think the better way is just replace multiple space to one space
> Should I create a patch? Or just provide the fix:
> cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " "), project, offset,
> limit, acceptPartial,
> backdoorToggles);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
