[GitHub] [kylin] shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation
shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation URL: https://github.com/apache/kylin/pull/528#issuecomment-478327127 Merged with a review commit; Thank you xiaodong! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation
shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation URL: https://github.com/apache/kylin/pull/528#issuecomment-475862636 integration test failed with: Caused by: java.lang.NullPointerException at org.apache.kylin.common.util.DateFormat.isAllDigits(DateFormat.java:129) at org.apache.kylin.common.util.DateFormat.stringToMillis(DateFormat.java:101) at org.apache.kylin.provision.BuildCubeWithEngine.checkNormalSegRangeInfo(BuildCubeWithEngine.java:498) at org.apache.kylin.provision.BuildCubeWithEngine.doBuildAndMergeOnCube(BuildCubeWithEngine.java:318) at org.apache.kylin.provision.BuildCubeWithEngine.testInnerJoinCube(BuildCubeWithEngine.java:353) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation
shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation URL: https://github.com/apache/kylin/pull/528#issuecomment-473929129 Hi @xbirbird, thank you for the patch! The change looks good, could you please add some test case for this? Or at least it can be covered by the integration test (BuildCubeWithEngine.java). Just let me know how you test and verify this feature, thx! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
