[jira] [Comment Edited] (KYLIN-3580) CuboidStatsUtil#complementRowCountForMandatoryCuboids uses entrySet to add elements

2018-09-25 Thread Lijun Cao (JIRA) 


[ 
https://issues.apache.org/jira/browse/KYLIN-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626904#comment-16626904
 ] 

Lijun Cao edited comment on KYLIN-3580 at 9/25/18 7:18 AM:
---

Similar problem: 
https://stackoverflow.com/questions/11856391/findbugs-dmi-entry-sets-may-reuse-entry-objects


was (Author: caolijun1166):
https://stackoverflow.com/questions/11856391/findbugs-dmi-entry-sets-may-reuse-entry-objects

> CuboidStatsUtil#complementRowCountForMandatoryCuboids uses entrySet to add 
> elements
> ---
>
> Key: KYLIN-3580
> URL: https://issues.apache.org/jira/browse/KYLIN-3580
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Lijun Cao
>Priority: Major
>
> Here is related code:
> {code}
> sortedStatsSet.addAll(statistics.entrySet());
> {code}
> The entrySet() method is allowed to return a view of the underlying Map in 
> which a single Entry object is reused and returned during the iteration.
> When iterating through such a Map, the Entry value is only valid until you 
> advance to the next iteration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (KYLIN-3580) CuboidStatsUtil#complementRowCountForMandatoryCuboids uses entrySet to add elements

2018-09-24 Thread Lijun Cao (JIRA) 


[ 
https://issues.apache.org/jira/browse/KYLIN-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625460#comment-16625460
 ] 

Lijun Cao edited comment on KYLIN-3580 at 9/24/18 7:21 AM:
---

I'll take this.


was (Author: caolijun1166):
i'll take this.

> CuboidStatsUtil#complementRowCountForMandatoryCuboids uses entrySet to add 
> elements
> ---
>
> Key: KYLIN-3580
> URL: https://issues.apache.org/jira/browse/KYLIN-3580
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Major
>
> Here is related code:
> {code}
> sortedStatsSet.addAll(statistics.entrySet());
> {code}
> The entrySet() method is allowed to return a view of the underlying Map in 
> which a single Entry object is reused and returned during the iteration.
> When iterating through such a Map, the Entry value is only valid until you 
> advance to the next iteration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)