[jira] [Commented] (KYLIN-2155) get-properties.sh doesn't support parameters starting with hyphen

2016-11-02 Thread hongbin ma (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631278#comment-15631278
 ] 

hongbin ma commented on KYLIN-2155:
---

got it. then the patch will be suffice to deal with most cases.
I'm merging your patch to master

> get-properties.sh doesn't support parameters starting with hyphen
> -
>
> Key: KYLIN-2155
> URL: https://issues.apache.org/jira/browse/KYLIN-2155
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: Future, v1.6.1
>Reporter: Ricardo Jorge de Sousa Teixeira
>Assignee: hongbin ma
> Attachments: fix.patch
>
>
> The last echo in get-properties.sh silently ignores strings with {{-n}}.
> It should be double quoted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KYLIN-2155) get-properties.sh doesn't support parameters starting with hyphen

2016-11-02 Thread Ricardo Jorge de Sousa Teixeira (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631085#comment-15631085
 ] 

Ricardo Jorge de Sousa Teixeira commented on KYLIN-2155:


For me it didn't work because I was using it to pass a username with {{-n
myuser}} to beeline.

I think it is counterintuitive that we have to be worried about the string
we put. Double quoting the string passed to {{echo}} is the normal approach.

Regards.




> get-properties.sh doesn't support parameters starting with hyphen
> -
>
> Key: KYLIN-2155
> URL: https://issues.apache.org/jira/browse/KYLIN-2155
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: Future, v1.6.1
>Reporter: Ricardo Jorge de Sousa Teixeira
>Assignee: hongbin ma
> Attachments: fix.patch
>
>
> The last echo in get-properties.sh silently ignores strings with {{-n}}.
> It should be double quoted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)