[jira] [Commented] (KYLIN-2706) Should disable Storage limit push down when singleValuesD doesn't containsAll othersD

2017-07-23 Thread kangkaisen (JIRA) 

[ 
https://issues.apache.org/jira/browse/KYLIN-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097583#comment-16097583
 ] 

kangkaisen commented on KYLIN-2706:
---

After discussed with [~mahongbin], we thought the root cause of this issue is 
the Comparator of SortedIteratorMergerWithLimit has a bug.
I think we only need to compare with group columns in 
SortedIteratorMergerWithLimit.

> Should disable Storage limit push down when singleValuesD doesn't containsAll 
> othersD
> -
>
> Key: KYLIN-2706
> URL: https://issues.apache.org/jira/browse/KYLIN-2706
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.0.0
>Reporter: kangkaisen
>Assignee: kangkaisen
> Fix For: v2.1.0
>
> Attachments: KYLIN-2706.patch
>
>
> For this SQL, which should disable Storage limit push. Because this SQL will 
> return more than one record from HBase tables, but the 
> SortedIteratorMergerWithLimit only return one record, which will get wrong 
> result.
> {code:java}
> SELECT sum(A) 
> FROM TABLE 
> WHERE date_id >= 20170624 and date_id <= 20170626 
> limit 1
> {code}
> We should disable Storage limit push down when singleValuesD doesn't 
> containsAll othersD



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KYLIN-2706) Should disable Storage limit push down when singleValuesD doesn't containsAll othersD

2017-07-16 Thread kangkaisen (JIRA) 

[ 
https://issues.apache.org/jira/browse/KYLIN-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088903#comment-16088903
 ] 

kangkaisen commented on KYLIN-2706:
---

This is the commit: 
https://github.com/apache/kylin/commit/0dc2cd4665efd32d2f782e53382f86e5dadb720a

> Should disable Storage limit push down when singleValuesD doesn't containsAll 
> othersD
> -
>
> Key: KYLIN-2706
> URL: https://issues.apache.org/jira/browse/KYLIN-2706
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.0.0
>Reporter: kangkaisen
>Assignee: kangkaisen
> Attachments: KYLIN-2706.patch
>
>
> For this SQL, which should disable Storage limit push. Because this SQL will 
> return more than one record from HBase tables, but the 
> SortedIteratorMergerWithLimit only return one record, which will get wrong 
> result.
> {code:java}
> SELECT sum(A) 
> FROM TABLE 
> WHERE date_id >= 20170624 and date_id <= 20170626 
> limit 1
> {code}
> We should disable Storage limit push down when singleValuesD doesn't 
> containsAll othersD



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KYLIN-2706) Should disable Storage limit push down when singleValuesD doesn't containsAll othersD

2017-07-12 Thread liyang (JIRA) 

[ 
https://issues.apache.org/jira/browse/KYLIN-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084006#comment-16084006
 ] 

liyang commented on KYLIN-2706:
---

+1

> Should disable Storage limit push down when singleValuesD doesn't containsAll 
> othersD
> -
>
> Key: KYLIN-2706
> URL: https://issues.apache.org/jira/browse/KYLIN-2706
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.0.0
>Reporter: kangkaisen
>Assignee: kangkaisen
> Attachments: KYLIN-2706.patch
>
>
> For this SQL, which should disable Storage limit push. Because this SQL will 
> return more than one record from HBase tables, but the 
> SortedIteratorMergerWithLimit only return one record, which will get wrong 
> result.
> {code:java}
> SELECT sum(A) 
> FROM TABLE 
> WHERE date_id >= 20170624 and date_id <= 20170626 
> limit 1
> {code}
> We should disable Storage limit push down when singleValuesD doesn't 
> containsAll othersD



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)